Signed-off-by: Francois Gouget
---
On Thu, 3 Sep 2015, Frediano Ziglio wrote:
> >
> > Signed-off-by: Francois Gouget
>
> Acked-by: Frediano Ziglio
>
> Cannot actually push it.
> It also would help if you can rebase to new master (patch apply but git am
> complains).
There you go:
diff -
This patch contains a bit of small optimizations.
It avoid booleans operations which could involve branches replacing
with binary operations (equal/all_ident -> some_differences).
The other optimization avoid the use of ABS. First the way the macro
was used (with a large expression) was not easy to
>
> Signed-off-by: Francois Gouget
Acked-by: Frediano Ziglio
Cannot actually push it.
It also would help if you can rebase to new master (patch apply but git am
complains).
> ---
> src/spiceqxl_spice_server.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/sr
On Thu, 2015-09-03 at 16:20 +0200, Jonathon Jongsma wrote:
> On Thu, 2015-09-03 at 11:22 +0200, Christophe Fergeau wrote:
> > On Thu, Sep 03, 2015 at 05:09:31AM -0400, Frediano Ziglio wrote:
> > >
> > > >
> > > > Hey,
> > > >
> > > > On Thu, Sep 03, 2015 at 09:21:04AM +0100, Frediano Ziglio wrot
On Thu, 2015-09-03 at 11:22 +0200, Christophe Fergeau wrote:
> On Thu, Sep 03, 2015 at 05:09:31AM -0400, Frediano Ziglio wrote:
> >
> > >
> > > Hey,
> > >
> > > On Thu, Sep 03, 2015 at 09:21:04AM +0100, Frediano Ziglio wrote:
> > > > Do not access to timer after we call the associated function.
On Thu, 3 Sep 2015, Frediano Ziglio wrote:
[...]
> One thing that scare me with this set of patches are the variability of some
> codecs. For current formats there is just a capabilities exchange like "I
> support this format", "ok, I'll use it". But what would happen if h264 is
> enabled and the s
Hey,
On Fri, Aug 21, 2015 at 11:26:10AM +0100, Frediano Ziglio wrote:
> Hi,
> I came to look close at this patch
>
> http://cgit.freedesktop.org/spice/spice/commit/?id=c914e96fb4de3ba8b2df174d7c7af8ff76af1081
>
> I think the intention of the patch is to change the image compression from
> the
Ack
On Thu, 2015-09-03 at 15:31 +0200, Jonathon Jongsma wrote:
> When a display channel is associated with a particular SpiceDisplay
> widget, it previously set the display to 'enabled' unconditionally.
> There is a couple of problems with this behavior.
>
> First, simply because a display widget
ACK
On Fri, 2015-08-21 at 11:16 +0100, Frediano Ziglio wrote:
> Due to how the MIN macro is defined the function was called twice
> unless the compiler could demonstrate that was returning the same
> value (which actually is impossible as function as clock_gettime
> are not deterministic).
>
> Si
When a display channel is associated with a particular SpiceDisplay
widget, it previously set the display to 'enabled' unconditionally.
There is a couple of problems with this behavior.
First, simply because a display widget has an associated display
channel, it doesn't necessarily mean that the d
Hi,
On Thu, 2015-09-03 at 11:52 +0200, Fabio Fantoni wrote:
> Hi, based also on js console output:
> http://pastebin.com/L9Rr3Y25
> I tried this patch for fix the non-topdown problem (remove one of the
> FIXME type):
> http://lists.freedesktop.org/archives/spice-devel/2013-March/012590.html
>
> I
Oops, overlooked Pavel's earlier review. Sorry.
On Tue, 2015-08-18 at 14:59 +0200, Pavel Grunt wrote:
> Hi Jonathon,
> looks good, just one question below.
.
> > @@ -226,6 +239,16 @@ static void update_ready(SpiceDisplay *display)
> >
> > ready = d->mark != 0 && d->monitor_ready;
>
Out of curiosity, did you measure the performance impact of these
changes? If so, it would be nice to include this in the commit log.
Just a few minor terminology suggestions below
On Fri, 2015-08-21 at 10:57 +0100, Frediano Ziglio wrote:
> This patch contains a bit of small optimizations.
> It
This patch still needs review.
On Thu, 2015-08-06 at 15:22 -0500, Jonathon Jongsma wrote:
> When a display channel is associated with a particular SpiceDisplay
> widget, it previously set the display to 'enabled' unconditionally.
> There is a couple of problems with this behavior.
>
> First, sim
>
> On Mon, 31 Aug 2015, Fabio Fantoni wrote:
> [...]
> > Is possible add to optionally enable streaming on client request instead
> > enable/disable on start only spice-server side?
>
> Spice already supports streaming video using its built-in MJPEG encoder.
> That streaming can be disabled/conf
Hi, based also on js console output:
http://pastebin.com/L9Rr3Y25
I tried this patch for fix the non-topdown problem (remove one of the
FIXME type):
http://lists.freedesktop.org/archives/spice-devel/2013-March/012590.html
I applied it clean on latest spice-html5 from source (official git
repositor
On Thu, Sep 03, 2015 at 05:09:31AM -0400, Frediano Ziglio wrote:
>
> >
> > Hey,
> >
> > On Thu, Sep 03, 2015 at 09:21:04AM +0100, Frediano Ziglio wrote:
> > > Do not access to timer after we call the associated function.
> > > Some of these callbacks can free timer making the pointer pointing
>
>
> Hey,
>
> On Thu, Sep 03, 2015 at 09:21:04AM +0100, Frediano Ziglio wrote:
> > Do not access to timer after we call the associated function.
> > Some of these callbacks can free timer making the pointer pointing
> > to freed data.
>
> Some callbacks are calling
> spice_timer_remove()/spice_t
Hey,
On Thu, Sep 03, 2015 at 09:21:04AM +0100, Frediano Ziglio wrote:
> Do not access to timer after we call the associated function.
> Some of these callbacks can free timer making the pointer pointing
> to freed data.
Some callbacks are calling
spice_timer_remove()/spice_timer_queue_destroy() w
Do not access to timer after we call the associated function.
Some of these callbacks can free timer making the pointer pointing
to freed data.
This happen for instance when the client is disconnecting.
This does not cause memory corruption on current allocator
implementations as all freeing/access
>
> Do not access to timer after we call the associated function.
> Some of these callbacks can free timer making the pointer pointing
> to freed data.
> This happen for instance when the client is disconnecting.
> This does not cause memory corruption on current allocator
> implementations as all
Do not access to timer after we call the associated function.
Some of these callbacks can free timer making the pointer pointing
to freed data.
This happen for instance when the client is disconnecting.
This does not cause memory corruption on current allocator
implementations as all freeing/access
22 matches
Mail list logo
