On Mon, Jul 20, 2015 at 09:56:10PM +0200, Pavel Grunt wrote:
> Ack,
Thanks, pushed.
Christophe
pgpAKEx_nmMZU.pgp
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/sp
Hi Again.
On 7/17/2015 5:43 AM, Victor Toso wrote:
> Hi,
>
> On Thu, Jul 09, 2015 at 10:29:14AM -0400, Sandy Stutsman wrote:
>> Hi All.
>>
>> On 6/25/2015 10:58 AM, Sandy Stutsman wrote:
>>> Hello
>>>
>>> - Original Message -
From: "Marc-André Lureau"
To: "Sandy Stutsman"
Ack,
Thanks,
Pavel
On Mon, 2015-07-20 at 20:57 +0200, Christophe Fergeau wrote:
> There are 3 lines in spice.proto/spice1.proto which start with spaces
> and then contain a tab. This commit removes the spaces and only keep the
> tab.
> ---
> spice.proto | 4 ++--
> spice1.proto | 2 +-
> 2 file
There are 3 lines in spice.proto/spice1.proto which start with spaces
and then contain a tab. This commit removes the spaces and only keep the
tab.
---
spice.proto | 4 ++--
spice1.proto | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/spice.proto b/spice.proto
index 2889802
On Mon, Jul 20, 2015 at 11:51:11AM +0200, Pavel Grunt wrote:
> Hey Christophe,
>
> there are some mixed spaces & tabs:
>
> Applying: build-sys: Import code generation files from spice-common
> /home/pgrunt/RH/Spice/spice-protocol/.git/rebase-apply/patch:3568: space
> before
> tab in indent.
>
On Mon, Jul 20, 2015 at 08:18:48PM +0200, Christophe Fergeau wrote:
> ACK 1 through 8 once some minor comments are addressed.
Ok, I managed to comment on the wrong series ;) All of this was meant
for the v2, which are the patches I actually looked at/tested.
Christophe
pgp3TO9_lRPh2.pgp
Descrip
Hi,
On Mon, Jul 20, 2015 at 05:46:41PM +0200, Hans de Goede wrote:
> On 20-07-15 11:51, Christophe Fergeau wrote:
> >Looks good te me now.
> >Hans, would you mind taking a quick look at that
> >patch in case you have objections on the change (if
> >spice_usb_acl_helper_open_acl_finish() fails, try
ACK 1 through 8 once some minor comments are addressed.
Christophe
On Wed, Jul 01, 2015 at 06:09:52PM +0100, Frediano Ziglio wrote:
> As we have a file to specify the protocol and as is hard to align
> wireshark dissector for each change we made I'm trying to do
> part of this job to a code gener
On Wed, Jul 01, 2015 at 06:09:54PM +0100, Frediano Ziglio wrote:
> Blocks was mainly the same, reduce code.
>
> Signed-off-by: Frediano Ziglio
> ---
> python_modules/marshal.py | 29 +++--
> 1 file changed, 11 insertions(+), 18 deletions(-)
>
> diff --git a/python_module
On Wed, Jul 01, 2015 at 06:09:59PM +0100, Frediano Ziglio wrote:
> Verify that the attribute is known. This could help for instance to
> avoid some future typo mistake.
> Also we have a list of attributes we can comment.
>
> Signed-off-by: Frediano Ziglio
> ---
> python_modules/ptypes.py | 69
>
On Wed, Jul 01, 2015 at 06:10:00PM +0100, Frediano Ziglio wrote:
> This attribute is not use in code.
'used'
This was removed in commit 2e8aecc2a56e5b7690d77516e41436b697921b1b I
think. I'd move this commit before the preceding one as you are removing
code that you just added. Or did you use these
Excerpts from Hans de Goede's message of Mon Jul 20 17:46:41 +0200 2015:
> Hi,
>
> On 20-07-15 11:51, Christophe Fergeau wrote:
> > Hey,
> >
> > Looks good te me now.
> > Hans, would you mind taking a quick look at that
> > patch in case you have objections on the change (if
> > spice_usb_acl_help
Hi,
On 20-07-15 11:51, Christophe Fergeau wrote:
Hey,
Looks good te me now.
Hans, would you mind taking a quick look at that
patch in case you have objections on the change (if
spice_usb_acl_helper_open_acl_finish() fails, try to directly open the
device node anyway as it may be user-accessible
Currently, spice-gtk debugging logs contain no traces of the
values of the auto-redir/redir-on-connect filter, and it does not tell
you about the vid/pid of the devices being connected/redirected.
This commit adds the appropriate SPICE_DEBUG/CHANNEL_DEBUG calls so that
this data is logged.
---
src
Hi,
On Mon, Jul 13, 2015 at 11:18:49AM +0400, Viacheslav Ivanov wrote:
> Ok, resending the letter with attachments gzipped.
>
> Hello, Christophe
>
> Thank you for your reply.
>
> I've seen the redirect-on-connect option when we were developing a method to
> get the smartcards to appear in VM
>
> Hey,
>
> Any more comments on this series? Shall I go ahead with this and push
> it?
>
> Christophe
>
The only command I have is go ahead. .proto files describe the protocol so they
should be in spice-protocol by definition. Also they are used to produce a file
used in spice-protocol bu
Hey,
Looks good te me now.
Hans, would you mind taking a quick look at that
patch in case you have objections on the change (if
spice_usb_acl_helper_open_acl_finish() fails, try to directly open the
device node anyway as it may be user-accessible).
Thanks,
Christophe
On Wed, Jul 15, 2015 at 10
On Mon, Jul 20, 2015 at 09:43:23AM +0100, Frediano Ziglio wrote:
The new spice-server function to limit the number of monitors (0.12.6)
changed while development from spice_qxl_set_monitors_config_limit to
spice_qxl_max_monitors (accepted upstream).
By mistake I post patch with former name.
This
Hey,
Any more comments on this series? Shall I go ahead with this and push
it?
Christophe
On Mon, Jul 06, 2015 at 06:33:09PM +0200, Christophe Fergeau wrote:
> Hey,
>
> My goal is (once again) to try to remove the use of spice-protocol as a
> submodule, but always use the installed version inst
Hey,
I've pushed your 3 spice-server patches with the change Uri asked.
Christophe
On Wed, Jul 15, 2015 at 04:34:00PM +0200, Francois Gouget wrote:
> Signed-off-by: Francois Gouget
> ---
> server/main_channel.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/ser
Thanks, pushed.
Christophe
On Wed, Jul 15, 2015 at 02:15:52PM +0100, Frediano Ziglio wrote:
> If a previous Qemu executable is not able to delete the statistic file
> on the next creation with same name (statitics file are based on pid
> numbers so if pid get reused for another Qemu process you g
On Fri, Jul 17, 2015 at 06:02:25PM +0200, Christophe Fergeau wrote:
On Fri, Jul 17, 2015 at 03:42:36PM +0200, Martin Kletzander wrote:
On Fri, Jul 17, 2015 at 12:11:55PM +0200, Peter Krempa wrote:
>On Fri, Jul 17, 2015 at 09:29:44 +0100, Frediano Ziglio wrote:
>>Allows to specify maximum number
On Mon, Jul 20, 2015 at 09:43:23AM +0100, Frediano Ziglio wrote:
> The new spice-server function to limit the number of monitors (0.12.6)
> changed while development from spice_qxl_set_monitors_config_limit to
> spice_qxl_max_monitors (accepted upstream).
> By mistake I post patch with former name.
The new spice-server function to limit the number of monitors (0.12.6)
changed while development from spice_qxl_set_monitors_config_limit to
spice_qxl_max_monitors (accepted upstream).
By mistake I post patch with former name.
This patch fix the function name.
Signed-off-by: Frediano Ziglio
---
24 matches
Mail list logo
