Re: [Spice-devel] [PATCH v3] qemu: Use heads parameter for QXL driver

2015-07-09 Thread Martin Kletzander
On Tue, Jul 07, 2015 at 11:44:11AM +0200, Martin Kletzander wrote: On Mon, Jul 06, 2015 at 09:18:59AM +0100, Frediano Ziglio wrote: Allows to specify maximum number of head to QXL driver. The patch to support the "max_outputs" in Qemu is still not merged but I got agreement on the name of the a

Re: [Spice-devel] [PATCH V2] usbredir: fix redirection of user-accesible device nodes.

2015-07-09 Thread Christophe Fergeau
On Thu, Jul 09, 2015 at 04:58:52PM +0200, Michal Suchanek wrote: > Excerpts from Christophe Fergeau's message of Thu Jul 09 16:41:58 +0200 2015: > > On Thu, Jul 09, 2015 at 03:25:19PM +0100, Michal Suchanek wrote: > > > When calling ACL helper fails also try to open the device node directly. > > >

Re: [Spice-devel] [PATCH V2] usbredir: fix redirection of user-accesible device nodes.

2015-07-09 Thread Michal Suchanek
Excerpts from Christophe Fergeau's message of Thu Jul 09 16:41:58 +0200 2015: > On Thu, Jul 09, 2015 at 03:25:19PM +0100, Michal Suchanek wrote: > > When calling ACL helper fails also try to open the device node directly. > > > > Otherwise user-accessible device nodes are rejected when policykit >

Re: [Spice-devel] [usbredir PATCH] usbredirfilter_check: block device if all its interfaces skipped

2015-07-09 Thread Uri Lublin
On Thu, 2015-07-09 at 10:13 +0200, Hans de Goede wrote: > Hi, > > On 09-07-15 09:19, Christophe Fergeau wrote: > > On Wed, Jul 08, 2015 at 07:36:40PM +0200, Hans de Goede wrote: > > > Can you ask the reporter to provide lsusb -v output for the usb > > > interface > > > of the kvm in question, the

Re: [Spice-devel] [PATCH V2] usbredir: fix redirection of user-accesible device nodes.

2015-07-09 Thread Christophe Fergeau
On Thu, Jul 09, 2015 at 03:25:19PM +0100, Michal Suchanek wrote: > When calling ACL helper fails also try to open the device node directly. > > Otherwise user-accessible device nodes are rejected when policykit > support is compiled in and policy is not set up when in fact the device > could be ac

Re: [Spice-devel] [spice-gtk PATCH] Handle single headed monitors that have a non-zero x, y config

2015-07-09 Thread Sandy Stutsman
Hi All. On 6/25/2015 10:58 AM, Sandy Stutsman wrote: > Hello > > - Original Message - >> From: "Marc-André Lureau" >> To: "Sandy Stutsman" >> Cc: spice-devel@lists.freedesktop.org >> Sent: Thursday, June 25, 2015 7:12:33 AM >> Subject: Re: [Spice-devel] [spice-gtk PATCH] Handle single he

[Spice-devel] [PATCH V2] usbredir: fix redirection of user-accesible device nodes.

2015-07-09 Thread Michal Suchanek
When calling ACL helper fails also try to open the device node directly. Otherwise user-accessible device nodes are rejected when policykit support is compiled in and policy is not set up when in fact the device could be accessed. Signed-off-by: Michal Suchanek -- v2: - clear errors properly

[Spice-devel] [spice-gtk PATCH v3] This adds reference counting to cached images.

2015-07-09 Thread Sandy Stutsman
Windows guests with multi-monitors will often send down the same image via different channels. If these instances are not counted, one channel can delete an image before all the rest of the channels are finished with it. In this case, the client will hang. This can happen, for instance, when the

Re: [Spice-devel] [PATCH] Typo fix in xcode-select command

2015-07-09 Thread Christophe Fergeau
ACK, would be nice to do something like git config format.subjectprefix spice-osx to make it easier to know what the patches relate to. Christophe On Thu, Jul 09, 2015 at 04:17:50PM +0300, Kirill Moizik wrote: > From: Kirill Moizik > > --- > README | 6 +++--- > 1 file changed, 3 insertions(+)

Re: [Spice-devel] [PATCH] usbredir: fix redirection of user-accesible device nodes.

2015-07-09 Thread Christophe Fergeau
On Thu, Jul 09, 2015 at 02:35:58PM +0200, Michal Suchanek wrote: > Excerpts from Christophe Fergeau's message of Thu Jul 09 13:47:51 +0200 2015: > > On Mon, Jun 29, 2015 at 03:46:56PM +0200, Michal Suchanek wrote: > > > When calling ACL helper fails also try to open the device node directly. > > >

[Spice-devel] [PATCH] Typo fix in xcode-select command

2015-07-09 Thread Kirill Moizik
From: Kirill Moizik --- README | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README b/README index 2e8b461..d9d55c5 100644 --- a/README +++ b/README @@ -1,7 +1,7 @@ SHORT INSTRUCTIONS - download XCode -- run sudo xcode-select --switch /Applications/Xcode.app/Conte

Re: [Spice-devel] [PATCH] usbredir: fix redirection of user-accesible device nodes.

2015-07-09 Thread Michal Suchanek
Excerpts from Christophe Fergeau's message of Thu Jul 09 13:47:51 +0200 2015: > On Mon, Jun 29, 2015 at 03:46:56PM +0200, Michal Suchanek wrote: > > When calling ACL helper fails also try to open the device node directly. > > > > Otherwise user-accessible device nodes are rejected when policykit >

Re: [Spice-devel] [PATCH] usbredir: fix redirection of user-accesible device nodes.

2015-07-09 Thread Christophe Fergeau
On Mon, Jun 29, 2015 at 03:46:56PM +0200, Michal Suchanek wrote: > When calling ACL helper fails also try to open the device node directly. > > Otherwise user-accessible device nodes are rejected when policykit > support is compiled in and policy is not set up when in fact the device > could be ac

Re: [Spice-devel] [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

2015-07-09 Thread Alex Elsayed
Alan Stern wrote: > On Mon, 6 Jul 2015, Jeremy White wrote: > >> Anything else fundamental to usbip that should inform the design of a >> usbredir driver? usbip appears to be based off a 2004 vintage of >> dummy_hcd. I'll look thoughtfully at the current dummy_hcd; please let >> me know if ther

Re: [Spice-devel] [spice-common PATCH 4/7 v2] ppc: Fix colors on ppc when using QUIC

2015-07-09 Thread Christophe Fergeau
On Wed, Jul 08, 2015 at 12:09:39PM -0400, Lukas Venhoda wrote: > Hi, > > > Any reason why there is not a patch fixing canvas_get_jpeg{_alpha} ? > I didn't know how to test it, or when it is used (I was just trying to fix > image compressions), so I left it as is. > If someone provides a test case

Re: [Spice-devel] [PATCH] usbredir: fix redirection of user-accesible device nodes.

2015-07-09 Thread Michal Suchanek
Hello, any problem with this one? I am not sure about the GError memory management. Unfortunately the Debian provided version of spicy crashes on exit so I don't get clear valgrind output regarding leaks. The only minor issue is that if you in fact have a libusb issue but have support for the po

Re: [Spice-devel] [spice-common PATCH 7/7 v2] ppc: Fix alpha state checking on BE machines

2015-07-09 Thread Christophe Fergeau
On Wed, Jul 08, 2015 at 12:19:18PM -0400, Lukas Venhoda wrote: > Hi > > > There's a bit of code in the same method doing: > > ... > > does this need fixing too? > > To be honest... I don't know. > It works fine without changing it, and when I changed it, nothing changed :) > > I imagine this sni

Re: [Spice-devel] [usbredir PATCH] usbredirfilter_check: block device if all its interfaces skipped

2015-07-09 Thread Hans de Goede
Hi, On 09-07-15 09:19, Christophe Fergeau wrote: On Wed, Jul 08, 2015 at 07:36:40PM +0200, Hans de Goede wrote: Can you ask the reporter to provide lsusb -v output for the usb interface of the kvm in question, then we can better analyse what exactly is going wrong here. Perhaps my analyses of t

Re: [Spice-devel] [usbredir PATCH] usbredirfilter_check: block device if all its interfaces skipped

2015-07-09 Thread Christophe Fergeau
On Wed, Jul 08, 2015 at 07:36:40PM +0200, Hans de Goede wrote: > Can you ask the reporter to provide lsusb -v output for the usb interface > of the kvm in question, then we can better analyse what exactly is going > wrong here. Perhaps my analyses of the problem is wrong. Is https://bugzilla.redha