On 07/08/2015 02:11 AM, Hans de Goede wrote:
Hi,
On 07-07-15 18:47, Jeremy White wrote:
Well, the checkpatch.pl reports were all style (and mostly whitespace);
roughly 3000 of them against 3000 lines of code :-/. I did review the
code, looking for areas where I thought it would badly cram i
Hi,
Thinking more about this I think I've a good solution.
If we end up skipping all interfaces, then do not return
-ENOENT, but rerun the filter with the
usbredirfilter_fl_dont_skip_non_boot_hid flag or-ed
into the flags argument.
That shhold fix the use case on hand while not overriding
the u
Hi,
On 08-07-15 18:22, Uri Lublin wrote:
Hi Hans,
Thanks for the quick review.
See answers below
On Wed, 2015-07-08 at 15:45 +0200, Hans de Goede wrote:
Hi,
On 08-07-15 15:26, Uri Lublin wrote:
See usbredirfilter.h for when interfaces are skipped.
Fixes rhbz#1179210
Sigh, the kvm in ques
Hi Hans,
Thanks for the quick review.
See answers below
On Wed, 2015-07-08 at 15:45 +0200, Hans de Goede wrote:
> Hi,
>
> On 08-07-15 15:26, Uri Lublin wrote:
> > See usbredirfilter.h for when interfaces are skipped.
> >
> > Fixes rhbz#1179210
>
> Sigh, the kvm in question is really messed up
Hi
> There's a bit of code in the same method doing:
> ...
> does this need fixing too?
To be honest... I don't know.
It works fine without changing it, and when I changed it, nothing changed :)
I imagine this snippet just makes sure, that alpha channel is 255 when using
XRGB.
As I sad before,
Hi,
> Any reason why there is not a patch fixing canvas_get_jpeg{_alpha} ?
I didn't know how to test it, or when it is used (I was just trying to fix
image compressions), so I left it as is.
If someone provides a test case, I can test it and change it later.
> I suspect we are not going to prope
Hi,
> In the subject line "support" (typo)
> "machines"
Can those be fixed before pushing? Or would you prefer me to resend the patch?
> Why do we get both on BE machines, and only one byte order on LE
> machines ? surface_create is called sometimes to create surfaces using
> the 'native' byte or
In the subject line "support" (typo)
On Thu, Jul 02, 2015 at 04:01:40PM +0200, Lukas Venhoda wrote:
> On LE machine, color order will always be ARGB.
> On BE mcahines both ARGB and BGRA states are correct.
"machines"
Why do we get both on BE machines, and only one byte order on LE
machines ? sur
Any reason why there is not a patch fixing canvas_get_jpeg{_alpha} ?
On Thu, Jul 02, 2015 at 04:01:41PM +0200, Lukas Venhoda wrote:
> Fixes color order on PowerPC when using QUIC image compression.
> ---
> Changes since v1:
> - No changes
> ---
> common/canvas_base.c | 6 +++---
> 1 file changed
On Thu, Jul 02, 2015 at 04:01:44PM +0200, Lukas Venhoda wrote:
> When checking, whether we use alpha channel, we need to compare color
> format with constant with the same byte order.
> ---
> Changes since v1:
> - New commit
> ---
> common/canvas_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1
On Wed, Jul 08, 2015 at 04:41:30PM +0200, Victor Toso wrote:
> Hey,
>
> So Phodav and libgovirt are upstream on jhbuild, I removed this two
> patches from the series and updated the phodav dependency in the right
> patch.
>
> Pushed!
> http://cgit.freedesktop.org/spice/spice-jhbuild/log/
Great,
On Wed, Jul 08, 2015 at 06:02:16PM +0300, Kirill Moizik wrote:
> From: Kirill Moizik
>
> The git repository moved from
> http://cgit.freedesktop.org/~teuf/spice-jhbuild/ to
> http://cgit.freedesktop.org/spice/spice-jhbuild/
> ---
> spice-osx-build-setup.sh | 2 +-
> 1 file changed, 1 insertion(+
From: Kirill Moizik
The git repository moved from
http://cgit.freedesktop.org/~teuf/spice-jhbuild/ to
http://cgit.freedesktop.org/spice/spice-jhbuild/
---
spice-osx-build-setup.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/spice-osx-build-setup.sh b/spice-osx-build-setup
Hey,
So Phodav and libgovirt are upstream on jhbuild, I removed this two
patches from the series and updated the phodav dependency in the right
patch.
Pushed!
http://cgit.freedesktop.org/spice/spice-jhbuild/log/
Best,
On Tue, May 26, 2015 at 04:27:54PM +0200, Victor Toso wrote:
> Hi,
>
> On Tu
After the previous commit, spice_bitmap_try_as_pixman() can be
simplified as its #ifdef WORDS_BIGENDIAN exactly match what the
PIXMAN_LE_ constants do.
Last ifdef was left as is, as I don't know what it could break.
---
Changes since v2:
- Changed commit log
Changes since v1:
- New commit
---
On Thu, Jul 02, 2015 at 04:01:39PM +0200, Lukas Venhoda wrote:
> ---
> Last ifdef was left as is, as I don't know what it could break.
I think the log would be clearer with something like:
"pixman_utils: Use PIXMAN_LE_ constants in spice_bitmap_try_as_pixman()
After the previous commit, spice_bi
On Thu, Jul 02, 2015 at 04:01:38PM +0200, Lukas Venhoda wrote:
> When using image compression on PowerPC architecture, colors are in
> wrong order ARGB -> BGRA.
>
> This commit introduces macros, that will change the color order
> according to machine endianness.
ACK.
Christophe
pgpXbc0ypjEzj.
---
python_modules/dissector.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/python_modules/dissector.py b/python_modules/dissector.py
index 413aca4..a7add96 100644
--- a/python_modules/dissector.py
+++ b/python_modules/dissector.py
@@ -223,7 +223,7 @@ def write_wireshark_fi
Support ws_txt and ws_txt_n attributes.
These attributes are there to allow to set specific text to different
elements.
The can be used to output in a single line the features of a structure.
Or they can be used to format small array items.
They can applied to almost everything from primitives, arr
These descriptions will be used to show in wireshark dissector.
Signed-off-by: Frediano Ziglio
---
python_modules/ptypes.py | 16
python_modules/spice_parser.py | 2 +-
2 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/python_modules/ptypes.py b/python_modul
Signed-off-by: Frediano Ziglio
---
python_modules/dissector.py | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/python_modules/dissector.py b/python_modules/dissector.py
index c88118f..554f59c 100644
--- a/python_modules/dissector.py
+++ b/python_modules/dissecto
If just raw data add a single field.
If more complex loop through them.
Signed-off-by: Frediano Ziglio
---
codegen/check_dissector | 4
codegen/data_u16s | Bin 0 -> 2000 bytes
codegen/out_array_primitive.txt | 25 +
codegen/out_array_raw.txt
ws_type override the type (BOOLEAN -> FT_BOOLEAN).
ws_base override the base (DEC -> BASE_HEX).
ws_desc override the description.
ws allow to specify description and name for wireshark. Name is
important as allows filters. Having a single attribute with 2 values
allows to quickly specify the main a
Write a function and call it to be able to reuse it.
Signed-off-by: Frediano Ziglio
---
codegen/check_dissector | 2 ++
codegen/out_struct1.txt | 7 +++
codegen/test.proto | 9 +
python_modules/dissector.py | 20
4 files changed, 38 insertions
---
python_modules/dissector.py | 39 +++
1 file changed, 39 insertions(+)
diff --git a/python_modules/dissector.py b/python_modules/dissector.py
index d623576..827f7f0 100644
--- a/python_modules/dissector.py
+++ b/python_modules/dissector.py
@@ -25,6 +25,45 @
Signed-off-by: Frediano Ziglio
---
codegen/dissector_test.c | 424 ++-
1 file changed, 423 insertions(+), 1 deletion(-)
diff --git a/codegen/dissector_test.c b/codegen/dissector_test.c
index 25a33b5..5a49f40 100644
--- a/codegen/dissector_test.c
+++ b/
Check different format or small arrays formatting.
Is possible to omit to have a tree and dump just the elements.
This is useful for small arrays or if is possible to format all
the item (for instance having a small structure) in a single line.
Signed-off-by: Frediano Ziglio
---
codegen/check_di
Signed-off-by: Frediano Ziglio
---
python_modules/dissector.py | 41 -
1 file changed, 40 insertions(+), 1 deletion(-)
diff --git a/python_modules/dissector.py b/python_modules/dissector.py
index caf817f..b204c61 100644
--- a/python_modules/dissector.py
++
Try to test possible combinations of different attributes
with arrays to make sure output is what is expected.
Signed-off-by: Frediano Ziglio
---
codegen/out_array_primitive.txt | 109 +
codegen/out_array_raw.txt | 12 +++-
codegen/out_array_struct.txt|
Read the pointer and if not 0 create a function to parse it and
call it.
Signed-off-by: Frediano Ziglio
---
python_modules/dissector.py | 49 +
1 file changed, 49 insertions(+)
diff --git a/python_modules/dissector.py b/python_modules/dissector.py
ind
Type will be mapped to an enumerator containing all channel types.
Signed-off-by: Frediano Ziglio
---
codegen/check_dissector | 2 ++
codegen/out_channel.txt | 7 +++
codegen/test.proto | 15 +++
python_modules/dissector.py | 14 +-
spice.proto
This allow to emulate reading from network
Signed-off-by: Frediano Ziglio
---
codegen/check_dissector | 4 ++--
codegen/dissector_test.c | 32 +---
2 files changed, 31 insertions(+), 5 deletions(-)
diff --git a/codegen/check_dissector b/codegen/check_dissector
inde
Add fields to base tree (so basically there is no tree).
Names is now generated from container + member name.
The check for duplicate is not that strong, should check if same field
is defined with same attributes.
Signed-off-by: Frediano Ziglio
---
codegen/Makefile.am | 36 +
This attribute allow structure to be aligned instead of be contained
in a separate function.
This is helpful as variable are declared in the function so allows
other member to reference to a nested structure.
Signed-off-by: Frediano Ziglio
---
python_modules/dissector.py | 11 ---
1 file
Instead of only show the hexadecimal value show all bits.
Signed-off-by: Frediano Ziglio
---
codegen/dissector_test.c| 22
codegen/out_base1.txt | 81 -
python_modules/dissector.py | 81 +--
Allow to reuse code and check better if field was already registered
Signed-off-by: Frediano Ziglio
---
python_modules/dissector.py | 58 +
1 file changed, 48 insertions(+), 10 deletions(-)
diff --git a/python_modules/dissector.py b/python_modules/dis
Generate global definitions.
Generate function to registers various dissector components.
For the moment the field array is empty bu we save some global to
be able to register new ones.
Add a base test for generated dissector.
Signed-off-by: Frediano Ziglio
---
Makefile.am | 2 +
Signed-off-by: Frediano Ziglio
---
python_modules/dissector.py | 48 +++--
1 file changed, 46 insertions(+), 2 deletions(-)
diff --git a/python_modules/dissector.py b/python_modules/dissector.py
index a7add96..aa71615 100644
--- a/python_modules/dissector.
To make output more useful fields from the protocol should have
additional information like description, name, type and so on.
List of attributes added:
- ws_desc, just a simple description
- ws_name name of the field. See below
- ws allow to specify a description and a name. Useful as easy to
t
Store into references for future usage.
Signed-off-by: Frediano Ziglio
---
python_modules/dissector.py | 32
1 file changed, 32 insertions(+)
diff --git a/python_modules/dissector.py b/python_modules/dissector.py
index cd653b3..da89def 100644
--- a/python_module
Messages are not generated as stub.
Code partially from demarshaller.
Signed-off-by: Frediano Ziglio
---
codegen/Makefile.am | 3 +-
codegen/check_dissector | 13 +
codegen/dissector_test.c| 54 -
python_modules/dissector.py | 138 +
Signed-off-by: Frediano Ziglio
---
spice.proto | 414
1 file changed, 218 insertions(+), 196 deletions(-)
diff --git a/spice.proto b/spice.proto
index 2889802..163215b 100644
--- a/spice.proto
+++ b/spice.proto
@@ -5,14 +5,14 @@
typed
I'm generating code for dissector from demarshaller.
Make simple to hangle ifdef/endif not having to check manually attribute.
Signed-off-by: Frediano Ziglio
---
python_modules/dissector.py | 18 ++
1 file changed, 18 insertions(+)
diff --git a/python_modules/dissector.py b/pyth
Signed-off-by: Frediano Ziglio
---
python_modules/dissector.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/python_modules/dissector.py b/python_modules/dissector.py
index af0494c..40e348a 100644
--- a/python_modules/dissector.py
+++ b/python_modules/dissector.py
@@ -236,6 +236,8 @@ def
Add some classes to be able to store retrieved data from structure
and messages.
The idea is to generate code dynamically when variable are readed.
Signed-off-by: Frediano Ziglio
---
python_modules/dissector.py | 104 +++-
1 file changed, 103 insertions(+)
This attribute is not use in code.
Signed-off-by: Frediano Ziglio
---
python_modules/ptypes.py | 4
1 file changed, 4 deletions(-)
diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py
index 3a307ed..f94fd24 100644
--- a/python_modules/ptypes.py
+++ b/python_modules/ptypes.py
@@
Signed-off-by: Frediano Ziglio
---
python_modules/ptypes.py | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py
index d031d09..845fa73 100644
--- a/python_modules/ptypes.py
+++ b/python_modules/
Use an array to declare tree items instead of allocating it statically.
This save a bit of memory and it also generate smaller code to read.
A tree in wireshark represent an item which could be expanded.
Possibly wireshark is using these registrations to save expansion
state in the user interface.
Specifying attributes for items allows to specify different attribute
for the same member where some are specific to the item while the
other to the array.
The element attributes are attached to the array as they cannot be
attached to the type as the object is unique for each type.
Same for pointer
Verify that the attribute is known. This could help for instance to
avoid some future typo mistake.
Also we have a list of attributes we can comment.
Signed-off-by: Frediano Ziglio
---
python_modules/ptypes.py | 69
1 file changed, 69 insertions(+
This to prepare to generate wireshark dissector which use
glib types instead of new C ones (for compatibility with some
compiler).
Signed-off-by: Frediano Ziglio
---
python_modules/codegen.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/python_modules/codegen.py b/pytho
Added a stub dissector.py code.
Added file to Makefiles.
Add option to call dissector and code to call it.
Signed-off-by: Frediano Ziglio
---
common/Makefile.am | 1 +
python_modules/Makefile.am | 1 +
python_modules/dissector.py | 14 ++
spice_codegen.py| 17
Parse all members of the containers
Signed-off-by: Frediano Ziglio
---
python_modules/dissector.py | 19 +++
1 file changed, 19 insertions(+)
diff --git a/python_modules/dissector.py b/python_modules/dissector.py
index 588becd..ed3b939 100644
--- a/python_modules/dissector.py
++
Check members are all of a giver type and call stubs for each type.
Signed-off-by: Frediano Ziglio
---
python_modules/dissector.py | 50 +++--
1 file changed, 48 insertions(+), 2 deletions(-)
diff --git a/python_modules/dissector.py b/python_modules/disse
Signed-off-by: Frediano Ziglio
---
python_modules/spice_parser.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/python_modules/spice_parser.py b/python_modules/spice_parser.py
index 80b559b..97af8b2 100644
--- a/python_modules/spice_parser.py
+++ b/python_modules/spice_parser.py
@@ -58,7 +58
Signed-off-by: Frediano Ziglio
---
python_modules/codegen.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/python_modules/codegen.py b/python_modules/codegen.py
index 55500b7..02ffdb9 100644
--- a/python_modules/codegen.py
+++ b/python_modules/codegen.py
@@ -130,8 +130,7 @
---
python_modules/codegen.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/python_modules/codegen.py b/python_modules/codegen.py
index 02ffdb9..c470988 100644
--- a/python_modules/codegen.py
+++ b/python_modules/codegen.py
@@ -357,6 +357,7 @@ class CodeWriter:
return index
d
Signed-off-by: Frediano Ziglio
---
python_modules/codegen.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/python_modules/codegen.py b/python_modules/codegen.py
index f324498..55500b7 100644
--- a/python_modules/codegen.py
+++ b/python_modules/codegen.py
@@ -193,7 +193,7 @@
As we have a file to specify the protocol and as is hard to align
wireshark dissector for each change we made I'm trying to do
part of this job to a code generator.
The idea is to have the dissector split in two part, one hand
written and the other automatic.
I tested that changing the code and p
The module was used in the initial try/except so make sure it is
already imported.
Signed-off-by: Frediano Ziglio
---
python_modules/spice_parser.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/python_modules/spice_parser.py b/python_modules/spice_parser.py
index d60bb10
Blocks was mainly the same, reduce code.
Signed-off-by: Frediano Ziglio
---
python_modules/marshal.py | 29 +++--
1 file changed, 11 insertions(+), 18 deletions(-)
diff --git a/python_modules/marshal.py b/python_modules/marshal.py
index b77b910..cbda2ab 100644
--- a/pyth
Hi,
On 08-07-15 15:26, Uri Lublin wrote:
See usbredirfilter.h for when interfaces are skipped.
Fixes rhbz#1179210
Sigh, the kvm in question is really messed up as it uses non bootclass hid
interfaces,
that means it won't work in many BIOS' etc. What a mess ...
---
usbredirparser/usbredir
See usbredirfilter.h for when interfaces are skipped.
Fixes rhbz#1179210
---
usbredirparser/usbredirfilter.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/usbredirparser/usbredirfilter.c b/usbredirparser/usbredirfilter.c
index ef9c63a..5cbbfbf 100644
--- a/usbred
On Wed, Jul 8, 2015 at 11:55 AM, Christophe Fergeau wrote:
> Hey, since the spice-jhbuild repository moved from
> http://cgit.freedesktop.org/~teuf/spice-jhbuild/ to
> http://cgit.freedesktop.org/spice/spice-jhbuild/ , a few things needed to be
> adjusted in the osx moduleset.
>
>
Hey,
I've pushed these, thanks for the resend!
Christophe
pgp13hneMpqJy.pgp
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
On Wed, Jul 8, 2015 at 12:07 PM, Christophe Fergeau
wrote:
> Hey,
>
> On Tue, Jul 07, 2015 at 05:12:22PM +0300, Kirill Moizik wrote:
> > On Tue, Jul 7, 2015 at 3:51 PM, Christophe Fergeau
> > wrote:
> >
> > > On Mon, Jul 06, 2015 at 08:59:06PM +0300, Kirill Moizik wrote:
> > > > we will spawn a
Probably no ill effect, but caused bad highlighting in my vim.
---
bundle/remote-viewer-gtk3.bundle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bundle/remote-viewer-gtk3.bundle b/bundle/remote-viewer-gtk3.bundle
index a6315ca..49508e4 100644
--- a/bundle/remote-viewer-gtk3.
The git repository moved from
http://cgit.freedesktop.org/~teuf/spice-jhbuild/ to
http://cgit.freedesktop.org/spice/spice-jhbuild/
---
README| 4 ++--
jhbuildrc | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/README b/README
index 2e8b461..c480c5e 100644
--- a/README
+++
Hey, since the spice-jhbuild repository moved from
http://cgit.freedesktop.org/~teuf/spice-jhbuild/ to
http://cgit.freedesktop.org/spice/spice-jhbuild/ , a few things needed to be
adjusted in the osx moduleset.
___
Spice-devel mailing list
Spice-devel@li
It's more convenient to handle if it's stored together with the jhbuild
moduleset rather than in a separate webspace.
---
modulesets/spice.xml | 2 +-
patches/celt-0.5.1.3-dont-recurse-into-tests.patch | 13 +
2 files changed, 14 insertions(+), 1 deletion
Hey,
On Tue, Jul 07, 2015 at 05:12:22PM +0300, Kirill Moizik wrote:
> On Tue, Jul 7, 2015 at 3:51 PM, Christophe Fergeau
> wrote:
>
> > On Mon, Jul 06, 2015 at 08:59:06PM +0300, Kirill Moizik wrote:
> > > we will spawn a separate thread to disconnect usb device, when finish we
> > will update wi
Hi,
On 07-07-15 18:47, Jeremy White wrote:
Well, the checkpatch.pl reports were all style (and mostly whitespace);
roughly 3000 of them against 3000 lines of code :-/. I did review the
code, looking for areas where I thought it would badly cram into the
kernel, and I adjusted the few I found
72 matches
Mail list logo
