Hi all,
I worked directly with Victor to test out his patch and wanted to report
back to the mailing list on my results. I set SPICE_KEYPRESS_DELAY=10 and
saw an improvement in the response time when I was typing. I was using
Fedora 21 in the client with Gnome 3 and tried typing in LibreOffice
Sorry for the duplicate. I was getting a bogus "mail not sent" message.
-S
- Original Message -
> From: "Sandy Stutsman"
> To: spice-devel@lists.freedesktop.org
> Sent: Monday, June 22, 2015 5:44:28 PM
> Subject: [Spice-devel] [spice PATCH] Lock the pixmap cache for the fill_bits
> fun
When a Windows guest uses the "Set Resolution" applet to change
resolutions and/or monitor positions, this escape sends the new monitor
configurations to the client via a new QXL driver escape.
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1202419
---
Change from v1:
* Add call to update
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1202419
A monitors_config message needs to be sent from the guest to the client
when monitors are ordered with the "Set Resolution" applet.
---
I think it is best to keep the Windows driver escape structures together
in the qxl_windows.h fil
Locking the individual calls that access the pixmap cache in fill_bits is
not adequately thread safe. Often a windows guest with multiple monitors
will be sending the same image via different threads. Both threads can
be in fill_bits at the same making changes to the cache for the same
image. This
Locking the individual calls that access the pixmap cache in fill_bits is
not adequately thread safe. Often a windows guest with multiple monitors
will be sending the same image via different threads. Both threads can
be in fill_bits at the same making changes to the cache for the same
image. This
- Original Message -
> This is the equivalent of the patches which were just pushed to spice-server,
> rather than duplicating configure checks between spice-server and spice-gtk,
> we
> can use m4 macros available from spice-common.
looks good, ack
__
Locking the individual calls that access the pixmap cache in fill_bits is
not adequately thread safe. Often a windows guest with multiple monitors
will be sending the same image via different threads. Both threads can
be in fill_bits at the same making changes to the cache for the same
image. This
Add missing information
---
%u is better than %d !
---
xddm/display/res.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xddm/display/res.c b/xddm/display/res.c
index bfb3571..6864e51 100644
--- a/xddm/display/res.c
+++ b/xddm/display/res.c
@@ -2005,7 +2005,7 @@ static BOOL Ca
>
> Missing useful information.
> ---
> xddm/display/res.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xddm/display/res.c b/xddm/display/res.c
> index bfb3571..84f9756 100644
> --- a/xddm/display/res.c
> +++ b/xddm/display/res.c
> @@ -2005,7 +2005,7 @@ static BOOL Cach
---
xddm/miniport/qxl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xddm/miniport/qxl.c b/xddm/miniport/qxl.c
index f5d6b48..85e4fcf 100644
--- a/xddm/miniport/qxl.c
+++ b/xddm/miniport/qxl.c
@@ -1261,7 +1261,7 @@ BOOLEAN StartIO(PVOID dev_extension,
PVIDEO_REQUEST_PACKET p
Missing useful information.
---
xddm/display/res.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xddm/display/res.c b/xddm/display/res.c
index bfb3571..84f9756 100644
--- a/xddm/display/res.c
+++ b/xddm/display/res.c
@@ -2005,7 +2005,7 @@ static BOOL CacheSizeTest(PDev *pdev,
On Mon, Jun 22, 2015 at 06:19:03PM +0200, Victor Toso wrote:
> On Mon, Jun 22, 2015 at 06:17:35PM +0200, Victor Toso wrote:
> > Hey,
> >
> > This series and moving the --enable-lz4 to spice-common looks good to
> > me.
> + version check on lz4 (> 118)
Ok I've pushed all of this, thanks.
Christoph
spice-common has an m4 macro adding a --enable-smartcard option and
doing the needed checks, so we can use it in configure.ac rather than
duplicating it here.
---
configure.ac | 19 ++-
1 file changed, 2 insertions(+), 17 deletions(-)
diff --git a/configure.ac b/configure.ac
index
This is the equivalent of the patches which were just pushed to spice-server,
rather than duplicating configure checks between spice-server and spice-gtk, we
can use m4 macros available from spice-common.
Christophe
___
Spice-devel mailing list
Spice-de
spice-common now has an m4 macro adding a --enable-lz4 option and
doing the needed checks, so we can use it in configure.ac rather than
duplicating it here.
---
configure.ac | 13 +
spice-common | 2 +-
2 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/configure.ac b/con
On Mon, Jun 22, 2015 at 07:09:05PM +0200, Christophe Fergeau wrote:
> On Mon, Jun 22, 2015 at 04:08:12PM +0200, Javier Celaya wrote:
> > El Lunes, 22 de junio de 2015 13:39:17 Christophe Fergeau escribió:
> > > Hey,
> > >
> > > On Fri, Jun 19, 2015 at 02:05:10PM +0200, Javier Celaya wrote:
> > > >
---
src/qxl_surface.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/qxl_surface.c b/src/qxl_surface.c
index 6fc2146..6a7e275 100644
--- a/src/qxl_surface.c
+++ b/src/qxl_surface.c
@@ -84,6 +84,7 @@ make_drawable (qxl_screen_t *qxl, qxl_surface_t *surf,
uint8_t type,
if (rect)
On Mon, Jun 22, 2015 at 04:08:12PM +0200, Javier Celaya wrote:
> El Lunes, 22 de junio de 2015 13:39:17 Christophe Fergeau escribió:
> > Hey,
> >
> > On Fri, Jun 19, 2015 at 02:05:10PM +0200, Javier Celaya wrote:
> > > When KMS is enabled, the mm_time value of a QXLDrawable is undefined.
> > > Thi
On Thu, Jun 18, 2015 at 07:14:10PM -0400, sstut...@redhat.com wrote:
> From: Sandy Stutsman
>
> When a Windows guest uses the "Set Resolution" applet to change
> resolutions and/or monitor positions, this escape sends the new monitor
> configurations to the client via a new QXL driver escape.
>
That's a good question. I didn't see it happen and I haven't follow the code
paths for the other cached
items other than to notice that they were different. I was opting to let
"sleeping dogs" alone by not
changing things that didn't seem broken.
- Original Message -
> From: "Marc-An
On Mon, Jun 22, 2015 at 06:17:35PM +0200, Victor Toso wrote:
> Hey,
>
> This series and moving the --enable-lz4 to spice-common looks good to
> me.
+ version check on lz4 (> 118)
>
> - toso
>
> On Thu, Jun 18, 2015 at 11:58:28AM +0200, Christophe Fergeau wrote:
> > Besides the code factorization,
On Wed, 10 Jun 2015, Francois Gouget wrote:
> The checks would lead the reader to think these functions can be called when
> bit rate control is off when in fact they are only called when it is active.
>
> Signed-off-by: Francois Gouget
> ---
>
> This patch stands on its own and I think it mak
Hey,
This series and moving the --enable-lz4 to spice-common looks good to
me.
- toso
On Thu, Jun 18, 2015 at 11:58:28AM +0200, Christophe Fergeau wrote:
> Besides the code factorization, this will allow smartcard support to be
> automatically enabled if libcacard is present and --disable-smartc
On 06/22/2015 10:26 AM, Hans de Goede wrote:
> Hi Jeremy,
>
> On 17-06-15 21:06, Jeremy White wrote:
>> I have started work on a usbredir kernel module to enable USB
>> redirection for XSpice.
>>
>> I'd like to reuse the usbredirparser.c code, but it needs changes to
>> compile as part of a kernel
On Thu, 11 Jun 2015, Francois Gouget wrote:
> Signed-off-by: Francois Gouget
> ---
>
> This implements Marc-André Lureau's suggestion:
> http://lists.freedesktop.org/archives/spice-devel/2015-June/020202.html
>
> And supersedes the input-fps rounding patch.
> http://lists.freedesktop.org/archiv
Not familiar at all with the windows driver code, but this one looks
good. The setting of QXLRam::monitors_config value is quite convoluted,
but seems in line with what the rest of the code does.
SetMonitorsConfig will change if you agree with the suggested changes
for the QXLEscapeMonitorConfig st
Hi,
> Actually, when a new image arrives with an id that is currently in the cache,
> it will replace the older one. It will just be created with a +1 reference
> count.
>
> In the case I've been debugging, the image in question is the Windows
> wallpaper.
> As there is a driver instance for each
- Original Message -
> Hello
>
> - Original Message -
> > From: "Marc-André Lureau"
> > To: "Sandy Stutsman"
> > Cc: spice-devel@lists.freedesktop.org
> > Sent: Friday, June 19, 2015 6:58:36 PM
> > Subject: Re: [Spice-devel] [spice-gtk PATCH] This adds reference counting
> > to
Hi Jeremy,
On 17-06-15 21:06, Jeremy White wrote:
I have started work on a usbredir kernel module to enable USB
redirection for XSpice.
I'd like to reuse the usbredirparser.c code, but it needs changes to
compile as part of a kernel module. These are those changes.
The changes look fine to m
On Thu, Jun 18, 2015 at 07:14:11PM -0400, sstut...@redhat.com wrote:
> From: Sandy Stutsman
>
> Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1202419
>
> A monitors_config message needs to be sent from the guest to the client
> when monitors are ordered with the "Set Resolution" applet.
Hello
- Original Message -
> From: "Marc-André Lureau"
> To: "Sandy Stutsman"
> Cc: spice-devel@lists.freedesktop.org
> Sent: Friday, June 19, 2015 6:58:36 PM
> Subject: Re: [Spice-devel] [spice-gtk PATCH] This adds reference counting to
> cached images.
>
> Hi
>
> - Original Mess
El Lunes, 22 de junio de 2015 13:39:17 Christophe Fergeau escribió:
> Hey,
>
> On Fri, Jun 19, 2015 at 02:05:10PM +0200, Javier Celaya wrote:
> > When KMS is enabled, the mm_time value of a QXLDrawable is undefined.
> > This results in severe synchronization problems. This patch sets it to
> > zer
On Mon, Jun 22, 2015 at 03:03:24PM +0200, Christophe Fergeau wrote:
> On Thu, Jun 18, 2015 at 07:14:13PM -0400, sstut...@redhat.com wrote:
> > From: Sandy Stutsman
> >
> > Each monitor on a Windows guest is represented as a separate, single-headed
> > device with its own framebuffer. When there
On Thu, Jun 18, 2015 at 07:14:13PM -0400, sstut...@redhat.com wrote:
> From: Sandy Stutsman
>
> Each monitor on a Windows guest is represented as a separate, single-headed
> device with its own framebuffer. When there are multiple monitors, all
> monitors but one will have a non-zero xy config p
Hey,
Seems fine, though it's not clear to me why this would only impact the
first image? Also, do we have limitations on the kind of images quic can
compress? This patch always uses quic when SPICE_IMAGE_COMPRESS_QUIC is
used.
Christophe
On Fri, Jun 19, 2015 at 03:44:39PM +0200, Pavel Grunt wrot
Hey,
On Fri, Jun 19, 2015 at 02:05:10PM +0200, Javier Celaya wrote:
> When KMS is enabled, the mm_time value of a QXLDrawable is undefined.
> This results in severe synchronization problems. This patch sets it to
> zero to force the spice-server to use the local clock.
> ---
> src/qxl_surface.c |
From: Sandy Stutsman
Locking the individual calls that access the pixmap cache in fill_bits
is not adequately thread safe. Often a windows guest with multiple
monitors will be sending the same image via different threads. Both
threads can be in fill_bits at the same making changes to the cache fo
38 matches
Mail list logo
