From: Sandy Stutsman
Provides correct monitor locations when specified via the guest
"Screen Resolution" applet.
Addresses:https://bugzilla.redhat.com/show_bug.cgi?id=1202419
---
xddm/display/driver.c | 34 ++
xddm/display/qxldd.h | 4
xddm/display
From: Sandy Stutsman
Each monitor on a Windows guest is represented as a separate, single-headed
device with its own framebuffer. When there are multiple monitors, all
monitors but one will have a non-zero xy config position. But even in
these cases the whole area (frame-buffer) of each monitor
From: Sandy Stutsman
When a Windows guest uses the "Set Resolution" applet to change
resolutions and/or monitor positions, this escape sends the new monitor
configurations to the client via a new QXL driver escape.
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1202419
---
Depends on spi
From: Sandy Stutsman
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1202419
A monitors_config message needs to be sent from the guest to the client
when monitors are ordered with the "Set Resolution" applet.
---
spice/qxl_windows.h | 10 ++
1 file changed, 10 insertions(+)
diff
From: Sandy Stutsman
Patches for BZ1210796 and BZ1202419
If a Windows guest uses the "Screen Resolution" applet to arrange its
monitors, there is currently no way to pass that information to the
client.
As a result, the monitors can't be properly configured this way and the
monitors often en
Hey,
On Thu, Jun 18, 2015 at 06:57:10PM +, Klaus Hochlehnert wrote:
> Both are version 114
So, yes, lz4 package is too old in Ubuntu 14.04.
Looks like that this LZ4_streamDecode_t was introduced on r118.
(last release is 130, Fedora 22 has 129).
Best,
-toso
>
> -Original Message-
>
Sent from my iPad
> On Jun 18, 2015, at 18:29, Christophe Fergeau wrote:
>
> Hey,
>
>> On Thu, Jun 18, 2015 at 03:46:16PM +0300, Kirill Moizik wrote:
>> From: Kirill Moizik
>>
>> Introduce UsbDk API definitions and binding code.
>>
>> Signed-off-by: Kirill Moizik
>> ---
>> src/Makefile.am
Both are version 114
-Original Message-
From: Victor Toso [mailto:victort...@redhat.com]
Sent: Thursday, June 18, 2015 8:32 PM
To: Klaus Hochlehnert
Cc: spice-devel@lists.freedesktop.org
Subject: Re: [Spice-devel] Make problem wit lz4
Hi,
On Thu, Jun 18, 2015 at 05:40:29PM +, Klaus
Hi,
On Thu, Jun 18, 2015 at 05:40:29PM +, Klaus Hochlehnert wrote:
> Hi,
>
> I tried to build spice-gtk-0.29 with lz4 support on Ubuntu 14.04 and get this
> error:
>
> ...
> In file included from ../spice-common/common/sw_canvas.c:29:0,
> from client_sw_canvas.c:20:
> ../spic
This small series is a first effort to fix client-side endianess
problems. With the patches applied (plus the ones for spice-common), we
can connect to and play with a guest running on a LE machine with a BE
client. However, there a few things that are not working properly
- Connecting to a guest
From: Fabiano Fidêncio
---
src/spice-channel.c | 61 -
1 file changed, 37 insertions(+), 24 deletions(-)
diff --git a/src/spice-channel.c b/src/spice-channel.c
index e247ba5..acdc55c 100644
--- a/src/spice-channel.c
+++ b/src/spice-channel.c
@
From: Fabiano Fidêncio
---
src/spice-channel.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/spice-channel.c b/src/spice-channel.c
index c67e0aa..e247ba5 100644
--- a/src/spice-channel.c
+++ b/src/spice-channel.c
@@ -372,9 +372,9 @@ static inline
Converts all decoded words in quic from little endian to local
machine endianness.
---
common/quic.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/common/quic.c b/common/quic.c
index 498b9cc..a9bd215 100644
--- a/common/quic.c
+++ b/common/quic.c
@@ -23,6 +23,8 @@
#i
Quic magic would have to be converted when sending to BE client.
This ensures, that both client and server always have the same quick magic.
---
common/quic.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/common/quic.c b/common/quic.c
index 16290d4..498b9cc 100644
--- a/com
Commit d39dfbfe changes to be lz magic always treated as LE when encoded.
Changing lz magic to constant instead of a runtime coversion from string
to int is a better way to go. This way lz magic will stay the same on
both BE and LE machines.
This commit reverts d39dfbfe changes in lz.c while keep
Theese patches will fix connection from BE client to LE host/guest.
It's not 100%, but it won't crash anymore.
Theese patches need to be applyed both on spice-gtk and spice-server.
There are a few issues:
- If compression is not off, colors are swapped (RGBA->GRAB).
- If compression is off, onl
Hi,
I tried to build spice-gtk-0.29 with lz4 support on Ubuntu 14.04 and get this
error:
...
In file included from ../spice-common/common/sw_canvas.c:29:0,
from client_sw_canvas.c:20:
../spice-common/common/canvas_base.c: In function 'canvas_get_lz4':
../spice-common/common/canv
ack thanks
On Thu, Jun 18, 2015 at 5:50 PM, Christophe Fergeau
wrote:
> These are only meant to be test tools so they don't need to be
> translated.
> ---
> po/POTFILES.in | 4 ---
> src/spicy-connect.c| 15 -
> src/spicy-screenshot.c | 27 +++-
> src/spicy-stat
These are only meant to be test tools so they don't need to be
translated.
---
po/POTFILES.in | 4 ---
src/spicy-connect.c| 15 -
src/spicy-screenshot.c | 27 +++-
src/spicy-stats.c | 15 +++--
src/spicy.c| 86 --
Hey,
Series looks good apart from some minor comments on "UsbDk: Add UsbDk
wrapper"
Christophe
On Thu, Jun 18, 2015 at 03:46:13PM +0300, Kirill Moizik wrote:
> From: Kirill Moizik
>
> V4 changeset :
> -fix commit author
> -fix "usbdk standalone fix" commit description
> -fix too long lines in
Hey,
On Thu, Jun 18, 2015 at 03:46:16PM +0300, Kirill Moizik wrote:
> From: Kirill Moizik
>
> Introduce UsbDk API definitions and binding code.
>
> Signed-off-by: Kirill Moizik
> ---
> src/Makefile.am | 2 +
> src/usbdk_api.c | 173
>
On Thu, Jun 18, 2015 at 04:39:26PM +0200, Christophe Fergeau wrote:
> ACK.
And I've pushed the series.
Christophe
pgpXxiUcaskGN.pgp
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/
On Thu, Jun 18, 2015 at 09:46:50AM -0400, Marc-André Lureau wrote:
> - Original Message -
> > Well, it's already translated before these patches, except for some
> > strings, so these patches are fixing a preexisting bug. I don't mind
> > dropping i18n support from spicy altogether, but sin
ACK.
Christophe
On Thu, Jun 18, 2015 at 04:35:24PM +0200, Lukas Venhoda wrote:
> Changed connect dialog from GtkDialog to GtkWindow.
>
> Added the necessary signals and buttons, to keep then
> behaviour of a dialog (ESC to close, ENTER to submit).
>
> spicy_connect_dialog now returns TRUE and F
Changed connect dialog from GtkDialog to GtkWindow.
Added the necessary signals and buttons, to keep then
behaviour of a dialog (ESC to close, ENTER to submit).
spicy_connect_dialog now returns TRUE and FALSE instead of 0 and -1.
---
Changes since v5
- Changed gtk2 compatibility macro back
-
Hi
- Original Message -
> Hey,
>
> On Thu, Jun 18, 2015 at 03:12:53PM +0200, Victor Toso wrote:
> > Hey,
> >
> > On Tue, Jun 16, 2015 at 02:34:22PM +0200, Christophe Fergeau wrote:
> > > Hey, this 3 patch series goes on top of Lukas changes, and fix some
> > > translation related bugs (u
On Fri, Jun 12, 2015 at 03:05:10PM +0100, Frediano Ziglio wrote:
> This patch allow to limit number of heads using qxl driver. By default
> qxl driver is not limited on any kind on head use so can decide to use
> as much heads.
>
> libvirt has this as a video card parameter (actually set to 1 but
Hey,
On Thu, Jun 18, 2015 at 03:12:53PM +0200, Victor Toso wrote:
> Hey,
>
> On Tue, Jun 16, 2015 at 02:34:22PM +0200, Christophe Fergeau wrote:
> > Hey, this 3 patch series goes on top of Lukas changes, and fix some
> > translation related bugs (untranslated strings in the UI).
>
> I just feel
Hey,
On Thu, Jun 18, 2015 at 09:11:08AM -0400, Marc-André Lureau wrote:
> > +if (env != NULL)
> > +delay = (guint) g_ascii_strtoull(env, NULL, 10);
> > +
> strtoul is probably fine too (without cast?)
Yeah, I'm always using glib even when not necessary...
> > +
Hi
- Original Message -
> Hey,
>
> On Tue, Jun 16, 2015 at 02:34:22PM +0200, Christophe Fergeau wrote:
> > Hey, this 3 patch series goes on top of Lukas changes, and fix some
> > translation related bugs (untranslated strings in the UI).
>
> I just feel a small conflict about tagging spi
>
> Hey,
>
>
> Looks good to me, a few comments below. A bit worried that the guest
> does not really know about the maximum number of monitors and about
> truncating monitors info behind its back, but I don't have actual issues
> to point out... (well, with an UMS driver, you can use xrandr to
Hey,
On Tue, Jun 16, 2015 at 02:34:22PM +0200, Christophe Fergeau wrote:
> Hey, this 3 patch series goes on top of Lukas changes, and fix some
> translation related bugs (untranslated strings in the UI).
I just feel a small conflict about tagging spicy as a testing tool and
translating it. But as
hi
- Original Message -
> ---
> src/spice-widget.c | 10 +-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/src/spice-widget.c b/src/spice-widget.c
> index 260fda5..30a6636 100644
> --- a/src/spice-widget.c
> +++ b/src/spice-widget.c
> @@ -364,7 +364,15 @@ stati
On Fri, Jun 12, 2015 at 03:17:38PM +0100, Frediano Ziglio wrote:
> As one interface was added bump the version and put a comment to avoid
> too much updates.
This usually is done right before making a release, but change is
correct, ACK.
Christophe
>
> Signed-off-by: Frediano Ziglio
> ---
> c
Hey,
Looks good to me, a few comments below. A bit worried that the guest
does not really know about the maximum number of monitors and about
truncating monitors info behind its back, but I don't have actual issues
to point out... (well, with an UMS driver, you can use xrandr to enable
more monit
---
src/spice-widget.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index 260fda5..30a6636 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -364,7 +364,15 @@ static void spice_display_set_property(GObject
*ob
From: Kirill Moizik
Only grey out the USB redirection widget if neither usbclerk nor usbdk
are available. Currently, spice_usb_device_manager_initable_init() will
return FALSE when UsbClerk is not
present even if we are trying to use UsbDk. This will cause the USB
redirection widget to be greyed
From: Kirill Moizik
Introduce UsbDk API definitions and binding code.
Signed-off-by: Kirill Moizik
---
src/Makefile.am | 2 +
src/usbdk_api.c | 173
src/usbdk_api.h | 34 +++
3 files changed, 209 insertions(+)
create mode 100
From: Kirill Moizik
V4 changeset :
-fix commit author
-fix "usbdk standalone fix" commit description
-fix too long lines in usbdk_api.c file
V3 changeset :
-use Christophe's split
-fix usbdk standalone mode (usb redirection widget gray out when usbclerk not
installed)
-use match_all constant at
From: Kirill Moizik
Backend is chosen dynamically, if UsbDk is not installed, then WinUsb/usbclerk
will be chosen.
Signed-off-by: Kirill Moizik
---
src/usb-device-manager.c | 86 +++-
1 file changed, 78 insertions(+), 8 deletions(-)
diff --git a/src
From: Christophe Fergeau
The Windows-specific version duplicates some code from
spice_usb_device_manager_libdev_match(), this commit
switches to using that helper instead.
---
src/usb-device-manager.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/src/usb-devic
From: Christophe Fergeau
This additional parameter is currently unused, but this is in
preparation for the next commits.
---
src/usb-device-manager.c | 40 ++--
1 file changed, 22 insertions(+), 18 deletions(-)
diff --git a/src/usb-device-manager.c b/src/usb-
From: Christophe Fergeau
The Windows-specific version duplicates some code from
spice_usb_device_equal_libdev(), this commit
switches to using that helper instead.
---
src/usb-device-manager.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/src/usb-device-manager.c b/sr
From: Kirill Moizik
This will be useful when adding usbdk support as usbdk may not be
available, so we'll need to switch between the usbdk and usbclerk code
paths at runtime (only at init-time). For now, this is used to replace
the #ifdef G_OS_WIN32/G_OS_LINUX blocks with a runtime test (on linux
Hey,
On Thu, Jun 18, 2015 at 06:42:04AM -0400, Marc-André Lureau wrote:
> hi
>
> - Original Message -
> > ---
> > src/spice-widget.c | 8 +++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/spice-widget.c b/src/spice-widget.c
> > index 260fda5..6541e0b 1
ACK series, one minor comment in 2/6
Christophe
On Tue, Jun 16, 2015 at 04:23:28PM +0200, Lukas Venhoda wrote:
> Connect dialog didn't have a parent window.
>
> Changed dialog to a window, because spicy creates no window prior to creating
> the dialog. No parent can be supplied.
>
> Moved the "
On Tue, Jun 16, 2015 at 04:23:30PM +0200, Lukas Venhoda wrote:
> Changed connect dialog from GtkDialog to GtkWindow.
>
> Added the necessary signals and buttons, to keep then
> behaviour of a dialog (ESC to close, ENTER to submit).
>
> spicy_connect_dialog now returns TRUE and FALSE instead of 0
hi
- Original Message -
> ---
> src/spice-widget.c | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/src/spice-widget.c b/src/spice-widget.c
> index 260fda5..6541e0b 100644
> --- a/src/spice-widget.c
> +++ b/src/spice-widget.c
> @@ -1209,8 +1209,14 @@ static
Hey,
Currently doing a scratch build for spice-gtk for Fedora 21.
After it is finished, you should be able to download, install and test
the patch. The link for koji is:
http://koji.fedoraproject.org/koji/taskinfo?taskID=10133624
Best,
On Thu, Jun 18, 2015 at 12:20:26PM +0200, Victor Toso wrote
Hey,
On Wed, Jun 17, 2015 at 01:19:40PM -0700, Jared Kwek wrote:
> Hi all,
>
> Switching email addresses...I thought I'd follow up to see if there is any
> interest in working on this. The only way for me to be able to play with
> the keypress-delay value is to recompile the code, something that
---
src/spice-widget.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index 260fda5..6541e0b 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -1209,8 +1209,14 @@ static void send_key(SpiceDisplay *display, int
scancode
This will allow to sharer this detection code with spice-gtk.
---
configure.ac | 12 +---
spice-common | 2 +-
2 files changed, 2 insertions(+), 12 deletions(-)
diff --git a/configure.ac b/configure.ac
index 12c6e4e..14217e2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -76,11 +76,6 @@
This factorizes a bit of configure.ac m4 code.
---
configure.ac | 33 -
1 file changed, 4 insertions(+), 29 deletions(-)
diff --git a/configure.ac b/configure.ac
index e17911e..12c6e4e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -71,12 +71,10 @@ esac
dnl ===
Besides the code factorization, this will allow smartcard support to be
automatically enabled if libcacard is present and --disable-smartcard is
not used.
---
configure.ac | 24 ++--
1 file changed, 6 insertions(+), 18 deletions(-)
diff --git a/configure.ac b/configure.ac
inde
It's not directly used by spice-common, but this way spice-gtk and
spice-server can share the same implementation.
---
m4/spice-deps.m4 | 24
1 file changed, 24 insertions(+)
diff --git a/m4/spice-deps.m4 b/m4/spice-deps.m4
index 600dd98..df35a92 100644
--- a/m4/spice-dep
Hi all,
Switching email addresses...I thought I'd follow up to see if there is any
interest in working on this. The only way for me to be able to play with
the keypress-delay value is to recompile the code, something that users
like myself are not too keen on doing. But if this value were user
c
56 matches
Mail list logo
