Re: [Spice-devel] 2K/4K resolutions not available?

2015-06-15 Thread Mike
Hi Christophe, I installed Debian Testing and interestingly enough the higher resolutions appear in the available resolution dropdown box, so we can just pick the one we want and everything worked fine, even without the spice agent installed and mucking about with dynamic resizing (which we

Re: [Spice-devel] [PATCH v5] Check too long password

2015-06-15 Thread Marc-André Lureau
My bad Cédric, I applied your patch and I had to modify it after the gtk->src move. Unfortunately, during this churning, I changed the author name, and I didn't notcied before I pushed it.. Sorry, thank you very much for your contribution, at least it made it! On Thu, Jun 4, 2015 at 5:35 PM, Mar

[Spice-devel] spice-gtk release v0.29

2015-06-15 Thread Marc-André Lureau
Hi! The Spice team is pleased to release a new spice-gtk version 0.29, with the following highlights: - sync guest audio volume with client volume - use stream volume for PulseAudio source - on Windows, fail early during initialization if the usbclerk service can't be reached - fix audio and us

Re: [Spice-devel] [vdagent-linux] Add -fno-strict-aliasing to default CFLAGS

2015-06-15 Thread Fabiano Fidencio
- Original Message - > From: "Christophe Fergeau" > To: spice-de...@freedesktop.org > Sent: Monday, June 15, 2015 4:31:44 PM > Subject: [Spice-devel] [vdagent-linux] Add -fno-strict-aliasing to default > CFLAGS > > Compilation breaks with older gcc versions (gcc (GCC) 4.4.7 20120313

[Spice-devel] [vdagent-linux] Add -fno-strict-aliasing to default CFLAGS

2015-06-15 Thread Christophe Fergeau
Compilation breaks with older gcc versions (gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-11) on RHEL6) with the following error (due to the additional use of -Werror in the default CFLAGS) CC src/src_spice_vdagent-vdagent-x11-randr.o cc1: warnings being treated as errors src/vdagent-x11-randr.c: In

Re: [Spice-devel] [PATCH spice-gtk v3] configure: Try gstreamer audio backend if pulse is not available

2015-06-15 Thread Marc-André Lureau
I haven't tried it, but it looks good, ack - Original Message - > Disable audio if no backend is available and configure is used with > the option '--with-audio=auto' > --- > v3: Fixed problem when both backends were available (both WITH_PULSE and > WITH_GSTAUDIO were defined) > v2: Remove

[Spice-devel] [PATCH spice-gtk v3] configure: Try gstreamer audio backend if pulse is not available

2015-06-15 Thread Pavel Grunt
Disable audio if no backend is available and configure is used with the option '--with-audio=auto' --- v3: Fixed problem when both backends were available (both WITH_PULSE and WITH_GSTAUDIO were defined) v2: Removed AS_IF cascade, merged with "configure: Do not force audio by default" --- confi

Re: [Spice-devel] [spicy PATCH 3/5 v3] spicy: Changed the dialog into a window

2015-06-15 Thread Lukas Venhoda
Slight error. > Changes since v2 > - Now only contains changing dialog to window > - UX changes to XML in later patches Should read Changes since v2 - Now only contains changing dialog to window - UX changes in later patches - Original Message - > From: "Lukas Venhoda" > To:

[Spice-devel] [spicy PATCH 1/5 v3] spicy: Connect dialog moved to its own file

2015-06-15 Thread Lukas Venhoda
Connect dialog from spicy is now in its own file. Renamed connect_dialog to spicy_connect_dialog. Added new file for translation. --- Changes since v2 - New patch - Reversed order of patches. Now create a module first, modify after. - Renamed the function from connect_dialog to spicy_connect_d

[Spice-devel] [spicy PATCH 5/5 v3] spicy: Host and port entries are now required

2015-06-15 Thread Lukas Venhoda
Connect button is now non-sensitive when addres entry is empty. Pressing enter will now also NOT connect, when address entry is empty. --- Changes since v2 - New patch - Split from the v2 patch as requested - Changed response type from GtkResponseType to gboolean --- src/spicy-connect.c | 32 ++

[Spice-devel] [spicy PATCH 3/5 v3] spicy: Changed the dialog into a window

2015-06-15 Thread Lukas Venhoda
Changed connect dialog from GtkDialog to GtkWindow. Added the necessary signals and buttons, to keep then behaviour of a dialog (ESC to close, ENTER to submit). --- Changes since v2 - Now only contains changing dialog to window - UX changes to XML in later patches - Changed response type from

[Spice-devel] [spicy PATCH 4/5 v3] spicy: Fixed reselecting in recent chooser

2015-06-15 Thread Lukas Venhoda
Recent chooser didn't unselect on loosing focus. Selecting recent connection, then modifying the entries and doubleclicking on the same recent connection caused spicy to connect to address in the entry, instead of the one in recent chooser. Recent chooser now unselects on loosing focus, forcing to

[Spice-devel] [spicy PATCH 2/5 v3] spicy: Changed response to gboolean

2015-06-15 Thread Lukas Venhoda
spicy_connect_dialog now returns TRUE and FALSE instead of 0 and -1. --- Changes since v2 - New patch --- src/spicy-connect.c | 9 + src/spicy-connect.h | 2 +- src/spicy.c | 6 ++ 3 files changed, 8 insertions(+), 9 deletions(-) diff --git a/src/spicy-connect.c b/src/spicy-c

[Spice-devel] [spicy PATCH 0/5 v3] spicy: Rewrite of connect dialog

2015-06-15 Thread Lukas Venhoda
Connect dialog didn't have a parent window. Changed dialog to a window, because spicy creates no window prior to creating the dialog. No parent can be supplied. Moved the "dialog" code to its own module. --- Changes since v2: - Split the 3 patches into 5 - Hopefully this new split makes mor

Re: [Spice-devel] [PATCH spice-gtk v2] configure: Try gstreamer audio backend if pulse is not available

2015-06-15 Thread Pavel Grunt
On Mon, 2015-06-15 at 07:37 -0400, Marc-André Lureau wrote: > Hmm, it looks like it would compile fine with both gst & pulse, but at > runtime > you would only have gst backend, and a leak: > > #ifdef WITH_PULSE > self = SPICE_AUDIO(spice_pulse_new(session, context, name)); > #endif > #if de

Re: [Spice-devel] [PATCH spice-gtk v2] configure: Try gstreamer audio backend if pulse is not available

2015-06-15 Thread Marc-André Lureau
Hmm, it looks like it would compile fine with both gst & pulse, but at runtime you would only have gst backend, and a leak: #ifdef WITH_PULSE self = SPICE_AUDIO(spice_pulse_new(session, context, name)); #endif #if defined(WITH_GSTAUDIO) self = SPICE_AUDIO(spice_gstaudio_new(session, conte

[Spice-devel] [PATCH spice-gtk v2] configure: Try gstreamer audio backend if pulse is not available

2015-06-15 Thread Pavel Grunt
Disable audio if no backend is available and configure is used with the option '--with-audio=auto' --- v2: Removed AS_IF cascade, merged with "configure: Do not force audio by default" --- configure.ac | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/c

Re: [Spice-devel] [PATCH spice-gtk 1/2] configure: Try gstreamer audio backend if pulse is not available

2015-06-15 Thread Marc-André Lureau
The cascaded if could be simpler imho, by backend priority if auto & have pulse: pulse if auto & have gst: gst if auto: no some day, hopefully, we will have only one backend :) On Fri, Jun 12, 2015 at 12:24 PM, Pavel Grunt wrote: > --- > configure.ac | 23 +++ > 1 file chan

[Spice-devel] [PATCH v3 6/7] UsbDk: Add UsbDk as a default backend

2015-06-15 Thread Kirill Moizik
From: Christophe Fergeau Backend is chosen dynamically, if UsbDk is not installed, then WinUsb/usbclerk will be chosen. Signed-off-by: Kirill Moizik --- src/usb-device-manager.c | 86 +++- 1 file changed, 78 insertions(+), 8 deletions(-) diff --git

[Spice-devel] [PATCH v3 2/7] Simplify spice_usb_device_manager_device_to_libdev()

2015-06-15 Thread Kirill Moizik
From: Christophe Fergeau The Windows-specific version duplicates some code from spice_usb_device_equal_libdev(), this commit switches to using that helper instead. --- src/usb-device-manager.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/usb-device-manager.c b/sr

[Spice-devel] [PATCH v3 3/7] UsbDk: Add UsbDk wrapper

2015-06-15 Thread Kirill Moizik
From: Kirill Moizik Introduce UsbDk API definitions and binding code. Signed-off-by: Kirill Moizik --- src/Makefile.am | 2 + src/usbdk_api.c | 163 src/usbdk_api.h | 34 3 files changed, 199 insertions(+) create mode 10

[Spice-devel] [PATCH v3 4/7] Add SpiceUsbDeviceManager parameter to device comparison functions

2015-06-15 Thread Kirill Moizik
From: Christophe Fergeau This additional parameter is currently unused, but this is in preparation for the next commits. --- src/usb-device-manager.c | 40 ++-- 1 file changed, 22 insertions(+), 18 deletions(-) diff --git a/src/usb-device-manager.c b/src/usb-

[Spice-devel] [PATCH v3 5/7] Add SpiceUsbDeviceManager::use_usbclerk

2015-06-15 Thread Kirill Moizik
From: Christophe Fergeau This will be useful when adding usbdk support as usbdk may not be available, so we'll need to switch between the usbdk and usbclerk code paths at runtime (only at init-time). For now, this is used to replace the #ifdef G_OS_WIN32/G_OS_LINUX blocks with a runtime test (on

[Spice-devel] [PATCH v3 1/7] Simplify spice_usb_device_equal_libdev()

2015-06-15 Thread Kirill Moizik
From: Christophe Fergeau The Windows-specific version duplicates some code from spice_usb_device_manager_libdev_match(), this commit switches to using that helper instead. --- src/usb-device-manager.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/usb-devic

[Spice-devel] [PATCH v3 7/7] UsbDeviceManager: fix usbdk standalone mode

2015-06-15 Thread Kirill Moizik
From: Kirill Moizik grey out usb redirection widget if neither usbclerk nor usbdk available Signed-off-by: Kirill Moizik --- src/usb-device-manager.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c index 987cb20

[Spice-devel] [PATCH v3 0/7] Support UsbDk backend

2015-06-15 Thread Kirill Moizik
From: Kirill Moizik sbDk (USB Development Kit) is a set of software components meant to provide Windows user mode applications with direct and exclusive access to USB devices. Some distinctive UsbDk properties are: 1. UsbDk supports all types of devices and interfaces - bulk, isochronous, co

Re: [Spice-devel] (no subject)

2015-06-15 Thread Dmitry Fleytman
Sent from my iPhone > On Jun 15, 2015, at 11:59, Christophe Fergeau wrote: > >> On Sun, Jun 14, 2015 at 08:27:00PM +0300, Kirill Moizik wrote: >> Hi, >> Indeed good split, unfortunately it cause crash without any errors in log, >> when usbdk installed and usbclerk not. > > Ah sorry about tha

Re: [Spice-devel] (no subject)

2015-06-15 Thread Christophe Fergeau
On Sun, Jun 14, 2015 at 08:27:00PM +0300, Kirill Moizik wrote: > Hi, > Indeed good split, unfortunately it cause crash without any errors in log, > when usbdk installed and usbclerk not. Ah sorry about that, though not a huge surprise given that I only compile tested them :-/. Feel free to send m

Re: [Spice-devel] 2K/4K resolutions not available?

2015-06-15 Thread Christophe Fergeau
On Fri, Jun 12, 2015 at 10:48:56AM -0700, Mike wrote: > Hi Christophe, > > I fired up a Fedora 22 live CD and it does change the guest resolution > when > I resize the window, but only larger, it doesn't resize it smaller for some > reason. > > When comparing the package versions between F