Re: [Spice-devel] 2K/4K resolutions not available?

2015-06-11 Thread Gerd Hoffmann
On Do, 2015-06-11 at 08:58 -0700, Mike wrote: > Hi Christophe, > > I was using just "spicec" as the viewer in full screen mode, but trying > remote-viewer doesn't seem to make any difference (full-screen or > windowed mode), it just scales the guest display (and results in blurry > text)

[Spice-devel] [PATCH spice 12/12] server: Add h264 support to the GStreamer video encoder. (take 3b)

2015-06-11 Thread Francois Gouget
Signed-off-by: Francois Gouget --- Updated so it applies after the VP8 'take 3b' patch. diff --git a/server/gstreamer_encoder.c b/server/gstreamer_encoder.c index c638c3e..58c4c7e 100644 --- a/server/gstreamer_encoder.c +++ b/server/gstreamer_encoder.c @@ -206,6 +206,9 @@ static gboolean constr

[Spice-devel] [PATCH spice 10/12] server: Add GStreamer 1.0 support. (take 3b)

2015-06-11 Thread Francois Gouget
Signed-off-by: Francois Gouget --- Updated so it applies after the new VP8 patch. diff --git a/configure.ac b/configure.ac index ed3a337..6a5ddb9 100644 --- a/configure.ac +++ b/configure.ac @@ -92,14 +92,32 @@ if test "x$enable_smartcard" = "xyes"; then fi AC_ARG_ENABLE(gstreamer, -

[Spice-devel] [PATCH spice 7/12] server: Add VP8 support, a video codec preference list and compatibility checks with the Spice client. (take 3b)

2015-06-11 Thread Francois Gouget
The video encoder preferences can be expressed by building a semi-colon separated list of encoder:codec pairs. For instance 'gstreamer:vp8;spice:mjpeg' to pick first the GStreamer VP8 video encoder first and used the original MJPEG video encoder one as a fallback. The server has a default prefere

Re: [Spice-devel] [PATCH spice 1/2] server: Refresh the input fps every 5 second, without a timer.

2015-06-11 Thread Marc-André Lureau
Hi On Thu, Jun 11, 2015 at 7:39 PM, Francois Gouget wrote: > Signed-off-by: Francois Gouget > --- > > This implements Marc-André Lureau's suggestion: > http://lists.freedesktop.org/archives/spice-devel/2015-June/020202.html > > And supersedes the input-fps rounding patch. > http://lists.freedes

[Spice-devel] [PATCH] Use AS_HELP_STRING for configure options

2015-06-11 Thread Jonathon Jongsma
--- configure.ac | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/configure.ac b/configure.ac index 7a9fc4b..1802ff1 100644 --- a/configure.ac +++ b/configure.ac @@ -70,30 +70,31 @@ esac dnl ===

[Spice-devel] [PATCH] Add 'Send Ctrl-Alt-Delete' button to spice_auto.html

2015-06-11 Thread Felipe Reyes
This patch adds a new button aligned to the right in the top header. OpenStack Horizon embeds spice-html5 in an iframe, but it doesn't include this button, this is because it uses novnc as well which it does include an equivalent button as part of its UI. Also when loading spice_auto.html directly

[Spice-devel] [PATCH spice 2/2] server: Provide a framerate estimate based on the frames that lead to the stream creation.

2015-06-11 Thread Francois Gouget
This way the video encoder can actually count on a real estimate when it is initializing. Signed-off-by: Francois Gouget --- Initialisation time is when video encoders need an fps most since they have no other information at that point. Yet, all they were getting is MAX_FPS (30). This patch

[Spice-devel] [PATCH spice 1/2] server: Refresh the input fps every 5 second, without a timer.

2015-06-11 Thread Francois Gouget
Signed-off-by: Francois Gouget --- This implements Marc-André Lureau's suggestion: http://lists.freedesktop.org/archives/spice-devel/2015-June/020202.html And supersedes the input-fps rounding patch. http://lists.freedesktop.org/archives/spice-devel/2015-June/020176.html server/red_worker.c |

[Spice-devel] [PATCH spice] HAVE_CLOCK_GETTIME is not used so remove it.

2015-06-11 Thread Francois Gouget
Signed-off-by: Francois Gouget --- Maybe we should actually use it but currently clock_gettime() uses are all over the place and this macro was only used in the client code anyway (see 18769714 and 3f3283ee). configure.ac | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a

[Spice-devel] [PATCH spice] server: Fix an incorrect time calculation.

2015-06-11 Thread Francois Gouget
Signed-off-by: Francois Gouget --- I don't see how this minus sign could be right... server/spice_timer_queue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/spice_timer_queue.c b/server/spice_timer_queue.c index 71de84a..d457845 100644 --- a/server/spice_timer_queu

Re: [Spice-devel] [PATCH v2 1/2] UsbDk: Add UsbDk wrapper

2015-06-11 Thread Christophe Fergeau
Hey, I think I forgot to mention this in the initial review, but GModule might probably have been useful as a wrapper for the GetProcAddress calls. As we only need to do that on Windows, GModule VS direct win32 API calls do not bring us much. I'd squash the attached patch in with just some cosmet

Re: [Spice-devel] 2K/4K resolutions not available?

2015-06-11 Thread Mike
Hi Christophe, I was using just "spicec" as the viewer in full screen mode, but trying remote-viewer doesn't seem to make any difference (full-screen or windowed mode), it just scales the guest display (and results in blurry text) and doesn't actually change the resolution on the guest side.

Re: [Spice-devel] [spice-gtk PATCH 1/3 v2] spicy-connect: Connect dialog changed to window

2015-06-11 Thread Christophe Fergeau
Hey, On Tue, Jun 09, 2015 at 04:59:32PM +0200, Lukas Venhoda wrote: > Connect dialog in spicy had no transinient parent. > It didn't make much sense for it to be a dialog. > > Changed the connect dialog to a window. > Moved the dialog code to its own module. I'd make the description a bit more c

Re: [Spice-devel] [PATCH spice-server v2 1/2] Use image compress constants from spice-protocol

2015-06-11 Thread Javier Celaya
El Jueves, 11 de junio de 2015 16:44:51 Christophe Fergeau escribió: > On Mon, Jun 01, 2015 at 04:48:15PM +0200, Javier Celaya wrote: > > diff --git a/server/spice-server.h b/server/spice-server.h > > index bca0da6..5880ff0 100644 > > --- a/server/spice-server.h > > +++ b/server/spice-server.h > >

Re: [Spice-devel] [PATCH v2] Use spice_malloc instead of malloc

2015-06-11 Thread Christophe Fergeau
On Wed, Jun 10, 2015 at 02:53:05PM +0100, Frediano Ziglio wrote: > Do not just check and give warning before crashing the program > accessing a NULL pointer but use spice_malloc which exits with a > proper message. > > Signed-off-by: Frediano Ziglio > --- > server/red_worker.c | 6 ++ > 1 fi

Re: [Spice-devel] [PATCHv2] LZ4: warn if trying to set lz4 but not supported

2015-06-11 Thread Christophe Fergeau
On Tue, Jan 27, 2015 at 05:26:41PM +0100, Christophe Fergeau wrote: > ACK. I had this in my local tree but never pushed it, this is now done. Christophe pgpY7iMIABHJa.pgp Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freed

Re: [Spice-devel] [PATCH spice-server v2 1/2] Use image compress constants from spice-protocol

2015-06-11 Thread Christophe Fergeau
On Mon, Jun 01, 2015 at 04:48:15PM +0200, Javier Celaya wrote: > diff --git a/server/spice-server.h b/server/spice-server.h > index bca0da6..5880ff0 100644 > --- a/server/spice-server.h > +++ b/server/spice-server.h > @@ -67,20 +67,9 @@ int spice_server_add_interface(SpiceServer *s, >

Re: [Spice-devel] [RFC PATCH] qemu: Use heads parameter for QXL driver

2015-06-11 Thread Christophe Fergeau
On Thu, Jun 11, 2015 at 12:39:50PM +0100, Frediano Ziglio wrote: > > Actually can be a compatiblity problem as heads in the XML configuration > was set by default to '1'. Yes, this bit is worrying, the old behaviour could be considered as buggy as the XML contained '1' but the number of heads was

Re: [Spice-devel] [RFC PATCH] qemu: Use heads parameter for QXL driver

2015-06-11 Thread Christophe Fergeau
Hey, On Thu, Jun 11, 2015 at 12:39:50PM +0100, Frediano Ziglio wrote: > Allow to specify maximum number of head to QXL driver. I've tested this with an older qemu without qxl-vga.max_outputs, and with a newer one with support for it, and in both cases this is doing the right thing. > > Signed-o

Re: [Spice-devel] [PATCH spice 10/12] server: Add GStreamer 1.0 support.

2015-06-11 Thread Fabio Fantoni
Il 10/06/2015 17:38, Francois Gouget ha scritto: > Signed-off-by: Francois Gouget > --- > > This adds GStreamer 1.0 support! > > By default GStreamer 1.0 is used if available, otherwise GStreamer 0.10 > is used and Spice is compiled without GStreamer support as a last > resort. It's possible to

[Spice-devel] 3D Support

2015-06-11 Thread Chris Harvey
Hey, I currently use spice in my home. I have a server in my attic which has several virtual machines running on it (Windows & Linux). I then have some really low spec laptops and Raspberry Pi's which I use as thin clients to connect to the virtual machines through spice. Pretty weird setup, b

Re: [Spice-devel] [PATCH v2 0/2] Support UsbDk backend

2015-06-11 Thread Kirill Moizik
Hi, What do you think about those patches, guys ? Kirill On Tue, Jun 9, 2015 at 3:53 PM, Kirill Moizik wrote: > From: Kirill Moizik > > UsbDk (USB Development Kit) is a set of software components meant to > provide > Windows user mode applications with direct and exclusive access to USB > devi

[Spice-devel] [RFC PATCH] qemu: Use heads parameter for QXL driver

2015-06-11 Thread Frediano Ziglio
Allow to specify maximum number of head to QXL driver. Signed-off-by: Frediano Ziglio --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 11 +++ tests/qemucapabilitiesda

Re: [Spice-devel] 2K/4K resolutions not available?

2015-06-11 Thread Gerd Hoffmann
On Do, 2015-06-11 at 12:04 +0200, Christophe Fergeau wrote: > Hey, > > On Wed, Jun 10, 2015 at 03:37:09PM -0700, Mike wrote: > > I'm trying to get 2K+ resolutions to work with SPICE/QXL and QEMU 2.2 > > (Ubuntu Vivid) on the host and Ubuntu Trusty on the guest. Currently the > > highest resolution

Re: [Spice-devel] [PATCH v2] RFC: qxl: allow to specify head limit to qxl driver

2015-06-11 Thread Gerd Hoffmann
On Do, 2015-06-11 at 10:38 +0100, Frediano Ziglio wrote: > libvirt has this as a video card parameter (actually set to 1 but not > used). This parameter will allow to limit setting a use can do (which > could be confusing). Hmm. So heads is '1' by default but ignored today. When this starts to b

Re: [Spice-devel] [PATCH spice-gtk] Send monitor config when enough display channels are connected

2015-06-11 Thread Marc-André Lureau
Hi Pavel, The previous approach is better, since it waits until the monitor config is received. Just waiting for channels to be connected would be racy. - Original Message - > Fixes: > https://bugs.freedesktop.org/show_bug.cgi?id=90914 > --- > src/channel-main.c | 2 +- > src/spi

Re: [Spice-devel] 2K/4K resolutions not available?

2015-06-11 Thread Christophe Fergeau
Hey, On Wed, Jun 10, 2015 at 03:37:09PM -0700, Mike wrote: > I'm trying to get 2K+ resolutions to work with SPICE/QXL and QEMU 2.2 > (Ubuntu Vivid) on the host and Ubuntu Trusty on the guest. Currently the > highest resolution is 1920x1200... I tried increasing the QXL video memory > to 128MB from

Re: [Spice-devel] [PATCH] server: allow to set maximum monitors

2015-06-11 Thread Marc-André Lureau
looks good to me, ACK On Wed, Jun 10, 2015 at 1:54 PM, Frediano Ziglio wrote: > spice-server will attempt to limit number of monitors. > Guest machine can send monitor list it accepts. Limiting the number sent > by guest will limit the number of monitors client will try to enable. > The guest us

[Spice-devel] [PATCH spice-gtk] Send monitor config when enough display channels are connected

2015-06-11 Thread Pavel Grunt
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=90914 --- src/channel-main.c | 2 +- src/spice-session-priv.h | 1 + src/spice-session.c | 25 + 3 files changed, 27 insertions(+), 1 deletion(-) diff --git a/src/channel-main.c b/src/channel-main.c index fbc

[Spice-devel] [PATCH v2] RFC: qxl: allow to specify head limit to qxl driver

2015-06-11 Thread Frediano Ziglio
This patch allow to limit number of heads using qxl driver. By default qxl driver is not limited on any kind on head use so can decide to use as much heads. libvirt has this as a video card parameter (actually set to 1 but not used). This parameter will allow to limit setting a use can do (which c

Re: [Spice-devel] [PATCH spice-gtk] channel-main: Notify about existence of monitor

2015-06-11 Thread Marc-André Lureau
Hi Pavel - Original Message - > SpiceMainChannel should be notify about existence of monitors > assigned to a SpiceDisplayChannel, even when the SpiceDisplayChannel > is not connected to a SpiceDisplay widget. Otherwise the automatic > resizing (the "resize-guest" property) of SpiceDisplay

[Spice-devel] [PATCH spice-gtk] channel-main: Notify about existence of monitor

2015-06-11 Thread Pavel Grunt
SpiceMainChannel should be notify about existence of monitors assigned to a SpiceDisplayChannel, even when the SpiceDisplayChannel is not connected to a SpiceDisplay widget. Otherwise the automatic resizing (the "resize-guest" property) of SpiceDisplay will not work when there is more display chann