ack latest series, with minor comment on first patch
thanks
On Tue, Jun 2, 2015 at 6:00 PM, Victor Toso wrote:
> Previous:
> http://lists.freedesktop.org/archives/spice-devel/2015-May/019939.html
>
> changes from v3:
> - track all GSource that is created and dispatch them when possible
> - add
On Wed, Jun 3, 2015 at 11:33 AM, Victor Toso wrote:
> PipeInputStream and PipeOutputStream should not fail when creating
> GPollableStream source as this currently does not work with default
> write_all and read_all functions;
>
> In order to avoid creating zombie GSource in create_source of both
On Thu, Jun 4, 2015 at 10:12 AM, Victor Toso wrote:
> Is it okay to push this?
pushed, thanks
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
Hi
Patch looks ok to me (although I still think it's a superflous check at
spice-gtk level)
On Thu, Jun 4, 2015 at 11:44 AM, Cédric Bosdonnat
wrote:
> Make sure that the password length is under the maximum lenght. If not
> report it as an authentication failure with an adapted message.
> ---
On Thu, Jun 4, 2015 at 1:23 PM, Fabiano Fidêncio wrote:
> Updating the display causes weird behaviors in virt-viewer, like
> re-resizing to a previous monitor config when, after changing the
> display resolution (through System > PReferences > Displays). the agent
> reconnects.
> It is not perfect
Hey Christophe,
-if (msg.type == SPICE_MSG_DISPLAY_STREAM_DATA)
+if (msg.type == SPICE_MSG_DISPLAY_STREAM_DATA ||
+msg.type == SPICE_MSG_DISPLAY_STREAM_DATA_SIZED)
{
-var m = new SpiceMsgDisplayStreamData(msg.data);
+var m;
+if (msg.type == SPICE_MS
Il 02/06/2015 12:29, Francois Gouget ha scritto:
> On Tue, 2 Jun 2015, Fabio Fantoni wrote:
> [...]
>> Video on youtube,
> Does it look like the video moves back and forth? Or maybe just the
> progress bar area, with some shearing too. That's a known issue caused
> by the progress bar popping up
Updating the display causes weird behaviors in virt-viewer, like
re-resizing to a previous monitor config when, after changing the
display resolution (through System > PReferences > Displays). the agent
reconnects.
It is not perfect yet, because when the agent reconnects the guest
resizes to the pr
Make sure that the password length is under the maximum lenght. If not
report it as an authentication failure with an adapted message.
---
Diff to v4
* Applied teuf's feedback
gtk/spice-channel.c | 77 +
1 file changed, 48 insertions(+), 29
> Something like that diff squashed into this patch?
Yep, looks okay.
This is an interesting hack by firefox btw, looks hard to catch.
> --- a/SpiceXPI/src/plugin/controller.cpp
> +++ b/SpiceXPI/src/plugin/controller.cpp
> @@ -174,6 +174,7 @@ gpointer SpiceController::ClientThread(gpointer data)
On Thu, Jun 04, 2015 at 11:14:03AM +0200, Victor Toso wrote:
> Hey,
>
> On Wed, Jun 03, 2015 at 03:36:09PM +0200, Christophe Fergeau wrote:
> > Ping ?
>
> I would only add a FIXME in the comment to easily find it and check
> if it is already fixed;
Something like that diff squashed into this pat
On Thu, Jun 04, 2015 at 11:14:03AM +0200, Victor Toso wrote:
> Hey,
>
> On Wed, Jun 03, 2015 at 03:36:09PM +0200, Christophe Fergeau wrote:
> > Ping ?
>
> I would only add a FIXME in the comment to easily find it and check
> if it is already fixed;
Sure, I'll add this.
Christophe
>
> -toso
>
ACK.
On Wed, Jun 03, 2015 at 04:19:44PM +0200, Cédric Bosdonnat wrote:
> Don't allow setting a too long password.
> ---
>
> Diff to v1: only kept the admin/user password setting check
>
> server/reds.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/server/reds.c b/server/reds.c
>
On Wed, Jun 03, 2015 at 04:22:35PM +0200, Cédric Bosdonnat wrote:
> Make sure that the password lenght is under the maximum lenght. If not
> report it as an authentication failure with an adapted message.
> ---
> Diff to v3:
>
>* Removed the checks on the server side and the corresponding cod
Hey,
On Wed, Jun 03, 2015 at 03:36:09PM +0200, Christophe Fergeau wrote:
> Ping ?
I would only add a FIXME in the comment to easily find it and check
if it is already fixed;
-toso
>
> On Thu, May 28, 2015 at 01:37:24PM +0200, Christophe Fergeau wrote:
> > When it's built with gtk3, firefox plug
Only change was the subject? ACK.
Christophe
On Wed, Jun 03, 2015 at 04:58:18PM +0200, Javier Celaya wrote:
> ---
> gtk/spice-option.c | 37 +
> 1 file changed, 37 insertions(+)
>
> diff --git a/gtk/spice-option.c b/gtk/spice-option.c
> index 958e03c..463a3e3
On Wed, Jun 03, 2015 at 05:07:52PM +0200, Javier Celaya wrote:
> If the user prefers a specific compression algorithm, report it when
> setting up the display channel.
> ---
> gtk/channel-display.c | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git a/gtk/channel-display.c b/gtk/
Hey,
On Wed, Jun 03, 2015 at 05:22:55PM -0500, Jeremy White wrote:
> This helps video playback do a slightly better job of keeping up
> in the browser. It's not a dramatic effect, but enough to start making
> video playback almost tolerable.
>
> Signed-off-by: Jeremy White
> ---
> display.js
Hey,
Not very familiar with the html5 code, but looks good
On Wed, Jun 03, 2015 at 05:22:54PM -0500, Jeremy White wrote:
> Signed-off-by: Jeremy White
> ---
> display.js | 60
> ++--
> enums.js | 11 +++
> spiceconn.js | 4
Hey,
Is it okay to push this?
On Fri, Apr 24, 2015 at 02:05:00PM +0200, Marc-André Lureau wrote:
> During migration, a volume jump is observed by the client. This is due
> to qemu setting up destination server with default sound state, and the
> server sending it after the client is connected. Th
On Wed, Jun 03, 2015 at 05:22:53PM -0500, Jeremy White wrote:
> Signed-off-by: Jeremy White
> ---
> display.js | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/display.js b/display.js
> index 814ada6..a749dae 100644
> --- a/display.js
> +++ b/display.js
> @@ -469,11 +
21 matches
Mail list logo
