Re: [Spice-devel] [PATCH 0/11] Add GStreamer and VP8 support

2015-06-01 Thread Francois Gouget
On Mon, 1 Jun 2015, Fabio Fantoni wrote: [...] > I suppose that these warning I saw on client are related: > http://pastebin.com/GeTPyscG > > 0:00:00.150227452 27501 0x29f98f0 WARNvideodecoder > > gstvideodecoder.c:2026:gst_video_decoder_chain: Received > > buffer without a new-seg

Re: [Spice-devel] [PATCH 4/5] usbdk: Add UsbDk hider interface wrapper

2015-06-01 Thread Jonathon Jongsma
On Thu, 2015-05-28 at 13:24 +0300, Kirill Moizik wrote: > From: Dmitry Fleytman > > add UsbDkDataHider.h UsbDkHelperHider.h usbdk_api.h usbdk_api.c files > to allow hide devices according auto redirect rule functionality > > Signed-off-by: Kirill Moizik > Signed-off-by: Dmitry Fleytman > ---

[Spice-devel] [PATCH spice-protocol v2 0/2] Add preferred compression enums and capability.

2015-06-01 Thread Javier Celaya
Javier Celaya (2): Update enums.h for preferred compression message Add a preferred compression capability spice/enums.h| 14 ++ spice/protocol.h | 1 + 2 files changed, 15 insertions(+) -- 1.9.3 ___ Spice-devel mailing list Spic

[Spice-devel] [PATCH spice-gtk v3 3/3] Display: Send a preferred compression message on init.

2015-06-01 Thread Javier Celaya
If the user prefers a specific compression algorithm, report it when setting up the display channel. --- gtk/channel-display.c | 12 1 file changed, 12 insertions(+) diff --git a/gtk/channel-display.c b/gtk/channel-display.c index efe2259..b440f9b 100644 --- a/gtk/channel-display.c +

[Spice-devel] [PATCH spice-gtk v3 2/3] Cmdline: Get the preferred-compression property

2015-06-01 Thread Javier Celaya
--- gtk/spice-option.c | 37 + 1 file changed, 37 insertions(+) diff --git a/gtk/spice-option.c b/gtk/spice-option.c index 958e03c..463a3e3 100644 --- a/gtk/spice-option.c +++ b/gtk/spice-option.c @@ -41,6 +41,7 @@ static gint cache_size = 0; static gint glz_w

[Spice-devel] [PATCH spice-gtk v3 0/3] Report the preferred compression method to server

2015-06-01 Thread Javier Celaya
This patch set allows the client to report its preferred image compression method to the server. It is read from command line and sent when the display channel is set up, if the server supports it. Javier Celaya (3): Spice-session: Add preferred-compression property. Cmdline: Get the preferred

[Spice-devel] [PATCH spice-gtk v3 1/3] Spice-session: Add preferred-compression property.

2015-06-01 Thread Javier Celaya
Also, depend on the spice-common commit that introduces the SpiceImageCompress enum. --- gtk/spice-session.c | 58 + spice-common| 2 +- 2 files changed, 59 insertions(+), 1 deletion(-) diff --git a/gtk/spice-session.c b/gtk/spice-sessi

[Spice-devel] [PATCH spice-server v2 2/2] Handle preferred image compression messages

2015-06-01 Thread Javier Celaya
--- server/red_dispatcher.c | 1 + server/red_worker.c | 25 + 2 files changed, 26 insertions(+) diff --git a/server/red_dispatcher.c b/server/red_dispatcher.c index 4965a97..312b4f7 100644 --- a/server/red_dispatcher.c +++ b/server/red_dispatcher.c @@ -1154,6 +1154,7

[Spice-devel] [PATCH spice-server v2 1/2] Use image compress constants from spice-protocol

2015-06-01 Thread Javier Celaya
--- server/red_dispatcher.c | 2 +- server/red_dispatcher.h | 2 +- server/red_worker.c | 8 server/red_worker.h | 2 +- server/reds.c | 8 server/spice-server.h | 15 ++- spice-common| 2 +- 7 files changed, 14 insertions(+), 25

[Spice-devel] [PATCH spice-server v2 0/2] Handle client's preferred image compression

2015-06-01 Thread Javier Celaya
Handle the message with the preferred image compression method reported by the client. The spice-common commit has been removed from the first patch to avoid conflicts, fix it as needed. Javier Celaya (2): Use image compress constants from spice-protocol Handle preferred image compression mess

[Spice-devel] [PATCH spice-protocol v2 1/2] Update enums.h for preferred compression message

2015-06-01 Thread Javier Celaya
--- spice/enums.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/spice/enums.h b/spice/enums.h index 18e2f74..6a0ab0b 100644 --- a/spice/enums.h +++ b/spice/enums.h @@ -181,6 +181,19 @@ typedef enum SpiceImageType { SPICE_IMAGE_TYPE_ENUM_END } SpiceImageType; +typedef

[Spice-devel] [PATCH spice-protocol v2 2/2] Add a preferred compression capability

2015-06-01 Thread Javier Celaya
--- spice/protocol.h | 1 + 1 file changed, 1 insertion(+) diff --git a/spice/protocol.h b/spice/protocol.h index bea376c..d3c5962 100644 --- a/spice/protocol.h +++ b/spice/protocol.h @@ -134,6 +134,7 @@ enum { SPICE_DISPLAY_CAP_A8_SURFACE, SPICE_DISPLAY_CAP_STREAM_REPORT, SPICE_DI

Re: [Spice-devel] [PATCH 0/11] Add GStreamer and VP8 support

2015-06-01 Thread Fabio Fantoni
Il 29/05/2015 15:20, Francois Gouget ha scritto: > On Fri, 29 May 2015, Fabio Fantoni wrote: > [...] >> I'm trying the gst1 support but build fails with this error: >> gstreamer_encoder.c: In function 'construct_pipeline': >> gstreamer_encoder.c:219:41: error: 'GstEncoder' has no member named 'frc'

Re: [Spice-devel] [PATCH xf86-video-qxl] Do not process watches on select() error.

2015-06-01 Thread Jeremy White
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/01/2015 03:09 AM, Christophe Fergeau wrote: > On Wed, May 27, 2015 at 01:58:25PM -0500, Jeremy White wrote: >> This enables a kill of an Xorg process to propogate further. > > If not pushed yet s/propogate/propagate/ Correct patch propagated, t

Re: [Spice-devel] [PATCH v3] Report invalid password as a special auth error

2015-06-01 Thread Marc-André Lureau
Hi - Original Message - > Provide a special authentication error message for too long passwords. > Also check for too long passwords before sending them over the wire. > --- > Diff to v2: >* Make spice_channel_send_spice_ticket return TRUE / FALSE to indicate >success > > gtk/s

[Spice-devel] [PATCH v3] Report invalid password as a special auth error

2015-06-01 Thread Cédric Bosdonnat
Provide a special authentication error message for too long passwords. Also check for too long passwords before sending them over the wire. --- Diff to v2: * Make spice_channel_send_spice_ticket return TRUE / FALSE to indicate success gtk/spice-channel.c | 74

Re: [Spice-devel] [PATCH v2 3/3] Display: Send a preferred compression message on init.

2015-06-01 Thread Christophe Fergeau
On Mon, Jun 01, 2015 at 12:57:15PM +0200, Javier Celaya wrote: > El Viernes, 29 de mayo de 2015 18:18:15 Christophe Fergeau escribió: > > On Mon, Apr 27, 2015 at 10:05:17AM +0200, Javier Celaya wrote: > > > If the user prefers a specific compression algorithm, report it when > > > setting up the di

Re: [Spice-devel] [PATCH v2 3/3] Display: Send a preferred compression message on init.

2015-06-01 Thread Javier Celaya
El Viernes, 29 de mayo de 2015 18:18:15 Christophe Fergeau escribió: > On Mon, Apr 27, 2015 at 10:05:17AM +0200, Javier Celaya wrote: > > If the user prefers a specific compression algorithm, report it when > > setting up the display channel. > > ACK. > > Christophe I just realized that a server

Re: [Spice-devel] [PATCH v2 2/3] Cmdline: Get the preferred-compression property

2015-06-01 Thread Christophe Fergeau
On Mon, Jun 01, 2015 at 11:37:22AM +0200, Javier Celaya wrote: > El Viernes, 29 de mayo de 2015 18:17:57 Christophe Fergeau escribió: > > ACK, but gtk/spice-option.c needs similar changes otherwise > > remote-viewer won't pick up the new compression parameters. > > > > Christophe > > In fact, it'

Re: [Spice-devel] [PATCH v2 2/3] Cmdline: Get the preferred-compression property

2015-06-01 Thread Javier Celaya
El Viernes, 29 de mayo de 2015 18:17:57 Christophe Fergeau escribió: > ACK, but gtk/spice-option.c needs similar changes otherwise > remote-viewer won't pick up the new compression parameters. > > Christophe In fact, it's enough to move these changes to gtk/spice-option.c. I did not realize that

Re: [Spice-devel] [PATCH] Prepare for spice-protocol 0.12.8 release

2015-06-01 Thread Christophe Fergeau
On Sun, May 31, 2015 at 05:38:35PM +0300, Uri Lublin wrote: > On 05/27/2015 04:18 PM, Christophe Fergeau wrote: > >--- > >This is needed if we are to do a spice-vdagent release. There are a few > >pending > >patches on the mailing list doing more additions to that file, but we can aim > >at making

Re: [Spice-devel] [PATCH 5/5] usb-device-manager: Configure UsbDk hiding rules on auto-redirection

2015-06-01 Thread Dmitry Fleytman
> On Jun 1, 2015, at 10:22 AM, Christophe Fergeau wrote: > > On Sun, May 31, 2015 at 12:30:56PM +0300, Dmitry Fleytman wrote: + +static +void spice_usb_device_manager_set_rules(SpiceUsbDeviceManagerPrivate *priv) +{ +struct usbredirfilter_rule *rules; +

Re: [Spice-devel] [PATCH xf86-video-qxl] Do not process watches on select() error.

2015-06-01 Thread Christophe Fergeau
On Wed, May 27, 2015 at 01:58:25PM -0500, Jeremy White wrote: > This enables a kill of an Xorg process to propogate further. If not pushed yet s/propogate/propagate/ Christophe pgpcNpPrqxRnI.pgp Description: PGP signature ___ Spice-devel mailing list

Re: [Spice-devel] [PATCH 5/5] usb-device-manager: Configure UsbDk hiding rules on auto-redirection

2015-06-01 Thread Christophe Fergeau
On Sun, May 31, 2015 at 12:30:56PM +0300, Dmitry Fleytman wrote: > > > On May 28, 2015, at 18:48 PM, Christophe Fergeau > > wrote: > > > > On Thu, May 28, 2015 at 01:24:04PM +0300, Kirill Moizik wrote: > >> #ifdef USE_WINUSB > >> use_usbdk = is_usbdk_driver_installed(); > > > > Any reason

Re: [Spice-devel] [PATCH 0/5] RFC: Support UsbDk backend

2015-06-01 Thread Dmitry Fleytman
> On Jun 1, 2015, at 10:06 AM, Dmitry Fleytman wrote: > >> >> On Jun 1, 2015, at 24:26 AM, Marc-André Lureau wrote: >> >> >> >> - Original Message - On May 28, 2015, at 19:03 PM, Christophe Fergeau wrote: On Thu, May 28, 2015 at 01:23:59PM +0300, Kirill Moizik

Re: [Spice-devel] [PATCH 0/5] RFC: Support UsbDk backend

2015-06-01 Thread Christophe Fergeau
On Sun, May 31, 2015 at 12:11:11PM +0300, Dmitry Fleytman wrote: > Hi Christophe, > > Thanks for the review. See below. > > > > On May 28, 2015, at 19:03 PM, Christophe Fergeau > > wrote: > > > > On Thu, May 28, 2015 at 01:23:59PM +0300, Kirill Moizik wrote: > > Hey, > > > >> This set of pat

Re: [Spice-devel] [PATCH 5/5] usb-device-manager: Configure UsbDk hiding rules on auto-redirection

2015-06-01 Thread Christophe Fergeau
On Sun, May 31, 2015 at 12:30:56PM +0300, Dmitry Fleytman wrote: > >> + > >> +static > >> +void spice_usb_device_manager_set_rules(SpiceUsbDeviceManagerPrivate > >> *priv) > >> +{ > >> +struct usbredirfilter_rule *rules; > >> +int r, count; > >> + > >> +r = usbredirfilter_string_to_rul

Re: [Spice-devel] [PATCH 0/5] RFC: Support UsbDk backend

2015-06-01 Thread Dmitry Fleytman
> On Jun 1, 2015, at 24:26 AM, Marc-André Lureau wrote: > > > > - Original Message - >>> On May 28, 2015, at 19:03 PM, Christophe Fergeau >>> wrote: >>> >>> On Thu, May 28, 2015 at 01:23:59PM +0300, Kirill Moizik wrote: >>> Hey, >>> This set of patches add UsbDk backend support