[Spice-devel] keypress-delay issue

2015-05-29 Thread jkwek1
Hi all, I've noticed a typing delay in my VM's through the SPICE protocol when typing emails or text files. It's noticeable to the point that it is hurting my typing speed and is contributing to more mistakes (as the letters appear after the slight delay). I'm running Fedora 21 on the host

Re: [Spice-devel] [PATCH v2 3/3] Display: Send a preferred compression message on init.

2015-05-29 Thread Christophe Fergeau
On Mon, Apr 27, 2015 at 10:05:17AM +0200, Javier Celaya wrote: > If the user prefers a specific compression algorithm, report it when > setting up the display channel. ACK. Christophe pgpjUItWxXEe2.pgp Description: PGP signature ___ Spice-devel mailin

Re: [Spice-devel] [PATCH v2 2/3] Cmdline: Get the preferred-compression property

2015-05-29 Thread Christophe Fergeau
ACK, but gtk/spice-option.c needs similar changes otherwise remote-viewer won't pick up the new compression parameters. Christophe On Mon, Apr 27, 2015 at 10:04:35AM +0200, Javier Celaya wrote: > --- > gtk/spice-cmdline.c | 48 > 1 file changed, 4

Re: [Spice-devel] [PATCH 1/3] Spice-session: Add preferred-compression property.

2015-05-29 Thread Christophe Fergeau
On Fri, Apr 17, 2015 at 12:40:23PM +0200, Javier Celaya wrote: > Also, depend on the spice-common commit that introduces the > SpiceImageCompress enum. > --- > gtk/spice-session.c | 26 ++ > spice-common| 2 +- > 2 files changed, 27 insertions(+), 1 deletion(-) >

Re: [Spice-devel] [PATCH v2] Proto: Add preferred compression message and constants.

2015-05-29 Thread Christophe Fergeau
ACK. On Mon, Apr 27, 2015 at 10:01:00AM +0200, Javier Celaya wrote: > When accessing a virtual desktop from different devices, some may have > different image compression requirements, e.g. slow devices may prefer > the faster LZ4 over GLZ. This message instructs the server to switch the > image c

Re: [Spice-devel] [PATCH 2/2] Handle preferred image compression messages

2015-05-29 Thread Christophe Fergeau
ACK too, I was initially worried that display_channel->common.worker->image_compression would be accessed from different thread, but after adding a few printf, this looks fine. Christophe On Fri, Apr 17, 2015 at 12:40:48PM +0200, Javier Celaya wrote: > --- > server/red_worker.c | 25

Re: [Spice-devel] [PATCH 0/2] Set the image compression reported by client

2015-05-29 Thread Christophe Fergeau
Hey, I'm finally taking a closer look at these patches, sorry that it took an awfully long time to get them reviewed :( Christophe On Fri, Apr 17, 2015 at 12:40:46PM +0200, Javier Celaya wrote: > This patch set uses the SpiceImageCompress enum from spice-common > instead of spice_image_compressi

Re: [Spice-devel] [PATCH 1/2] Use image compress constants from spice-protocol

2015-05-29 Thread Christophe Fergeau
Looks good, ACK. Christophe On Fri, Apr 17, 2015 at 12:40:47PM +0200, Javier Celaya wrote: > --- > server/red_dispatcher.c | 2 +- > server/red_dispatcher.h | 2 +- > server/red_worker.c | 8 > server/red_worker.h | 2 +- > server/reds.c | 8 > server/spi

Re: [Spice-devel] [PATCH 0/11] Add GStreamer and VP8 support

2015-05-29 Thread Francois Gouget
On Fri, 29 May 2015, Fabio Fantoni wrote: [...] > I'm trying the gst1 support but build fails with this error: > gstreamer_encoder.c: In function 'construct_pipeline': > gstreamer_encoder.c:219:41: error: 'GstEncoder' has no member named 'frc' > "deadline", encoder->frc.period

Re: [Spice-devel] [PATCH v2] Report invalid password as a special auth error

2015-05-29 Thread Christophe Fergeau
Hey, On Wed, May 27, 2015 at 04:05:16PM +0200, Cédric Bosdonnat wrote: > Provide a special authentication error message for too long passwords. > Also check for too long passwords before sending them over the wire. > --- > > Diff to v1: >* Added a check in spice_channel_send_spice_ticket >

Re: [Spice-devel] [PATCH 09/11] Move main reference counter to GEM object instead of TTM ones

2015-05-29 Thread Frediano Ziglio
> On 27 May 2015 at 20:04, Frediano Ziglio wrote: > > qxl_bo structure has two reference counters, one in the GEM object and > > another in the TTM object. The GEM object keep a counter to the TTM object > > so when GEM counter reached zero the TTM counter (using qxl_bo_unref) was > > decremented

Re: [Spice-devel] [PATCH 0/11] Add GStreamer and VP8 support

2015-05-29 Thread Fabio Fantoni
Il 29/05/2015 04:29, Francois Gouget ha scritto: > On Thu, 28 May 2015, Fabio Fantoni wrote: > [...] >> Thanks for reply, I'm preparing spice-gtk with vp8 patches armhf for >> test it on arm thin client (for example raspberry 2), I want try to use >> gst-omx for hardware decoding of mjpeg and vp8,

Re: [Spice-devel] [PATCH 00/11] Miscellaneous stability patches

2015-05-29 Thread Frans Klaver
On Thu, May 28, 2015 at 4:10 PM, Frediano Ziglio wrote: > >> also indicating in each patch what is a right now fix and what isn't. > > What do you mean by right fix or not ? He probably meant indicating whether it is an urgent fix. Frans ___ Spice-deve

Re: [Spice-devel] [spice-gtk PATCH v3 1/5] giopipe: don't fail on create_source

2015-05-29 Thread Marc-André Lureau
Hi On Tue, May 26, 2015 at 3:35 PM, Victor Toso wrote: > PipeInputStream and PipeOutputStream should not fail when creating > GPollableStream source. It is already checked and unref in case of > existing source. > > In order to track possible issues, the g_return_val_if_fail was > changed to a g