Re: [Spice-devel] [PATCH spice 6/11] server: Add VP8 support, a video codec preference list and compatibility checks with the Spice client.

2015-05-26 Thread Francois Gouget
On Tue, 19 May 2015, Marc-André Lureau wrote: [...] > > +/* Set the encoder initial bit rate, and ask for a low latency */ > > +adjust_bit_rate(encoder); > > +g_object_set(G_OBJECT(encoder->gstenc), "bitrate", encoder->bit_rate, > > NULL); > > +g_object_set(G_OBJECT(encoder->gstenc

Re: [Spice-devel] [PATCH spice 4/11] server: Add a GStreamer 0.10 MJPEG video encoder and use it by default.

2015-05-26 Thread Francois Gouget
On Tue, 19 May 2015, Marc-André Lureau wrote: [...] > I think this should target at least gstreamer 1.0. Do you have good reasons > to want 0.10 support? I need to target CentOS 6.5 which does not have GStreamer 1.0. I have started work on adding GStreamer 1.0 support anyway but that's not worki

Re: [Spice-devel] [PATCH] Report invalid password as a special auth error

2015-05-26 Thread Christophe Fergeau
On Tue, May 26, 2015 at 04:14:02PM +0200, Christophe Fergeau wrote: > Hey, > > I think you should report an error somehow in > spice_channel_send_spice_ticket() if SpiceSession::password is too > long. Hmm looking at this some more, things seem messy :( The on-wire encrypted password seems to hav

Re: [Spice-devel] Prepare for release 0.16.0 ?

2015-05-26 Thread Jonathon Jongsma
On Tue, 2015-05-26 at 13:30 +0200, poma wrote: > On 26.05.2015 12:49, Christophe Fergeau wrote: > > On Tue, May 26, 2015 at 12:37:09PM +0200, poma wrote: > >> On 26.05.2015 12:12, Christophe Fergeau wrote: > >>> Hey, > >>> > >>> I assume you are asking for a 0.16.0 spice-vdagent release as there we

Re: [Spice-devel] [PATCH spice 3/11] server: Refactor the Spice server video encoding so alternative implementations can be added.

2015-05-26 Thread Francois Gouget
On Tue, 19 May 2015, Marc-André Lureau wrote: [...] > > +struct VideoEncoder { > > +/* Releases the video encoder's resources */ > > +void (*destroy)(VIDEO_ENCODER_T *encoder); > > + > > +/* Compresses the specified src image area into the outbuf buffer. > > + * > > + * @encoder

Re: [Spice-devel] [PATCH 0/11] Add GStreamer and VP8 support

2015-05-26 Thread Fabio Fantoni
Il 25/05/2015 17:07, Fabio Fantoni ha scritto: > Il 21/05/2015 10:34, Fabio Fantoni ha scritto: >> Il 13/05/2015 22:20, Francois Gouget ha scritto: >>> This is a followup on Jeremy White's concept patch to use GStreamer: >>> http://www.spinics.net/lists/spice-devel/msg10030.html >>> >>> There is st

Re: [Spice-devel] [spice-jhbuild PATCH v2 00/12] updating spice-jhbuild

2015-05-26 Thread Victor Toso
Hi, On Tue, May 26, 2015 at 12:09:45PM +0200, Christophe Fergeau wrote: > ACK series, a few minor comments here and there, but good to push > whether you decide to address them or not. I'll fix the commit logs apply the configure options you suggested. I don't mind waiting Phodav and libgovirt on

Re: [Spice-devel] [PATCH] Report invalid password as a special auth error

2015-05-26 Thread Christophe Fergeau
Hey, I think you should report an error somehow in spice_channel_send_spice_ticket() if SpiceSession::password is too long. Christophe On Fri, May 22, 2015 at 06:12:35PM +0200, Cédric Bosdonnat wrote: > Provide a special authentication error message for too long passwords. > --- > Note: this pa

[Spice-devel] [spice-gtk PATCH v3 4/5] tests: pipe using _write_all_async function

2015-05-26 Thread Victor Toso
--- tests/pipe.c | 75 1 file changed, 75 insertions(+) diff --git a/tests/pipe.c b/tests/pipe.c index ec11b6f..e4757b6 100644 --- a/tests/pipe.c +++ b/tests/pipe.c @@ -16,6 +16,10 @@ typedef struct _Fixture { GOutputStream *op2;

[Spice-devel] [spice-gtk PATCH v3 5/5] tests: add test to concurrent write to pipe

2015-05-26 Thread Victor Toso
Concurrent write is not supported and should fail. The GIO error is G_IO_ERROR_PENDING --- tests/pipe.c | 45 + 1 file changed, 45 insertions(+) diff --git a/tests/pipe.c b/tests/pipe.c index e4757b6..9e411f3 100644 --- a/tests/pipe.c +++ b/tests/pipe.c

[Spice-devel] [spice-gtk PATCH v3 2/5] webdav: write all buffer to client webdav

2015-05-26 Thread Victor Toso
Client's webdav can request less data (8192) then the amount sent by guest's webdav. Using g_output_stream_write_all_async in order to avoid losing data. --- gtk/channel-webdav.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/gtk/channel-webdav.c b/

[Spice-devel] [spice-gtk PATCH v3 3/5] tests: remove read8_cb to use generic read_cb

2015-05-26 Thread Victor Toso
Both functions are basic the same so let's keep the generic one. --- tests/pipe.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/tests/pipe.c b/tests/pipe.c index 841cb77..ec11b6f 100644 --- a/tests/pipe.c +++ b/tests/pipe.c @@ -160,26 +160,12 @@ test_pipe_

[Spice-devel] [spice-gtk PATCH v3 0/5] Fix sharing from guest to client

2015-05-26 Thread Victor Toso
In the guest, if you put a file bigger then 8192 bytes would result in data loss in the client. - 01/05 and 02/05 does the fix - 03/05 changing a test callback - 04/05 and 05/05 testing new behavior Victor Toso (5): giopipe: don't fail on create_source webdav: write all buffer to client webdav

[Spice-devel] [spice-gtk PATCH v3 1/5] giopipe: don't fail on create_source

2015-05-26 Thread Victor Toso
PipeInputStream and PipeOutputStream should not fail when creating GPollableStream source. It is already checked and unref in case of existing source. In order to track possible issues, the g_return_val_if_fail was changed to a g_debug message; --- gtk/giopipe.c | 14 -- 1 file change

Re: [Spice-devel] [spice-gtk PATCH v2 1/5] giopipe: don't fail on create_source

2015-05-26 Thread Victor Toso
Hi, On Wed, May 20, 2015 at 12:51:46PM +0200, Marc-André Lureau wrote: > Hi > > On Tue, May 19, 2015 at 4:34 PM, Victor Toso wrote: > > > PipeInputStream and PipeOutputStream should not fail when creating > > GPollableStream source. It is already checked and unref in case of > > existing source

Re: [Spice-devel] Prepare for release 0.16.0 ?

2015-05-26 Thread poma
On 26.05.2015 12:49, Christophe Fergeau wrote: > On Tue, May 26, 2015 at 12:37:09PM +0200, poma wrote: >> On 26.05.2015 12:12, Christophe Fergeau wrote: >>> Hey, >>> >>> I assume you are asking for a 0.16.0 spice-vdagent release as there were >>> quite a few patches since the last one, which was qu

Re: [Spice-devel] Prepare for release 0.16.0 ?

2015-05-26 Thread Christophe Fergeau
On Tue, May 26, 2015 at 12:37:09PM +0200, poma wrote: > On 26.05.2015 12:12, Christophe Fergeau wrote: > > Hey, > > > > I assume you are asking for a 0.16.0 spice-vdagent release as there were > > quite a few patches since the last one, which was quite some time ago > > (2013-10-14) ? > > > > Bet

Re: [Spice-devel] Prepare for release 0.16.0 ?

2015-05-26 Thread poma
On 26.05.2015 12:12, Christophe Fergeau wrote: > Hey, > > I assume you are asking for a 0.16.0 spice-vdagent release as there were > quite a few patches since the last one, which was quite some time ago > (2013-10-14) ? > > Better to sum up in a few sentences what you want rather than letting us

Re: [Spice-devel] Prepare for release 0.16.0 ?

2015-05-26 Thread Christophe Fergeau
Hey, I assume you are asking for a 0.16.0 spice-vdagent release as there were quite a few patches since the last one, which was quite some time ago (2013-10-14) ? Better to sum up in a few sentences what you want rather than letting us play some guess work ;) Christophe On Tue, May 26, 2015 at

Re: [Spice-devel] [spice-jhbuild PATCH v2 00/12] updating spice-jhbuild

2015-05-26 Thread Christophe Fergeau
ACK series, a few minor comments here and there, but good to push whether you decide to address them or not. Christophe On Mon, May 25, 2015 at 02:42:46PM +0200, Victor Toso wrote: > spice-jhbuild v2 > - Addressing Christophe's suggestions: The build is a bit lighter now; > spice-gtk and qemu (

Re: [Spice-devel] [spice-jhbuild PATCH v2 09/12] modulesets: update configure options

2015-05-26 Thread Christophe Fergeau
On Mon, May 25, 2015 at 02:42:55PM +0200, Victor Toso wrote: > spice-server: with lz4, removed client option; > > spice-gtk: with webdav smartcard and usbredir, removed polikit due: > http://lists.freedesktop.org/archives/spice-devel/2014-December/018350.html > > virt-viewer: with spice-gtk > ---

Re: [Spice-devel] [spice-jhbuild PATCH v2 08/12] moduleset: include libgovirt

2015-05-26 Thread Christophe Fergeau
On Mon, May 25, 2015 at 02:42:54PM +0200, Victor Toso wrote: > --- > modulesets/spice.xml | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/modulesets/spice.xml b/modulesets/spice.xml > index 04c1db1..1943af1 100644 > --- a/modulesets/spice.xml > +++ b/modulesets/spice.xml > @@

Re: [Spice-devel] [spice-jhbuild PATCH v2 07/12] moduleset: include Phodav module

2015-05-26 Thread Christophe Fergeau
On Mon, May 25, 2015 at 02:42:53PM +0200, Victor Toso wrote: > This module is necessary to have webdav option enable on spice-gtk I'd reformulate this. "This module is necessary to enable webdav support in spice-gtk" maybe? or "to build spice-gtk with webdav support" Christophe > --- > modulese

Re: [Spice-devel] [spice-jhbuild PATCH v2 05/12] moduleset: use libusb from system

2015-05-26 Thread Christophe Fergeau
On Mon, May 25, 2015 at 02:42:51PM +0200, Victor Toso wrote: > All necessary patches from Hans branch is upstream. 'are upstream' Christophe pgppplf0rvVfs.pgp Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org ht

Re: [Spice-devel] [spice-jhbuild PATCH v2 02/12] moduleset: use celt051 from system packages

2015-05-26 Thread Christophe Fergeau
On Mon, May 25, 2015 at 02:42:48PM +0200, Victor Toso wrote: > - spice-gtk no longer depends on celt Do we want to add a --enable-opus to force opus use instead? Or is it better to rely on autodetection and not force people to install another system package? Christophe pgptOBLqX9dXV.pgp Descrip

Re: [Spice-devel] [vdagent-linux] Bump minimum spice-protocol version

2015-05-26 Thread Fabiano Fidencio
- Original Message - > From: "Christophe Fergeau" > To: spice-de...@freedesktop.org > Sent: Tuesday, May 26, 2015 11:30:55 AM > Subject: [Spice-devel] [vdagent-linux] Bump minimum spice-protocol version > > spice-protocol newer than 0.12.7 is needed for the volume > synchronization bits

Re: [Spice-devel] [PATCH] Post-release version bump

2015-05-26 Thread Fabiano Fidencio
- Original Message - > From: "Christophe Fergeau" > To: spice-devel@lists.freedesktop.org > Sent: Tuesday, May 26, 2015 11:31:00 AM > Subject: [Spice-devel] [PATCH] Post-release version bump > > This allows spice-protocol users to depend on the git version. > spice-vdagent.git needs a s

Re: [Spice-devel] [PATCH linux/vd_agent] configure.ac: Bump spice-protocol to v0.12.8

2015-05-26 Thread Fabiano Fidencio
- Original Message - > From: "Pavel Grunt" > To: spice-devel@lists.freedesktop.org > Sent: Tuesday, May 26, 2015 9:25:43 AM > Subject: [Spice-devel] [PATCH linux/vd_agent] configure.ac: Bump > spice-protocol to v0.12.8 > > It is needed for the volume sync (VD_AGENT_AUDIO_VOLUME_SY

[Spice-devel] [PATCH] Post-release version bump

2015-05-26 Thread Christophe Fergeau
This allows spice-protocol users to depend on the git version. spice-vdagent.git needs a spice-protocol version newer than the latest release for the volume synchronization work or it won't build. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/c

[Spice-devel] [vdagent-linux] Bump minimum spice-protocol version

2015-05-26 Thread Christophe Fergeau
spice-protocol newer than 0.12.7 is needed for the volume synchronization bits. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index f41347d..76bb3ae 100644 --- a/configure.ac +++ b/configure.ac @@ -80,7 +80,7 @@ AC_ARG_ENABLE([stat

Re: [Spice-devel] type name ‘VDAgentAudioVolumeSync’

2015-05-26 Thread poma
On 26.05.2015 09:12, Christophe Fergeau wrote: > Hi, > > On Tue, May 26, 2015 at 08:21:51AM +0200, poma wrote: >> >> http://cgit.freedesktop.org/spice/linux/vd_agent/commit/?id=9b0eb8b >> 0028-vdagent-volume-synchronization-from-client.patch >> >> src/vdagent.c: In function ‘daemon_read_complete’:

Re: [Spice-devel] [PATCH] Do not loop on ERESTARTSYS using interruptible waits

2015-05-26 Thread Christophe Fergeau
Hey, On Fri, May 22, 2015 at 09:58:10AM -0400, Frediano Ziglio wrote: > > > } > > > > > > int qxl_io_update_area(struct qxl_device *qdev, struct qxl_bo *surf, > > > - const struct qxl_rect *area) > > > + const struct qxl_rect *area, bool intr) > > > { > > > i

[Spice-devel] [PATCH linux/vd_agent] configure.ac: Bump spice-protocol to v0.12.8

2015-05-26 Thread Pavel Grunt
It is needed for the volume sync (VD_AGENT_AUDIO_VOLUME_SYNC) --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 959c474..37ae160 100644 --- a/configure.ac +++ b/configure.ac @@ -79,7 +79,7 @@ AC_ARG_ENABLE([static-uinput], PKG

Re: [Spice-devel] type name ‘VDAgentAudioVolumeSync’

2015-05-26 Thread Christophe Fergeau
Hi, On Tue, May 26, 2015 at 08:21:51AM +0200, poma wrote: > > http://cgit.freedesktop.org/spice/linux/vd_agent/commit/?id=9b0eb8b > 0028-vdagent-volume-synchronization-from-client.patch > > src/vdagent.c: In function ‘daemon_read_complete’: > src/vdagent.c:114:9: error: unknown type name ‘VDAgen