[Spice-devel] [PATCH] Report invalid password as a special auth error

2015-05-22 Thread Cédric Bosdonnat
Provide a special authentication error message for too long passwords. --- Note: this patch needs a pending one for spice-common. submodule will need to be updated. gtk/spice-channel.c | 18 ++ gtk/spice-client.h | 2 ++ 2 files changed, 16 insertions(+), 4 deletions(-) diff

[Spice-devel] [PATCH] Add password length checks

2015-05-22 Thread Cédric Bosdonnat
Don't allow setting a too long password. Also send a specific error if the user provides a too long password for client to be able to tell the user about it. --- Note: This patch needs a pending one in spice-common, submodule will need to be updated. server/reds.c | 7 +++ 1 file changed, 7

[Spice-devel] [PATCH] Report invalid password as a special auth error

2015-05-22 Thread Cédric Bosdonnat
Provide a special authentication error message for too long passwords. --- Note that this patch depends on a pending patch in spice-common. gtk/spice-channel.c | 18 ++ gtk/spice-client.h | 2 ++ 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/gtk/spice-channel.

[Spice-devel] [PATCH] Add INVALID_PASSWORD link error

2015-05-22 Thread Cédric Bosdonnat
This link error reports too long password error, to have proper error reporting rather than having an undefined behavior in such a case. --- Note: commits using this one in spice and spice-gtk will follow. spice.proto | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/spice.pr

Re: [Spice-devel] [PATCH qemu 08/11] Add the ability to specify Spice video codecs.

2015-05-22 Thread Jeremy White
Thanks for the review. > > How do you specify "any"? (this would be useful to avoid changing qemu > configuration for various setups) I'm thinking 'auto', instead of any, which would just go through the list of supported codecs, in a hard codec preference order, and test them. If supported, the

Re: [Spice-devel] [PATCH] Do not loop on ERESTARTSYS using interruptible waits

2015-05-22 Thread Frediano Ziglio
> > Hey, > > On Tue, May 19, 2015 at 05:54:54AM -0400, Frediano Ziglio wrote: > > This problem happens using KMS surfaces and QXL driver. > > To easy reproduce use KDE Plasma (which use surfaces a lot) and assure > > you are using KMS surfaces (QXL driver on Fedora/RedHat has a patch to > > stop

Re: [Spice-devel] [PATCH xf86-qxl 1/2] kms: initialize primary surface to screen virtual size

2015-05-22 Thread Christophe Fergeau
ACK series, I haven't tested the first one, I've checked that the second one. Can you expand a bit on what the "rendering glitches" are if that's easy? I'd mention explicitly that there's a crash in the second patch log. Christophe On Wed, May 13, 2015 at 07:12:17PM +0200, Marc-André Lureau wrote

Re: [Spice-devel] [PATCH] Do not loop on ERESTARTSYS using interruptible waits

2015-05-22 Thread Christophe Fergeau
Hey, On Tue, May 19, 2015 at 05:54:54AM -0400, Frediano Ziglio wrote: > This problem happens using KMS surfaces and QXL driver. > To easy reproduce use KDE Plasma (which use surfaces a lot) and assure > you are using KMS surfaces (QXL driver on Fedora/RedHat has a patch to > stop using them). Open