Re: [Spice-devel] [PATCH spice 6/11] server: Add VP8 support, a video codec preference list and compatibility checks with the Spice client.

2015-05-19 Thread Marc-André Lureau
On Wed, May 13, 2015 at 10:28 PM, Francois Gouget wrote: > Preferences can be expressed by sending a semicolon-separated > encoder:codec list. For instance spice:mjpeg for the original video > encoder, and gstreamer:mjpeg for the new one. > The client compatibility check relies on the following n

Re: [Spice-devel] spice-html5 and raw PCM playback

2015-05-19 Thread Jeremy White
> I have tried to add the audio device when the client is connected, but I > can't do it while the virtual machine is running, and I can't keep the > client connected whith the machine turned off or during a reboot. > > I'm using virt-manager to do this and I don't know if there's another > way to

Re: [Spice-devel] Cac redirection through spice client

2015-05-19 Thread Thomas Foster
David, Thank you! I will look into this and see if this can make a difference. On Tue, May 19, 2015 at 10:34 AM, David Jaša wrote: > On Út, 2015-05-19 at 15:59 +0200, David Jaša wrote: > > On Út, 2015-05-19 at 09:00 -0400, Thomas Foster wrote: > > > David, > > > > > > While using the spice clie

Re: [Spice-devel] spice-html5 and raw PCM playback

2015-05-19 Thread lgcortinas
El 18/05/15 a las 18:48, Jeremy White escribió: I do have one possible theory - if qemu initializes the audio device before your client is connected, then spice will not provide opus support. (That is, qemu needs to know what frequency to create the audio line at; it asks spice for advice on th

Re: [Spice-devel] [spice-gtk PATCH v2 2/5] webdav: write all buffer to client webdav

2015-05-19 Thread Victor Toso
On Tue, May 19, 2015 at 04:34:34PM +0200, Victor Toso wrote: > Client's webdav can request less data (8192) then the amount sent by > guest's webdav. Using g_output_stream_write_all_async in order to avoid > losing data. > --- > gtk/channel-webdav.c | 23 +-- > 1 file changed,

[Spice-devel] [spice-gtk PATCH v2 5/5] tests: pipe using _write_all_async function

2015-05-19 Thread Victor Toso
--- tests/pipe.c | 75 1 file changed, 75 insertions(+) diff --git a/tests/pipe.c b/tests/pipe.c index 6dbd7cf..62e3a7b 100644 --- a/tests/pipe.c +++ b/tests/pipe.c @@ -16,6 +16,10 @@ typedef struct _Fixture { GOutputStream *op2;

[Spice-devel] [spice-gtk PATCH v2 0/5] Fix sharing from guest to client

2015-05-19 Thread Victor Toso
In the guest, if you put a file bigger then 8192 bytes would result in data loss in the client. - 01/05 and 01/02 does the fix; - 03/05 is a small fix on test; - 04/05 unref pipe-input-stream and pipe-output-stream which is not being freed by GIOStream; - 05/05 implements test of _write_all to ch

[Spice-devel] [spice-gtk PATCH v2 1/5] giopipe: don't fail on create_source

2015-05-19 Thread Victor Toso
PipeInputStream and PipeOutputStream should not fail when creating GPollableStream source. It is already checked and unref in case of existing source. --- gtk/giopipe.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/gtk/giopipe.c b/gtk/giopipe.c index 440cae9..32fa4fa 100644 --- a/gtk/gi

Re: [Spice-devel] Cac redirection through spice client

2015-05-19 Thread David Jaša
On Út, 2015-05-19 at 15:59 +0200, David Jaša wrote: > On Út, 2015-05-19 at 09:00 -0400, Thomas Foster wrote: > > David, > > > > While using the spice client have you put your cac into your local > > reader? If so, we're you able to use it? I ask because if you look > > at my screenshots from my

[Spice-devel] [spice-gtk PATCH v2 2/5] webdav: write all buffer to client webdav

2015-05-19 Thread Victor Toso
Client's webdav can request less data (8192) then the amount sent by guest's webdav. Using g_output_stream_write_all_async in order to avoid losing data. --- gtk/channel-webdav.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/gtk/channel-webdav.c b/gt

[Spice-devel] [spice-gtk PATCH v2 4/5] tests: fix leaks from pipes

2015-05-19 Thread Victor Toso
==30787== 2,808 (648 direct, 2,160 indirect) bytes in 9 blocks are definitely lost in loss record 479 of 482 ==30787==at 0x93AEBFD: g_type_create_instance (gtype.c:1849) ==30787==by 0x939128A: g_object_new_internal (gobject.c:1774) ==30787==by 0x9392AA0: g_object_newv (gobject.c:1921) =

[Spice-devel] [spice-gtk PATCH v2 3/5] tests: read8_cb expects GMainLoop as user_data

2015-05-19 Thread Victor Toso
--- tests/pipe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/pipe.c b/tests/pipe.c index 841cb77..ead8c99 100644 --- a/tests/pipe.c +++ b/tests/pipe.c @@ -179,7 +179,7 @@ test_pipe_write16read8(Fixture *f, gconstpointer user_data) g_output_stream_write_async(

Re: [Spice-devel] [PATCH spice 4/11] server: Add a GStreamer 0.10 MJPEG video encoder and use it by default.

2015-05-19 Thread Marc-André Lureau
Hi On Wed, May 13, 2015 at 10:27 PM, Francois Gouget wrote: > The GStreamer video encoder is quite primitive and mostly meant to > introduce, test and debug the basic infrastructure. > The main limitation is the lack of rate control: the bitrate is set at > startup and will not react to changes

Re: [Spice-devel] [PATCH spice 3/11] server: Refactor the Spice server video encoding so alternative implementations can be added.

2015-05-19 Thread Marc-André Lureau
looks good On Wed, May 13, 2015 at 10:27 PM, Francois Gouget wrote: > This patch simply replaces the mjpeg_encoder_xxx() call points with a > more object oriented design. > --- > server/Makefile.am | 2 +- > server/mjpeg_encoder.c | 134 +--- > server/m

Re: [Spice-devel] Cac redirection through spice client

2015-05-19 Thread Thomas Foster
Screenshots: https://docs.google.com/file/d/0B8YKYK8tZF1zdUpCZjVmdGZYa3hScEtfczhYemRJdFdnUGlF/edit?usp=docslist_api https://docs.google.com/file/d/0B8YKYK8tZF1zTGhjMkFENl8xWFVYMHdqSEZtcHBfMHJWY3RZ/edit?usp=docslist_api https://docs.google.com/file/d/0B8YKYK8tZF1zeXNicWEwVUg4VDY4Q01lbDJPWXdMZ1c1L

Re: [Spice-devel] [PATCH spice 1/11] server: Convert a couple of rate control checks into asserts in the mjpeg video encoder.

2015-05-19 Thread Marc-André Lureau
ack On Wed, May 13, 2015 at 10:25 PM, Francois Gouget wrote: > The checks would lead the reader to think these functions can be called > when bit rate control is off when in fact they are only called when it > is active. > --- > > This patch makes sense independently from the rest of the series.

Re: [Spice-devel] [PATCH spice 2/11] server: Remove the rate_control_is_active field from MJpegEncoder.

2015-05-19 Thread Marc-André Lureau
ack On Wed, May 13, 2015 at 10:26 PM, Francois Gouget wrote: > It is redundant with the corresponding callbacks. > --- > > This patch only depends on patch 1/11 and is independent from the rest > of the series. > > server/mjpeg_encoder.c | 22 +- > server/mjpeg_encoder.h |

Re: [Spice-devel] [PATCH protocol 5/11] Add support for the VP8 video codec and for advertising supported video codecs.

2015-05-19 Thread Marc-André Lureau
On Wed, May 13, 2015 at 10:27 PM, Francois Gouget wrote: > Clients that support other codecs besides MJPEG should advertise the > SPICE_DISPLAY_CAP_MULTI_CODEC capability and one > SPICE_DISPLAY_CAP_CODEC_XXX per supported codec. ack -- Marc-André Lureau _

Re: [Spice-devel] Cac redirection through spice client

2015-05-19 Thread Thomas Foster
David, While using the spice client have you put your cac into your local reader? If so, we're you able to use it? I ask because if you look at my screenshots from my last email I get the same usb device (usbccid), but I also get an extra device that is a problem.

Re: [Spice-devel] [PATCH qxl 7/11] Add SpiceVideoCodecs and $XSPICE_VIDEO_CODECS for specifying video codec preferences.

2015-05-19 Thread Marc-André Lureau
looks fine On Wed, May 13, 2015 at 10:28 PM, Francois Gouget wrote: > --- > examples/spiceqxl.xorg.conf.example | 7 +++ > src/qxl.h | 1 + > src/qxl_driver.c| 2 ++ > src/spiceqxl_spice_server.c | 16 > 4 files chang

Re: [Spice-devel] [PATCH qemu 08/11] Add the ability to specify Spice video codecs.

2015-05-19 Thread Marc-André Lureau
On Wed, May 13, 2015 at 10:30 PM, Jeremy White wrote: > Signed-off-by: Jeremy White > --- > qemu-options.hx | 8 > ui/spice-core.c | 17 + > 2 files changed, 25 insertions(+) > > diff --git a/qemu-options.hx b/qemu-options.hx > index ec356f6..acd78a7 100644 > --- a/qem

Re: [Spice-devel] [PATCH spice-gtk 9/11] Add the ability to use gstreamer for vp8 decoding.

2015-05-19 Thread Marc-André Lureau
Hi On Wed, May 13, 2015 at 10:31 PM, Jeremy White wrote: > +// TODO. Grr. Seems like a wasted alloc > +d = g_malloc(size); > +memcpy(d, data, size); > + > It could reference the msg, this would guarantee the data remains valid and unref it when no longer needed. > +buffer =

[Spice-devel] [PATCH] Do not loop on ERESTARTSYS using interruptible waits

2015-05-19 Thread Frediano Ziglio
This problem happens using KMS surfaces and QXL driver. To easy reproduce use KDE Plasma (which use surfaces a lot) and assure you are using KMS surfaces (QXL driver on Fedora/RedHat has a patch to stop using them). Open some complex application like LibreOffice and after a while your machine get s

Re: [Spice-devel] [spice-common][PATCH 1/2] ppc: Deal with lz magic endianess

2015-05-19 Thread Denis Kirjanov
On 5/18/15, Fabiano Fidêncio wrote: > On Mon, May 18, 2015 at 6:13 PM, Christophe Fergeau > wrote: >> On Mon, May 18, 2015 at 03:10:57PM +0200, Fabiano Fidêncio wrote: >>> Since commit d39dfbfe lz magic is always treated as LE when encoded. >>> Treating it as a LE when decoding is now necessary a

Re: [Spice-devel] [spice-common][PATCH 2/2] ppc: Fix quic magic endianess

2015-05-19 Thread Christophe Fergeau
On Tue, May 19, 2015 at 05:18:44AM -0400, Frediano Ziglio wrote: > > > > --- > > common/quic.c | 6 -- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/common/quic.c b/common/quic.c > > index 16290d4..0fbe6c5 100644 > > --- a/common/quic.c > > +++ b/common/quic.c > >

Re: [Spice-devel] [spice-common][PATCH 2/2] ppc: Fix quic magic endianess

2015-05-19 Thread Frediano Ziglio
> > --- > common/quic.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/common/quic.c b/common/quic.c > index 16290d4..0fbe6c5 100644 > --- a/common/quic.c > +++ b/common/quic.c > @@ -23,6 +23,8 @@ > #include > #endif > > +#include > + > #include "quic.h" >

Re: [Spice-devel] [spice-common][PATCH 1/2] ppc: Deal with lz magic endianess

2015-05-19 Thread Christophe Fergeau
On Mon, May 18, 2015 at 06:44:28PM +0200, Fabiano Fidêncio wrote: > On Mon, May 18, 2015 at 6:13 PM, Christophe Fergeau > wrote: > > On Mon, May 18, 2015 at 03:10:57PM +0200, Fabiano Fidêncio wrote: > >> Since commit d39dfbfe lz magic is always treated as LE when encoded. > >> Treating it as a LE