Re: [Spice-devel] [PATCH spice-gtk] spicy: remove useless signal handlers

2015-05-12 Thread Christophe Fergeau
On Wed, May 06, 2015 at 05:31:06PM +0200, Marc-André Lureau wrote: > There is no strong reason to have signal handlers in spicy (a test > tool). Clean quit can be achieved through the File/Quit menu. ACK. Christophe pgpJ2I3EXWD0i.pgp Description: PGP signature __

Re: [Spice-devel] [PATCH 12/13] README: Fix url, include info and more

2015-05-12 Thread Christophe Fergeau
On Thu, Apr 30, 2015 at 06:59:13PM +0200, Victor Toso wrote: > --- > README | 32 +--- > 1 file changed, 29 insertions(+), 3 deletions(-) > > diff --git a/README b/README > index 1d724d2..b533bda 100644 > --- a/README > +++ b/README > @@ -8,25 +8,51 @@ cd jhbuild > ./

Re: [Spice-devel] spice-html5 and raw PCM playback

2015-05-12 Thread Jeremy White
Hi Lorenzo, > Maybe I missing something or it's impossible to make PCM audio work on > MediaSource API. I'm afraid that is the reality; the Media Source API is pretty limited in the codecs that it supports, and raw is very definitely not one of them. > > Modify the server would be hard at this

Re: [Spice-devel] Regression: qemu crash of hvm domUs with spice (backtrace included)

2015-05-12 Thread Stefano Stabellini
On Tue, 12 May 2015, Stefano Stabellini wrote: > On Tue, 12 May 2015, Fabio Fantoni wrote: > > Il 12/05/2015 12:26, Fabio Fantoni ha scritto: > > > Il 12/05/2015 11:23, Fabio Fantoni ha scritto: > > > > Il 11/05/2015 17:04, Fabio Fantoni ha scritto: > > > > > Il 21/04/2015 14:53, Stefano Stabellini

Re: [Spice-devel] [PATCH 13/13] moduleset: Update dependencies

2015-05-12 Thread Christophe Fergeau
On Thu, Apr 30, 2015 at 06:59:14PM +0200, Victor Toso wrote: > --- > modulesets/spice.xml | 25 + > 1 file changed, 25 insertions(+) > > diff --git a/modulesets/spice.xml b/modulesets/spice.xml > index 589b250..6b0180f 100644 > --- a/modulesets/spice.xml > +++ b/modulesets

Re: [Spice-devel] Regression: qemu crash of hvm domUs with spice (backtrace included)

2015-05-12 Thread Stefano Stabellini
On Tue, 12 May 2015, Fabio Fantoni wrote: > Il 12/05/2015 12:26, Fabio Fantoni ha scritto: > > Il 12/05/2015 11:23, Fabio Fantoni ha scritto: > > > Il 11/05/2015 17:04, Fabio Fantoni ha scritto: > > > > Il 21/04/2015 14:53, Stefano Stabellini ha scritto: > > > > > On Tue, 21 Apr 2015, Fabio Fantoni

Re: [Spice-devel] [PATCH 10/13] jhbuildrc: use module_autogenargs

2015-05-12 Thread Christophe Fergeau
On Thu, Apr 30, 2015 at 06:59:11PM +0200, Victor Toso wrote: > It is better to have the default configure options inside jhbuildrc > instead of xml moduleset. NACK on this one, in other modulesets the configure args are in the moduleset file. You can remove some of the --enable-xxx flags if you pr

Re: [Spice-devel] [PATCH 02/13] moduleset: use packages instead of tarballs

2015-05-12 Thread Christophe Fergeau
On Thu, Apr 30, 2015 at 06:59:03PM +0200, Victor Toso wrote: > - pyparsing and celt051 are system packages; > - spice-gtk no longer depends on celt Do we have a way of makinng jhbuild check that these packages are available? If not, I'd prefer to keep pyparsing as this is required to build spice-g

Re: [Spice-devel] [PATCH 11/13] jhbuildrc: using system icons and files not needed

2015-05-12 Thread Christophe Fergeau
On Thu, Apr 30, 2015 at 06:59:12PM +0200, Victor Toso wrote: > --- > jhbuildrc | 9 - > 1 file changed, 9 deletions(-) > > diff --git a/jhbuildrc b/jhbuildrc > index 4cfff9b..cfffb88 100644 > --- a/jhbuildrc > +++ b/jhbuildrc > @@ -18,15 +18,6 @@ checkoutroot = os.path.join(os.environ['HO

Re: [Spice-devel] [PATCH 04/13] moduleset: libcacard is part of qemu now

2015-05-12 Thread Christophe Fergeau
Hey, On Thu, Apr 30, 2015 at 06:59:05PM +0200, Victor Toso wrote: > The source is inside qemu but it is kept as different package which > spice-gtk and spice-server depends on currently. I dono't really understand your commit log here. The module you remove is building libcacard from qemu sources

Re: [Spice-devel] [PATCH 09/13] moduleset: include libgovirt

2015-05-12 Thread Christophe Fergeau
On Thu, Apr 30, 2015 at 06:59:10PM +0200, Victor Toso wrote: > --- > modulesets/spice.xml | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/modulesets/spice.xml b/modulesets/spice.xml > index d0d58c7..29fa7b9 100644 > --- a/modulesets/spice.xml > +++ b/modulesets/spice.xml >

Re: [Spice-devel] [PATCH 06/13] moduleset: use libusb from system

2015-05-12 Thread Christophe Fergeau
ACK. You could mention that all the necessary patches have been merged upstream now. Christophe On Thu, Apr 30, 2015 at 06:59:07PM +0200, Victor Toso wrote: > --- > modulesets/spice.xml | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/modulesets/spice.xml b/modulesets/spice.xml > in

Re: [Spice-devel] [PATCH 08/13] moduleset: include Phodav module

2015-05-12 Thread Christophe Fergeau
On Thu, Apr 30, 2015 at 06:59:09PM +0200, Victor Toso wrote: > This module is necessary to have webdav option enable on spice-gtk > --- > modulesets/spice.xml | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/modulesets/spice.xml b/modulesets/spice.xml > index 67812f5..d0d58c7

Re: [Spice-devel] [PATCH 07/13] moduleset: improve qemu configure options

2015-05-12 Thread Christophe Fergeau
On Thu, Apr 30, 2015 at 06:59:08PM +0200, Victor Toso wrote: > --- > modulesets/spice.xml | 18 +- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/modulesets/spice.xml b/modulesets/spice.xml > index 630bc24..67812f5 100644 > --- a/modulesets/spice.xml > +++ b/mo

Re: [Spice-devel] [PATCH 01/13] moduleset: include gnome-apps-3.18 moduleset

2015-05-12 Thread Christophe Fergeau
On Thu, Apr 30, 2015 at 06:59:02PM +0200, Victor Toso wrote: > By including gnome-apps-3.18 we have the following modules: > - gnome-boxes > - libvirt-glib > - vinagre > - gtk-vnc > - libosinfo ACK. Christophe pgpaHN2rwCs6H.pgp Description: PGP signature

Re: [Spice-devel] [PATCH 05/13] moduleset: virtinst is part of virt-manager

2015-05-12 Thread Christophe Fergeau
ACK. On Thu, Apr 30, 2015 at 06:59:06PM +0200, Victor Toso wrote: > --- > modulesets/spice.xml | 8 > 1 file changed, 8 deletions(-) > > diff --git a/modulesets/spice.xml b/modulesets/spice.xml > index 7085ec4..7346242 100644 > --- a/modulesets/spice.xml > +++ b/modulesets/spice.xml > @

Re: [Spice-devel] [PATCH 03/13] moduleset: usbredir was moved to spice repository

2015-05-12 Thread Christophe Fergeau
ACK. On Thu, Apr 30, 2015 at 06:59:04PM +0200, Victor Toso wrote: > --- > modulesets/spice.xml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/modulesets/spice.xml b/modulesets/spice.xml > index b57689a..291dbf2 100644 > --- a/modulesets/spice.xml > +++ b/moduleset

Re: [Spice-devel] [PATCH v2 1/3] jhbuildrc: switch default from gtk2 to gtk3

2015-05-12 Thread Christophe Fergeau
On Tue, May 12, 2015 at 03:48:50PM +0200, Victor Toso wrote: > On Tue, May 12, 2015 at 03:34:22PM +0200, Christophe Fergeau wrote: > > On Mon, May 11, 2015 at 09:07:19PM +0200, Victor Toso wrote: > > > Hi, > > > > > > On Sun, May 10, 2015 at 06:47:31PM +0300, Kirill Moizik wrote: > > > > From: Kir

Re: [Spice-devel] Regression: qemu crash of hvm domUs with spice (backtrace included)

2015-05-12 Thread Fabio Fantoni
Il 12/05/2015 12:26, Fabio Fantoni ha scritto: Il 12/05/2015 11:23, Fabio Fantoni ha scritto: Il 11/05/2015 17:04, Fabio Fantoni ha scritto: Il 21/04/2015 14:53, Stefano Stabellini ha scritto: On Tue, 21 Apr 2015, Fabio Fantoni wrote: Il 21/04/2015 12:49, Stefano Stabellini ha scritto: On Mo

Re: [Spice-devel] [PATCH v2 1/3] jhbuildrc: switch default from gtk2 to gtk3

2015-05-12 Thread Victor Toso
On Tue, May 12, 2015 at 03:34:22PM +0200, Christophe Fergeau wrote: > On Mon, May 11, 2015 at 09:07:19PM +0200, Victor Toso wrote: > > Hi, > > > > On Sun, May 10, 2015 at 06:47:31PM +0300, Kirill Moizik wrote: > > > From: Kirill Moizik > > > > > > change default modules from modules using gtk2 to

Re: [Spice-devel] [PATCH v2 1/3] jhbuildrc: switch default from gtk2 to gtk3

2015-05-12 Thread Christophe Fergeau
On Mon, May 11, 2015 at 09:07:19PM +0200, Victor Toso wrote: > Hi, > > On Sun, May 10, 2015 at 06:47:31PM +0300, Kirill Moizik wrote: > > From: Kirill Moizik > > > > change default modules from modules using gtk2 to modules using gtk3 > > As Fabiano mentioned, the requirements for virt-viewer-gt

Re: [Spice-devel] [PATCH v2 2/3] jhbuildrc: fix autogen flags for cmake

2015-05-12 Thread Christophe Fergeau
On Mon, May 11, 2015 at 09:11:02PM +0200, Victor Toso wrote: > Hi, > > On Sun, May 10, 2015 at 06:47:32PM +0300, Kirill Moizik wrote: > > From: Kirill Moizik > > > > cmake autogen can not be run with --disable-introspection flag > > > > Signed-off-by: Kirill Moizik > > --- > > jhbuildrc | 1 +

Re: [Spice-devel] [PATCH v2 2/3] jhbuildrc: fix autogen flags for cmake

2015-05-12 Thread Christophe Fergeau
On Sun, May 10, 2015 at 06:47:32PM +0300, Kirill Moizik wrote: > From: Kirill Moizik > > cmake autogen can not be run with --disable-introspection flag Isn't this is fixed upstream already? https://git.gnome.org/browse/gtk-osx/commit/?id=ec925a5c Christophe pgp5_Y3Jl6olw.pgp Description: PGP

Re: [Spice-devel] [PATCH v2 0/3] Fix Mac OS spice client build

2015-05-12 Thread Christophe Fergeau
Hi, On Mon, May 11, 2015 at 12:01:05AM +0200, Fabiano Fidêncio wrote: > Thanks for taking a look on the OSX client. > > I have a some doubts not exactly related to your patches. > Did you update the repo spice.xml file? If not, why? Seems that you're > building virt-viewer 0.5.7 (last release is

Re: [Spice-devel] [PATCH v2 0/3] Fix Mac OS spice client build

2015-05-12 Thread Christophe Fergeau
On Mon, May 11, 2015 at 09:23:26PM +0200, Victor Toso wrote: > Hi, > > On Mon, May 11, 2015 at 12:01:05AM +0200, Fabiano Fidêncio wrote: > > I have a some doubts not exactly related to your patches. > > Did you update the repo spice.xml file? If not, why? Seems that you're > > building virt-viewer

Re: [Spice-devel] [spice-gtk][PATCH] spice-gtk: Fixed build when using audio gstreamer

2015-05-12 Thread Marc-André Lureau
ack, I'll apply On Tue, May 12, 2015 at 2:51 PM, Lukas Venhoda wrote: > Commit No. 63bf00275769928850113b4df205df08d6303b45 changed number of > arguments of function playback_stop(), and didn't change call of this > function on line 628. > > This would break building when using --with-audio=gstr

[Spice-devel] [spice-gtk][PATCH] spice-gtk: Fixed build when using audio gstreamer

2015-05-12 Thread Lukas Venhoda
Commit No. 63bf00275769928850113b4df205df08d6303b45 changed number of arguments of function playback_stop(), and didn't change call of this function on line 628. This would break building when using --with-audio=gstreamer --- gtk/spice-gstaudio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [Spice-devel] Regression: qemu crash of hvm domUs with spice (backtrace included)

2015-05-12 Thread Fabio Fantoni
Il 12/05/2015 11:23, Fabio Fantoni ha scritto: Il 11/05/2015 17:04, Fabio Fantoni ha scritto: Il 21/04/2015 14:53, Stefano Stabellini ha scritto: On Tue, 21 Apr 2015, Fabio Fantoni wrote: Il 21/04/2015 12:49, Stefano Stabellini ha scritto: On Mon, 20 Apr 2015, Fabio Fantoni wrote: I updated x

[Spice-devel] spice-html5 and raw PCM playback

2015-05-12 Thread lgcortinas
Hello, I'm running Debian 7.7 guest on Ubuntu 14.04 with QEMU 2.0.0 downloaded from the Ubuntu repositories. With spicec client everything runs fine, but when using the spice-html5 client the sound doesn't work. I have noticed that the server is sending the audio in raw PCM format and the html

Re: [Spice-devel] [PATCH] server: input_channel: fix input on BE machines

2015-05-12 Thread Christophe Fergeau
On Mon, May 11, 2015 at 07:08:40PM +0300, Denis Kirjanov wrote: > On 5/11/15, Christophe Fergeau wrote: > > Hi, > > > > On Tue, Apr 14, 2015 at 10:26:20AM +0300, Denis Kirjanov wrote: > >> > As this is a similar issue as your patch about the number of channels, > >> > can you double check that on

Re: [Spice-devel] Regression: qemu crash of hvm domUs with spice (backtrace included)

2015-05-12 Thread Fabio Fantoni
Il 11/05/2015 17:04, Fabio Fantoni ha scritto: Il 21/04/2015 14:53, Stefano Stabellini ha scritto: On Tue, 21 Apr 2015, Fabio Fantoni wrote: Il 21/04/2015 12:49, Stefano Stabellini ha scritto: On Mon, 20 Apr 2015, Fabio Fantoni wrote: I updated xen and qemu from xen 4.5.0 with its upstream qem