Re: [Spice-devel] [spice-gtk PATCH v7 2/4] audio: spice-pulse implement async volume-info

2015-04-15 Thread Marc-André Lureau
On Wed, Apr 15, 2015 at 6:39 PM, Victor Toso wrote: > In case of volume-sync between client and guest, we request volume-info > from the availables streams and if the stream is not available we rely > on ext-stream-restore. > > By using ext-stream-restore we can get the last stream data of the >

Re: [Spice-devel] [spice-gtk PATCH v6 2/4] audio: spice-pulse implement async volume-info

2015-04-15 Thread Marc-André Lureau
On Wed, Apr 15, 2015 at 2:12 PM, Victor Toso wrote: > > > + > > > +if (info->channel_map.channels == 0) { > > > +SPICE_DEBUG("%s - Number of channels stored is zero. Ignore. > > > (%s)", __func__, info->name); > > > +return; > > > + > > > > What if there is already a playing s

[Spice-devel] [spice-gtk PATCH v7 0/4] volume-sync v7 changes

2015-04-15 Thread Victor Toso
Sending only the patches not-acked of client: spice-pulse v7 - Keep pa_operation in case async operation is cancelled; - Cancellation is done with "cancelled" signal from GCancellable; Before glib 2.40 we can't disconnect the callback inside the callback without a deadlock so I'm freeing the m

[Spice-devel] [spice-gtk PATCH v7 2/4] audio: spice-pulse implement async volume-info

2015-04-15 Thread Victor Toso
In case of volume-sync between client and guest, we request volume-info from the availables streams and if the stream is not available we rely on ext-stream-restore. By using ext-stream-restore we can get the last stream data of the application that is stored by PulseAudio. Related: https://bugzi

[Spice-devel] [spice-gtk PATCH v7 4/4] agent: sync guest audio with client values

2015-04-15 Thread Victor Toso
Functions to sync volume and mute value when necessary. In this patch, only one sync is allowed after agent connect. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1012868 --- gtk/channel-main.c | 141 +++ gtk/spice-session-priv.h | 2 +-

Re: [Spice-devel] [spice-common] codegen: Use six.PY3 rather than six.PY2

2015-04-15 Thread Alex Wauck
Good to know. Which distro has that version? Also, changes look correct. On Wed, 15 Apr 2015 16:03:22 +0200 Christophe Fergeau wrote: > Older versions of python-six (at least 1.3.0) defined six.PY3 but not > six.PY2. six.PY2 is only used twice in straightforward tests so it's > easy to use six

Re: [Spice-devel] [spice-common] codegen: Use six.PY3 rather than six.PY2

2015-04-15 Thread Christophe Fergeau
On Wed, Apr 15, 2015 at 09:53:18AM -0500, Alex Wauck wrote: > Good to know. Which distro has that version? RHEL7.1 Christophe pgpmJ1NIXe6oV.pgp Description: PGP signature ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.fre

Re: [Spice-devel] [PATCH] spice: fix simple display on bigendian hosts

2015-04-15 Thread Gerd Hoffmann
On Mi, 2015-04-15 at 15:55 +0300, Denis Kirjanov wrote: > On 4/15/15, Gerd Hoffmann wrote: > > On Di, 2015-04-14 at 17:47 +0300, Denis Kirjanov wrote: > >> On 4/14/15, Denis Kirjanov wrote: > >> > On 4/14/15, Denis Kirjanov wrote: > >> >> On 4/14/15, Gerd Hoffmann wrote: > >> >>> Denis Kirjanov

[Spice-devel] [spice-common] codegen: Use six.PY3 rather than six.PY2

2015-04-15 Thread Christophe Fergeau
Older versions of python-six (at least 1.3.0) defined six.PY3 but not six.PY2. six.PY2 is only used twice in straightforward tests so it's easy to use six.PY3 instead. --- python_modules/codegen.py | 6 +++--- spice_codegen.py | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)

Re: [Spice-devel] [PATCH] spice: fix simple display on bigendian hosts

2015-04-15 Thread Denis Kirjanov
On 4/15/15, Gerd Hoffmann wrote: > On Di, 2015-04-14 at 17:47 +0300, Denis Kirjanov wrote: >> On 4/14/15, Denis Kirjanov wrote: >> > On 4/14/15, Denis Kirjanov wrote: >> >> On 4/14/15, Gerd Hoffmann wrote: >> >>> Denis Kirjanov is busy getting spice run on ppc64 and trapped into >> >>> this >>

Re: [Spice-devel] [spice-gtk PATCH v6 2/4] audio: spice-pulse implement async volume-info

2015-04-15 Thread Victor Toso
Hi, many thanks for the review! On Wed, Apr 15, 2015 at 12:05:53PM +0200, Marc-André Lureau wrote: > Hi > > On Tue, Apr 14, 2015 at 2:18 PM, Victor Toso wrote: > > > In case of volume-sync between client and guest, we request volume-info > > from the availables streams and if the stream is not av

Re: [Spice-devel] [PATCH] spice: fix simple display on bigendian hosts

2015-04-15 Thread Gerd Hoffmann
On Di, 2015-04-14 at 17:47 +0300, Denis Kirjanov wrote: > On 4/14/15, Denis Kirjanov wrote: > > On 4/14/15, Denis Kirjanov wrote: > >> On 4/14/15, Gerd Hoffmann wrote: > >>> Denis Kirjanov is busy getting spice run on ppc64 and trapped into this > >>> one. Spice wire format is little endian, so

Re: [Spice-devel] [vdagent-win] build-sys: Ship mingw-spice-vdagent.spec in tarballs

2015-04-15 Thread Fabiano Fidêncio
On Wed, Apr 15, 2015 at 1:59 PM, Christophe Fergeau wrote: > On Wed, Apr 15, 2015 at 12:16:05PM +0200, Fabiano Fidêncio wrote: >> While you're on this (and considering you are in the mood) ... would >> worth to add the same thing for spice-gtk and vdagent-linux ... > > I don't think any of these s

Re: [Spice-devel] [vdagent-win] build-sys: Ship mingw-spice-vdagent.spec in tarballs

2015-04-15 Thread Christophe Fergeau
On Wed, Apr 15, 2015 at 12:16:05PM +0200, Fabiano Fidêncio wrote: > While you're on this (and considering you are in the mood) ... would > worth to add the same thing for spice-gtk and vdagent-linux ... I don't think any of these ship a .spec.in file, are you suggesting they should be added there

Re: [Spice-devel] [spice-gtk PATCH v6 3/4] audio: spice-gstaudio implements async volume-info

2015-04-15 Thread Marc-André Lureau
looks good, ack On Tue, Apr 14, 2015 at 2:18 PM, Victor Toso wrote: > Gstaudio rely on sink/src elements to get the volume/mute. > (e.g. pulsesink and pulsesrc, the values are updated by PulseAudio > itself when requested) > --- > gtk/spice-gstaudio.c | 191 > +++

Re: [Spice-devel] [vdagent-win] build-sys: Ship mingw-spice-vdagent.spec in tarballs

2015-04-15 Thread Fabiano Fidêncio
On Wed, Apr 15, 2015 at 11:29 AM, Christophe Fergeau wrote: > Having this file pregenerated is useful if one wants to use it to > generate a package from tarball with: > tar xf vdagent-win-$version.tar.xz mingw-virt-viewer.spec > rpmbuild mingw-virt-viewer.spec > > This is more convenient than ext

Re: [Spice-devel] [spice-gtk PATCH v6 2/4] audio: spice-pulse implement async volume-info

2015-04-15 Thread Marc-André Lureau
On Tue, Apr 14, 2015 at 2:18 PM, Victor Toso wrote: > +if (p->playback.name) > +g_free(p->playback.name); > + > +if (p->record.name) > +g_free(p->record.name); > + > g_free() accepts NULL, no need for if -- Marc-André Lureau

Re: [Spice-devel] [spice-gtk PATCH v6 2/4] audio: spice-pulse implement async volume-info

2015-04-15 Thread Marc-André Lureau
Hi On Tue, Apr 14, 2015 at 2:18 PM, Victor Toso wrote: > In case of volume-sync between client and guest, we request volume-info > from the availables streams and if the stream is not available we rely > on ext-stream-restore. > > By using ext-stream-restore we can get the last stream data of th

[Spice-devel] [vdagent-win] build-sys: Ship mingw-spice-vdagent.spec in tarballs

2015-04-15 Thread Christophe Fergeau
Having this file pregenerated is useful if one wants to use it to generate a package from tarball with: tar xf vdagent-win-$version.tar.xz mingw-virt-viewer.spec rpmbuild mingw-virt-viewer.spec This is more convenient than extracting the whole tarball, and configuring it in order to generate mingw

[Spice-devel] are there any new spice protocol document?

2015-04-15 Thread Dennis Chen
Hi, I am studying spice protocol, and I found a document here : http://www.spice-space.org/docs/spice_protocol.pdf, which is draft and version is 1.0. Just want to know is this document new enough ( I try to write a proxy to study from the real communication, but I found there are some extra data

Re: [Spice-devel] [PATCH] Make update-symbol-files work when builddir != srcdir

2015-04-15 Thread Christophe Fergeau
On Tue, Apr 14, 2015 at 12:35:32PM -0500, Jonathon Jongsma wrote: > rewrite the update-symbol-files rule to use dependencies and automatic > variables ($<) so that VPATH will allow make to find these files in the > srcdir as well as the builddir. ACK. > --- > gtk/Makefile.am | 14 ++