Re: [Spice-devel] windows guest file transfer

2015-02-03 Thread Marc-André Lureau
Hi - Original Message - > On 02/02/2015 06:23 AM, Marc-André Lureau wrote: > >> The failing step was this program: > >> > > >> >http://elmarco.fedorapeople.org/spice-webdavd-x86-0.1.24.msi > > > Have you read those > > instructions:https://elmarco.fedorapeople.org/manual.html#_folder_sha

Re: [Spice-devel] windows guest file transfer

2015-02-03 Thread John Griessen
On 02/02/2015 06:23 AM, Marc-André Lureau wrote: The failing step was this program: > >http://elmarco.fedorapeople.org/spice-webdavd-x86-0.1.24.msi Have you read those instructions:https://elmarco.fedorapeople.org/manual.html#_folder_sharing ? I tried doing the below setup:

Re: [Spice-devel] windows guest file transfer

2015-02-03 Thread John Griessen
On 02/03/2015 10:55 AM, Marc-André Lureau wrote: (why not cc the ML?) - Original Message - > >Please try to give more details on what failed, and how you configured > >libvirt/qemu. >I configured it with virt-manager up to the point of folder sharing, then >tried running the >guest ins

Re: [Spice-devel] [PATCH] char-device: spice_char_device_write_to_device: protect against recursion

2015-02-03 Thread Marc-André Lureau
- Original Message - > On Mon, 2015-02-02 at 11:37 -0500, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > This fixes Spice's smart card support and is related to > > > commit 697f3214fd16adcd524456003619f7f44ddd031b. > > > > > > Reported-by: Swapna Krishnan >

Re: [Spice-devel] [PATCH] char-device: spice_char_device_write_to_device: protect against recursion

2015-02-03 Thread Uri Lublin
On Mon, 2015-02-02 at 11:37 -0500, Marc-André Lureau wrote: > Hi > > - Original Message - > > This fixes Spice's smart card support and is related to > > commit 697f3214fd16adcd524456003619f7f44ddd031b. > > > > Reported-by: Swapna Krishnan > > > > Recursion is now possible starting with

[Spice-devel] [PATCH] LZ4: Do not include arpa/inet.h in Windows builds

2015-02-03 Thread Javier Celaya
--- common/canvas_base.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/canvas_base.c b/common/canvas_base.c index fb35c4a..1c96c9c 100644 --- a/common/canvas_base.c +++ b/common/canvas_base.c @@ -27,7 +27,9 @@ #include #ifdef USE_LZ4 +#ifndef WIN32 #include +#endif #include

Re: [Spice-devel] [PATCH 6/6] LZ4: Include winsock.h when compiling for Windows

2015-02-03 Thread Javier Celaya
El Martes, 3 de febrero de 2015 11:54:27 Christophe Fergeau escribió: > Hey, > > Are you sure this one is required? I did not get warnings when using > ntohl without including winsock.h first. > > Christophe Ok, maybe it is included by some other header... But in any case the include of arpa/in

Re: [Spice-devel] [PATCH 6/6] LZ4: Include winsock.h when compiling for Windows

2015-02-03 Thread Christophe Fergeau
Hey, Are you sure this one is required? I did not get warnings when using ntohl without including winsock.h first. Christophe On Wed, Jan 28, 2015 at 11:49:49AM +0100, Javier Celaya wrote: > --- > common/canvas_base.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/common/canvas_b

Re: [Spice-devel] [spice-common 1/3] Remove another redundant (SW_CANVAS_CACHE) || (SW_CANVAS_IMAGE_CACHE) #ifdef

2015-02-03 Thread Christophe Fergeau
Ping for patch series ? Christophe On Mon, Jan 26, 2015 at 01:18:24PM +0100, Christophe Fergeau wrote: > --- > common/canvas_base.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/common/canvas_base.c b/common/canvas_base.c > index 7ebea7b..417741e 100644 > --- a/common/canvas_base.c