Hi,
Spice-html5 does not support webdav. It is included in spice-gtk since v0.24.
Best regards,
Pavel Grunt
>
> I tried testing the file transfer method of installing this
> http://elmarco.fedorapeople.org/spice-webdavd-x86-0.1.24.msi
> in a windows 7 guest running on a debian host and it faile
On 01/16/2015 08:29 AM, Pavel Grunt wrote:
> ---
> filexfer.js | 29 +
> main.js | 4
> spice.html | 5 +
> spice_auto.html | 4
> 4 files changed, 42 insertions(+)
I tried testing the file transfer method of installing this
http://el
On Fri, Jan 30, 2015 at 8:52 PM, Christophe Fergeau wrote:
> « The basic rule to follow is
>
> The commit message must contain all the information required to fully
> understand & review the patch for correctness. Less is not more. More is
> more. »
I beg to disagree. More is often less, let's s
On Fri, Jan 30, 2015 at 05:18:54PM +0100, Marc-André Lureau wrote:
> This sums up to the same conclusion. I am sorry, I prefer shorter
> commit log
https://www.berrange.com/posts/2012/06/27/thoughts-on-improving-openstack-git-commit-practicehistory/
The text starting at "Information in commit mess
On Fri, Jan 30, 2015 at 5:10 PM, Christophe Fergeau wrote:
>> I am not familiar with this code, I didn't write most of it. But I can
>> read code and see when things are useless. If you pay a few minutes
>> reading,
>
> The point of having an explanation in the log is to save these few
> minutes o
On Fri, Jan 30, 2015 at 04:20:43PM +0100, Marc-André Lureau wrote:
>
> I am not familiar with this code, I didn't write most of it. But I can
> read code and see when things are useless. If you pay a few minutes
> reading,
The point of having an explanation in the log is to save these few
minutes
The image cache is clearly unused.
It was made unused by this patch:
---
commit 420876da9eafeece83e4719a469d2e1ce0b13478
Author: Søren Sandmann Pedersen
Date: Tue Aug 9 05:16:56 2011 -0400
Transmit images in smaller chunks
This makes use of the 'chunks' feature of the SPICE protocol
Hi
On Fri, Jan 30, 2015 at 4:17 PM, Jonathon Jongsma wrote:
> How about this: Can you explain why removing the code is a better idea
> than simply fixing it? Why is the cache unnecessary? When did it become
> unnecessary? You clearly know all of this information since you made the
> decision to
On Fri, 2015-01-30 at 14:07 +0100, Marc-André Lureau wrote:
> On Fri, Jan 30, 2015 at 1:57 PM, Christophe Fergeau
> wrote:
> > Yes, so we are back to my original question, which of its intended
> > purpose is it failing to achieve, and why ? I'm not saying it's not
> > useless or unused, I'm only
On Fri, Jan 30, 2015 at 1:57 PM, Christophe Fergeau wrote:
> Yes, so we are back to my original question, which of its intended
> purpose is it failing to achieve, and why ? I'm not saying it's not
> useless or unused, I'm only saying the commit log needs to be more
> descriptive.
Well, I suppos
On Fri, Jan 30, 2015 at 01:50:05PM +0100, Marc-André Lureau wrote:
> On Fri, Jan 30, 2015 at 12:43 PM, Christophe Fergeau
> wrote:
> > Hmm, do you mean "useless" or "unused"?
>
> It is used, same way I can't say it's not really dead code by definition.
>
> Google defines useless: not fulfilling
On Fri, Jan 30, 2015 at 12:43 PM, Christophe Fergeau
wrote:
> Hmm, do you mean "useless" or "unused"?
It is used, same way I can't say it's not really dead code by definition.
Google defines useless: not fulfilling or not expected to achieve the
intended purpose or desired outcome.
"a piece of u
On Fri, Jan 30, 2015 at 12:29:55PM +0100, Marc-André Lureau wrote:
> and it removes something that is just plain "without use" == "useless".
Hmm, do you mean "useless" or "unused"?
Christophe
pgp4HTH6plwoh.pgp
Description: PGP signature
___
Spice-deve
On Fri, Jan 30, 2015 at 12:09 PM, Christophe Fergeau
wrote:
> Not a very convincing argument ;) Can I say "nack, this commit is
> useless." and expect that the discussion would stop here without any
> more details ? :)
I would find it funny if it was true. But the fact is that this commit
is use
On Fri, Jan 30, 2015 at 11:58:56AM +0100, Marc-André Lureau wrote:
> On Fri, Jan 30, 2015 at 11:39 AM, Christophe Fergeau
> wrote:
> > Useless because ... ? (if you want to mention this in the commit log,
> > you need to give more details...)
>
>
> Nothing else to say, it is just plain useless.
On Fri, Jan 30, 2015 at 11:39 AM, Christophe Fergeau
wrote:
> Useless because ... ? (if you want to mention this in the commit log,
> you need to give more details...)
Nothing else to say, it is just plain useless.
--
Marc-André Lureau
___
Spice-deve
On Thu, Jan 29, 2015 at 02:14:01PM +0100, Marc-André Lureau wrote:
> While looking for leaks, I realized that the image cache looks
> quite suspicious.
>
> Not only it leaks when qxl_drop_image_cache() is called,
> since all the allocated image_info_t references are lost.
> But it is also useless.
Hey,
Thanks for the respinned series and the improved logs! ACK series except
the row alignment one.
Christophe
On Wed, Jan 28, 2015 at 11:49:43AM +0100, Javier Celaya wrote:
> Mostly the same as v2, but I stick to using ntohl, and improved log comments.
> Also, the row alignment is done with me
On Wed, Jan 28, 2015 at 11:49:47AM +0100, Javier Celaya wrote:
> Fix the row alignment for 16/24 bpp images when it is not in a 32bit
> boundary. This is needed for 16bpp images when the width is an odd
> number, and for the future support of 24bpp images.
> ---
> @@ -620,6 +623,21 @@ static pixman
Hey,
On Wed, Jan 28, 2015 at 11:49:49AM +0100, Javier Celaya wrote:
> ---
> common/canvas_base.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/common/canvas_base.c b/common/canvas_base.c
> index fb35c4a..5867f3e 100644
> --- a/common/canvas_base.c
> +++ b/common/canvas_base.c
> @@
20 matches
Mail list logo
