[Spice-devel] [PATCH v3] Provide support for using the passthru smartcard mode in libcacard.

Add an optional args parameter to the --spice-smartcard which will be passed to vcard_emul_options. This allows us to deprecate the --smartcard-db and --smartcard-certificates options as well. Signed-off-by: Jeremy White --- gtk/smartcard-manager.c | 14 ++ gtk/spice-option.c

Re: [Spice-devel] [PATCH v2] Provide support for using the passthru smartcard mode in libcacard.

*blush*. This is badly broken.. Teach me to test man pages / help stuff, without revisiting basic functionality. v3 to follow, sorry for the noise. Cheers, Jeremy On 01/21/2015 03:05 PM, Jeremy White wrote: > Add an optional args parameter to the --spice-smartcard which > will be passed to vc

Re: [Spice-devel] [spice-common 2/2] Remove unused 'invers' arg from canvas_get_*

ack - Original Message - > All canvas_get_{quic,jpeg,lz4,jpeg_alpha,lz} methods have an 'invers' > argument, but are always called with that argument being 0, so we can > drop it from the argument list, and remove the code triggerring when > it's true. > --- > common/canvas_base.c | 78 >

Re: [Spice-devel] [spice-common 1/2] Remove redundant #if defined(SW_CANVAS_CACHE) || defined(SW_CANVAS_IMAGE_CACHE)

ack - Original Message - > SW_CANVAS_CACHE is always defined when building spice-gtk, > SW_CANVAS_IMAGE_CACHE is always defined when building spice-server, and > they are the only 2 users of spice-common. Moreover, build when none of > these is defined is broken. > --- > common/canvas_bas

[Spice-devel] [spice-common 2/2] Remove unused 'invers' arg from canvas_get_*

All canvas_get_{quic,jpeg,lz4,jpeg_alpha,lz} methods have an 'invers' argument, but are always called with that argument being 0, so we can drop it from the argument list, and remove the code triggerring when it's true. --- common/canvas_base.c | 78

[Spice-devel] [spice-common 1/2] Remove redundant #if defined(SW_CANVAS_CACHE) || defined(SW_CANVAS_IMAGE_CACHE)

SW_CANVAS_CACHE is always defined when building spice-gtk, SW_CANVAS_IMAGE_CACHE is always defined when building spice-server, and they are the only 2 users of spice-common. Moreover, build when none of these is defined is broken. --- common/canvas_base.c | 38 +

[Spice-devel] [PATCH 3/6] LZ4: Correctly read the top_down flag

--- common/canvas_base.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index 0f6b7f4..ec83123 100644 --- a/common/canvas_base.c +++ b/common/canvas_base.c @@ -566,7 +566,7 @@ static pixman_image_t *canvas_get_lz4(CanvasBase

[Spice-devel] [PATCH 5/6] LZ4: Fix the row alignment when it is not on a 32bit boundary

--- common/canvas_base.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index c45d535..170def1 100644 --- a/common/canvas_base.c +++ b/common/canvas_base.c @@ -563,8 +563,7 @@ static pixman_image_t *canvas_

[Spice-devel] [PATCH 6/6] LZ4: Add support for 24bit pixman surfaces

--- common/canvas_base.c | 4 common/canvas_utils.c | 10 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index 170def1..107d056 100644 --- a/common/canvas_base.c +++ b/common/canvas_base.c @@ -584,6 +584,10 @@ static pix

[Spice-devel] [PATCH 4/6] LZ4: Decode the image format from the stream

--- common/canvas_base.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index ec83123..c45d535 100644 --- a/common/canvas_base.c +++ b/common/canvas_base.c @@ -568,6 +568,8 @@ static pixman_image_t *canvas_get_lz

[Spice-devel] [PATCH 4/5] LZ4: Implement htonl to remove dependency on arpa/inte.h

--- server/lz4_encoder.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c index 2327e9a..4f0f3c8 100644 --- a/server/lz4_encoder.c +++ b/server/lz4_encoder.c @@ -22,7 +22,6 @@ #define SPICE_LOG_DOMAIN "SpiceLz4Encoder

[Spice-devel] [PATCH 5/5] LZ4: Send the original format with the compressed data

--- server/lz4_encoder.c | 9 + server/lz4_encoder.h | 2 +- server/red_worker.c | 2 +- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c index 4f0f3c8..f1db69f 100644 --- a/server/lz4_encoder.c +++ b/server/lz4_encoder.c @@ -59,7

[Spice-devel] [PATCH 1/5] LZ4: Limit LZ4 to RGB formats

--- server/red_worker.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/server/red_worker.c b/server/red_worker.c index a18987a..8f07ee9 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -6678,6 +6678,7 @@ static inline int red_compress_image(DisplayChannelClient *dcc,

[Spice-devel] [PATCH 2/5] LZ4: Fix encoder output size

--- server/lz4_encoder.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c index 531ab4b..aa03721 100644 --- a/server/lz4_encoder.c +++ b/server/lz4_encoder.c @@ -56,7 +56,7 @@ int lz4_encode(Lz4EncoderContext *lz4, int height, int st

[Spice-devel] [PATCH 2/6] LZ4: Implement ntohl to remove dependency on arpa/inet.h

--- common/canvas_base.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index cfbba5e..0f6b7f4 100644 --- a/common/canvas_base.c +++ b/common/canvas_base.c @@ -27,7 +27,6 @@ #include #ifdef USE_LZ4 -#include #

[Spice-devel] [spice-server PATCHv2 0/5] LZ4: Fix supported image formats

This v2 patch set is splitted into smaller patches. Also, I implemented htonl to remove the include of arpa/inet.h. Javier Celaya (5): LZ4: Limit LZ4 to RGB formats LZ4: Fix encoder output size LZ4: Do not reverse bottom-up images LZ4: Implement htonl to remove dependency on arpa/inte.h

[Spice-devel] [PATCH 1/6] LZ4: Fix output buffer size

--- common/canvas_base.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index a1bfc27..cfbba5e 100644 --- a/common/canvas_base.c +++ b/common/canvas_base.c @@ -551,7 +551,7 @@ static pixman_image_t *canvas_get_jpeg(CanvasBase *

[Spice-devel] [PATCH 3/5] LZ4: Do not reverse bottom-up images

--- server/lz4_encoder.c | 13 ++--- server/lz4_encoder.h | 7 +++ server/red_worker.c | 18 +- 3 files changed, 14 insertions(+), 24 deletions(-) diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c index aa03721..2327e9a 100644 --- a/server/lz4_encoder.c +++ b/

[Spice-devel] [spice-common PATCHv2 0/6] LZ4: Fix bugs in LZ4 decompression algorithm

This v2 of the patch set is splitted into smaller patches. I have also added two improvements: - A simple implementation of ntohl, to avoid including arpa/inet.h, which would probably break under MSVC. - Fix the row alignment for 16bit and 24bit images, instead of transforming them into 32bit.

Re: [Spice-devel] spice proxy support in govirt

On Thu, Jan 15, 2015 at 02:04:37PM +0100, Christophe Fergeau wrote: > I quickly cooked/compile-tested the attached patch, if you have time to > test it, let me know how it works, otherwise I'll get back to that later > (need to get lot of email under control first ;) > > Christophe > diff --git a

Re: [Spice-devel] [linux vdagent PATCH V2] man: vdagentd: document -f (fake) and -o (once) command line options

On 01/22/2015 12:57 PM, Christophe Fergeau wrote: On Thu, Jan 22, 2015 at 12:28:44PM +0200, Uri Lublin wrote: Added by commits: 251637aa23 and 1c25f882a --- data/spice-vdagentd.1.in |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/data/spice-vdagentd.1.in b/data/

Re: [Spice-devel] [linux vdagent PATCH V2] man: vdagentd: document -f (fake) and -o (once) command line options

On Thu, Jan 22, 2015 at 12:28:44PM +0200, Uri Lublin wrote: > Added by commits: 251637aa23 and 1c25f882a > --- > data/spice-vdagentd.1.in |7 +++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/data/spice-vdagentd.1.in b/data/spice-vdagentd.1.in > index 0647585..e63555

[Spice-devel] [linux vdagent PATCH V2] man: vdagentd: document -f (fake) and -o (once) command line options

Added by commits: 251637aa23 and 1c25f882a --- data/spice-vdagentd.1.in |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/data/spice-vdagentd.1.in b/data/spice-vdagentd.1.in index 0647585..e63555f 100644 --- a/data/spice-vdagentd.1.in +++ b/data/spice-vdagentd.1.in @@

Re: [Spice-devel] [linux vdagent PATCH] man: vdagentd: document -f (fake) and -o (once) command line options

On 01/20/2015 04:55 PM, Christophe Fergeau wrote: On Sun, Dec 28, 2014 at 05:31:47PM +0200, Uri Lublin wrote: Added by commits: 251637aa23 and 1c25f882a --- data/spice-vdagentd.1.in |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/data/spice-vdagentd.1.in b/data/s

Re: [Spice-devel] [PATCH 2/2] Fix LZ4 supported image formats.

Hello, El Miércoles, 21 de enero de 2015 17:27:01 Christophe Fergeau escribió: > Hey, > > On Thu, Jan 15, 2015 at 12:50:45PM +0100, Javier Celaya wrote: > > - Read the original image format from the LZ4 stream. Only RGB formats > > > > are supported. > > > > - Expand 24bit to 32bit image form

Re: [Spice-devel] [PATCH] Fix LZ4 supported image formats.

Hello El Miércoles, 21 de enero de 2015 17:05:00 Christophe Fergeau escribió: > Hey, > > Sorry for the late review... > > On Thu, Jan 15, 2015 at 12:50:21PM +0100, Javier Celaya wrote: > > This patch limits the LZ4 algorithm to RGB formats. Other formats are > > compressed with LZ. It also sends