Re: [Spice-devel] [PATCH spice-html5] Use WheelEvent instead of MouseWheelEvent

2015-01-15 Thread Jeremy White
ACK, pushed Cheers, Jeremy On 01/14/2015 11:42 AM, Pavel Grunt wrote: > MouseWheelEvent is deprecated and not working in Firefox. > --- > display.js | 4 ++-- > inputs.js | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/display.js b/display.js > index 2aa5985..814ad

Re: [Spice-devel] [PATCH spice-html5] Inform agent about client's capabilities

2015-01-15 Thread Jeremy White
>> Shouldn't we go ahead and store the inbound caps? >> > > Well, we have no use for them. I can add the line, if you prefer. Nah, you're right. ACKed and pushed. Cheers, Jeremy ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://li

Re: [Spice-devel] Patch to support LZ4 compression algorithm‏‏

2015-01-15 Thread Fabio Fantoni
Il 15/01/2015 16:22, Javier Celaya ha scritto: > El Miércoles, 14 de enero de 2015 12:30:50 Fabio Fantoni escribió: >> Should be good resend them directly to mailing list instead as attachments >> for review and add them upstream. > It looks like the list is rejecting what I send with git send-emai

Re: [Spice-devel] [PATCH spice 3/4] Remove spice-experimental

2015-01-15 Thread Marc-André Lureau
Hi On Mon, Oct 27, 2014 at 10:42 AM, Christophe Fergeau wrote: > I'm fine with it. If we want to be extra careful, we could start by not > installing the header with these function, but still export them, and > remove them in a subsequent release, this way we first break API, and if > we don't ge

Re: [Spice-devel] [PATCHv2 0/3] Add UNIX socket support

2015-01-15 Thread Uri Lublin
On 01/12/2015 06:35 PM, Marc-André Lureau wrote: Learn to listen on a Unix address. In this case, the connection is plain only (non-tls). This v2 series addresses the getsockopt warning seen during runtime by removing some useless network benchmark in this case. Marc-André Lureau (3): reds:

Re: [Spice-devel] [PATCHv2 1/3] reds: add Unix socket support

2015-01-15 Thread Uri Lublin
On 01/13/2015 04:12 PM, Marc-André Lureau wrote: Hi On Mon, Jan 12, 2015 at 5:35 PM, Marc-André Lureau wrote: +} else if (flags == SPICE_ADDR_FLAG_IPV6_ONLY) { spice_family = PF_INET6; +} else if (flags == SPICE_ADDR_FLAG_UNIX_ONLY) { +spice_family = AF_UNIX; +} e

Re: [Spice-devel] [PATCHv2 2/3] reds-stream: add reds_stream_get_family() function

2015-01-15 Thread Marc-André Lureau
Hi - Original Message - > On 01/12/2015 06:35 PM, Marc-André Lureau wrote: > > --- > > server/reds_stream.c | 10 ++ > > server/reds_stream.h | 1 + > > 2 files changed, 11 insertions(+) > > > > diff --git a/server/reds_stream.c b/server/reds_stream.c > > index 4b61e31..e0b6f4

Re: [Spice-devel] [PATCHv2 2/3] reds-stream: add reds_stream_get_family() function

2015-01-15 Thread Uri Lublin
On 01/12/2015 06:35 PM, Marc-André Lureau wrote: --- server/reds_stream.c | 10 ++ server/reds_stream.h | 1 + 2 files changed, 11 insertions(+) diff --git a/server/reds_stream.c b/server/reds_stream.c index 4b61e31..e0b6f43 100644 --- a/server/reds_stream.c +++ b/server/reds_stream

Re: [Spice-devel] [PATCH spice-html5] Inform agent about client's capabilities

2015-01-15 Thread Pavel Grunt
Hi Jeremy, > > Hi Pavel, > > Mostly looks good; one question: > > > Shouldn't we go ahead and store the inbound caps? > Well, we have no use for them. I can add the line, if you prefer. Best regards, Pavel ___ Spice-devel mailing list Spice-devel

Re: [Spice-devel] lack of OSX PulseAudio?

2015-01-15 Thread Christophe Fergeau
On Mon, Dec 29, 2014 at 09:12:26AM +0800, 密 wrote: > lack of OSX PulseAudio,How to solve。How to configure configure --with-audio=gstreamer should help. Christophe pgpj2yIUp6Qy6.pgp Description: PGP signature ___ Spice-devel mailing list Spice-devel@li

Re: [Spice-devel] [PATCH] common: fix build with mingw

2015-01-15 Thread Christophe Fergeau
On Tue, Jan 06, 2015 at 06:05:46PM +0100, Victor Toso wrote: > Building spice-common is breaking with mingw: http://fpaste.org/166365/ Nit: you could have pasted at least part of the compilation failures in the commit log (think offline git log). Christophe pgptNdK0ruSZv.pgp Description: PGP si

Re: [Spice-devel] [PATCH spice-html5] Inform agent about client's capabilities

2015-01-15 Thread Jeremy White
Hi Pavel, Mostly looks good; one question: On 01/15/2015 06:33 AM, Pavel Grunt wrote: > The client should inform the agent about capabilities > when the connection is established. This avoid receiving unhandled > agent messages. > +if (agent_data.type == VD_AGENT_ANNOUNCE_CAPABILITIES) >

Re: [Spice-devel] [PATCH spice-html5 v3 0/7] Enable file transfer from client to guest

2015-01-15 Thread Jeremy White
>> * 2K limit > > I believe the problem is somewhere else as it is working with spice-gtk. > The limit is checked in spice-server: > http://cgit.freedesktop.org/spice/spice/tree/server/agent-msg-filter.c#n43 Hmm. You are right; the performance hit is barely noticeable in spice-gtk; files tra

Re: [Spice-devel] Patch to support LZ4 compression algorithm‏‏

2015-01-15 Thread Javier Celaya
El Miércoles, 14 de enero de 2015 12:30:50 Fabio Fantoni escribió: > Should be good resend them directly to mailing list instead as attachments > for review and add them upstream. It looks like the list is rejecting what I send with git send-email... I'll keep trying.

Re: [Spice-devel] spice proxy support in govirt

2015-01-15 Thread i iordanov
Hi Christophe, I am quite busy during the week, but I'll try to find time during the weekend. Thanks! iordan On Thu, Jan 15, 2015 at 8:04 AM, Christophe Fergeau wrote: > Hey, > > On Sun, Dec 28, 2014 at 02:34:10AM -0600, i iordanov wrote: >> Hello, >> >> My apologies for the partial mail sent o

Re: [Spice-devel] spice proxy support in govirt

2015-01-15 Thread Christophe Fergeau
Hey, On Sun, Dec 28, 2014 at 02:34:10AM -0600, i iordanov wrote: > Hello, > > My apologies for the partial mail sent out, I hit a strange key > combination by mistake :). As I was saying, this bug got closed not > long ago: Sorry for the late reply, was on holidays for a while, came back just no

[Spice-devel] [PATCH spice-html5] Inform agent about client's capabilities

2015-01-15 Thread Pavel Grunt
The client should inform the agent about capabilities when the connection is established. This avoid receiving unhandled agent messages. --- depends on: http://lists.freedesktop.org/archives/spice-devel/2015-January/018590.html Unhandled agent messages are related to the clipboard sharing capabil

[Spice-devel] [PATCH 1/2] Fix LZ4 output buffer size.

2015-01-15 Thread Javier Celaya
--- common/canvas_base.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index ddcbe32..bb7a424 100644 --- a/common/canvas_base.c +++ b/common/canvas_base.c @@ -550,7 +550,7 @@ static pixman_image_t *canvas_get_jpeg(CanvasBase *

[Spice-devel] [PATCH 0/2] Fix two bugs in LZ4 decompression algorithm

2015-01-15 Thread Javier Celaya
These two patches fix two problems that crashed the Spice client when using the LZ4 algorithm. Note that the second patch also expects the server to send the original image format, so it must be used with the corresponding patch in the server. Javier Celaya (2): Fix LZ4 output buffer size. Fix

[Spice-devel] [PATCH 2/2] Fix LZ4 supported image formats.

2015-01-15 Thread Javier Celaya
- Read the original image format from the LZ4 stream. Only RGB formats are supported. - Expand 24bit to 32bit image format. --- common/canvas_base.c | 48 +++- 1 file changed, 43 insertions(+), 5 deletions(-) diff --git a/common/canvas_base.c b/common

[Spice-devel] [PATCH] Fix LZ4 supported image formats.

2015-01-15 Thread Javier Celaya
This patch limits the LZ4 algorithm to RGB formats. Other formats are compressed with LZ. It also sends the top_down flag and the original format to the client, so that it can create the right kind of pixman surface. --- server/lz4_encoder.c | 21 +++-- server/lz4_encoder.h | 7 ++

Re: [Spice-devel] How to build the laest mingw-spice-gtk on Fedora?

2015-01-15 Thread Marc-André Lureau
Hi - Original Message - > Or you can get all the dependencies and build directly from spice-gtk branch: > $ NOCONFIGURE=1 ./autogen.sh && configure && make Replace "configure" with mingw32-configure or mingw64-configure depending on the build target x86 or x64. _

Re: [Spice-devel] How to build the laest mingw-spice-gtk on Fedora?

2015-01-15 Thread Marc-André Lureau
Hi - Original Message - > Hi, Dear Elmarco > > I facing a lots of problem to build the mingw-spice-gtk on fedora. > Would you please share me the steps how to build the mingw-spice-gtk on > Fedora? > Better with docs. Like any Fedora package, you can do with fedpkg: # clone anonymously

Re: [Spice-devel] [PATCH spice-html5 v3 0/7] Enable file transfer from client to guest

2015-01-15 Thread Pavel Grunt
Hi Jeremy, > > Hi Pavel, > > This looks (mostly) good to me. I'm really troubled by the 2K limit, > and the 5 token window size; that makes transfers painfully slow. > That > is arguably outside the scope of this patch set, though. > In spice-gtk we are also sending 2K agent data messages and

[Spice-devel] [PATCH spice-html5 v2 1/7] Handle agent tokens

2015-01-15 Thread Pavel Grunt
--- v2: - number of agent tokens is set before sending monitor config --- main.js | 19 +-- spicemsg.js | 15 +++ 2 files changed, 32 insertions(+), 2 deletions(-) diff --git a/main.js b/main.js index e487551..c71de7a 100644 --- a/main.js +++ b/main.js @@ -66,6 +6