Hi,
On 12/16/2014 04:55 PM, Christophe Fergeau wrote:
Hey,
Thanks to the detailed description. Adding Hans to cc: since he knows
USB redirection the best.
This is only a problem with libusb on windows, there is a patch-set at the
upstream libusb mailinglist to stop libusb from taking the even
On Tue, Dec 16, 2014 at 6:36 PM, Pavel Grunt wrote:
> ACK this and the series
Thanks a lot Pavel for finding the regression and your help!
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.or
>
> This patch depends on "Fix authentication error handling regression"
> series.
>
ACK this and the series
Pavel
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
Hi,
>
> It is common that clients attempt to reconnect during the
> SPICE_CHANNEL_ERROR_AUTH callback. However, the channel must exit
> the coroutine first before reconnection can happen.
> ---
> gtk/spice-channel.c | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git
This patch depends on "Fix authentication error handling regression" series.
On Tue, Dec 16, 2014 at 6:33 PM, Marc-André Lureau
wrote:
> When entered authentication details are wrong, spice-gtk will reset
> channel error, which will result in the following warning:
>
> (remote-viewer:20753): GLib
When entered authentication details are wrong, spice-gtk will reset
channel error, which will result in the following warning:
(remote-viewer:20753): GLib-WARNING **: GError set over the top of a
previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an er
It is common that clients attempt to reconnect during the
SPICE_CHANNEL_ERROR_AUTH callback. However, the channel must exit
the coroutine first before reconnection can happen.
---
gtk/spice-channel.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/gtk/spice-channel.c b/
Add a new state that permits reconnection, because it's < CONNECTING.
It also simplifies some code by removing unneeded variables in
spice_channel_coroutine(): the channel.tls and session.protocol version
properties are already modified during initial connection steps.
---
gtk/spice-channel-priv.h
Hi,
With the recent changes in channel life-cycle, I introduced
regressions with authentication: when authentication fails, a client
may attempt to reconnect, but all channels are removed from the
session and clients may decide to quit.
This series is an attempt to fix this to keep compatibility
For legacy reasons, spice-gtk should keep at least one channel in the
session when reconnecting (clients may decide that the session is
disconnected when all channels are gone). The most obvious is to
keep and reuse the main channel.
---
gtk/spice-session.c | 30 +-
1 f
There are a few things that should be common to all wrong authentication
cases. Let's put them all in the same function.
---
gtk/spice-channel-priv.h | 1 +
gtk/spice-channel.c | 62 ++--
2 files changed, 34 insertions(+), 29 deletions(-)
diff --g
There is no need to enter channel_iterate() if we found an early
connection steps error.
---
gtk/spice-channel.c | 32 +---
1 file changed, 17 insertions(+), 15 deletions(-)
diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c
index d0e6df8..524a13e 100644
--- a/gtk/
Hey,
Thanks to the detailed description. Adding Hans to cc: since he knows
USB redirection the best.
Christophe
On Tue, Dec 16, 2014 at 10:36:12AM +0800, hust...@sina.com wrote:
> I met a dead lock in usbredir. When a device with interrupt endpoint
> was plugged in, the func usbredirhost_start_
Hey,
After this patch the authentication dialog for sasl connection does not show up
at all.
Also it is not failing when trying to connect to vnc guest.
Pavel
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/
The commit summary could probably be improved: "channel: throw auth error when
coroutine ends" perhaps ?
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
There are a few things that should be common to all wrong authentication
cases. Let's put them all in the same function.
---
gtk/spice-channel-priv.h | 1 +
gtk/spice-channel.c | 62 ++--
2 files changed, 34 insertions(+), 29 deletions(-)
diff --g
For legacy reasons, spice-gtk should keep at least one channel in the
session when reconnecting (clients may decide that the session is
disconnected when all channels are gone). The most obvious is to
keep and reuse the main channel.
---
gtk/spice-session.c | 30 +-
1 f
Hi,
With the recent changes in channel life-cycle, I introduced
regressions with authentication: when authentication fails, a client
may attempt to reconnect, but all channels are removed from the
session and clients may decide to quit.
This series is an attempt to fix this to keep compatibility
It is common that clients attempt to reconnect during the
SPICE_CHANNEL_ERROR_AUTH callback. However, the channel must exit
the coroutine first before reconnection can happen.
---
gtk/spice-channel.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/gtk/spice-channel.c b
Hi guys. I need you help, i have installed on my remote server Xorg with
support spice protocol and i need to add support for spice multiple
monitors, how i can do it and change my xorg.conf file for this
I configured my xorg.conf like this:
/Section "ServerLayout"
Identifier "Layo
Hi!
I tried searching the bug tracker and devel list for my issue but could not
find a similar case. I must admit searching for "mouse" only gave a bit to much
results to look at...
I'm using virt-viewer 1.0256 on Windows to connect to a Debian 7.7 Server
running qemu-kvm-1.1.2+dfsg-6+deb7u6
On 12/15/2014 09:04 PM, Jeremy White wrote:
Maybe retry immediately for EINTR:
do {
rc = read()
} while (! ((rc == -1) && (errno == EINTR)))
and remove "|| errno == EINTR" below.
Can you explain why? I imagine that the EINTR case should be quite
rare, and that in those cases, it would
22 matches
Mail list logo
