[Spice-devel] [spice-common v2 01/11] build-sys: Remove unused X check

2014-12-09 Thread Christophe Fergeau
AC_PATH_X sets a bunch of variables (x_includes, x_libraries, no_x) after finding/not finding X. Since none of them are used afterwards, having this check is not useful. --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index 273d935..e67e60b 100644 --

[Spice-devel] spice-xpi client fails to run

2014-12-09 Thread Alex
Hi, I have a RHEV 3.3 environment but I run 3.17.4-1-ARCH on my work station and would like to access the RHEV spice server on the VM's, I have also tried with openSuSE but I never get the expected "Spice window frame" that I would get if I used a RHEL system with the spice-xpi. The spice f

Re: [Spice-devel] [spice-common v2 07/11] build-sys: Move smartcard check to m4 macro

2014-12-09 Thread Jonathon Jongsma
On Tue, 2014-12-09 at 15:39 +0100, Christophe Fergeau wrote: > --- > common/Makefile.am | 3 ++- > configure.ac | 19 +++ > m4/spice-deps.m4 | 29 + > 3 files changed, 34 insertions(+), 17 deletions(-) > > diff --git a/common/Makefile.am b/comm

[Spice-devel] [spice-common v2 00/11] Misc configure.ac improvements

2014-12-09 Thread Christophe Fergeau
Hey, Here is a v2 of my series reworking a bit spice-common configure.ac and Makefile.am Christophe Changes since v1: - reordered the patches - moved all macros in a spice-deps.m4 file instead of 1 file per macro - added documentation header to each m4 macro ___

[Spice-devel] [spice-common v2 03/11] build-sys: Remove unused WITH_SMARTCARD conditional

2014-12-09 Thread Christophe Fergeau
--- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index e5468b2..8613833 100644 --- a/configure.ac +++ b/configure.ac @@ -49,7 +49,6 @@ if test "x$enable_smartcard" != "xno"; then AC_DEFINE(USE_SMARTCARD, [1], [Define if supporting smartcard proxy

[Spice-devel] [spice-common v2 08/11] build-sys: Move celt check to m4 macro

2014-12-09 Thread Christophe Fergeau
--- common/Makefile.am | 4 +--- configure.ac | 17 + m4/spice-deps.m4 | 26 ++ 3 files changed, 28 insertions(+), 19 deletions(-) diff --git a/common/Makefile.am b/common/Makefile.am index cbb8f8b..362fce6 100644 --- a/common/Makefile.am +++ b/com

[Spice-devel] [spice-common v2 05/11] build-sys: Add fallback for AS_VAR_APPEND

2014-12-09 Thread Christophe Fergeau
This macro is not available with RHEL6 autoconf. --- configure.ac | 4 1 file changed, 4 insertions(+) diff --git a/configure.ac b/configure.ac index 8613833..a58fcd6 100644 --- a/configure.ac +++ b/configure.ac @@ -12,6 +12,10 @@ AC_CONFIG_AUX_DIR([build-aux]) # For automake >= 1.12 m4_if

[Spice-devel] [spice-common v2 02/11] build-sys: Remove unused win32 check

2014-12-09 Thread Christophe Fergeau
--- configure.ac | 15 --- 1 file changed, 15 deletions(-) diff --git a/configure.ac b/configure.ac index e67e60b..e5468b2 100644 --- a/configure.ac +++ b/configure.ac @@ -114,21 +114,6 @@ AC_FUNC_ERROR_AT_LINE AC_FUNC_FORK AC_CHECK_FUNCS([dup2 floor inet_ntoa memmove memset pow sqr

[Spice-devel] [spice-common v2 07/11] build-sys: Move smartcard check to m4 macro

2014-12-09 Thread Christophe Fergeau
--- common/Makefile.am | 3 ++- configure.ac | 19 +++ m4/spice-deps.m4 | 29 + 3 files changed, 34 insertions(+), 17 deletions(-) diff --git a/common/Makefile.am b/common/Makefile.am index 2c82adc..cbb8f8b 100644 --- a/common/Makefile.am +++ b

[Spice-devel] [spice-common v2 06/11] build-sys: Move posix checks to a separate m4 macro

2014-12-09 Thread Christophe Fergeau
--- configure.ac | 25 ++--- m4/spice-deps.m4 | 27 +++ 2 files changed, 29 insertions(+), 23 deletions(-) create mode 100644 m4/spice-deps.m4 diff --git a/configure.ac b/configure.ac index a58fcd6..67e485e 100644 --- a/configure.ac +++ b/configure

[Spice-devel] [spice-common v2 10/11] build-sys: Move opengl check to m4 macro

2014-12-09 Thread Christophe Fergeau
--- common/Makefile.am | 1 - configure.ac | 21 + m4/spice-deps.m4 | 31 +++ 3 files changed, 32 insertions(+), 21 deletions(-) diff --git a/common/Makefile.am b/common/Makefile.am index c5e2e2a..5a689fe 100644 --- a/common/Makefile.am +++

[Spice-devel] [spice-common v2 09/11] build-sys: Move opus check to m4 macro

2014-12-09 Thread Christophe Fergeau
--- common/Makefile.am | 3 +-- configure.ac | 5 + m4/spice-deps.m4 | 18 ++ 3 files changed, 20 insertions(+), 6 deletions(-) diff --git a/common/Makefile.am b/common/Makefile.am index 362fce6..c5e2e2a 100644 --- a/common/Makefile.am +++ b/common/Makefile.am @@ -94

[Spice-devel] [spice-common v2 11/11] build-sys: Move pixman check to m4 macro

2014-12-09 Thread Christophe Fergeau
--- common/Makefile.am | 1 - configure.ac | 4 +--- m4/spice-deps.m4 | 12 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/common/Makefile.am b/common/Makefile.am index 5a689fe..b4384e8 100644 --- a/common/Makefile.am +++ b/common/Makefile.am @@ -92,7 +92,6

[Spice-devel] [spice-common v2 04/11] build-sys: small cleanup of AM_CPPFLAGS

2014-12-09 Thread Christophe Fergeau
Commit 4fafa210 added WARN_CFLAGS, VISIBILITY_HIDDEN_CFLAGS and -std=gnu99 to AM_CFLAGS in common/Makefile.am, but these are not needed. WARN_CFLAGS and VISIBILITY_HIDDEN_CFLAGS are not defined anywhere in spice-common, and spice-common compiles fine without -std=gnu99 on my f21 box. --- common/Ma

Re: [Spice-devel] spice-xpi client fails to run

2014-12-09 Thread Christophe Fergeau
Hey, On Mon, Dec 08, 2014 at 02:31:51PM -0800, Alex wrote: > Hi, I have a RHEV 3.3 environment but I run 3.17.4-1-ARCH on my work station > and would like to access the RHEV spice server on the VM's, I have also > tried with openSuSE but I never get the expected "Spice window frame" that I > w