Yes, I was hoping to see a difference because of the version bumps between
Fedora/Ubuntu package sources, but no such luck.
I don't think it's a packaging issue specifically since I didn't package
the build, just did a straight 'make install' instead (using /usr as the
path rather than /usr/local)
Yes, I had seen those options. That was part of why I was asking about the
ucds socket. I found now that the ucds socket is used to talk to multiple
agents. I have tried both setting each argument to specify the paths of
each piece (ucds socket, uinput, and virtio port) and letting Xspice set
them
ping
On Tue, Nov 25, 2014 at 3:38 PM, Marc-André Lureau
wrote:
> The union is already declared in .
> ---
> server/spice.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/server/spice.h b/server/spice.h
> index bd5bba8..84f9696 100644
> --- a/server/spice.h
> +++ b/server/spice.h
> @@ -1
This is a workaround for existing clients such as virt-viewer that do
not hold a reference to their sessions when calling
spice_session_disconnect() and crash now that channels are removed from
session during the call. They expect disconnection events to be deferred
instead, let's defer actual disc
This used to help prevent double-unref when channel were considered part
of the session as long as they lived. Now it shouldn't be required
anymore
---
gtk/spice-session.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/gtk/spice-session.c b/gtk/spice-session.c
index a7f
Avoid the following critical when a channel is disconnected with a
pending stream (the streams are cleared on channel reset, after
coroutine exit)
(process:17188): GSpice-CRITICAL **: spice_session_get_mm_time: assertion
'session != NULL' failed
#0 0x771c24e5 in spice_session_get_mm
It is idiomatic for client code to clean up its reference on channel
disconnection. Keeping a reference during disconnect helps solving
potential crashes if the session is unref'ed during callbacks.
---
gtk/spice-session.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gtk/spice-session.c b
Use session accessors to initialize the device manager.
Add missing session parameter check (public API).
---
gtk/spice-session.c | 34 ++
gtk/usb-device-manager.c | 33 -
2 files changed, 34 insertions(+), 33 deletions(-)
diff
---
gtk/usb-device-manager.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/gtk/usb-device-manager.c b/gtk/usb-device-manager.c
index a7b1140..7b27516 100644
--- a/gtk/usb-device-manager.c
+++ b/gtk/usb-device-manager.c
@@ -758,14 +758,15 @@ static void
This function is somewhat useless, and dangerous since it is calling
g_object_unref() behind your back (although this is mentioned in the
doc, I consider this a bad practice).
---
gtk/spice-channel.c | 6 +-
gtk/spice-channel.h | 3 ++-
gtk/spice-session.c | 8
3 files changed, 11 ins
A channel is considered to be part of a session as long as it is
alive. However, this model is problematic, since library user may hold
channel references, and thus the channel will remain in the
session. Calling spice_session_disconnect() several time will end up
calling spice_channel_destroy(), r
It was assumed the session would remain alive as long as channel
existed, so USB context would be valid too. Now that channels
are removed from session, USB context may be destroyed before
channels. This produces invalid read/write on USB context.
Make sure the context is alive as long as USB chann
Make sure none of the SpiceSessionPrivate fields are accessed directly anymore
---
gtk/spice-session-priv.h | 82 --
gtk/spice-session.c | 84
2 files changed, 84 insertions(+), 82 deletions(-)
diff
Use GObject object association for session helpers.
GtkSession and DesktopIntegration are in the gtk library SpiceSession is
in glib one. So far we had the SessionPriv structure shared between the
two libraries, so they could fit their pointers there. But this is no
longer possible when moving the
---
gtk/channel-main.c | 2 +-
gtk/spice-session-priv.h | 6 +++---
gtk/spice-session.c | 8
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/gtk/channel-main.c b/gtk/channel-main.c
index b62da60..7af4a2e 100644
--- a/gtk/channel-main.c
+++ b/gtk/channel-main.c
@@
Use session accessors to initialize the webdav server
---
gtk/channel-webdav.c | 24 +---
gtk/spice-session-priv.h | 2 ++
gtk/spice-session.c | 23 +++
3 files changed, 30 insertions(+), 19 deletions(-)
diff --git a/gtk/channel-webdav.c b/gtk/cha
Hi,
This is the updated series on channel lifecycle changes, removing
channels from session on disconnection. The previous series revealed
some issues related to direct access to session fields. This new series
adds a lot more checks so that no session private fields can be
accessed directly anymo
---
gtk/spice-audio.c | 31 ---
gtk/spice-session.c | 34 ++
2 files changed, 34 insertions(+), 31 deletions(-)
diff --git a/gtk/spice-audio.c b/gtk/spice-audio.c
index ce303f1..7754736 100644
--- a/gtk/spice-audio.c
+++ b/gtk/spice-au
Avoid dereferencing session private data directly, and use accessors
instead.
---
gtk/channel-main.c | 11 +-
gtk/channel-webdav.c | 10 -
gtk/spice-channel.c | 6 +++---
gtk/spice-session-priv.h | 10 -
gtk/spice-session.c | 54
Make sure calling an internal session function returns with an error
when called with a NULL pointer. This will help channel code when
it is removed from session before being destructed.
---
gtk/spice-session.c | 130 ++--
1 file changed, 76 insertio
---
gtk/channel-main.c | 2 +-
gtk/spice-session-priv.h | 2 +-
gtk/spice-session.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/gtk/channel-main.c b/gtk/channel-main.c
index 6d06ee3..490d21c 100644
--- a/gtk/channel-main.c
+++ b/gtk/channel-main.c
@@ -2073,7 +
The migration session is temporary and shouldn't interact with system.
---
gtk/channel-smartcard.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/gtk/channel-smartcard.c b/gtk/channel-smartcard.c
index d27360c..243a8ce 100644
--- a/gtk/channel-smartcard.c
+++
---
gtk/channel-main.c | 1 -
gtk/spice-session.c | 3 +++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/gtk/channel-main.c b/gtk/channel-main.c
index 490d21c..bf7c204 100644
--- a/gtk/channel-main.c
+++ b/gtk/channel-main.c
@@ -2073,7 +2073,6 @@ static gboolean migrate_connect(gp
---
gtk/channel-smartcard.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gtk/channel-smartcard.c b/gtk/channel-smartcard.c
index 243a8ce..8588ae0 100644
--- a/gtk/channel-smartcard.c
+++ b/gtk/channel-smartcard.c
@@ -136,7 +136,7 @@ static void spice_smartcard_channel_co
---
doc/reference/spice-gtk-sections.txt | 1 +
gtk/map-file | 1 +
gtk/spice-glib-sym-file | 1 +
gtk/spice-session.c | 19 +++
gtk/spice-session.h | 1 +
5 files changed, 23 insertions(+)
diff --git a/doc
---
gtk/spice-audio.c| 19 ++-
gtk/spice-session-priv.h | 1 +
gtk/spice-session.c | 8
3 files changed, 19 insertions(+), 9 deletions(-)
diff --git a/gtk/spice-audio.c b/gtk/spice-audio.c
index 638f667..ce303f1 100644
--- a/gtk/spice-audio.c
+++ b/gtk/spic
ok
On Wed, Nov 26, 2014 at 4:18 PM, Christophe Fergeau wrote:
> On Tue, Nov 25, 2014 at 02:19:27PM +0100, Marc-André Lureau wrote:
>> It is idiomatic for client code to clean up it's reference on channel
>
> "its reference"
>
>> disconnection. Keeping a reference during disconnect help solving
>
On Wed, Nov 26, 2014 at 4:14 PM, Christophe Fergeau wrote:
> It seems it's "behind your back". "this is mentioned in the doc"
ack
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman
On Wed, Nov 26, 2014 at 4:10 PM, Christophe Fergeau wrote:
> You should write either "objects" or "an object" here I think.
fixed
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman
On Wed, Nov 26, 2014 at 11:54 AM, Christophe Fergeau
wrote:
> On Tue, Nov 25, 2014 at 02:19:18PM +0100, Marc-André Lureau wrote:
>> Avoid deferencing session private data directly, and use accessors instead.
>> ---
>> gtk/channel-main.c | 13 +-
>> gtk/channel-webdav.c | 10
On Tue, Nov 25, 2014 at 11:23 PM, Jonathon Jongsma wrote:
> On Tue, 2014-11-25 at 14:19 +0100, Marc-André Lureau wrote:
>> Avoid deferencing session private data directly, and use accessors instead.
>
> typo: "deferencing"
>
ok
>> ---
>> gtk/channel-main.c | 13 +-
>> gtk/channel-
ACK.
Christophe
On Tue, Nov 25, 2014 at 02:19:24PM +0100, Marc-André Lureau wrote:
> Avoid the following critical when a channel is disconnected with a
> pending stream (the streams are cleared on channel reset, after
> coroutine exit)
>
> (process:17188): GSpice-CRITICAL **: spice_session_get
On Tue, Nov 25, 2014 at 02:19:28PM +0100, Marc-André Lureau wrote:
> This is a workaround for existing clients such as virt-viewer that do
> not hold a reference to their sessions when calling
> spice_session_disconnect() and crash now that channels are removed from
> session during the call. They
On Wed, Nov 26, 2014 at 04:17:24PM +0100, Christophe Fergeau wrote:
> On Tue, Nov 25, 2014 at 02:19:26PM +0100, Marc-André Lureau wrote:
> > This used to help prevent double-unref when channel were considered part
> > of the session as long as they lived. Now it shouldn't be required
> > anymore
>
On Wed, Nov 26, 2014 at 4:47 PM, Christophe Fergeau wrote:
> On Tue, Nov 25, 2014 at 02:19:22PM +0100, Marc-André Lureau wrote:
>> -gboolean disconnecting;
>> +guint disconnecting;
>
> This change belongs to the last patch of the series
>
>
done
>> -guint8
- Original Message -
> On Wed, 2014-11-26 at 13:58 +0100, Marc-André Lureau wrote:
> > Hi
> >
> > On Tue, Nov 25, 2014 at 11:49 PM, Jonathon Jongsma
> > wrote:
> > > I find this name a little inconsistent. Generally the first part of the
> > > function name indicates the type of object
ACK
On Tue, 2014-11-25 at 14:19 +0100, Marc-André Lureau wrote:
> Make sure none of the SpiceSessionPrivate fields are accessed directly anymore
> ---
> gtk/spice-session-priv.h | 83 ---
> gtk/spice-session.c | 84
> ++
On Wed, 2014-11-26 at 13:58 +0100, Marc-André Lureau wrote:
> Hi
>
> On Tue, Nov 25, 2014 at 11:49 PM, Jonathon Jongsma
> wrote:
> > I find this name a little inconsistent. Generally the first part of the
> > function name indicates the type of object that this method belongs to.
>
> Except con
On Tue, Nov 25, 2014 at 02:19:22PM +0100, Marc-André Lureau wrote:
> -gboolean disconnecting;
> +guint disconnecting;
This change belongs to the last patch of the series
> -guint8 webdav_magic[16];
> +guint8 webdav_magic[WEBDAV_MAGIC_S
On Wed, 2014-11-26 at 14:02 +0100, Marc-André Lureau wrote:
> Hi
>
> On Wed, Nov 26, 2014 at 12:05 AM, Jonathon Jongsma
> wrote:
> > So, you just added internal accessor functions for a bunch of other
> > session member variables (_get_webdav_magic(), etc.). But for these, you
> > used the GObje
ack
- Original Message -
> Returning early on focus_in_event(), when widget is not realized, avoids
> segfault when running on Windows using GTK3.
>
> Program received signal SIGSEGV, Segmentation fault.
> _gdk_windows_has_impl at gdkwindow.c:584
> bt
> #0 _gdk_window_has_impl (window
On Tue, Nov 25, 2014 at 02:19:27PM +0100, Marc-André Lureau wrote:
> It is idiomatic for client code to clean up it's reference on channel
"its reference"
> disconnection. Keeping a reference during disconnect help solving
"helps"
> potential crashes if the session is unref during callbacks.
"
On Tue, Nov 25, 2014 at 02:19:26PM +0100, Marc-André Lureau wrote:
> This used to help prevent double-unref when channel were considered part
> of the session as long as they lived. Now it shouldn't be required
> anymore
This is a bit confusing as a commit message, as after this commit the
'discon
On Tue, Nov 25, 2014 at 02:19:25PM +0100, Marc-André Lureau wrote:
> This function is somewhat useless, and dangerous since it is
> calling g_object_unref() on your back (although this is mention in the
It seems it's "behind your back". "this is mentioned in the doc"
Looks good otherwise
Christo
Returning early on focus_in_event(), when widget is not realized, avoids
segfault when running on Windows using GTK3.
Program received signal SIGSEGV, Segmentation fault.
_gdk_windows_has_impl at gdkwindow.c:584
bt
#0 _gdk_window_has_impl (window=window@entry=0x0) at gdkwindow.c:584
#1 0x70f
On Tue, Nov 25, 2014 at 02:19:23PM +0100, Marc-André Lureau wrote:
> A channel is considered to be part of a session as long as it is
> alive. However, this model is problematic, since library user may hold
> channel references, and thus the channel will remain in the
> session. Calling spice_sessi
On Wed, Nov 26, 2014 at 3:30 PM, Victor Toso wrote:
> gst_parse_launch may return not NULL even when error is set.
> This can lead to data loss when playing or recording audio.
> ---
> gtk/spice-gstaudio.c | 20 ++--
> 1 file changed, 14 insertions(+), 6 deletions(-)
>
> diff --gi
gst_parse_launch may return not NULL even when error is set.
This can lead to data loss when playing or recording audio.
---
gtk/spice-gstaudio.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/gtk/spice-gstaudio.c b/gtk/spice-gstaudio.c
index 5f9abb2..1b8
Changes since v2
* changing the label from 'lerr' to 'cleanup'
---
gtk/spice-gstaudio.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/gtk/spice-gstaudio.c b/gtk/spice-gstaudio.c
index 6173783..5f9abb2 100644
--- a/gtk/spice-gstaudio.c
+++ b/gtk/spice-gstaudio.c
@@ -120,
Hi
On Wed, Nov 26, 2014 at 12:05 AM, Jonathon Jongsma wrote:
> So, you just added internal accessor functions for a bunch of other
> session member variables (_get_webdav_magic(), etc.). But for these, you
> used the GObject data functions. Why are these variables treated
> differently? By using
Hi
On Tue, Nov 25, 2014 at 11:49 PM, Jonathon Jongsma wrote:
> I find this name a little inconsistent. Generally the first part of the
> function name indicates the type of object that this method belongs to.
Except constructors, like here.
> So I'd expect channel_webdav_server_new() to take a
On Wed, Nov 26, 2014 at 11:18:23AM +0100, Fabiano Fidêncio wrote:
> On Wed, Nov 26, 2014 at 10:14 AM, Christophe Fergeau
> wrote:
> > On Tue, Nov 25, 2014 at 11:06:05PM +0100, Fabiano Fidêncio wrote:
> >> On Tue, 2014-11-25 at 17:25 +0100, Victor Toso wrote:
> >> > gst_parse_launch may return not
On Tue, Nov 25, 2014 at 02:19:18PM +0100, Marc-André Lureau wrote:
> Avoid deferencing session private data directly, and use accessors instead.
> ---
> gtk/channel-main.c | 13 +-
> gtk/channel-webdav.c | 10
> gtk/spice-channel.c | 6 ++---
> gtk/spice-session-pr
On Wed, Nov 26, 2014 at 10:14 AM, Christophe Fergeau
wrote:
> On Tue, Nov 25, 2014 at 11:06:05PM +0100, Fabiano Fidêncio wrote:
>> On Tue, 2014-11-25 at 17:25 +0100, Victor Toso wrote:
>> > gst_parse_launch may return not NULL even when error is set.
>> > This can lead to data loss when playing or
On St, 2014-11-26 at 15:02 +0800, yao xu wrote:
> Thanks David .
>
>
>I use ovirt to manage my vms , version is about 3.1, my workmates
> added some code .
>
So the issue you see is most likely ovirt bug. The easiest way should be
to put host into maintenance, delete spice certificates and
Hey,
On Tue, Nov 25, 2014 at 01:44:44PM -0600, Jonathon Jongsma wrote:
> In general spice code follows the C89 style of declaring all variables
> at the very beginning of a block. In fact, I have a vague recollection
> of being asked to move some of my variable declarations to the beginning
> of t
On Tue, Nov 25, 2014 at 11:06:05PM +0100, Fabiano Fidêncio wrote:
> On Tue, 2014-11-25 at 17:25 +0100, Victor Toso wrote:
> > gst_parse_launch may return not NULL even when error is set.
> > This can lead to data loss when playing or recording audio.
> > ---
> > gtk/spice-gstaudio.c | 12 +
Thanks David .
I use ovirt to manage my vms , version is about 3.1, my workmates added
some code .
In our environment , we can't migrate vm continuosly. Is libvirt or qemu
should do some configuration ?
my libvirt version is 1.2.8 , qemu's version is 1.7.1
I do appreciate your help! gu
On Wed, Nov 26, 2014 at 12:13:18AM +0100, Marc-André Lureau wrote:
> On Wed, Nov 26, 2014 at 12:11 AM, Marc-André Lureau
> wrote:
> > Ok, what about 2/4? Do you see a problem removing never working and
> > experimental code? What good is experimental code if it can't be
> > removed?
>
>
> Oh I s
59 matches
Mail list logo
