memset is fine with me. I'm also a bit curious about the warnings you
got, but I guess you no longer have these around.
I recall that one of the was the inodes array. Arguably, that was a
bug, not just a warning silence. (Just a bug with a very low
probability of triggering a problem).
diff --git a/src/qxl_image.c b/src/qxl_image.c
index 8927fd4..53212de 100644
--- a/src/qxl_image.c
+++ b/src/qxl_image.c
@@ -62,6 +62,8 @@ hash_and_copy (const uint8_t *src, int src_stride,
const uint8_t *src_line = src + i * src_stride;
uint8_t *dest_line = dest + i * dest_stride;
This problem was exposed (and probably only occurs) when using XSpice
in dfps mode with spice-html5, and resizing from larger to smaller.
The screen would be resized, but the update region would still attempt
to transmit any pending changes to the (now) truncated surface. This
would often lead to
On Fri, Sep 19, 2014 at 09:09:43AM -0500, Jeremy White wrote:
> Hey Christophe,
>
> Thanks for the patch review.
>
> >>+memset(&data, 0, sizeof(data));
> >
> >Could this be written as struct audio_data data = { 0, }; or something
> >like that?
>
> Sure.
>
> Note, though, that afaict, memset
On Fri, Sep 19, 2014 at 09:13:57AM -0500, Jeremy White wrote:
> On 09/19/2014 06:40 AM, Christophe Fergeau wrote:
> >Any idea in which situation we are trying to access uninitialized pixmap
> >memory?
>
> I no longer recall with precision. The valgrind trigger was in
> hash_and_copy; I suspect I
Did not look in details at v2, but ack series. Thanks for going the
extra mile of splitting them!
Christophe
On Fri, Sep 19, 2014 at 10:44:12AM -0500, Jeremy White wrote:
> Attempting to use x11perf to measure performance revealed a fairly
> serious weakness in the dfps code in that use case. I
Signed-off-by: Jeremy White
---
src/dfps.c | 58 +++---
1 file changed, 27 insertions(+), 31 deletions(-)
diff --git a/src/dfps.c b/src/dfps.c
index 4ab20a8..a57523b 100644
--- a/src/dfps.c
+++ b/src/dfps.c
@@ -128,6 +128,28 @@ static Bool u
Attempting to use x11perf to measure performance revealed a fairly
serious weakness in the dfps code in that use case. In between
fps ticks, the updated_region would grow to have thousands of
rectangles, which made processing extraordinarily slow.
This patch provides a cap on the number of rectan
On 09/19/2014 06:32 AM, Christophe Fergeau wrote:
Hey,
Looks good, ACK.
I would have split it one patch introducing dfps_update_{box,region}
with no functional change, and one patch adding the
DFPS_MAX_UPDATE_REGION limit.
Yeah, you're right. Resending.
Cheers,
Jeremy
__
On their web site they say:
The qxl.sys driver must be installed from the drivers folder using pnputil -i
-a qxl.inf from a cmd terminal.
So I assume there is a qxl spice display driver available...
CU, Klaus
-Original Message-
From: Spice-devel [mailto:spice-devel-boun...@lists.freedes
This thread veered; I'd like to bring it back, if I can.
I've got a clear case of thread unsafety in XSpice.
spice_server_playback_put_samples is called from a different thread than
the main thread. If the main thread calls
main_dispatcher_handle_mm_time_latency while we're putting samples, v
On 09/19/2014 06:40 AM, Christophe Fergeau wrote:
Any idea in which situation we are trying to access uninitialized pixmap
memory?
I no longer recall with precision. The valgrind trigger was in
hash_and_copy; I suspect I first encountered it in the case I fixed with
a later patch (copying pa
Hey Christophe,
Thanks for the patch review.
+memset(&data, 0, sizeof(data));
Could this be written as struct audio_data data = { 0, }; or something
like that?
Sure.
Note, though, that afaict, memset(...0...) seems more prevalent in the
spice code than the universal zero initializer.
Il 12/09/2014 16:46, Fabio Fantoni ha scritto:
Il 08/07/2014 12:34, Fabio Fantoni ha scritto:
Il 08/07/2014 12:06, Fabio Fantoni ha scritto:
Il 08/07/2014 10:53, David Jaša ha scritto:
Hi,
On Út, 2014-07-08 at 10:13 +0200, Fabio Fantoni wrote:
On xen 4.5 (tried with qemu 2.0.0/2.1-rc0, spice
On Fri, Sep 12, 2014 at 02:25:14PM -0500, Jeremy White wrote:
> This problem was exposed (and probably only occurs) when using XSpice
> in dfps mode with spice-html5, and resizing from larger to smaller.
> The screen would be resized, but the update region would still attempt
> to transmit any pend
Any idea in which situation we are trying to access uninitialized pixmap
memory?
Apart from that, why not.
Christophe
On Fri, Sep 12, 2014 at 02:20:36PM -0500, Jeremy White wrote:
>
> Signed-off-by: Jeremy White
> ---
> src/dfps.c | 14 ++
> 1 file changed, 14 insertions(+)
>
>
Hey,
Looks good, ACK.
I would have split it one patch introducing dfps_update_{box,region}
with no functional change, and one patch adding the
DFPS_MAX_UPDATE_REGION limit.
Christophe
On Wed, Sep 10, 2014 at 12:26:26PM -0500, Jeremy White wrote:
> Attempting to use x11perf to measure performance
On Mon, Sep 15, 2014 at 11:26:14AM -0500, Jeremy White wrote:
>
> Signed-off-by: Jeremy White
> ---
> src/spiceqxl_audio.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/spiceqxl_audio.c b/src/spiceqxl_audio.c
> index 7afc089..02859ee 100644
> --- a/src/spiceqxl
Hey,
On Fri, Sep 19, 2014 at 01:28:46PM +0800, PaulCheung wrote:
> Dear all,
> I am compiling virt-viewer 1.0 on debian(arm). I got the flowing problem!
> First I compiled & installed spice-gtk-0.24.tar.gz
> then I install this, 1. ./configure no error 2. makeand
> then sho
19 matches
Mail list logo
