Re: [Spice-devel] [PATCH] Validate surface bounding box before using it

2014-09-10 Thread Fabiano Fidêncio
On Sep 10, 2014 5:10 PM, "Christophe Fergeau" wrote: > > It's possible for a buggy guest driver to pass invalid bounding box > dimensions in QXL commands, which would then cause spice-server to > segfault. This patch checks the size of the bounding box of the QXL > command right after it has been

Re: [Spice-devel] [PATCH 0/3] 3 trivial patches

2014-09-10 Thread Fabiano Fidêncio
On Sep 10, 2014 5:11 PM, "Christophe Fergeau" wrote: > > Hey, > > Here are 3 trivial patches which just change indentation/comments, I guess they could have been pushed as is. > Does Spice have the trivial rule? Ack. > Christophe > > ___ > Spice-devel

[Spice-devel] [PATCH xf86-video-qxl] Tune the dfps region tracking to collapse to the bounding rectangle if too many small, incremental, updates are provided.

2014-09-10 Thread Jeremy White
Attempting to use x11perf to measure performance revealed a fairly serious weakness in the dfps code in that use case. In between fps ticks, the updated_region would grow to have thousands of rectangles, which made processing extraordinarily slow. This patch provides a cap on the number of rectan

[Spice-devel] [PATCH 3/3] Fix 'abberiviations' typo in comment

2014-09-10 Thread Christophe Fergeau
--- server/red_worker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/red_worker.c b/server/red_worker.c index 35a1a04..dcd8b77 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -21,7 +21,7 @@ #define SPICE_LOG_DOMAIN "SpiceWorker" -/* Common variable

[Spice-devel] [PATCH 0/3] 3 trivial patches

2014-09-10 Thread Christophe Fergeau
Hey, Here are 3 trivial patches which just change indentation/comments, I guess they could have been pushed as is. Christophe ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [PATCH 2/3] Fix indentation in red_get_opaque_ptr

2014-09-10 Thread Christophe Fergeau
This removes one extra space --- server/red_parse_qxl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/red_parse_qxl.c b/server/red_parse_qxl.c index 008705f..d2329a3 100644 --- a/server/red_parse_qxl.c +++ b/server/red_parse_qxl.c @@ -570,7 +570,7 @@ static void red_pu

[Spice-devel] [PATCH 1/3] server/tests/Makefile.am: White-space cleanup

2014-09-10 Thread Christophe Fergeau
Make sure the \ at the end of lines are nicely aligned --- server/tests/Makefile.am | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am index e2201cc..233393e 100644 --- a/server/tests/Makefile.am +++ b/

[Spice-devel] [PATCH] Validate surface bounding box before using it

2014-09-10 Thread Christophe Fergeau
It's possible for a buggy guest driver to pass invalid bounding box dimensions in QXL commands, which would then cause spice-server to segfault. This patch checks the size of the bounding box of the QXL command right after it has been parsed. This fixes rhbz#1135372 --- server/red_worker.c | 31 +

Re: [Spice-devel] [spice-gtk] Don't report IO error on clean guest shutdown

2014-09-10 Thread Zeeshan Ali (Khattak)
On Wed, Sep 10, 2014 at 3:35 PM, Christophe Fergeau wrote: > Since commit 9cf9ca434, spice_channel_iterate() will report a > SPICE_CHANNEL_ERROR_IO error to library users when > SpiceChannel::has_error is set. In particular, when the server side > closes its SPICE sockets because the VM is being s

[Spice-devel] [spice-gtk] Don't report IO error on clean guest shutdown

2014-09-10 Thread Christophe Fergeau
Since commit 9cf9ca434, spice_channel_iterate() will report a SPICE_CHANNEL_ERROR_IO error to library users when SpiceChannel::has_error is set. In particular, when the server side closes its SPICE sockets because the VM is being shut down, an IO error will get reported. Prior to this change, a cha