Re: [Spice-devel] [spice-gtk][PATCH] Fix -Wsign-compare

2014-09-04 Thread Marc-André Lureau
ack - Original Message - > --- > tests/util.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/tests/util.c b/tests/util.c > index e090f5c..b9b9535 100644 > --- a/tests/util.c > +++ b/tests/util.c > @@ -36,7 +36,7 @@ static void test_dos2unix(void) >

[Spice-devel] [spice-gtk][PATCH] Fix -Wsign-compare

2014-09-04 Thread Pavel Grunt
--- tests/util.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tests/util.c b/tests/util.c index e090f5c..b9b9535 100644 --- a/tests/util.c +++ b/tests/util.c @@ -36,7 +36,7 @@ static void test_dos2unix(void) { GError *err = NULL; gchar *tmp; -int i

Re: [Spice-devel] [spice-gtk] win-usb: Initialize GError before using it

2014-09-04 Thread Marc-André Lureau
ack - Original Message - > GError variables must be set to NULL before passing them to a function > which might set them. > This fixes the runtime warning reported in rhbz#1138195: > > (remote-viewer.exe:3896): GLib-WARNING **: GError set over the top of a > previous GError or uninitializ

[Spice-devel] [spice-gtk] win-usb: Initialize GError before using it

2014-09-04 Thread Christophe Fergeau
GError variables must be set to NULL before passing them to a function which might set them. This fixes the runtime warning reported in rhbz#1138195: (remote-viewer.exe:3896): GLib-WARNING **: GError set over the top of a previous GError or uninitialized memory. This indicates a bug in someone's c

[Spice-devel] The solution of usbredir display problems for windows, temporarily

2014-09-04 Thread Cody Chan
Ok, this's not a patch, for I don't think it's good enough to be applied to upstream. For windows client, it's really not friendly for usbredir: 1. We need usbclerk service to let it redirect automatically --> not stably currently 2. The display of redir-list is ALL "USB DEVICE" --> make users con

[Spice-devel] [CVE-2014-3615 PATCH v2 0/3] vbe: bochs dispi interface fixes

2014-09-04 Thread Gerd Hoffmann
Hi, Two fixes for the bochs dispi interface, one of them fixing a minor security issue. New in v2: Got a CVE number. Investigation & patch review found a related issue in the spice code, so there is an additional patch. /me plans to send a pull tomorrow, so this can go in fast enougth for be

[Spice-devel] [CVE-2014-3615 PATCH v2 1/3] vbe: make bochs dispi interface return the correct memory size with qxl

2014-09-04 Thread Gerd Hoffmann
VgaState->vram_size is the size of the pci bar. In case of qxl not the whole pci bar can be used as vga framebuffer. Add a new variable vbe_size to handle that case. By default (if unset) it equals vram_size, but qxl can set vbe_size to something else. This makes sure VBE_DISPI_INDEX_VIDEO_MEMO

[Spice-devel] [CVE-2014-3615 PATCH v2 3/3] spice: make sure we don't overflow ssd->buf

2014-09-04 Thread Gerd Hoffmann
Related spice-only bug. We have a fixed 16 MB buffer here, being presented to the spice-server as qxl video memory in case spice is used with a non-qxl card. It's also used with qxl in vga mode. When using display resolutions requiring more than 16 MB of memory we are going to overflow that buff

[Spice-devel] [CVE-2014-3615 PATCH v2 2/3] vbe: rework sanity checks

2014-09-04 Thread Gerd Hoffmann
Plug a bunch of holes in the bochs dispi interface parameter checking. Add a function doing verification on all registers. Call that unconditionally on every register write. That way we should catch everything, even changing one register affecting the valid range of another register. Some of the