Signed-off-by: Jeremy White
---
cursor.js | 14
display.js |5 +--
enums.js| 24 -
main.js | 112 ---
spice.css | 28 ---
spicemsg.js | 77
2. Surgically modify the snd_worker.c calls that handle the Playback
channel to introduce a mutex; lock and release that mutex around
operations. This is the direction I'm leaning, but I don't see a lot of
evidence that this is commonly done.
Now, with patch that solves my problem. Stop me
Although the driver doesn't support rotation, drmmode_set_mode_major may
call CrtcRotate when the crtc mode doesn't fit on screen.
This will trigger a call to crtc->shadow_allocate() that will result in
SEGV since our driver doesn't implement it. Instead, let's fail
gracefully.
PS: I didn't manag
ack
- Original Message -
> The return of the get_array_size() is used as a limit in a loop,
> being compared with an unsigned index (indexes are always unsigned).
> To avoid the -Wsign-compare warning, let's cast the return of the
> get_array_size() to unsigned and make GCC happier.
> ---
The return of the get_array_size() is used as a limit in a loop,
being compared with an unsigned index (indexes are always unsigned).
To avoid the -Wsign-compare warning, let's cast the return of the
get_array_size() to unsigned and make GCC happier.
---
python_modules/marshal.py | 6 +++---
1 fil
Hi
- Original Message -
> The most part of the values are already unsigned values. The exceptions,
> that are causing the warnings, are:
>
> generated_server_marshallers.c:1387:27: warning: comparison between
> signed and unsigned integer expressions [-Wsign-compare]
> for (j
On Wed, 2014-09-03 at 06:01 -0400, Marc-André Lureau wrote:
> Can limit be negative?
I don't think so: http://paste.stg.fedoraproject.org/4623/39072140/
> Can limit be made unsigned instead?
Actually, what I'm doing is making the limit unsigned, thanks for
catching the error in the commit log :-
On Wed, 2014-09-03 at 06:22 -0400, Marc-André Lureau wrote:
>
> - Original Message -
> > On Wed, 2014-09-03 at 06:01 -0400, Marc-André Lureau wrote:
> > > Can limit be negative?
> >
> > I don't think so: http://paste.stg.fedoraproject.org/4623/39072140/
> >
> > > Can limit be made unsign
- Original Message -
> On Wed, 2014-09-03 at 06:01 -0400, Marc-André Lureau wrote:
> > Can limit be negative?
>
> I don't think so: http://paste.stg.fedoraproject.org/4623/39072140/
>
> > Can limit be made unsigned instead?
>
> Actually, what I'm doing is making the limit unsigned, tha
Can limit be negative? Can limit be made unsigned instead?
- Original Message -
> A few functions are comparing signed and unsigned values, basically
> because some of the loop indexes are signed values. Casting it to
> unsigned seems harmless and makes GCC happier.
> ---
> python_modules
ack
- Original Message -
> Although the most part of the parameters marked as unused are actually
> being used for a few functions, a bunch of warnings can be seen when
> the code is compiled with "-Wall -Wextra". As adding the unused attribute
> means that the variable/parameter is meant
A few functions are comparing signed and unsigned values, basically
because some of the loop indexes are signed values. Casting it to
unsigned seems harmless and makes GCC happier.
---
python_modules/codegen.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/python_modules/code
Although the most part of the parameters marked as unused are actually
being used for a few functions, a bunch of warnings can be seen when
the code is compiled with "-Wall -Wextra". As adding the unused attribute
means that the variable/parameter is meant to be *possibly* unused, we're
safe adding
13 matches
Mail list logo
