Re: [Spice-devel] Odd issue with OSX Guest

2014-09-01 Thread Alon Levy
On 09/01/2014 09:01 PM, Brad Campbell wrote: > G'day All, > > I'm attempting to run an OSX guest using spice as the remote display > protocol (Yes, it's running on Apple hardware). The guest is using the > standard vga driver. > > I'm using the latest git of spice, spice-gtk, qemu and the kernel.

[Spice-devel] Odd issue with OSX Guest

2014-09-01 Thread Brad Campbell
G'day All, I'm attempting to run an OSX guest using spice as the remote display protocol (Yes, it's running on Apple hardware). The guest is using the standard vga driver. I'm using the latest git of spice, spice-gtk, qemu and the kernel. The issue I'm bumping up against is it appears someth

Re: [Spice-devel] [[spice-common] 0/4] Removing compilation warnings ("-Wall -Wextra")

2014-09-01 Thread Marc-André Lureau
ack series - Original Message - > While running coverity scan in spice I got a few warnings from > spice-common and the most part of them are fixed with these 4 patches. > There are still a bunch of "-Wunused-parameter" in the autot generated > code, but I'm not touching on this, at least

Re: [Spice-devel] [[spice] 0/9] Removing compilation warnings ("-Wall -Wextra")

2014-09-01 Thread Marc-André Lureau
ack series - Original Message - > While running coverity scan in spice I got a bunch of warnings from our > test code (and a few from spice-common, patches already sent). > > Fabiano Fidêncio (9): > server: Don't dump the bitmap when the format is invalid > Fix -Wunused-parameter >

[Spice-devel] [[spice] 9/9] Fix -Wunused-function

2014-09-01 Thread Fabiano Fidêncio
--- server/tests/test_display_base.c | 22 - server/tests/test_vdagent.c | 51 2 files changed, 73 deletions(-) diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c index 04dd1e8..1c909fb 100644 --- a/server

[Spice-devel] [[spice] 2/9] Fix -Wunused-parameter

2014-09-01 Thread Fabiano Fidêncio
--- server/tests/test_display_base.c | 37 +- server/tests/test_display_no_ssl.c | 2 +- server/tests/test_display_resolution_changes.c | 3 ++- server/tests/test_display_width_stride.c | 9 --- server/tests/test_empty_success.c

[Spice-devel] [[spice] 0/9] Removing compilation warnings ("-Wall -Wextra")

2014-09-01 Thread Fabiano Fidêncio
While running coverity scan in spice I got a bunch of warnings from our test code (and a few from spice-common, patches already sent). Fabiano Fidêncio (9): server: Don't dump the bitmap when the format is invalid Fix -Wunused-parameter Fix -Wunused-value Fix -Wsign Fix -Wswitch Fix -W

[Spice-devel] [[spice] 4/9] Fix -Wsign

2014-09-01 Thread Fabiano Fidêncio
--- server/tests/test_display_base.c | 4 ++-- server/tests/test_playback.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c index 9bb29b7..bdac680 100644 --- a/server/tests/test_display_base.c +++ b/serv

[Spice-devel] [[spice] 7/9] Fix -Wnonnull

2014-09-01 Thread Fabiano Fidêncio
--- server/tests/test_display_base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c index b197d1b..02f3378 100644 --- a/server/tests/test_display_base.c +++ b/server/tests/test_display_base.c @@ -88,10 +88,1

[Spice-devel] [[spice] 6/9] Fix -Wformat

2014-09-01 Thread Fabiano Fidêncio
--- server/tests/basic_event_loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/tests/basic_event_loop.c b/server/tests/basic_event_loop.c index c6f6698..79a4523 100644 --- a/server/tests/basic_event_loop.c +++ b/server/tests/basic_event_loop.c @@ -115,7 +115,7 @@ st

[Spice-devel] [[spice] 1/9] server: Don't dump the bitmap when the format is invalid

2014-09-01 Thread Fabiano Fidêncio
Caught by covscan: spice/server/spice_bitmap_utils.c:54: var_decl: Declaring variable "n_pixel_bits" without initializer. spice/server/spice_bitmap_utils.c:106: uninit_use: Using uninitialized value "n_pixel_bits". --- server/spice_bitmap_utils.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Spice-devel] [[spice] 3/9] Fix -Wunused-value

2014-09-01 Thread Fabiano Fidêncio
--- server/tests/test_display_streaming.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/tests/test_display_streaming.c b/server/tests/test_display_streaming.c index 01c7e7a..4515051 100644 --- a/server/tests/test_display_streaming.c +++ b/server/tests/test_display_str

[Spice-devel] [[spice] 8/9] Fix -Wmissing-field-initializers

2014-09-01 Thread Fabiano Fidêncio
--- server/tests/test_display_base.c | 15 ++- server/tests/test_display_resolution_changes.c | 4 ++-- server/tests/test_display_width_stride.c | 22 +++--- server/tests/test_playback.c | 12 ++-- server/tests/test_vdagent

[Spice-devel] [[spice] 5/9] Fix -Wswitch

2014-09-01 Thread Fabiano Fidêncio
--- server/tests/test_display_base.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c index bdac680..b197d1b 100644 --- a/server/tests/test_display_base.c +++ b/server/tests/test_display_base.c @@ -551,6 +551,8 @@ static void

[Spice-devel] [[spice-common] 0/4] Removing compilation warnings ("-Wall -Wextra")

2014-09-01 Thread Fabiano Fidêncio
While running coverity scan in spice I got a few warnings from spice-common and the most part of them are fixed with these 4 patches. There are still a bunch of "-Wunused-parameter" in the autot generated code, but I'm not touching on this, at least for now. Fabiano Fidêncio (4): common: Remove

[Spice-devel] [[spice-common] 4/4] common: Fix -Wmissing-field-initializers

2014-09-01 Thread Fabiano Fidêncio
--- common/lines.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/lines.c b/common/lines.c index 726a350..36b40a7 100644 --- a/common/lines.c +++ b/common/lines.c @@ -2978,7 +2978,7 @@ miWideDashSegment (GCPtr pGC, double L, l; double k; PolyVertexRec ver

[Spice-devel] [[spice-common] 1/4] common: Remove dead code

2014-09-01 Thread Fabiano Fidêncio
--- common/lines.c | 9 - 1 file changed, 9 deletions(-) diff --git a/common/lines.c b/common/lines.c index 4f404f1..e345b95 100644 --- a/common/lines.c +++ b/common/lines.c @@ -1835,15 +1835,6 @@ miPolyBuildEdge (double x0, double y0, double k, /* x0 * dy - y0 * dx */ dx

[Spice-devel] [[spice-common] 3/4] common: Fix -Wsign-compare

2014-09-01 Thread Fabiano Fidêncio
--- common/log.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/log.c b/common/log.c index 5e2db4c..fc5c129 100644 --- a/common/log.c +++ b/common/log.c @@ -84,7 +84,7 @@ void spice_logv(const char *log_domain, abort_level = getenv("SPICE_ABORT_LEVEL") ? a

[Spice-devel] [[spice-common] 2/4] common: Fix -Wunused-parameter

2014-09-01 Thread Fabiano Fidêncio
--- common/canvas_utils.c | 3 ++- common/lines.c | 19 ++- common/marshaller.c| 2 +- common/pixman_utils.c | 2 +- common/quic.c | 2 +- common/quic_rgb_tmpl.c | 8 common/quic_tmpl.c | 8 common/rop3.c | 14 +---