Re: [Spice-devel] [PATCH] spice.h: Don't use 48kHz for playback/recording rates

2014-08-19 Thread Jeremy White
When we are in the second situation, having 48000 in the public header will actually cause issues as spice-server will know QEMU does not support Opus, so internally spice-server will be using a 44100 rate for audio. However, QEMU will be using SPICE_INTERFACE_.*_FREQ and think it should use a 480

Re: [Spice-devel] [PATCH] [xf86-video-qxl] Free the region pointer as well; eliminates a memory leak in dfps mode.

2014-08-19 Thread Marc-André Lureau
ack, thanks - Original Message - > > Signed-off-by: Jeremy White > --- > src/dfps.c |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/dfps.c b/src/dfps.c > index 5cc1890..4ab20a8 100644 > --- a/src/dfps.c > +++ b/src/dfps.c > @@ -169,6 +169,7 @@ static void dfps_solid

[Spice-devel] [PATCH] spice.h: Don't use 48kHz for playback/recording rates

2014-08-19 Thread Christophe Fergeau
When adding Opus support, SPICE_INTERFACE_PLAYBACK_FREQ and SPICE_INTERFACE_RECORD_FREQ in the public header 'spice.h' were changed from 44100 to 48000. However, this was not really useful as these constants are not used in spice-server, but only by users of spice-server (ie QEMU). It turns out cha