Re: [Spice-devel] spice related qemu crash

2014-08-12 Thread David Mansfield
On 08/12/2014 05:10 AM, Christophe Fergeau wrote: On Mon, Aug 11, 2014 at 03:34:07PM -0400, David Mansfield wrote: Hi All, I have a qemu 1.6.2 (SRPM from F20 recompiled on Centos 7) which crashed with the following in the qemu log. Not sure exactly what the timing of the messages are here, si

Re: [Spice-devel] [spice-gtk] Ensure '\0' is not part of text clipboard data

2014-08-12 Thread Marc-André Lureau
ack - Original Message - > On Windows, with some versions of gtk+, GtkSelectionData::length > will include the final '\0'. > When a string with this trailing '\0' is pasted in some linux > applications, it will be pasted as or as an invisible character, > which is unwanted. > > This comm

[Spice-devel] [spice-gtk] Ensure '\0' is not part of text clipboard data

2014-08-12 Thread Christophe Fergeau
On Windows, with some versions of gtk+, GtkSelectionData::length will include the final '\0'. When a string with this trailing '\0' is pasted in some linux applications, it will be pasted as or as an invisible character, which is unwanted. This commit ensures the length we send to the agent does

[Spice-devel] [PATCH] [vd_agent] fix bug: display error when dragging file with CJK characters in name

2014-08-12 Thread Cody Chan
​ I submitted a patch several months ago about this issue, here http://lists.freedesktop.org/archives/spice-devel/2014-February/016158.html I check it again, and find that the value of g_key_file_to_data(keyfile,...) is always utf-8, for the value of g_uri_list_extract_uris() is utf8 urlencode. S

Re: [Spice-devel] [PATCH] [vd_agent] fix bug: display error when dragging file with CJK characters

2014-08-12 Thread Christophe Fergeau
Hey, On Mon, Aug 11, 2014 at 07:58:44PM +0800, Cody Chan wrote: > ​ > I submitted a patch several months ago about this issue, > here > http://lists.freedesktop.org/archives/spice-devel/2014-February/016158.html > > I check it again, and find that the value of > g_key_file_to_data(keyfile,...) is

Re: [Spice-devel] [PATCH] [vd_agent] fix bug: g_key_get_string() of vd_agent failed when keystring contains '['

2014-08-12 Thread Christophe Fergeau
On Tue, Aug 12, 2014 at 11:20:21AM +0200, Christophe Fergeau wrote: > On Mon, Aug 11, 2014 at 06:38:17PM +0800, Cody Chan wrote: > > Yeah!I think yours is elegant and simple! > > Have you tested this patch and verified it works? Ah sorry, I just saw your new version of the patch with this code w

Re: [Spice-devel] [PATCH] [vd_agent] fix bug: g_key_get_string() is failed when keystring contains '['

2014-08-12 Thread Christophe Fergeau
ACK On Mon, Aug 11, 2014 at 08:21:49PM +0800, Cody Chan wrote: > In vd_agent/file_xfer.cpp, it implemented a simple g_key_get_string, > but when dragging a file with a name containing '[' (like te[st.txt), it > will be failed. > From source code, > >next_group_pos = strstr(group_pos + strlen(grou

Re: [Spice-devel] [PATCH] [vd_agent] fix bug: g_key_get_string() of vd_agent failed when keystring contains '['

2014-08-12 Thread Christophe Fergeau
On Mon, Aug 11, 2014 at 06:38:17PM +0800, Cody Chan wrote: > Yeah!I think yours is elegant and simple! Have you tested this patch and verified it works? I did not try it at all, but it seems to make sense when reading the code and your explanations. Christophe pgpcTQRFSuMiU.pgp Description: PGP

Re: [Spice-devel] [PATCH] [spice-gtk] DND: fix special case that file size is 0

2014-08-12 Thread Christophe Fergeau
Hey, On Mon, Aug 11, 2014 at 12:58:44PM -0400, Marc-André Lureau wrote: > > > - Original Message - > > On windows guest, after dra gging a zero-size file, the file will be > > occupied > > by vdagent. For spice-gtk ignores this case, and stops sending data after > > sending > > a start

Re: [Spice-devel] spice related qemu crash

2014-08-12 Thread Christophe Fergeau
On Mon, Aug 11, 2014 at 03:34:07PM -0400, David Mansfield wrote: > Hi All, > > I have a qemu 1.6.2 (SRPM from F20 recompiled on Centos 7) which crashed > with the following in the qemu log. > > Not sure exactly what the timing of the messages are here, since the > messages are not all timestamped