[Spice-devel] spice related qemu crash

2014-08-11 Thread David Mansfield
Hi All, I have a qemu 1.6.2 (SRPM from F20 recompiled on Centos 7) which crashed with the following in the qemu log. Not sure exactly what the timing of the messages are here, since the messages are not all timestamped: main_channel_link: add main channel client main_channel_handle_parsed:

Re: [Spice-devel] [PATCH] [spice-gtk] DND: fix special case that file size is 0

2014-08-11 Thread Marc-André Lureau
- Original Message - > > > > On Tue, Aug 12, 2014 at 12:58 AM, Marc-André Lureau < mlur...@redhat.com > > wrote: > > > > > - Original Message - > > On windows guest, after dra gging a zero-size file, the file will be > > occupied > > by vdagent. For spice-gtk ignores this c

Re: [Spice-devel] [PATCH] [spice-gtk] DND: fix special case that file size is 0

2014-08-11 Thread Cody Chan
On Tue, Aug 12, 2014 at 12:58 AM, Marc-André Lureau wrote: > > > - Original Message - > > On windows guest, after dra gging a zero-size file, the file will be > occupied > > by vdagent. For spice-gtk ignores this case, and stops sending data after > > sending > > a start message to agent,

Re: [Spice-devel] [PATCH] [spice-gtk] DND: fix special case that file size is 0

2014-08-11 Thread Marc-André Lureau
- Original Message - > On windows guest, after dra gging a zero-size file, the file will be occupied > by vdagent. For spice-gtk ignores this case, and stops sending data after > sending > a start message to agent, see here for more details: > http://lists.freedesktop.org/archives/spice-d

[Spice-devel] [PATCH] [spice-gtk] DND: fix special case that file size is 0

2014-08-11 Thread Cody Chan
On windows guest, after dragging a zero-size file, the file will be occupied by vdagent. For spice-gtk ignores this case, and stops sending data after sending a start message to agent, see here for more details: http://lists.freedesktop.org/archives/spice-devel/2014-August/017184.html I accept the

Re: [Spice-devel] [PATCH] [vd_agent] close the file handler if file_size = 0

2014-08-11 Thread Cody Chan
On Mon, Aug 11, 2014 at 7:04 PM, Christophe Fergeau wrote: > On Sat, Aug 09, 2014 at 06:40:22PM +0800, Cody Chan wrote: > > After dragging a zero-size file, then I open it in guest, > > I get a warning message box which says: > > "the process cannot access the file because it is being used by an

[Spice-devel] [PATCH] [vd_agent] fix bug: g_key_get_string() is failed when keystring contains '['

2014-08-11 Thread Cody Chan
In vd_agent/file_xfer.cpp, it implemented a simple g_key_get_string, but when dragging a file with a name containing '[' (like te[st.txt), it will be failed. >From source code, >next_group_pos = strstr(group_pos + strlen(group_pfx), "["); >if (next_group_pos && key_pos > next_group_pos) return

[Spice-devel] [PATCH] [vd_agent] fix bug: display error when dragging file with CJK characters

2014-08-11 Thread Cody Chan
​ I submitted a patch several months ago about this issue, here http://lists.freedesktop.org/archives/spice-devel/2014-February/016158.html I check it again, and find that the value of g_key_file_to_data(keyfile,...) is always utf-8, for the value of g_uri_list_extract_uris() is utf8 urlencode. S

Re: [Spice-devel] [PATCH] [vd_agent] fix bug: display error when dragging file with CJK characters

2014-08-11 Thread Cody Chan
Sorry, memory leaks.. On Mon, Aug 11, 2014 at 7:43 PM, Cody Chan wrote: > ​ > I submitted a patch several months ago about this issue, > here > http://lists.freedesktop.org/archives/spice-devel/2014-February/016158.html > > I check it again, and find that the value of > g_key_file_to_data(keyfi

[Spice-devel] [PATCH] [vd_agent] fix bug: display error when dragging file with CJK characters

2014-08-11 Thread Cody Chan
​ I submitted a patch several months ago about this issue, here http://lists.freedesktop.org/archives/spice-devel/2014-February/016158.html I check it again, and find that the value of g_key_file_to_data(keyfile,...) is always utf-8, for the value of g_uri_list_extract_uris() is utf8 urlencode. S

Re: [Spice-devel] [PATCH] [vd_agent] close the file handler if file_size = 0

2014-08-11 Thread Christophe Fergeau
On Sat, Aug 09, 2014 at 06:40:22PM +0800, Cody Chan wrote: > After dragging a zero-size file, then I open it in guest, > I get a warning message box which says: > "the process cannot access the file because it is being used by another > process". > And I get to know the file is occupied by vdagent

Re: [Spice-devel] [PATCH] [vd_agent] fix bug: g_key_get_string() of vd_agent failed when keystring contains '['

2014-08-11 Thread Cody Chan
Yeah!I think yours is elegant and simple! On Mon, Aug 11, 2014 at 6:33 PM, Christophe Fergeau wrote: > Hey, > > On Fri, Aug 08, 2014 at 08:33:59PM +0800, Cody Chan wrote: > > Hi, as you can see, in vd_agent/file_xfer.cpp, it implemented > > the g_key_get_string, > > but I find a problem, when d

Re: [Spice-devel] [PATCH] [vd_agent] fix bug: g_key_get_string() of vd_agent failed when keystring contains '['

2014-08-11 Thread Christophe Fergeau
Hey, On Fri, Aug 08, 2014 at 08:33:59PM +0800, Cody Chan wrote: > Hi, as you can see, in vd_agent/file_xfer.cpp, it implemented > the g_key_get_string, > but I find a problem, when dragging a file with a name containing '[' (like > te[st.txt), it will be failed. > From source code, > >next_group_p

Re: [Spice-devel] [PATCH] fix bug: display error when dragging file with CJK characters

2014-08-11 Thread Christophe Fergeau
Hey, On Fri, Aug 08, 2014 at 02:22:30AM +0800, Cody Chan wrote: > I submitted a patch several months ago about this issue, > here > http://lists.freedesktop.org/archives/spice-devel/2014-February/016158.html > > I check it again, and find that the value of > g_key_file_to_data(keyfile,...) is alw

Re: [Spice-devel] Patches welcome??

2014-08-11 Thread Christophe Fergeau
Hey Cody, On Sun, Aug 10, 2014 at 09:01:02PM +0800, Cody Chan wrote: > Here're four patches I've contributed, but no ACK && no challenge, any > reason? Things tend to be slow in August, especially during the week-end, so don't worry, your patches will be looked at soon hopefully :) Thanks a lot

Re: [Spice-devel] [PATCH 3/3] Fix "NULL_RETURNS" caught by coverity

2014-08-11 Thread Christophe Fergeau
On Wed, Aug 06, 2014 at 12:08:52PM +0200, Fabiano Fidêncio wrote: > On Mon, Aug 4, 2014 at 3:39 PM, Christophe Fergeau > wrote: > > > On Mon, Jul 14, 2014 at 01:44:45PM +0200, Fabiano Fidêncio wrote: > > > On Mon, Jul 14, 2014 at 1:30 PM, Marc-André Lureau > > > wrote: > > > > Could malloc & fre