Re: [Spice-devel] Which version of windows OS on guest could support multi monitors

2014-07-14 Thread Marc-André Lureau
Hi - Original Message - > I have one qestion about Windows OS version: which version of windows on > guest could support multi monitors? ( running on linux+KVM (QEMU) ) > > For example: > (1)Windows XP Professional with sp3 > (2)Windows Server 2003 Enterprise Edition > (3)Windows 7 32bits

Re: [Spice-devel] [PATCH 3/3] Fix "NULL_RETURNS" caught by coverity

2014-07-14 Thread Fabiano Fidêncio
On Mon, Jul 14, 2014 at 1:30 PM, Marc-André Lureau wrote: > > > - Original Message - > > Hi Marc, > > > > > > On Mon, Jul 14, 2014 at 12:19 PM, Marc-André Lureau < mlur...@redhat.com > > > > wrote: > > > > > > Hi, > > > > All of those changes are OOM conditions. How can we shut coverity o

Re: [Spice-devel] [PATCH 3/3] Fix "NULL_RETURNS" caught by coverity

2014-07-14 Thread Marc-André Lureau
- Original Message - > Hi Marc, > > > On Mon, Jul 14, 2014 at 12:19 PM, Marc-André Lureau < mlur...@redhat.com > > wrote: > > > Hi, > > All of those changes are OOM conditions. How can we shut coverity on those? > > Yes, there is a simple way and that's what we have in Evolution Dat

[Spice-devel] [PATCHv2] Fix "REVERSE_INULL" caught by coverity

2014-07-14 Thread Fabiano Fidêncio
--- gtk/channel-cursor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtk/channel-cursor.c b/gtk/channel-cursor.c index fb19536..a7d7153 100644 --- a/gtk/channel-cursor.c +++ b/gtk/channel-cursor.c @@ -389,7 +389,7 @@ static display_cursor *set_cursor(SpiceChannel *channel,

Re: [Spice-devel] [PATCH 3/3] Fix "NULL_RETURNS" caught by coverity

2014-07-14 Thread Fabiano Fidêncio
Hi Marc, On Mon, Jul 14, 2014 at 12:19 PM, Marc-André Lureau wrote: > Hi, > > All of those changes are OOM conditions. How can we shut coverity on those? > Yes, there is a simple way and that's what we have in Evolution Data Server. Long story short, we can just add some comments in the code l

Re: [Spice-devel] [PATCHv2] quic: Fix "OVERRUN" caught by coverity

2014-07-14 Thread Uri Lublin
On 07/14/2014 01:09 PM, Fabiano Fidêncio wrote: Check for MELCSTAT - 1 to get inside the branch, otherwise MELCSTATES (missing ES, also below missing S) (...)->rgb_state.melcstate may be up to MELCSTATE after the pre-incrementing, which would result in an access to a position that is out bounds

Re: [Spice-devel] [PATCH 1/3] g_type_init() is deprecated in GLib 2.36

2014-07-14 Thread Marc-André Lureau
ack - Original Message - > --- > gtk/controller/dump.c | 2 ++ > gtk/spice-client-glib-usb-acl-helper.c | 2 ++ > gtk/spicy-screenshot.c | 2 ++ > gtk/spicy-stats.c | 2 ++ > gtk/spicy.c| 2 ++ > 5 files cha

Re: [Spice-devel] [PATCH 3/3] Fix "NULL_RETURNS" caught by coverity

2014-07-14 Thread Marc-André Lureau
Hi, All of those changes are OOM conditions. How can we shut coverity on those? Why does it warn here and not for other allocations? - Original Message - > --- > gtk/controller/test.c | 3 +++ > gtk/spice-client-gtk.override | 3 +++ > gtk/spice-widget.c| 2 ++ > 3 fi

Re: [Spice-devel] [PATCH 2/3] Fix "REVERSE_INULL" caught by coverity

2014-07-14 Thread Marc-André Lureau
Hi - Original Message - > --- > gtk/channel-cursor.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/gtk/channel-cursor.c b/gtk/channel-cursor.c > index fb19536..8d75e95 100644 > --- a/gtk/channel-cursor.c > +++ b/gtk/channel-cursor.c > @@ -324,6 +324,9 @@ st

[Spice-devel] [PATCHv2] quic: Fix "OVERRUN" caught by coverity

2014-07-14 Thread Fabiano Fidêncio
Check for MELCSTAT - 1 to get inside the branch, otherwise (...)->rgb_state.melcstate may be up to MELCSTATE after the pre-incrementing, which would result in an access to a position that is out bounds of the array size MELCSTATE. --- common/quic.c | 8 1 file changed, 4 insertions(+), 4

Re: [Spice-devel] [PATCH] quic: Fix "OVERRUN" caught by coverity

2014-07-14 Thread Uri Lublin
On 07/14/2014 11:14 AM, Fabiano Fidêncio wrote: Pre-incrementing the variable used as the array's index can make such index exceed the array's bounds. Although that (...)->rgb_state.melcstate has to be less than MELCSTATE to get inside the branch, it may be up to MELCSTATE after the pre-increment

[Spice-devel] [PATCH] quic: Fix "OVERRUN" caught by coverity

2014-07-14 Thread Fabiano Fidêncio
Pre-incrementing the variable used as the array's index can make such index exceed the array's bounds. Although that (...)->rgb_state.melcstate has to be less than MELCSTATE to get inside the branch, it may be up to MELCSTATE after the pre-incrementing, which would result in an access to a position

[Spice-devel] [PATCH 3/3] Fix "NULL_RETURNS" caught by coverity

2014-07-14 Thread Fabiano Fidêncio
--- gtk/controller/test.c | 3 +++ gtk/spice-client-gtk.override | 3 +++ gtk/spice-widget.c| 2 ++ 3 files changed, 8 insertions(+) diff --git a/gtk/controller/test.c b/gtk/controller/test.c index 851f237..5a9c8b9 100644 --- a/gtk/controller/test.c +++ b/gtk/controller/test.c

[Spice-devel] [PATCH 1/3] g_type_init() is deprecated in GLib 2.36

2014-07-14 Thread Fabiano Fidêncio
--- gtk/controller/dump.c | 2 ++ gtk/spice-client-glib-usb-acl-helper.c | 2 ++ gtk/spicy-screenshot.c | 2 ++ gtk/spicy-stats.c | 2 ++ gtk/spicy.c| 2 ++ 5 files changed, 10 insertions(+) diff --git a/gtk/control

[Spice-devel] [PATCH 0/3] Misc coverity fixes for spice-gtk

2014-07-14 Thread Fabiano Fidêncio
Howdy! Here are a few patches fixing some (minor) issues reported by coverity. There are still some unfixed issues, and the most part of them are in the vala-generated C code. Also, there are a few more warnings that looked as false-positives. Can we add explicit comments in the code telling cove

[Spice-devel] [PATCH 2/3] Fix "REVERSE_INULL" caught by coverity

2014-07-14 Thread Fabiano Fidêncio
--- gtk/channel-cursor.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gtk/channel-cursor.c b/gtk/channel-cursor.c index fb19536..8d75e95 100644 --- a/gtk/channel-cursor.c +++ b/gtk/channel-cursor.c @@ -324,6 +324,9 @@ static display_cursor *set_cursor(SpiceChannel *chann