[Spice-devel] [PATCH v2 2/2] Do not depend on libsoup directly

2014-05-20 Thread Tiziano Müller
The libsoup-dependency is not directly used but comes in as a dependency of phodav and phodav has libsoup correctly recorded in its pkg-config file. --- configure.ac | 3 --- 1 file changed, 3 deletions(-) diff --git a/configure.ac b/configure.ac index 70ab75c..f47ee20 100644 --- a/configure.ac +

[Spice-devel] [PATCH v2 1/2] Introduce --enable/disable-webdav option

2014-05-20 Thread Tiziano Müller
This makes the phodav dependency configureable. And name it after the corresponding channel. --- configure.ac | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index d89bd6f..70ab75c 100644 --- a/configure.ac +++ b/configure.ac @

Re: [Spice-devel] [PATCH 1/2] Introduce --enable/disable-folder-sharing option

2014-05-20 Thread Tiziano Müller
Hi Marc-André Am 20.05.2014 19:31, schrieb Marc-André Lureau: > > > - Original Message - >> This makes the phodav dependency configureable & optional. > > Well, it is already optional, if phodav isn't available. > > In general, I prefer not having a lot of options, but since that doesn

[Spice-devel] streaming assertion

2014-05-20 Thread Jonathon Jongsma
I've been investigating bug 1086820 that results in a failed assertion in spice-server (causing the guest to exit) related to mjpeg streaming. This is the debug output when we hit this issue: (/usr/bin/qemu-kvm:3165): Spice-ERROR **: mjpeg_encoder.c:627:mjpeg_encoder_adjust_params_to_bit_rate:

[Spice-devel] [spice-html5] Add support for audio streams using the Opus encoding.

2014-05-20 Thread Jeremy White
Requires a browser with MediaSource extension support, and Opus support for the source buffers. In practice, that is Chrome and Firefox. Signed-off-by: Jeremy White --- enums.js | 20 +++ main.js |2 + playback.js | 278 + spice.html |2 + spic

[Spice-devel] [spice-html5] Tweak hexdump to not generate new lines.

2014-05-20 Thread Jeremy White
Signed-off-by: Jeremy White --- utils.js |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/utils.js b/utils.js index 167f184..9eb42ff 100644 --- a/utils.js +++ b/utils.js @@ -63,7 +63,10 @@ function hexdump_buffer(a) hex += "0"; hex += h + " "; -

Re: [Spice-devel] [PATCH 1/2] Introduce --enable/disable-folder-sharing option

2014-05-20 Thread Marc-André Lureau
- Original Message - > This makes the phodav dependency configureable & optional. Well, it is already optional, if phodav isn't available. In general, I prefer not having a lot of options, but since that doesn't change default behaviour, I guess it's fine. I also have a preference for

Re: [Spice-devel] [PATCH 2/2] Do not depend on libsoup directly

2014-05-20 Thread Marc-André Lureau
- Original Message - > The libsoup-dependency is not directly used but comes in as a dependency > of phodav and phodav has libsoup correctly recorded in its pkg-config > file. Yes, but spice-gtk code uses soup api nonetheless, I am not sure what is the best practice in this case. I gues

[Spice-devel] [PATCH 1/2] Introduce --enable/disable-folder-sharing option

2014-05-20 Thread Tiziano Müller
This makes the phodav dependency configureable & optional. --- configure.ac | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index d89bd6f..608d69c 100644 --- a/configure.ac +++ b/configure.ac @@ -270,10 +270,23 @@ AC_SUBST(GTHREA

[Spice-devel] [PATCH 2/2] Do not depend on libsoup directly

2014-05-20 Thread Tiziano Müller
The libsoup-dependency is not directly used but comes in as a dependency of phodav and phodav has libsoup correctly recorded in its pkg-config file. --- configure.ac | 3 --- 1 file changed, 3 deletions(-) diff --git a/configure.ac b/configure.ac index 608d69c..80f4052 100644 --- a/configure.ac +

Re: [Spice-devel] [PATCH spice-gtk] Revert "clipboard: prevent reentering main loop if main channel is busy"

2014-05-20 Thread Christophe Fergeau
On Tue, May 20, 2014 at 04:58:53PM +0200, Marc-André Lureau wrote: > This change broke primary clipboard copying from remote to client, on win32. > > There is a pending ::clipboard-grab emission, so the channel is not > idle, and it will handle emission and resume in the inner loop without > issue

[Spice-devel] [PATCH spice-gtk] Revert "clipboard: prevent reentering main loop if main channel is busy"

2014-05-20 Thread Marc-André Lureau
This change broke primary clipboard copying from remote to client, on win32. There is a pending ::clipboard-grab emission, so the channel is not idle, and it will handle emission and resume in the inner loop without issue. We should really handle this situation with care though, and the best would