Re: [Spice-devel] [PATCH] how can i trace monitor change (etc) events

I opened. https://bugs.freedesktop.org/show_bug.cgi?id=78131 - Original Message - > From: "Greg Sheremeta" > To: "David Mansfield" > Cc: spice-devel@lists.freedesktop.org > Sent: Monday, April 28, 2014 9:53:15 AM > Subject: Re: [Spice-devel] [PATCH] how can i trace monitorchange (e

Re: [Spice-devel] [PATCH] migration: Don't assert() if MIGRATE_DATA comes before attaching the agent

Hi Christophe, I don't understand what exactly goes wrong and how this patch fixes the race. On 04/01/2014 04:58 PM, Christophe Fergeau wrote: During seamless migration, after switching host, if a client was connected during the migration, it will have data to send back to the new qemu/spice-s

Re: [Spice-devel] [PATCH 04/12] display\driver.c: remove unused FlotaToFixed

trivial, ack - Original Message - > --- > xddm/display/driver.c | 14 -- > 1 file changed, 14 deletions(-) > > diff --git a/xddm/display/driver.c b/xddm/display/driver.c > index aa4fe42..5a3dbfa 100644 > --- a/xddm/display/driver.c > +++ b/xddm/display/driver.c > @@ -1252,20

Re: [Spice-devel] [PATCH 05/12] build.bat: fix copy to install dir for amd64

- Original Message - > --- > xddm/build.bat | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/xddm/build.bat b/xddm/build.bat > index 1d19875..7dfe51b 100755 > --- a/xddm/build.bat > +++ b/xddm/build.bat > @@ -16,6 +16,12 @@ if not DEFINED SPICE_CO

Re: [Spice-devel] [PATCH 06/12] build.bat: more verbose build

ack - Original Message - > --- > xddm/build.bat | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/xddm/build.bat b/xddm/build.bat > index 7dfe51b..b2c5149 100755 > --- a/xddm/build.bat > +++ b/xddm/build.bat > @@ -30,9 +30,10 @@ if not x%1 == x set DEST=%1 >

Re: [Spice-devel] [PATCH 03/12] display/res.h: remove whitespace at EOF

trivial, ack - Original Message - > --- > xddm/display/res.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xddm/display/res.h b/xddm/display/res.h > index 6ce9a68..4d179c5 100644 > --- a/xddm/display/res.h > +++ b/xddm/display/res.h > @@ -74,4 +74,4 @@ void Emp

Re: [Spice-devel] [PATCH 01/12] Revert "miniport: halve QXL_IO_UPDATE_IRQ calls"

ack, should the bug state be changed back to ASSIGNED? - Original Message - > From: Yonit Halperin > > This reverts commit 49feefa95d3595f04355c4aed53ec5bf26551046. > The patch causes the display to get stuck. Till we understand exactly > why, I'm reverting it. > --- > xddm/miniport/qx

Re: [Spice-devel] [PATCH 02/12] miniport/qxl.inf: simplify by having FeatureScore for everyone

I forgot to mention in the cover letter: I fixed the comment here per old review by Yonit. Review appreciated! On 04/30/2014 05:40 PM, Alon Levy wrote: > FeatureScore is the only difference between the _vista options and the > rest, so just setting it also for windows xp using drivers results in

[Spice-devel] [PATCH 10/12] xddm/display/amd64: implement Save/RestoreFPU & fast_memcpy_*

Some notes: Follows AMD64 calling conventions. Uses masm 64 (ml64.exe). Dropped in the next patches because it is too slow. --- xddm/display/amd64/x64.asm | 236 + xddm/display/res.c | 13 +-- 2 files changed, 241 insertions(+), 8 deletions(-)

[Spice-devel] [PATCH 11/12] add benchmarks for memcpy (RtlCopyMemory) vs fast - fast is slower

Two benchmarks: 1. standalone, actually uses LIBCMT's memcpy to compare. 2. Part of qxldd.dll (in display/res.c called from display/driver.c) so using the same implementation. Note: next commit removes benchmark code as well as fast_memcpy_* code and related SSE check and FPU save/restore. Result

[Spice-devel] [PATCH 09/12] xddm/display/amd64: implement CheckAndSetSSE2

--- xddm/display/amd64/x64.asm | 13 + xddm/display/res.c | 4 2 files changed, 17 insertions(+) diff --git a/xddm/display/amd64/x64.asm b/xddm/display/amd64/x64.asm index e32b0df..36971d3 100644 --- a/xddm/display/amd64/x64.asm +++ b/xddm/display/amd64/x64.asm @@ -1 +1,

[Spice-devel] [PATCH 12/12] display: use RtlCopyMemory instead of fast_memcpy_*

It is common practice to use RtlCopyMemory. Currently it is defined by the preprocessor to be memcpy, which outperforms our implementation, see previous benchmark commit. This commit removes the benchmarks and our internal implementation in favor of RtlCopyMemory. RHBZ: 705785 --- xddm/build.bat

[Spice-devel] [PATCH 01/12] Revert "miniport: halve QXL_IO_UPDATE_IRQ calls"

From: Yonit Halperin This reverts commit 49feefa95d3595f04355c4aed53ec5bf26551046. The patch causes the display to get stuck. Till we understand exactly why, I'm reverting it. --- xddm/miniport/qxl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xddm/miniport/qxl.c b/xddm/miniport/qxl.c in

[Spice-devel] [PATCH 07/12] xddm/display/res.c: move ALIGN out of Save/RestoreFPU for easier amd64 implementation

--- xddm/display/res.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/xddm/display/res.c b/xddm/display/res.c index bfb3571..289ece5 100644 --- a/xddm/display/res.c +++ b/xddm/display/res.c @@ -1811,13 +1811,11 @@ static void FreeBitmapImage(PDev *pdev, Resourc

[Spice-devel] [PATCH 00/12] Fix 705785 (remove fast_memcpy_*)

This patchset ultimately does a little cleanup and mainly removes all inline assembly that was used to supposedly have a faster memcpy implementation. The patchset includes an amd64 implementation of the fast_memcpy_aligned and fast_memcpy_unaligned functions and benchmarks comparing them to RtlCo

[Spice-devel] [PATCH 04/12] display\driver.c: remove unused FlotaToFixed

--- xddm/display/driver.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/xddm/display/driver.c b/xddm/display/driver.c index aa4fe42..5a3dbfa 100644 --- a/xddm/display/driver.c +++ b/xddm/display/driver.c @@ -1252,20 +1252,6 @@ char *BitmapTypeToStr(int type) #include "utils.h

[Spice-devel] [PATCH 03/12] display/res.h: remove whitespace at EOF

--- xddm/display/res.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xddm/display/res.h b/xddm/display/res.h index 6ce9a68..4d179c5 100644 --- a/xddm/display/res.h +++ b/xddm/display/res.h @@ -74,4 +74,4 @@ void EmptyReleaseRing(PDev *pdev); void InitDeviceMemoryResources(PD

[Spice-devel] [PATCH 06/12] build.bat: more verbose build

--- xddm/build.bat | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xddm/build.bat b/xddm/build.bat index 7dfe51b..b2c5149 100755 --- a/xddm/build.bat +++ b/xddm/build.bat @@ -30,9 +30,10 @@ if not x%1 == x set DEST=%1 :build cd miniport -build -cZg +build -ceZg cd ../

[Spice-devel] [PATCH 08/12] adding initial empty AMD64 only external asm file

--- xddm/display/amd64/x64.asm | 1 + xddm/display/sources | 1 + 2 files changed, 2 insertions(+) create mode 100644 xddm/display/amd64/x64.asm diff --git a/xddm/display/amd64/x64.asm b/xddm/display/amd64/x64.asm new file mode 100644 index 000..e32b0df --- /dev/null +++ b/xddm/display

[Spice-devel] [PATCH 02/12] miniport/qxl.inf: simplify by having FeatureScore for everyone

FeatureScore is the only difference between the _vista options and the rest, so just setting it also for windows xp using drivers results in a simplification of the inf file, and no downside. According to [1] we use a feature score of FC to indicate a windows 2000 display driver [1] http://msdn.m

[Spice-devel] [PATCH 05/12] build.bat: fix copy to install dir for amd64

--- xddm/build.bat | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/xddm/build.bat b/xddm/build.bat index 1d19875..7dfe51b 100755 --- a/xddm/build.bat +++ b/xddm/build.bat @@ -16,6 +16,12 @@ if not DEFINED SPICE_COMMON_DIR ( set SPICE_COMMON_DIR=%CD%\..\spice-p

[Spice-devel] spice 0.12.4 / qemu 2.0.0 / redhat spice agent / html5

Hello, for your attention, one more test : spice 0.12.4 + qemu 2.0.0 + redhat spice agent windows seven guest connection with html5 client : when windows guest reboot, qemu ? receive a shutdown , and vm poweroff connection with spice-gtk client : no shutdown receive, vm reboot same test with qem