Re: [Spice-devel] [PATCH spice-gtk 08/14] usb: remove useless device ref/unref

2014-04-28 Thread Jonathon Jongsma
ACK - Original Message - > From: "Marc-André Lureau" > To: "Jonathon Jongsma" > Cc: "spice-devel" > Sent: Monday, April 28, 2014 12:40:20 PM > Subject: Re: [Spice-devel] [PATCH spice-gtk 08/14] usb: remove useless device > ref/unref > > Since the device can be removed from devices, wh

Re: [Spice-devel] [PATCH spice-gtk 08/14] usb: remove useless device ref/unref

2014-04-28 Thread Marc-André Lureau
Since the device can be removed from devices, while the async is till being performed, I changed the commit that way: commit 1542b1103c4a8df27eadd281501b39d2678117f1 Author: Marc-André Lureau Date: Wed Apr 23 17:24:09 2014 +0200 usb: unref the device when it is no longer needed The cu

Re: [Spice-devel] [PATCH spice-gtk 08/14] usb: remove useless device ref/unref

2014-04-28 Thread Marc-André Lureau
On Mon, Apr 28, 2014 at 7:01 PM, Jonathon Jongsma wrote: > > > - Original Message - > > From: "Marc-André Lureau" > > To: "Jonathon Jongsma" > > Cc: "Uri Lublin" , "Marc-André Lureau" < > mlur...@redhat.com>, spice-de...@freedesktop.org > > Sent: Monday, April 28, 2014 11:54:03 AM > > Su

Re: [Spice-devel] [PATCH spice-gtk 08/14] usb: remove useless device ref/unref

2014-04-28 Thread Jonathon Jongsma
- Original Message - > From: "Marc-André Lureau" > To: "Jonathon Jongsma" > Cc: "Uri Lublin" , "Marc-André Lureau" , > spice-de...@freedesktop.org > Sent: Monday, April 28, 2014 11:54:03 AM > Subject: Re: [Spice-devel] [PATCH spice-gtk 08/14] usb: remove useless device > ref/unref >

Re: [Spice-devel] [PATCH spice-gtk 08/14] usb: remove useless device ref/unref

2014-04-28 Thread Marc-André Lureau
On Mon, Apr 28, 2014 at 6:48 PM, Jonathon Jongsma wrote: > - Original Message - > > From: "Marc-André Lureau" > > To: "Uri Lublin" > > Cc: "Marc-André Lureau" , > spice-de...@freedesktop.org > > Sent: Monday, April 28, 2014 9:49:59 AM > > Subject: Re: [Spice-devel] [PATCH spice-gtk 08/14

Re: [Spice-devel] [PATCH spice-gtk 08/14] usb: remove useless device ref/unref

2014-04-28 Thread Jonathon Jongsma
- Original Message - > From: "Marc-André Lureau" > To: "Uri Lublin" > Cc: "Marc-André Lureau" , spice-de...@freedesktop.org > Sent: Monday, April 28, 2014 9:49:59 AM > Subject: Re: [Spice-devel] [PATCH spice-gtk 08/14] usb: remove useless > device ref/unref > > > On Mon, Apr 28,

Re: [Spice-devel] [PATCH spice-gtk 08/14] usb: remove useless device ref/unref

2014-04-28 Thread Marc-André Lureau
On Mon, Apr 28, 2014 at 4:42 PM, Uri Lublin wrote: > On 04/28/2014 03:49 PM, Marc-André Lureau wrote: > >> >> - Original Message - >> >>> On 04/23/2014 09:09 PM, Marc-André Lureau wrote: >>> A code doing an unref() on an object just before manipulating it looks horribly suspicio

Re: [Spice-devel] [PATCH spice-gtk 08/14] usb: remove useless device ref/unref

2014-04-28 Thread Uri Lublin
On 04/28/2014 03:49 PM, Marc-André Lureau wrote: - Original Message - On 04/23/2014 09:09 PM, Marc-André Lureau wrote: A code doing an unref() on an object just before manipulating it looks horribly suspicious... Suspicious indeed. But probably it's better to move the unref below ins

Re: [Spice-devel] spice 0.12.4 and qemu 2.0.0 : bad video perfomance

2014-04-28 Thread nicolas prochazka
Hello, thanks to point this . with: video is ok , qemu 2.0.0 manpage does not reflect the default streaming mode ( off) with qemu 2.0.0 , i need to setup, without the sound is very bad , not in with qemu 1.7.1 , is it a default parameter change ? Regards, Nicolas Prochazka. 2014-04-2

Re: [Spice-devel] [PATCH spice-gtk 00/14] USB fail early on win32 without usbclerk v2

2014-04-28 Thread Cody Chan
Hi, thx for your great work, I wonder when these patches will be in git upstream? On Thu, Apr 24, 2014 at 11:50 PM, Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > Hi, > > Here is a small series, of little cleanups, and of goal to throw early > an error when the win32 usbclerk can't be

Re: [Spice-devel] [PATCH] how can i trace monitor change (etc) events

2014-04-28 Thread Greg Sheremeta
Hi David, Did you open a BZ for this yet? It'll help the issue get more visibility. Thanks, Greg - Original Message - > From: "David Mansfield" > To: spice-devel@lists.freedesktop.org > Sent: Wednesday, April 23, 2014 9:45:46 AM > Subject: Re: [Spice-devel] [PATCH] how can i trace monit

Re: [Spice-devel] spice 0.12.4 and qemu 2.0.0 : bad video perfomance

2014-04-28 Thread Gerd Hoffmann
On Mo, 2014-04-28 at 08:40 -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > Hello, > > For your attention, > > I'm running two tests > > > > spice 0.12.4 + qemu 2.0.0 ( stable ) > > in window guest, watch a video stream ( youtube , or local divx) is a > > bad experience

Re: [Spice-devel] [PATCH spice-gtk 08/14] usb: remove useless device ref/unref

2014-04-28 Thread Marc-André Lureau
- Original Message - > On 04/23/2014 09:09 PM, Marc-André Lureau wrote: > > A code doing an unref() on an object just before manipulating it looks > > horribly suspicious... > > Suspicious indeed. > > But probably it's better to move the unref below instead of removing the > ref/unref (

Re: [Spice-devel] [PATCH spice-gtk 08/14] usb: remove useless device ref/unref

2014-04-28 Thread Uri Lublin
On 04/23/2014 09:09 PM, Marc-André Lureau wrote: A code doing an unref() on an object just before manipulating it looks horribly suspicious... Suspicious indeed. But probably it's better to move the unref below instead of removing the ref/unref (see below). A device is ref'ed when install/u

Re: [Spice-devel] spice 0.12.4 and qemu 2.0.0 : bad video perfomance

2014-04-28 Thread Marc-André Lureau
Hi - Original Message - > Hello, > For your attention, > I'm running two tests > > spice 0.12.4 + qemu 2.0.0 ( stable ) > in window guest, watch a video stream ( youtube , or local divx) is a > bad experience > - sound seems to be desynchronised > - video is very jerky > > spice 0.12.

[Spice-devel] spice 0.12.4 and qemu 2.0.0 : bad video perfomance

2014-04-28 Thread nicolas prochazka
Hello, For your attention, I'm running two tests spice 0.12.4 + qemu 2.0.0 ( stable ) in window guest, watch a video stream ( youtube , or local divx) is a bad experience - sound seems to be desynchronised - video is very jerky spice 0.12.4 + qemu 1.7.1 same test, same vm, same spice-gtk, jus

Re: [Spice-devel] spice scroll problem

2014-04-28 Thread Marc-André Lureau
- Original Message - > Hi, > i cannot get scroll events from xev screen. and I guess > remote-viewer is in client mode: > > > > I am not sure what this option really do. In any case, being in client or server mouse mode shouldn't change the events being sent, it should work in b

Re: [Spice-devel] [PATCH] Make use of the new playback rate interface, if available.

2014-04-28 Thread Andrew Eikum
On Mon, Apr 28, 2014 at 07:04:04AM -0500, Jeremy White wrote: > >> /* disable CELT */ > >> ret = spice_server_set_playback_compression(qxl->spice_server, 0); > >> if (ret < 0) > >> return errno; > >This codepath disables compression for some reason, should we do the > >same

Re: [Spice-devel] [PATCH] Make use of the new playback rate interface, if available.

2014-04-28 Thread Jeremy White
/* disable CELT */ ret = spice_server_set_playback_compression(qxl->spice_server, 0); if (ret < 0) return errno; This codepath disables compression for some reason, should we do the same in the newer codepath? I don't think it's a valuable code path; in fact, I fear

Re: [Spice-devel] spice scroll problem

2014-04-28 Thread Marc-André Lureau
Hi - Original Message - > Hi, > i use spice client for my kvm virtual environment. Everything is perfect > except mouse scroll. > I use spice-vdagent in my guest. > > and this is spice related xml script: > > > > > > > > > > > > > > I can get output with scroll event from /de

Re: [Spice-devel] [PATCH spice-gtk 00/14] USB fail early on win32 without usbclerk

2014-04-28 Thread Marc-André Lureau
Hi On Mon, Apr 28, 2014 at 12:35 PM, Uri Lublin wrote: > On 04/23/2014 09:09 PM, Marc-André Lureau wrote: > >> Hi, >> >> Here is a small series, of little cleanups, and of goal to throw early >> an error when the win32 usbclerk can't be reached. In turn, the error >> can be catched by client cod

Re: [Spice-devel] [PATCH spice-gtk 00/14] USB fail early on win32 without usbclerk

2014-04-28 Thread Uri Lublin
On 04/23/2014 09:09 PM, Marc-André Lureau wrote: Hi, Here is a small series, of little cleanups, and of goal to throw early an error when the win32 usbclerk can't be reached. In turn, the error can be catched by client code to show a useful dialog. Hi Marc-Andre, Thanks for taking the time to

[Spice-devel] spice scroll problem

2014-04-28 Thread Fırat KÜÇÜK
Hi, i use spice client for my kvm virtual environment. Everything is perfect except mouse scroll. I use spice-vdagent in my guest. and this is spice related xml script: I can get output with scroll event from /dev/input/mice. and this is the kern

Re: [Spice-devel] aSPICE/Opaque can now record audio

2014-04-28 Thread Marc-André Lureau
Hi - Original Message - > Hello SPICE devs, > > A user of aSPICE (and by extension Opaque) reported that with audio > recording enabled, the client continually records and sends data to > the server thereby wasting large amounts of bandwidth. This wouldn't > really be an issue for deskto

Re: [Spice-devel] [PATCH] Make use of the new playback rate interface, if available.

2014-04-28 Thread Christophe Fergeau
Hey, This has been pushed already, but I had one question: On Mon, Apr 21, 2014 at 09:39:49AM -0500, Jeremy White wrote: > --- > src/spiceqxl_audio.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/src/spiceqxl_audio.c b/src/spiceqxl_audio.c > index 5b87

Re: [Spice-devel] [PATCH] Mark sw_canvas.[ch] as automake source files

2014-04-28 Thread Christophe Fergeau
Ping? On Tue, Apr 22, 2014 at 03:45:35PM +0200, Christophe Fergeau wrote: > These 2 files are not build as part of spice-common > build system, but modules using spice-common will build > them with the appropriate options. We need to let automake > know that these are source files so that it can