Re: [Spice-devel] 0001-a patch for syncing keyboard lock status

2014-03-26 Thread Jonathon Jongsma
Hello, Thanks for the patch. First, a general comment: it's helpful if you write a few more details in the commit message. I can't tell exactly what bug you are trying to fix, what conditions trigger the bug, or what the expected behavior is. Knowing these things will make it easier to review th

Re: [Spice-devel] patch[1/1] fix a memory leak in qxl_screen_init

2014-03-26 Thread longguang.yue
please forgive my ignore. jwhite you are right, i post a new patch as you suggest. thanks At 2013-11-19 20:21:35,"Marian Krcmarik" wrote: >ping.. > >"bigclouds", >are you willing to finish the patch and address Jeremy's comment? It's imo >worthy to fix and It would be nice If you can f

Re: [Spice-devel] patch[1/1] fix a memory leak in qxl_screen_init

2014-03-26 Thread longguang.yue
please forgive my ignore. jwhite you are right, i post a new patch as you suggest. thanks At 2013-11-19 20:21:35,"Marian Krcmarik" wrote: >ping.. > >"bigclouds", >are you willing to finish the patch and address Jeremy's comment? It's imo >worthy to fix and It would be nice If you can fi

[Spice-devel] Automatic spice port selection

2014-03-26 Thread Fabio Fantoni
Time ago I have read somewhere that there is an option to automatically spice port in qemu as for vnc. I started to write a libxl patch to add this feature like the vnc one: https://github.com/Fantu/Xen/commit/63c54f354a34e7eb27b1c69016789a372a75843c Testing this patch lead to a missing "to=" pa

[Spice-devel] 0001-a patch for syncing keyboard lock status

2014-03-26 Thread bigclouds
thanks 0001-there-is-only-few-oppotunity-one-or-two-to-sync-keyb.patch Description: Binary data ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [vdagent-win V2 4/6] Fix Visual Studio compiler warning (sscanf/strcat)

2014-03-26 Thread Christophe Fergeau
On Wed, Mar 26, 2014 at 03:01:25PM +0100, Christophe Fergeau wrote: > One bit I did not get right yet is that a standalone test program and the > AC_CHECK_FUNCS() call can successfully use sscanf_s, but trying to use it > in file-xfer.c results in a compilation failure, not quite sure about the > d

Re: [Spice-devel] [vdagent-win V2 4/6] Fix Visual Studio compiler warning (sscanf/strcat)

2014-03-26 Thread Christophe Fergeau
Hey, Finally received 4/6 ;) On Mon, Mar 24, 2014 at 07:02:41PM +0200, Uri Lublin wrote: > This commit partially reverts 4b9e9b1d28ea7eaec44ff73e2f91c4064986b12a. > > Visual Studio complains about non-safe sscanf and strcat: > vdagent\file_xfer.cpp(89) : warning C4996: 'strcat': This functio

Re: [Spice-devel] spice client using Certificate and ipv6 question

2014-03-26 Thread David Jaša
On St, 2014-03-26 at 09:05 +0800, bigclouds wrote: > all the cases you mentioned have been tested. > > spice://[%eth0]?tls-port=5901 , failed > g_proxy_resolver_lookup_async: assertion uri != NULL failed > That's the "scope lost" bugs I mentioned in spice-gtk: https://bugzilla.redhat.com/s

Re: [Spice-devel] [vdagent-win V2 3/6] Fix Visual Studio compiler warning (strncpy)

2014-03-26 Thread Uri Lublin
On 03/26/2014 02:05 PM, Christophe Fergeau wrote: On Mon, Mar 24, 2014 at 07:02:40PM +0200, Uri Lublin wrote: Visual Studio complains: vdagent\file_xfer.h(28) : warning C4996: 'strncpy': This function or variable may be unsafe. Consider using strncpy_s instead. To disable depreca

Re: [Spice-devel] [vdagent-win V2 3/6] Fix Visual Studio compiler warning (strncpy)

2014-03-26 Thread Christophe Fergeau
On Mon, Mar 24, 2014 at 07:02:40PM +0200, Uri Lublin wrote: > Visual Studio complains: > vdagent\file_xfer.h(28) : warning C4996: 'strncpy': This function or > variable may be unsafe. > Consider using strncpy_s instead. > To disable deprecation, use _CRT_SECURE_NO_WARNINGS. > See o

Re: [Spice-devel] spice client using Certificate and ipv6 question

2014-03-26 Thread Christophe Fergeau
On Wed, Mar 26, 2014 at 09:05:23AM +0800, bigclouds wrote: > all the cases you mentioned have been tested. > > spice://[%eth0]?tls-port=5901 , failed > g_proxy_resolver_lookup_async: assertion uri != NULL failed I'd first get IPv4 + TLS to work, or IPv6 + non-TLS to work, I would not try to

Re: [Spice-devel] [PATCH] Use a2x instead of asciidoc

2014-03-26 Thread Christophe Fergeau
On Tue, Mar 25, 2014 at 05:47:21PM +0100, Marc-André Lureau wrote: > On Tue, Mar 25, 2014 at 4:15 PM, Christophe Fergeau > wrote: > > > + $(AM_V_GEN) $(A2X) -f xhtml $(A2X_FLAGS) $< > > > if you can manage to get syntax highlighting working, then ok. Otherwise we > should keep asciidoc wh

Re: [Spice-devel] [vdagent-win V2 1/6] Fix building with Visual Studio (inttypes.h)

2014-03-26 Thread Christophe Fergeau
On Tue, Mar 25, 2014 at 07:27:18PM +0200, Uri Lublin wrote: > I think that even when building with Visual Studio 2013, there should > be no problem with this patch as inttypes.h will not be included, so > PRIu64 should not be already defined (and redefined by this patch). inttypes.h could get pull