Re: [Spice-devel] spice client using Certificate and ipv6 question

2014-03-25 Thread bigclouds
all the cases you mentioned have been tested. spice://[%eth0]?tls-port=5901 , failed g_proxy_resolver_lookup_async: assertion uri != NULL failed 在 2014-03-25 19:20:12,"David Jaša" 写道: >Hi, > >On Út, 2014-03-25 at 09:50 +0100, Christophe Fergeau wrote: >> On Tue, Mar 25, 2014 at 09:45:5

Re: [Spice-devel] spice client using Certificate and ipv6 question

2014-03-25 Thread Christophe Fergeau
On Tue, Mar 25, 2014 at 12:20:12PM +0100, David Jaša wrote: > There used to be another bug about scope being stripped from the uris in > glib, I'm not sure about its status in .el6 though. This is still broken in el6 as far as I know. Christophe pgpsHx64Z60Vl.pgp Description: PGP signature ___

Re: [Spice-devel] [PATCH 1/7] Introduce reds_stream_async_read() helper

2014-03-25 Thread Christophe Fergeau
On Tue, Mar 25, 2014 at 11:58:40AM +0100, Marc-André Lureau wrote: > On Mon, Mar 17, 2014 at 2:20 PM, Christophe Fergeau > wrote: > > @@ -449,6 +446,23 @@ void async_read_handler(int fd, int event, void *data) > > } > > } > > > > +void reds_stream_async_read(RedsStream *stream, > > +

Re: [Spice-devel] [vdagent-win V2 1/6] Fix building with Visual Studio (inttypes.h)

2014-03-25 Thread Uri Lublin
On 03/25/2014 11:11 AM, Christophe Fergeau wrote: On Mon, Mar 24, 2014 at 07:02:38PM +0200, Uri Lublin wrote: As a followup of commit 462295d9f84658aa7. Building with Visual Studio, fails as there is no inttypes.h file: vdagent\file_xfer.cpp(21) : fatal error C1083: Cannot open include fi

[Spice-devel] [PATCH 3/2] marshaller: Use #include <> for headers in $srcdir/common

2014-03-25 Thread Christophe Fergeau
Since the (de)marshallers are now generated in $builddir and not in $srcdir, when these generated files include a file located in $srcdir/common, the compiler will find them thanks to a -I directive, so it makes more sense to use <> rather than "" when including them. --- Hey, I finally got what y

[Spice-devel] spice-gtk release v0.24

2014-03-25 Thread Marc-André Lureau
Hi! The Spice team is pleased to release a new spice-gtk version 0.24, with the following highlights: - support folder sharing, via WebDAV channel - add HTTPS proxy support (requires glib 2.28), and Basic auth - add SPICE_GTK_CHECK_VERSION macro - advertise SASL capability early (to help fips-ena

Re: [Spice-devel] [PATCH] Use a2x instead of asciidoc

2014-03-25 Thread Marc-André Lureau
On Tue, Mar 25, 2014 at 4:15 PM, Christophe Fergeau wrote: > + $(AM_V_GEN) $(A2X) -f xhtml $(A2X_FLAGS) $< if you can manage to get syntax highlighting working, then ok. Otherwise we should keep asciidoc which produces better looking results (no need for intermediate docbook conversion)

Re: [Spice-devel] [PATCH] migration: Don't assert() if MIGRATE_DATA comes before attaching the agent

2014-03-25 Thread Christophe Fergeau
Hey, On Tue, Mar 18, 2014 at 01:06:20PM +0200, Uri Lublin wrote: > > Hi Christophe, > > I'm concerned that reds_agent_state_restore() is called after > spice_char_device_start() I think the position for the call to reds_agent_state_restore() was quite arbitrary and that I should be able to move

[Spice-devel] [PATCH] Use a2x instead of asciidoc

2014-03-25 Thread Christophe Fergeau
This lets us generate a chunked (multipage) HTML doc in addition to the single page one. --- configure.ac| 12 ++-- docs/manual/Makefile.am | 6 -- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index 53d05a2..224b608 100644 ---

Re: [Spice-devel] [PATCH 2/2] Use #include "common/..." in (de)marshallers

2014-03-25 Thread Marc-André Lureau
- Original Message - > On Wed, Mar 19, 2014 at 05:52:23PM +0100, Christophe Fergeau wrote: > > On Wed, Mar 19, 2014 at 05:40:39PM +0100, Marc-André Lureau wrote: > > > On Wed, Mar 19, 2014 at 5:35 PM, Christophe Fergeau > > > wrote: > > > > > > > Hey, > > > > > > > > On Wed, Mar 19, 2014

Re: [Spice-devel] [PATCH 2/2] Use #include "common/..." in (de)marshallers

2014-03-25 Thread Christophe Fergeau
On Wed, Mar 19, 2014 at 05:52:23PM +0100, Christophe Fergeau wrote: > On Wed, Mar 19, 2014 at 05:40:39PM +0100, Marc-André Lureau wrote: > > On Wed, Mar 19, 2014 at 5:35 PM, Christophe Fergeau > > wrote: > > > > > Hey, > > > > > > On Wed, Mar 19, 2014 at 05:25:48PM +0100, Marc-André Lureau wrote:

Re: [Spice-devel] [PATCH 3/3] Don't set SpiceLinkReply::pub_key if client advertises SASL cap

2014-03-25 Thread Christophe Fergeau
On Thu, Mar 20, 2014 at 11:23:07AM +0100, Christophe Fergeau wrote: > If the client advertises the SASL cap, it means it guarantees it will be > able to use SASL if the server supports, and that it does not need a valid > SpiceLinkReply::pub_key field when using SASL. > > When the client cap is s

Re: [Spice-devel] [PATCH 2.5/7] Call AsyncRead variables 'async' instead of 'obj'

2014-03-25 Thread Marc-André Lureau
ack On Tue, Mar 25, 2014 at 2:23 PM, Christophe Fergeau wrote: > This is a more explicit name. > --- > > This goes after PATCH 2/7 and renames all 'obj' variables. > > server/reds_stream.c | 60 > ++-- > 1 file changed, 30 insertions(+), 30 deleti

[Spice-devel] [PATCH 2.5/7] Call AsyncRead variables 'async' instead of 'obj'

2014-03-25 Thread Christophe Fergeau
This is a more explicit name. --- This goes after PATCH 2/7 and renames all 'obj' variables. server/reds_stream.c | 60 ++-- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/server/reds_stream.c b/server/reds_stream.c index 50660e8..

Re: [Spice-devel] [PATCH 2/7] Add reds_stream_set_async_error_handler() helper

2014-03-25 Thread Christophe Fergeau
On Tue, Mar 25, 2014 at 12:00:42PM +0100, Marc-André Lureau wrote: > Ok, still unused. I am not sure why this should be move higher up in > classes (why at AsyncRead it wasn't nice enough)? I've changed the log to Add reds_stream_set_async_error_handler() helper This replaces async_read_

Re: [Spice-devel] [PATCH 2/7] Add reds_stream_set_async_error_handler() helper

2014-03-25 Thread Marc-André Lureau
- Original Message - > Hey, > > On Tue, Mar 25, 2014 at 12:00:42PM +0100, Marc-André Lureau wrote: > > Ok, still unused. I am not sure why this should be move higher up in > > classes (why at AsyncRead it wasn't nice enough)? > > We can pass the error_handler to each reds_stream_async_r

Re: [Spice-devel] [PATCH 2/7] Add reds_stream_set_async_error_handler() helper

2014-03-25 Thread Christophe Fergeau
Hey, On Tue, Mar 25, 2014 at 12:00:42PM +0100, Marc-André Lureau wrote: > Ok, still unused. I am not sure why this should be move higher up in > classes (why at AsyncRead it wasn't nice enough)? We can pass the error_handler to each reds_stream_async_read() call, but as we will be using the same

Re: [Spice-devel] spice client using Certificate and ipv6 question

2014-03-25 Thread David Jaša
Hi, On Út, 2014-03-25 at 09:50 +0100, Christophe Fergeau wrote: > On Tue, Mar 25, 2014 at 09:45:54AM +0800, bigclouds wrote: > > centos6.3 > > spice-gtk-0.20-11.el6.x86_64 > > spice-server-0.12.2-1.el6.x86_64 > > spice-glib-0.20-11.el6.x86_64 > > virt-viewer-0.5.6-8.el6.x86_64 > > > > > > i th

Re: [Spice-devel] [PATCH 7/7] Add missing buffer (re)allocation to reds_sasl_handle_auth_steplen()

2014-03-25 Thread Marc-André Lureau
ack On Mon, Mar 17, 2014 at 2:20 PM, Christophe Fergeau wrote: > We need to make sure we have a buffer big enough to accomodate the data > sent by the coming SASL step. > --- > server/reds_stream.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/server/reds_stream.c b/server/reds_strea

Re: [Spice-devel] [PATCH 6/7] Call correct SASL helper in reds_handle_auth_sasl_step

2014-03-25 Thread Marc-André Lureau
indeed, ack On Mon, Mar 17, 2014 at 2:20 PM, Christophe Fergeau wrote: > sasl_handle_auth_start() was called instead of reds_sasl_handle_auth_step() > --- > server/reds.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/server/reds.c b/server/reds.c > index c1c0efc..fb2a

Re: [Spice-devel] [PATCH 5/7] Add G_GNUC_UNUSED annotations to async_read_handler args

2014-03-25 Thread Marc-André Lureau
ack On Mon, Mar 17, 2014 at 2:20 PM, Christophe Fergeau wrote: > 2 of the arguments are not used, the G_GNUC_UNUSED annotation will make > this explicit. > --- > server/reds_stream.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/server/reds_stream.c b/server/reds_s

Re: [Spice-devel] [PATCH 4/7] Make struct AsyncRead/async_read_handler private

2014-03-25 Thread Marc-André Lureau
ack On Mon, Mar 17, 2014 at 2:20 PM, Christophe Fergeau wrote: > All users are now contained in reds_stream.c > --- > server/reds_stream.c | 12 +++- > server/reds_stream.h | 11 --- > 2 files changed, 11 insertions(+), 12 deletions(-) > > diff --git a/server/reds_stream.c b/ser

Re: [Spice-devel] [PATCH 3/7] Remove RedLinkInfo::async_read

2014-03-25 Thread Marc-André Lureau
that makes sense, ack On Mon, Mar 17, 2014 at 2:20 PM, Christophe Fergeau wrote: > 9feed69 moved the async reader code to RedsStream so that it can be used > for the SASL authentication code. In particular, it introduced a > RedsStream::async_read member which is used by the SASL authentication

Re: [Spice-devel] [PATCH 2/7] Add reds_stream_set_async_error_handler() helper

2014-03-25 Thread Marc-André Lureau
Ok, still unused. I am not sure why this should be move higher up in classes (why at AsyncRead it wasn't nice enough)? On Mon, Mar 17, 2014 at 2:20 PM, Christophe Fergeau wrote: > This replaces async_read_set_error_handler() which was unused. This sets a > callback to be called when an async ope

Re: [Spice-devel] [PATCH 1/7] Introduce reds_stream_async_read() helper

2014-03-25 Thread Marc-André Lureau
On Mon, Mar 17, 2014 at 2:20 PM, Christophe Fergeau wrote: > This will allow to make RedsStream::async_read private > --- > server/reds_stream.c | 77 > +++- > server/reds_stream.h | 2 ++ > 2 files changed, 36 insertions(+), 43 deletions(-) > > di

Re: [Spice-devel] Releasing ownership of Spice components in Fedora

2014-03-25 Thread Christophe Fergeau
On Tue, Mar 25, 2014 at 10:51:39AM +0100, Christophe Fergeau wrote: > On Fri, Mar 21, 2014 at 02:51:22PM +0100, Hans de Goede wrote: > > ping ? (for the spice-vdagent bits) > > Took it then since noone else volunteered. Forgot to mention that I did not pick the EPEL5 package. Christophe pgpzto

Re: [Spice-devel] Releasing ownership of Spice components in Fedora

2014-03-25 Thread Christophe Fergeau
Hey, On Fri, Mar 21, 2014 at 02:51:22PM +0100, Hans de Goede wrote: > Hi all, > > On 03/17/2014 10:08 AM, Hans de Goede wrote: > > I've just released the following components: > > > > https://admin.fedoraproject.org/pkgdb/acls/name/spice > > https://admin.fedoraproject.org/pkgdb/acls/name/spice-

Re: [Spice-devel] [PATCH 0/7] Fix SASL

2014-03-25 Thread Christophe Fergeau
Ping? Christophe On Mon, Mar 17, 2014 at 02:20:34PM +0100, Christophe Fergeau wrote: > The RedsStream refactoring broke SASL :( This series fixes that, first by > finishing the move of async reads to RedsStream, and then by using this to > start fixing SASL auth. 2 more commits are necessary to f

Re: [Spice-devel] [vdagent-win V2 0/6] Fix compilation error/warnings

2014-03-25 Thread Christophe Fergeau
I did not get patch 4/6 (sscanf/strcat), I commented on 1/6, ACK to the other ones. Christophe On Mon, Mar 24, 2014 at 07:02:37PM +0200, Uri Lublin wrote: > Changes from v1: Better log messages > The VS patch of V1 is now multiple patches > > Uri Lublin (6): > Fix building wit

Re: [Spice-devel] spice-gtk v.23 build issues under a 32bit Gentoo Linux

2014-03-25 Thread Toralf Förster
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 03/24/2014 10:24 AM, Christophe Fergeau wrote: > On Sun, Mar 23, 2014 at 10:37:48PM +0100, Toralf Förster wrote: >> Maybe I've to dive into the ebuild for the (rather complicated) >> configure step of the Gentoo ebuild - OTOH I'm just wondering if

Re: [Spice-devel] [vdagent-win V2 1/6] Fix building with Visual Studio (inttypes.h)

2014-03-25 Thread Christophe Fergeau
Hey, On Mon, Mar 24, 2014 at 07:02:38PM +0200, Uri Lublin wrote: > As a followup of commit 462295d9f84658aa7. > > Building with Visual Studio, fails as there is no inttypes.h file: > vdagent\file_xfer.cpp(21) : fatal error C1083: Cannot open > include file: 'inttypes.h': No such file or direc

Re: [Spice-devel] spice client using Certificate and ipv6 question

2014-03-25 Thread Christophe Fergeau
On Tue, Mar 25, 2014 at 09:45:54AM +0800, bigclouds wrote: > centos6.3 > spice-gtk-0.20-11.el6.x86_64 > spice-server-0.12.2-1.el6.x86_64 > spice-glib-0.20-11.el6.x86_64 > virt-viewer-0.5.6-8.el6.x86_64 > > > i think the problem is related to spice-glib, g_network_address_new. maybe > glib has

Re: [Spice-devel] spice-gtk v.23 build issues under a 32bit Gentoo Linux

2014-03-25 Thread Christophe Fergeau
On Mon, Mar 24, 2014 at 06:52:29PM +0100, Toralf Förster wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > On 03/24/2014 10:24 AM, Christophe Fergeau wrote: > > On Sun, Mar 23, 2014 at 10:37:48PM +0100, Toralf Förster wrote: > >> Maybe I've to dive into the ebuild for the (rather comp