Re: [Spice-devel] Mouse mode client vs Mouse mode server

2014-03-17 Thread Lindsay Mathieson
On Mon, 17 Mar 2014 11:21:50 AM Alon Levy wrote: > client/server mode has the client/server determine the location of the > cursor and render it. So client mode has better mouse responsiveness, > especially with high latency. A spice agent (vdagent) is required for > client mode. Thought that mig

[Spice-devel] [PATCH 7/7] Add missing buffer (re)allocation to reds_sasl_handle_auth_steplen()

2014-03-17 Thread Christophe Fergeau
We need to make sure we have a buffer big enough to accomodate the data sent by the coming SASL step. --- server/reds_stream.c | 1 + 1 file changed, 1 insertion(+) diff --git a/server/reds_stream.c b/server/reds_stream.c index 8476066..0b06771 100644 --- a/server/reds_stream.c +++ b/server/reds_

[Spice-devel] [PATCH 4/7] Make struct AsyncRead/async_read_handler private

2014-03-17 Thread Christophe Fergeau
All users are now contained in reds_stream.c --- server/reds_stream.c | 12 +++- server/reds_stream.h | 11 --- 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/server/reds_stream.c b/server/reds_stream.c index cb42561..9041033 100644 --- a/server/reds_stream.c +++

[Spice-devel] [PATCH 2/7] Add reds_stream_set_async_error_handler() helper

2014-03-17 Thread Christophe Fergeau
This replaces async_read_set_error_handler() which was unused. This sets a callback to be called when an async operation fails. --- server/reds_stream.c | 7 +++ server/reds_stream.h | 5 ++--- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/server/reds_stream.c b/server/reds_st

[Spice-devel] [PATCH 3/7] Remove RedLinkInfo::async_read

2014-03-17 Thread Christophe Fergeau
9feed69 moved the async reader code to RedsStream so that it can be used for the SASL authentication code. In particular, it introduced a RedsStream::async_read member which is used by the SASL authentication code for its async operations. However, what was not done is to remove the now redundant

[Spice-devel] [PATCH 5/7] Add G_GNUC_UNUSED annotations to async_read_handler args

2014-03-17 Thread Christophe Fergeau
2 of the arguments are not used, the G_GNUC_UNUSED annotation will make this explicit. --- server/reds_stream.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/server/reds_stream.c b/server/reds_stream.c index 9041033..8476066 100644 --- a/server/reds_stream.c +++ b/server/r

[Spice-devel] [PATCH 0/7] Fix SASL

2014-03-17 Thread Christophe Fergeau
The RedsStream refactoring broke SASL :( This series fixes that, first by finishing the move of async reads to RedsStream, and then by using this to start fixing SASL auth. 2 more commits are necessary to fix 2 more SASL bugs :( Christophe ___ Spice-dev

[Spice-devel] [PATCH 1/7] Introduce reds_stream_async_read() helper

2014-03-17 Thread Christophe Fergeau
This will allow to make RedsStream::async_read private --- server/reds_stream.c | 77 +++- server/reds_stream.h | 2 ++ 2 files changed, 36 insertions(+), 43 deletions(-) diff --git a/server/reds_stream.c b/server/reds_stream.c index 873b953..57eb1

[Spice-devel] [PATCH 6/7] Call correct SASL helper in reds_handle_auth_sasl_step

2014-03-17 Thread Christophe Fergeau
sasl_handle_auth_start() was called instead of reds_sasl_handle_auth_step() --- server/reds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/reds.c b/server/reds.c index c1c0efc..fb2a19b 100644 --- a/server/reds.c +++ b/server/reds.c @@ -1901,7 +1901,7 @@ static void re

Re: [Spice-devel] [PATCH] migration: Don't assert() if MIGRATE_DATA comes before attaching the agent

2014-03-17 Thread Alon Levy
On 02/24/2014 07:44 PM, Christophe Fergeau wrote: > During seamless migration, after switching host, if a client was connected > during the migration, it will have data to send back to the new > qemu/spice-server instance. This is handled through MIGRATE_DATA messages. > SPICE char devices use such

Re: [Spice-devel] [PATCH server] Associate org.spice-space.webdav.0 port to webdav channel

2014-03-17 Thread Christophe Fergeau
On Sun, Mar 16, 2014 at 07:01:16PM +0200, Alon Levy wrote: > On 01/12/2014 07:34 PM, Marc-André Lureau wrote: > > For example, with qemu, a webdav channel can be created this way: > > > > -chardev spiceport,name=org.spice-space.webdav.0,... > > > > And redirected to a virtio port: > > > > -dev

Re: [Spice-devel] wmctrl and spice

2014-03-17 Thread Christophe Fergeau
Hey, On Fri, Mar 14, 2014 at 02:22:03PM -0400, Daniel Rawson wrote: > We have just moved to using SPICE and virt-viewer (as provided by Redhat > with the Redhat Enterprise Virtualization server). In the past I have > used wmctrl to modify windows, move them between desktops, hide them from > the

Re: [Spice-devel] Releasing ownership of Spice components in Fedora

2014-03-17 Thread Christophe Fergeau
On Mon, Mar 17, 2014 at 10:08:27AM +0100, Hans de Goede wrote: > Hi All, > > It seems I was still the owner of various Spice components in Fedora. > > I've just released the following components: > > https://admin.fedoraproject.org/pkgdb/acls/name/spice > https://admin.fedoraproject.org/pkgdb/ac

[Spice-devel] wmctrl and spice

2014-03-17 Thread Daniel Rawson
We have just moved to using SPICE and virt-viewer (as provided by Redhat with the Redhat Enterprise Virtualization server). In the past I have used wmctrl to modify windows, move them between desktops, hide them from the taskbar, etc. but this does not appear to work with version of SPICE tha

Re: [Spice-devel] Mouse mode client vs Mouse mode server

2014-03-17 Thread Alon Levy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/15/2014 06:33 AM, Lindsay Mathieson wrote: > Whats the significance of this? does server mode come into play > when there is no qxl & spice agent in the guest? client/server mode has the client/server determine the location of the cursor and ren

Re: [Spice-devel] [PATCH 1/2] SpiceUserManual.xml: small clean-ups

2014-03-17 Thread Alon Levy
On 03/14/2014 03:48 PM, Marc-André Lureau wrote: > Remove some non-conventional/non-freesoftware editor-specific lines. > > Remove trailing whitespaces > > Get rid of DTD, which is too strict for docbook, see also: > http://docbook.org/tdg5/en/html/ch02.html > > This get rids of the following wa

[Spice-devel] Releasing ownership of Spice components in Fedora

2014-03-17 Thread Hans de Goede
Hi All, It seems I was still the owner of various Spice components in Fedora. I've just released the following components: https://admin.fedoraproject.org/pkgdb/acls/name/spice https://admin.fedoraproject.org/pkgdb/acls/name/spice-vdagent Someone from the team should go to the above urls and pi

Re: [Spice-devel] [PATCH] Don't truncate large 'now' values in _spice_timer_set

2014-03-17 Thread Alon Levy
On 03/10/2014 12:58 PM, Christophe Fergeau wrote: > From: David Gibson > > static void _spice_timer_set(SpiceTimer *timer, uint32_t ms, uint32_t now) > > The _spice_timer_set() function takes a 32-bit integer for the "now" value. > The now value passed in however, can exceed 2^32 (it's in ms and

Re: [Spice-devel] [PATCH spice-common] RFC: spice.proto: add webdav channel

2014-03-17 Thread Alon Levy
On 03/14/2014 06:17 PM, Marc-André Lureau wrote: > If no further comments, can I move ahead adding that new channel? ACK by me. > > On Fri, Feb 28, 2014 at 4:39 PM, David Jaša wrote: >> On Čt, 2014-02-27 at 18:27 +0100, Marc-André Lureau wrote: >>> Hi >>> >>> On Wed, Feb 26, 2014 at 11:00 PM, J

Re: [Spice-devel] [PATCH spice-gtk 1/2] Add webdav channel

2014-03-17 Thread Alon Levy
On 02/28/2014 02:16 PM, Marc-André Lureau wrote: > From: Marc-André Lureau > > See spice-common for protocol details. phodav, a webdav server library, > is imported thanks to a submodule, until this project has a stable API > and releases. > > The webdav channel is reponsible for handling port