Re: [Spice-devel] aSPICE/Opaque can now record audio

2014-03-13 Thread i iordanov
Hi Christophe, On Thu, Mar 13, 2014 at 5:18 AM, Christophe Fergeau wrote: > The point of autoaudiosrc is to guess for you the best recording source to > use, so I'd say this is a bug with gstreamer or with openslessrc. Is this > something shipped with gstreamer, or is it an out of tree gstreamer

Re: [Spice-devel] [spice-gtk] mingw64: Fix gssize printf-format warnings

2014-03-13 Thread Marc-André Lureau
ack - Original Message - > When building with mingw64, several warnings about using the wrong format > specifier for gssize/gsize occur similar to: > > win-usb-dev.c: In function 'g_udev_client_list_devices': > win-usb-dev.c:145:21: error: format '%i' expects argument of type 'int', but >

[Spice-devel] [spice-gtk] mingw64: Fix gssize printf-format warnings

2014-03-13 Thread Christophe Fergeau
When building with mingw64, several warnings about using the wrong format specifier for gssize/gsize occur similar to: win-usb-dev.c: In function 'g_udev_client_list_devices': win-usb-dev.c:145:21: error: format '%i' expects argument of type 'int', but argument 7 has type 'gssize' [-Werror=format

Re: [Spice-devel] [PATCH spice-xpi 2/2] controller: return immediately if already connected

2014-03-13 Thread Christophe Fergeau
On Thu, Mar 13, 2014 at 01:15:51PM -0400, Marc-André Lureau wrote: > > > - Original Message - > > On Fri, Mar 07, 2014 at 03:02:41PM +0100, Marc-André Lureau wrote: > > > From: Marc-André Lureau > > > > > > Do not try again if the unix socket is already connected, but fail > > > immedia

Re: [Spice-devel] [PATCH spice-xpi 2/2] controller: return immediately if already connected

2014-03-13 Thread Marc-André Lureau
- Original Message - > On Fri, Mar 07, 2014 at 03:02:41PM +0100, Marc-André Lureau wrote: > > From: Marc-André Lureau > > > > Do not try again if the unix socket is already connected, but fail > > immediately. > > Does that prevent a crash? Or what does this commit change from a end-us

Re: [Spice-devel] [vdagent-win 1/2] vdagent: file-xfer: fix compilation warnings when building with Visual Studio

2014-03-13 Thread Christophe Fergeau
What is the compilation warning? I guess you could mention in the log that this readds uses of _s methods, but substitute them with non _s methods on mingw through #define On Sun, Mar 09, 2014 at 07:05:05PM +0200, Uri Lublin wrote: > This patch reverts some of the changes made in commit > 4b9e9b1d

Re: [Spice-devel] [vdagent-win 2/2] vdagent: as_user: reorder initialization to make mingw-gcc happy

2014-03-13 Thread Christophe Fergeau
On Sun, Mar 09, 2014 at 07:05:06PM +0200, Uri Lublin wrote: > Fixes compiler warning that starts with: > > In file included from vdagent/as_user.cpp:19:0: > vdagent/as_user.h: In constructor 'AsUser::AsUser(DWORD)': > vdagent/as_user.h:35:10: warning: 'AsUser::_started' will be initialized > afte

Re: [Spice-devel] [PATCH spice-xpi 1/2] controller: try connection every second

2014-03-13 Thread Christophe Fergeau
On Fri, Mar 07, 2014 at 03:02:40PM +0100, Marc-André Lureau wrote: > From: Marc-André Lureau > > Currently, with 10 tries, it takes up to n(n+1)/2 = 55s before > returning failure. > > The default firefox plugin timeout is 45s, passed that time, the plugin > is killed. 10s should be enough in no

Re: [Spice-devel] [PATCH spice-xpi 2/2] controller: return immediately if already connected

2014-03-13 Thread Christophe Fergeau
On Fri, Mar 07, 2014 at 03:02:41PM +0100, Marc-André Lureau wrote: > From: Marc-André Lureau > > Do not try again if the unix socket is already connected, but fail > immediately. Does that prevent a crash? Or what does this commit change from a end-user perspective? Christophe > > https://bug

Re: [Spice-devel] [PATCH server] Associate org.spice-space.webdav.0 port to webdav channel

2014-03-13 Thread Marc-André Lureau
Hi I would like to push this change, along with the protocol channel change. I believe the implementation has been around and stable for a while, and is good enough for inclusion. This isn't a fundamental change, it's an optional new channel, and as such I think it shouldn't be any trouble. On

Re: [Spice-devel] [PATCH spice-gtk] Fix spice_display_get_pixbuf() with offset area

2014-03-13 Thread Jonathon Jongsma
ACK - Original Message - > From: "Marc-André Lureau" > To: spice-devel@lists.freedesktop.org > Sent: Thursday, March 13, 2014 8:23:55 AM > Subject: [Spice-devel] [PATCH spice-gtk] Fix spice_display_get_pixbuf() with > offset area > > Fix screenshot of secondary displays, with an area p

[Spice-devel] [PATCH spice-gtk] Fix spice_display_get_pixbuf() with offset area

2014-03-13 Thread Marc-André Lureau
Fix screenshot of secondary displays, with an area position != (0,0). This has never been working correctly since the surface display "area" was introducted in: commit e3bb7b1cfd162fcb8943e9d582dab43eeec6ce41 Author: Marc-André Lureau Date: Tue Jun 12 19:24:47 2012 +0200 display: learn to

Re: [Spice-devel] aSPICE/Opaque can now record audio

2014-03-13 Thread Christophe Fergeau
On Thu, Mar 13, 2014 at 12:41:46AM -0400, i iordanov wrote: > Hey guys, > > Following a suggestion by a developer, in order to enable audio > recording on Android, I changed spice-gstaudio.c from: > > gchar *pipeline = > g_strdup_printf("autoaudiosrc name=audiosrc ! queue ! > audi