Re: [Spice-devel] Inpout Channel Mouse Down

2014-03-11 Thread Lindsay Mathieson
On 12 March 2014 08:28, Marc-André Lureau wrote: > > > > I wasn't involved at early spice-gtk time, so I have never seen such problem. > > My guess: make sure the current button_state doesn't have already the button > you are pressing: > > spice_inputs_button_press (channel=0x773e20, button=1, bu

Re: [Spice-devel] Inpout Channel Mouse Down

2014-03-11 Thread Marc-André Lureau
- Original Message - > My QT4 wrapper round the spice lib is going well, to the stage where I'm > displaying screens and sending them mouse input. > > One quirk I can't figure out is the Mouse down event. When I send it to the > VM > it seems to immediately send a mouse up as well. > >

Re: [Spice-devel] [spice-gtk 2/3] Include glib-compat.h at the end of config.h

2014-03-11 Thread Marc-André Lureau
On Mon, Mar 10, 2014 at 4:45 PM, Christophe Fergeau wrote: > On Thu, Feb 27, 2014 at 01:54:22PM +0100, Marc-André Lureau wrote: >> On Thu, Feb 27, 2014 at 1:47 PM, Christophe Fergeau >> wrote: >> > As long as .c files include config.h, this will ensure we don't forget >> > to include glib-compat

[Spice-devel] Inpout Channel Mouse Down

2014-03-11 Thread Lindsay Mathieson
My QT4 wrapper round the spice lib is going well, to the stage where I'm displaying screens and sending them mouse input. One quirk I can't figure out is the Mouse down event. When I send it to the VM it seems to immediately send a mouse up as well. So if I press and hold on a button in the VM,

Re: [Spice-devel] Input Channel Mouse constants

2014-03-11 Thread Lindsay Mathieson
On Tue, 11 Mar 2014 12:04:17 PM Christophe Fergeau wrote: > On Tue, Mar 11, 2014 at 08:45:53PM +1000, Lindsay Mathieson wrote: > > > > But I can't find where they are defined or their values. > > See spice-protocol/spice/enums.h (which is autogenerated from spice.proto) > > Christophe Thanks Ch

Re: [Spice-devel] [spice-gtk] Fix TLS connections when both TLS/non-TLS port are given

2014-03-11 Thread Marc-André Lureau
On Tue, Mar 11, 2014 at 6:03 PM, Christophe Fergeau wrote: > When qemu only accepts TLS connections, but spice-gtk is given an URI with > both port and tls-port specified, spice_session_channel_open_host() is > first attempted to the non-TLS port, and when that fails, > spice_channel_coroutine() r

Re: [Spice-devel] [spice-gtk] Fix TLS connections when both TLS/non-TLS port are given

2014-03-11 Thread Marc-André Lureau
ack, thanks On Tue, Mar 11, 2014 at 6:03 PM, Christophe Fergeau wrote: > When qemu only accepts TLS connections, but spice-gtk is given an URI with > both port and tls-port specified, spice_session_channel_open_host() is > first attempted to the non-TLS port, and when that fails, > spice_channel_

[Spice-devel] [spice-gtk] Fix TLS connections when both TLS/non-TLS port are given

2014-03-11 Thread Christophe Fergeau
When qemu only accepts TLS connections, but spice-gtk is given an URI with both port and tls-port specified, spice_session_channel_open_host() is first attempted to the non-TLS port, and when that fails, spice_channel_coroutine() retries a TLS connection. Commit 3edcc04 broke this as when the non-

Re: [Spice-devel] [PATCH spice-gtk] Silence some gcc warnings

2014-03-11 Thread Jonathon Jongsma
ACK - Original Message - > From: "Marc-André Lureau" > To: spice-devel@lists.freedesktop.org > Sent: Tuesday, March 11, 2014 8:53:37 AM > Subject: [Spice-devel] [PATCH spice-gtk] Silence some gcc warnings > > cc1: warnings being treated as errors > spice-uri.c: In function ‘spice_uri_par

[Spice-devel] [PATCH spice-gtk] Silence some gcc warnings

2014-03-11 Thread Marc-André Lureau
cc1: warnings being treated as errors spice-uri.c: In function ‘spice_uri_parse’: spice-uri.c:105: error: ‘saveptr’ may be used uninitialized in this function [-Wuninitialized] spice-uri.c:105: error: ‘saveptr2’ may be used uninitialized in this function [-Wuninitialized] --- gtk/spice-uri.c | 2 +

Re: [Spice-devel] [PATCHv3 spice-gtk 13/14] channel: add spice_channel_get_error()

2014-03-11 Thread Marc-André Lureau
Hi - Original Message - > On Tue, Mar 11, 2014 at 08:15:49AM -0400, Marc-André Lureau wrote: > > > This avoids potentially losing the non-TLS error if remote-viewer is > > > started with only a non-TLS port. However, this will lose non-TLS > > > connection errors when starting QEMU with ju

Re: [Spice-devel] [PATCHv3 spice-gtk 13/14] channel: add spice_channel_get_error()

2014-03-11 Thread Christophe Fergeau
On Tue, Mar 11, 2014 at 08:15:49AM -0400, Marc-André Lureau wrote: > > This avoids potentially losing the non-TLS error if remote-viewer is > > started with only a non-TLS port. However, this will lose non-TLS > > connection errors when starting QEMU with just a non-TLS port and starting > > remote

Re: [Spice-devel] [PATCHv3 spice-gtk 13/14] channel: add spice_channel_get_error()

2014-03-11 Thread Marc-André Lureau
- Original Message - > Hey, > > On Mon, Feb 17, 2014 at 10:35:52PM +0100, Marc-André Lureau wrote: > > Add a function to retrieve the last GError from a channel, this may be > > useful to provide additional error details to the client. > > --- > > doc/reference/spice-gtk-sections.txt |

Re: [Spice-devel] [PATCHv3 spice-gtk 13/14] channel: add spice_channel_get_error()

2014-03-11 Thread Christophe Fergeau
Hey, On Mon, Feb 17, 2014 at 10:35:52PM +0100, Marc-André Lureau wrote: > Add a function to retrieve the last GError from a channel, this may be > useful to provide additional error details to the client. > --- > doc/reference/spice-gtk-sections.txt | 1 + > gtk/map-file

Re: [Spice-devel] Multiple qxl displays from the command-line.

2014-03-11 Thread Christophe Fergeau
Hey, On Tue, Mar 11, 2014 at 10:23:40AM +0100, David Jaša wrote: > What is your guest OS? The invocation differs for Linux and Windows, for > linux, you use just one device with big enough RAM: > -vga qxl -global qxl-vga.ram_size=134217728 > > for windows guests, you should use multiple qxl devic

Re: [Spice-devel] Input Channel Mouse constants

2014-03-11 Thread Christophe Fergeau
On Tue, Mar 11, 2014 at 08:45:53PM +1000, Lindsay Mathieson wrote: > The spicelib docs mention mouse event constants: > > http://elmarco.fedorapeople.org/spice-gtk/SpiceInputsChannel.html#spice-inputs-button-press > > Press a mouse button. > > /button/ : > a SPICE_MOUSE_BUTTON > /button_state/

[Spice-devel] Input Channel Mouse constants

2014-03-11 Thread Lindsay Mathieson
The spicelib docs mention mouse event constants: http://elmarco.fedorapeople.org/spice-gtk/SpiceInputsChannel.html#spice-inputs-button-press Press a mouse button. /button/ : a SPICE_MOUSE_BUTTON /button_state/ : SPICE_MOUSE_BUTTON_MASK flags But I can't find where they are defined or their val

Re: [Spice-devel] Multiple qxl displays from the command-line.

2014-03-11 Thread David Jaša
Hi Trebor, What is your guest OS? The invocation differs for Linux and Windows, for linux, you use just one device with big enough RAM: -vga qxl -global qxl-vga.ram_size=134217728 for windows guests, you should use multiple qxl devices: -vga qxl -device qxl [-device qxl [-device qxl]] BTW, based

Re: [Spice-devel] [PATCH] Don't truncate large 'now' values in _spice_timer_set

2014-03-11 Thread David Gibson
On Mon, 10 Mar 2014 11:58:19 +0100 Christophe Fergeau wrote: > From: David Gibson > > static void _spice_timer_set(SpiceTimer *timer, uint32_t ms, uint32_t now) > > The _spice_timer_set() function takes a 32-bit integer for the "now" value. > The now value passed in however, can exceed 2^32 (i