On Tue, Jan 07, 2014 at 01:47:12PM +0100, Christophe Fergeau wrote:
> Hey,
>
> On Mon, Jan 06, 2014 at 03:35:24PM +0200, Uri Lublin wrote:
> > On 01/06/2014 01:22 PM, Christophe Fergeau wrote:
> > >find_model_params() is first dereferencing nbuckets when setting
> > >it to 0, and then it checks it
Hey,
On Mon, Jan 06, 2014 at 03:35:24PM +0200, Uri Lublin wrote:
> On 01/06/2014 01:22 PM, Christophe Fergeau wrote:
> >find_model_params() is first dereferencing nbuckets when setting
> >it to 0, and then it checks it for NULL. The NULL-check will never trigger
> >as if the pointer was NULL, we'd
The private data is allocated at the same time as RedsStream and
goes immediatly after the main RedsStream data.
This private member will allow to hide internal RedsStream
implementation details from the rest of spice-server.
---
server/reds_stream.c | 6 +-
server/reds_stream.h | 4
2 fi
---
server/reds_stream.c | 35 ++-
server/reds_stream.h | 1 -
2 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/server/reds_stream.c b/server/reds_stream.c
index 95c159f..f558897 100644
--- a/server/reds_stream.c
+++ b/server/reds_stream.c
@@ -34,6
---
server/reds_stream.c | 33 +++--
server/reds_stream.h | 5 -
2 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/server/reds_stream.c b/server/reds_stream.c
index f558897..7f6172f 100644
--- a/server/reds_stream.c
+++ b/server/reds_stream.c
@@ -35,
Gather common RedsStream code there rather than having it
in reds.c
---
server/Makefile.am | 2 +
server/inputs_channel.c | 1 +
server/red_channel.c| 1 +
server/red_channel.h| 2 +-
server/red_worker.c | 1 +
server/reds.c | 181 +-
Now that stream creation and SSL enabling are done by helpers
in reds_stream.c, we can move the initialization of the vfunc
read/write pointers there too.
---
server/reds.c| 77
server/reds_stream.c | 75 +
---
server/reds_stream.c | 26 ++
server/reds_stream.h | 2 --
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/server/reds_stream.c b/server/reds_stream.c
index d0d8213..837d2cb 100644
--- a/server/reds_stream.c
+++ b/server/reds_stream.c
@@ -71,6 +71,8 @@
Initializing a new stream means initializing quite a few fields.
This commit factors this initialization in a dedicated reds_stream_new
helper. This also helps moving more code from reds.c to reds_stream.c
---
server/reds.c| 22 ++
server/reds_stream.c | 29
---
server/reds_stream.c | 107 ++-
server/reds_stream.h | 35 -
2 files changed, 71 insertions(+), 71 deletions(-)
diff --git a/server/reds_stream.c b/server/reds_stream.c
index 7f6172f..d0d8213 100644
--- a/server/reds_stream.c
++
They are renamed to reds_stream_write*
---
server/reds.c| 78
server/reds_stream.c | 28 +++
server/reds_stream.h | 5
3 files changed, 57 insertions(+), 54 deletions(-)
diff --git a/server/reds.c b/server/reds.c
i
SASL authentication mostly use members from RedsStream to do its work, so
it makes sense to have its code in reds_stream.c. This should allow to make
RedsStream::sasl private in the future.
---
server/reds.c| 458 -
server/reds_stream.c | 510 +++
Hey,
This is a series I've had locally for a while. It moves RedsStream related code
out of reds.c to its own file. This shaves ~1000 lines of code out of reds.c
The patch series could be split in 2 independent series, first one would be
patches 1-8 which is code movements from reds.c to redsstrea
---
server/inputs_channel.c | 2 +-
server/reds.c | 10 +-
server/reds_stream.c| 5 +
server/reds_stream.h| 1 +
4 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/server/inputs_channel.c b/server/inputs_channel.c
index 8d4feab..395b81f 100644
--- a/se
Code to initiate a SSL stream belongs there
---
server/reds.c| 85 +++-
server/reds_stream.c | 50 +++
server/reds_stream.h | 2 ++
3 files changed, 82 insertions(+), 55 deletions(-)
diff --git a/server/reds.c b/
---
server/reds_stream.c | 50 --
server/reds_stream.h | 6 --
2 files changed, 28 insertions(+), 28 deletions(-)
diff --git a/server/reds_stream.c b/server/reds_stream.c
index 6af3cd1..331e505 100644
--- a/server/reds_stream.c
+++ b/server/red
The AsyncRead structure in reds.h wraps an async read + callback to
be done on a stream. Moving it to reds_stream.h is needed in order
to move SASL authentication there.
---
server/reds.c| 60
server/reds_stream.c | 64 ++
---
server/reds.c| 6 +++---
server/reds_stream.c | 9 +
server/reds_stream.h | 2 ++
3 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index a993f2c..c6983d8 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -1416,9 +1416,9 @@ static voi
---
server/reds.c| 2 +-
server/reds_stream.c | 10 ++
server/reds_stream.h | 1 +
3 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/server/reds.c b/server/reds.c
index f35f989..a993f2c 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -1414,7 +1414,7 @@ static void
---
server/red_common.h | 2 ++
server/reds.h | 2 --
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/red_common.h b/server/red_common.h
index 585b13c..b6b643a 100644
--- a/server/red_common.h
+++ b/server/red_common.h
@@ -29,6 +29,8 @@
#include "spice.h"
+#define
On Tue, 7 Jan 2014 10:38:26 AM David Jaša wrote:
> No, only one client can connect at the same time.
>
> David
>
> On Út, 2014-01-07 at 10:05 +0800, hhb584520 wrote:
> > how to multiple spice clients can connect to spice server at one time?
It can be done:
http://www.spice-space.org/page/Fea
No, only one client can connect at the same time.
David
On Út, 2014-01-07 at 10:05 +0800, hhb584520 wrote:
> how to multiple spice clients can connect to spice server at one time?
>
> thank you!
>
>
>
>
> hhb584520
>
> From: Liang Guo
> Date: 2014-01-06 23:31
> To: hhb584520
> Subject: Re:
how to multiple spice clients can connect to spice server at one time?
thank you!
hhb584520
From: Liang Guo
Date: 2014-01-06 23:31
To: hhb584520
Subject: Re: multiple client connect spice-server
Hi,
AFAIK, only one spice client can connect to spice server at one time.
You'd better ask this
23 matches
Mail list logo
