Hey,
A few minor comments below,
Christophe
On Tue, Nov 12, 2013 at 03:52:53PM -0600, Jeremy White wrote:
> diff --git a/server/snd_worker.c b/server/snd_worker.c
> index 57f30c2..1590abf 100644
> --- a/server/snd_worker.c
> +++ b/server/snd_worker.c
> @@ -156,12 +156,14 @@ struct SpicePlaybackS
Fwiw, I tested upstream spice-gtk+remote-viewer against opus
qemu/spice-server and did not observe issues with recording (including when
running in valgrind). Is it only spicec which could be impacted by the
issues you mention? If it is, then I don't think it's really important, I
thought it was a
hey,
On Tue, Nov 12, 2013 at 03:52:17PM -0600, Jeremy White wrote:
> I have not yet, but still intend to, research the corner cases where
> hard coding in the old spicec can fail to record properly.
Fwiw, I tested upstream spice-gtk+remote-viewer against opus
qemu/spice-server and did not observe
Hey,
On Thu, Nov 07, 2013 at 03:06:45PM +, Dietmar Maurer wrote:
> > On Fri, Oct 25, 2013 at 10:43:13AM +0200, Christophe Fergeau wrote:
> > > On Tue, Oct 22, 2013 at 11:07:56AM +0200, diet...@proxmox.com wrote:
> > > > Current code works with DIGEST-MD5, but not with PLAIN.
> > >
> > > After
On Wed, Nov 20, 2013 at 11:39:52AM +0100, Diego COSTE wrote:
> FYI I attached the log of a failing remote-viewer session when the proxy
> variables are set and the host firewall disabled.
iirc SPICE proxy code fails to take into account the variable indicating
which hosts should not be proxied, ma
On Wed, Nov 20, 2013 at 06:49:36PM -0500, i iordanov wrote:
> Hi Christophe,
>
> Does the OvirtProxy object always need to authenticate by emitting the
> "authenticate" signal?
>
> It seems to still emit the signal even though I set its username and
> password properties a priori with known good
ACK
(still needs to go through qemu-devel/kraxel)
Christophe
On Tue, Nov 12, 2013 at 03:53:17PM -0600, Jeremy White wrote:
> Signed-off-by: Jeremy White
> ---
> audio/spiceaudio.c | 27 +--
> 1 file changed, 25 insertions(+), 2 deletions(-)
>
> diff --git a/audio/spic
Looks good, ACK (and works in my testing)
Christophe
On Tue, Nov 12, 2013 at 03:53:09PM -0600, Jeremy White wrote:
> Signed-off-by: Jeremy White
> ---
> gtk/Makefile.am|2 ++
> gtk/channel-playback.c | 49
> ++--
> gtk/channel-record.c
