- Original Message -
> From: "Jonathon Jongsma"
> To: spice-de...@freedesktop.org
> Sent: Friday, November 15, 2013 10:43:59 PM
> Subject: [Spice-devel] 4-display windows guest problems
>
> I'm trying to understand a bug I encountered in virt-viewer.
>
> I set up a windows 7 guest with
I'm trying to understand a bug I encountered in virt-viewer.
I set up a windows 7 guest with 4 QXL devices. When I connect to this guest
with virt-viewer, it gets 4 display channels, and virt-viewer offers to let me
enable 4 displays (via toggling 'View > Dislays > Display N'). However,
dis
On Fri, Nov 15, 2013 at 6:34 PM, Christophe Fergeau wrote:
> On Fri, Nov 15, 2013 at 11:56:03AM -0500, Marc-André Lureau wrote:
>> ack for your patch, comparing to the static "leader" seems the correct thing
>> to do.
>
> It will need a v2:
>
> In file included from coroutine_ucontext.c:29:0:
> c
From: Marc-André Lureau
---
gtk/spicy.c | 101 +++-
1 file changed, 94 insertions(+), 7 deletions(-)
diff --git a/gtk/spicy.c b/gtk/spicy.c
index dff9d44..7f6a169 100644
--- a/gtk/spicy.c
+++ b/gtk/spicy.c
@@ -97,6 +97,7 @@ struct spice_co
From: Marc-André Lureau
This channel implements the NBD protocol and the port events defined by
Spice protocol.
---
doc/reference/spice-gtk-docs.xml | 1 +
doc/reference/spice-gtk-sections.txt | 18 ++
doc/reference/spice-gtk.types| 3 +-
gtk/Makefile.am |
From: Marc-André Lureau
This allows to use conveniently GIOStream APIs without caring about
coroutine and Spice messages details.
---
gtk/Makefile.am | 2 +
gtk/channel-base.c | 48 ++
gtk/channel-port.c | 33 +---
gtk/spice-channel-priv.h | 8 +
gtk/vmcstream.c
From: Marc-André Lureau
---
gtk/spice-session-priv.h | 1 +
gtk/spice-session.c | 11 ++-
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/gtk/spice-session-priv.h b/gtk/spice-session-priv.h
index 55fee47..95de0fc 100644
--- a/gtk/spice-session-priv.h
+++ b/gtk/spice-
From: Marc-André Lureau
Hi list,
This is an updated patch series for the NBD channel support, sent back
in June that was ack by Hans. The most notable change is the handling
of migration, which is simply a session recreation. For the moment, as
long as the corresponding patches are not in qemu,
When leaving a coroutine, it swaps back to where it came from, not to
the leader/main coroutine.
---
gtk/coroutine_ucontext.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gtk/coroutine_ucontext.c b/gtk/coroutine_ucontext.c
index 6251528..889f0d6 100644
--- a/gtk/coroutine_uc
---
gtk/spice-channel-priv.h | 1 -
gtk/spice-channel.c | 5 ++---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/gtk/spice-channel-priv.h b/gtk/spice-channel-priv.h
index 80a6563..351126f 100644
--- a/gtk/spice-channel-priv.h
+++ b/gtk/spice-channel-priv.h
@@ -113,7 +113,6 @@
---
gtk/coroutine_gthread.c | 7 +++
gtk/coroutine_ucontext.c | 8
gtk/coroutine_winfibers.c | 7 +++
3 files changed, 10 insertions(+), 12 deletions(-)
diff --git a/gtk/coroutine_gthread.c b/gtk/coroutine_gthread.c
index 14231a0..51d2d6f 100644
--- a/gtk/coroutine_gthread.c
+
---
tests/Makefile.am | 18 -
tests/coroutine.c | 80 +++
2 files changed, 91 insertions(+), 7 deletions(-)
create mode 100644 tests/coroutine.c
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 9510e2c..6f80d93 100644
--- a/
On Fri, Nov 15, 2013 at 11:56:03AM -0500, Marc-André Lureau wrote:
> ack for your patch, comparing to the static "leader" seems the correct thing
> to do.
It will need a v2:
In file included from coroutine_ucontext.c:29:0:
coroutine.h:71:1: error: unknown type name 'gboolean'
gboolean coroutine
On Fri, Nov 15, 2013 at 6:20 PM, Christophe Fergeau wrote:
> configure help text says that by default python will be used automatically
> if appropriate, however this only means that on !windows and !gtk3, we will
> force build of the python bindings, and fail if any needed package to build
> them
ack
On Fri, Nov 15, 2013 at 6:20 PM, Christophe Fergeau wrote:
> Commit daa4ece tried to disable building of python bindings on Windows by
> default, but in doing so, it also disabled building of python bindings by
> default when we are building neither for Windows nor for gtk3.
We s
--
Marc-A
On Fri, Nov 15, 2013 at 6:20 PM, Christophe Fergeau wrote:
> test ... -o test ... is not a valid shell construct, change it to
> test ... || test ... as this is more portable than test ... -o ...
>
> This was causing a warning when running configure.
ack
> ---
> configure.ac | 2 +-
> 1 file ch
Commit daa4ece tried to disable building of python bindings on Windows by
default, but in doing so, it also disabled building of python bindings by
default when we are building neither for Windows nor for gtk3.
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/co
Hey,
Commit daa4ece9 introduced several regressions in the decision of whether
to build the python bindings or not. This patch series fixes them, and
improves the autodetection logic.
Christophe
___
Spice-devel mailing list
Spice-devel@lists.freedeskto
test ... -o test ... is not a valid shell construct, change it to
test ... || test ... as this is more portable than test ... -o ...
This was causing a warning when running configure.
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
configure help text says that by default python will be used automatically
if appropriate, however this only means that on !windows and !gtk3, we will
force build of the python bindings, and fail if any needed package to build
them is missing.
This commit improves on the current checks so that whe
- Original Message -
> On Fri, Nov 15, 2013 at 10:45:42AM -0500, Marc-André Lureau wrote:
> >
> >
> > - Original Message -
> > > On Fri, Nov 15, 2013 at 04:05:55PM +0100, Christophe Fergeau wrote:
> > > > However, this is an
> > > > implementation detail of the ucontext coroutin
On Fri, Nov 15, 2013 at 10:45:42AM -0500, Marc-André Lureau wrote:
>
>
> - Original Message -
> > On Fri, Nov 15, 2013 at 04:05:55PM +0100, Christophe Fergeau wrote:
> > > However, this is an
> > > implementation detail of the ucontext coroutine implementation, in the
> > > gthread implem
- Original Message -
> On Fri, Nov 15, 2013 at 04:05:55PM +0100, Christophe Fergeau wrote:
> > However, this is an
> > implementation detail of the ucontext coroutine implementation, in the
> > gthread implementation, coroutine_self()->caller will be non-NULL even in
> > the main context.
On Fri, Nov 15, 2013 at 04:05:55PM +0100, Christophe Fergeau wrote:
> However, this is an
> implementation detail of the ucontext coroutine implementation, in the
> gthread implementation, coroutine_self()->caller will be non-NULL even in
> the main context.
NB: Maybe the actual bug is that corout
The IN_MAIN_CONTEXT macro checks coroutine_self()->caller against NULL to
decide whether we are in the main context or not. However, this is an
implementation detail of the ucontext coroutine implementation, in the
gthread implementation, coroutine_self()->caller will be non-NULL even in
the main c
ack
On Fri, Nov 15, 2013 at 12:07 PM, Christophe Fergeau
wrote:
> g_object_notify_main_context() was recently changed to automatically
> detect whether we are running in the main context or not, and SpiceSession
> is now using g_object_notify_main_context().
>
> In order to achieve that, IN_MAIN_
g_object_notify_main_context() was recently changed to automatically
detect whether we are running in the main context or not, and SpiceSession
is now using g_object_notify_main_context().
In order to achieve that, IN_MAIN_CONTEXT is used, but it's not safe
to be used before coroutine_init() is ca
hello again,
in fact this commit on spice-gtk seems to be correct this problem.
http://cgit.freedesktop.org/spice/spice-gtk/commit/?id=11ddba4b09bc2e3024cfd1c9f0d78948d004bb40
regards,
Nicolas Prochazka
2013/11/14 nicolas prochazka :
> Hello
> I've two environnement
> the first with qemu 1.5.3 ha
28 matches
Mail list logo
