[Spice-devel] [PATCH usbclerk] Fix possibly missing files after upgrade

2013-11-08 Thread Marc-André Lureau
From: Marc-André Lureau This is similar to the fix for virt-viewer: https://www.redhat.com/archives/virt-tools-list/2013-November/msg00030.html Although it's not mandatory for simple cases, RemoveExistingProducts should be Schedule='afterInstallFinalize', see also: http://msdn.microsoft.com/en-

Re: [Spice-devel] [spice-common RFC] Introduce SPICE_COMMON_SETUP m4 macro

2013-11-08 Thread Marc-André Lureau
- Original Message - > On Fri, Nov 08, 2013 at 04:10:16PM -0500, Marc-André Lureau wrote: > > > > > > - Original Message - > > > This macro gathers the various checks/substitutions that spice-common's > > > configure.ac needs to do. It's meant to be called by users of the > > >

Re: [Spice-devel] [spice-common RFC] Introduce SPICE_COMMON_SETUP m4 macro

2013-11-08 Thread Christophe Fergeau
On Fri, Nov 08, 2013 at 04:10:16PM -0500, Marc-André Lureau wrote: > > > - Original Message - > > This macro gathers the various checks/substitutions that spice-common's > > configure.ac needs to do. It's meant to be called by users of the > > spice-common submodule instead of calling AC_

Re: [Spice-devel] linux with multiple "monitors" issues

2013-11-08 Thread Marc-André Lureau
- Original Message - > Hi All, > > You may remember me as the guy who about once a month complains that > multiple "monitors" simply doesn't work in linux. > > I have tested various configurations of centos 6, fedora 19 and fedora > 20 beta as host, guest and client. > > Well I think I

Re: [Spice-devel] [spice-common sound rework 1/3 (take 4)] Add a snd_codec interface to abstract the use of audio codecs such as celt.

2013-11-08 Thread Christophe Fergeau
On Tue, Nov 05, 2013 at 04:24:47PM -0600, Jeremy White wrote: > diff --git a/common/snd_codec.c b/common/snd_codec.c > new file mode 100644 > index 000..2683143 > --- /dev/null > +++ b/common/snd_codec.c > @@ -0,0 +1,285 @@ > +/* -*- Mode: C; c-basic-offset: 4; indent-tabs-mode: nil -*- */ > +/

Re: [Spice-devel] [spice opus support 3/5 (take 2)] Add support for the Opus codec

2013-11-08 Thread Christophe Fergeau
On Thu, Oct 31, 2013 at 12:13:44PM -0500, Jeremy White wrote: > Signed-off-by: Jeremy White > --- > client/audio_devices.h |8 --- > client/platform.h |6 ++- > client/playback_channel.cpp | 11 +++- > client/record_channel.cpp | 24 + > client/x11/platform.cp

[Spice-devel] linux with multiple "monitors" issues

2013-11-08 Thread David Mansfield
Hi All, You may remember me as the guy who about once a month complains that multiple "monitors" simply doesn't work in linux. I have tested various configurations of centos 6, fedora 19 and fedora 20 beta as host, guest and client. Well I think I've finally made some progress which I'll th

Re: [Spice-devel] [qemu opus support 5/5 (take 2)] Add the ability to vary Spice playback and record rates, to facilitate Opus support.

2013-11-08 Thread Christophe Fergeau
Will need to go through qemu-devel, but looks ok to me. The subject misled me, after reading it, I expected this commit was doing much more than asking spice-server for the rate to use. Christophe On Thu, Oct 31, 2013 at 12:13:56PM -0500, Jeremy White wrote: > Signed-off-by: Jeremy White > --- >

Re: [Spice-devel] [spice-common RFC] Introduce SPICE_COMMON_SETUP m4 macro

2013-11-08 Thread Marc-André Lureau
- Original Message - > This macro gathers the various checks/substitutions that spice-common's > configure.ac needs to do. It's meant to be called by users of the > spice-common submodule instead of calling AC_CONFIG_SUBDIRS() which is > much slower and less flexible. Speed? It takes les

[Spice-devel] [spice-common RFC] Use m4 macro to configure the spice-common submodule

2013-11-08 Thread Christophe Fergeau
Hey, We currently configure the spice-common submodule by running its configure script, which takes quite some time, and is not very flexible (for example if we want to pass back information to the module using the spice-common submodule). This patch replaces this by a macro that does all this wor

[Spice-devel] sound rework 0/4 - take 5

2013-11-08 Thread Jeremy White
Following 4 patches are take 5 of the sound rework series. This set moves the use of config.h to the top of the new snd_codec.c file, and adds a patch to prevent a start signal if the codec creation fails. Cheers, Jeremy ___ Spice-devel mailing list Sp

[Spice-devel] [spice-common sound rework 1/4 (take 5)] Add a snd_codec interface to abstract the use of audio codecs such as celt.

2013-11-08 Thread Jeremy White
Signed-off-by: Jeremy White --- common/Makefile.am |7 ++ common/snd_codec.c | 285 common/snd_codec.h | 69 + configure.ac | 16 +++ 4 files changed, 377 insertions(+) create mode 100644 common/snd_codec.c create m

[Spice-devel] [spice sound rework 2/4 (take 5)] Revise the spice client and server to use the new snd_codec functions in spice-common.

2013-11-08 Thread Jeremy White
This makes celt optional, and paves the way to readily add additional codecs. Signed-off-by: Jeremy White --- README |1 - client/audio_channels.h | 12 ++- client/playback_channel.cpp | 59 ++-- client/record_channel.cpp | 69 ++- configu

[Spice-devel] [spice-gtk sound rework 4/4 (take 5)] Don't emit start signals if codec creation fails.

2013-11-08 Thread Jeremy White
Signed-off-by: Jeremy White --- gtk/channel-playback.c |4 +++- gtk/channel-record.c |4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/gtk/channel-playback.c b/gtk/channel-playback.c index bcb4728..f02d08a 100644 --- a/gtk/channel-playback.c +++ b/gtk/channel-playb

[Spice-devel] [spice-common RFC] Introduce SPICE_COMMON_SETUP m4 macro

2013-11-08 Thread Christophe Fergeau
This macro gathers the various checks/substitutions that spice-common's configure.ac needs to do. It's meant to be called by users of the spice-common submodule instead of calling AC_CONFIG_SUBDIRS() which is much slower and less flexible. This also removes spice-protocol as a submodule, it's a sta

Re: [Spice-devel] [spice-gtk opus support 4/5 (take 2)] Add support for the Opus codec.

2013-11-08 Thread Christophe Fergeau
Hey, this one is pretty straightforward, just one comment below. Christophe On Thu, Oct 31, 2013 at 12:13:49PM -0500, Jeremy White wrote: > diff --git a/gtk/channel-record.c b/gtk/channel-record.c > index 67d4a26..5333041 100644 > --- a/gtk/channel-record.c > +++ b/gtk/channel-record.c > @@ -90,6

[Spice-devel] [spice-gtk sound rework 3/4 (take 5)] Use the new snd_codec interface to process encoded audio.

2013-11-08 Thread Jeremy White
Signed-off-by: Jeremy White --- README |2 +- configure.ac |8 +--- gtk/channel-playback.c | 59 - gtk/channel-record.c | 99 4 files changed, 49 insertions(+), 119 deletions(-) d

Re: [Spice-devel] [PATCH spice-gtk] main: send max-clipboard to agent

2013-11-08 Thread Hans de Goede
Hi, On 11/07/2013 01:03 AM, Marc-André Lureau wrote: Send configured max-clipboard size to the agent, after receiving agent capabilities. See also spice-protocol patch description: http://lists.freedesktop.org/archives/spice-devel/2013-November/015254.html ACK, for both this patch as well as

Re: [Spice-devel] [spice-gtk sound rework 3/3 (take 4)] Use the new snd_codec interface to process encoded audio.

2013-11-08 Thread Christophe Fergeau
And a few more comments to that one as well :( On Tue, Nov 05, 2013 at 04:25:23PM -0600, Jeremy White wrote: > diff --git a/gtk/channel-playback.c b/gtk/channel-playback.c > @@ -428,7 +410,6 @@ static void playback_handle_start(SpiceChannel *channel, > SpiceMsgIn *in) > { > SpicePlaybackCha

Re: [Spice-devel] Spice bug62033, Gnome bug 680195 rework: new inhibitors for desktop effects

2013-11-08 Thread Bastien Nocera
On Thu, 2013-11-07 at 22:25 +0400, Fedor Lyakhov wrote: > Hi Bastein, > > On Mon, Nov 4, 2013 at 4:27 PM, Hans de Goede wrote: > > Hi, > > > > > > On 11/02/2013 05:50 PM, Fedor Lyakhov wrote: > >> > >> Bastein, Hans, > >> > >> We need an agreement on this topic so I can implement something - and

Re: [Spice-devel] [vdagent-win PATCH 5/6] Makefile.am: tabify

2013-11-08 Thread Christophe Fergeau
trivial, ACK On Fri, Nov 08, 2013 at 12:02:55AM +0200, Uri Lublin wrote: > > diff --git a/Makefile.am b/Makefile.am > index 768e984..da0b5a5 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -32,8 +32,8 @@ vdagent_SOURCES = \ > vdagent/desktop_layout.h\ > v

Re: [Spice-devel] [vdagent-win PATCH 3/6] vdagent: file_xfer: make g_key_get_string safer

2013-11-08 Thread Christophe Fergeau
On Fri, Nov 08, 2013 at 12:02:53AM +0200, Uri Lublin wrote: > By providing the size of the destination string buffer. > > diff --git a/vdagent/file_xfer.cpp b/vdagent/file_xfer.cpp > index 2a6480a..0c44c45 100644 > --- a/vdagent/file_xfer.cpp > +++ b/vdagent/file_xfer.cpp > @@ -49,7 +49,7 @@ void

Re: [Spice-devel] [vdagent-win PATCH 6/6] Makefile.am: add INCLUDES to AM_CPPFLAGS

2013-11-08 Thread Marc-André Lureau
On Thu, Nov 7, 2013 at 11:02 PM, Uri Lublin wrote: > Fixes the following autoreconf (automake) warning: > Makefile.am:6: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or > '*_CPPFLAGS') > > diff --git a/Makefile.am b/Makefile.am > index da0b5a5..fc017d5 100644 > --- a/Makefile.am > +++ b

Re: [Spice-devel] [vdagent-win PATCH 1/6] vdagent: add as_user to run tasks with user privileges

2013-11-08 Thread Christophe Fergeau
On Fri, Nov 08, 2013 at 12:02:51AM +0200, Uri Lublin wrote: > The class calls Impersonate upon begin(), and Revert > upon end() or destruction. > > The user is the current user that is logged in. > > create mode 100644 vdagent/as_user.cpp > create mode 100644 vdagent/as_user.h > > diff --git a

Re: [Spice-devel] [vdagent-win PATCH 0/6] file_xfer fixes and some cleanups

2013-11-08 Thread Marc-André Lureau
The series doesn't seem to apply on top of http://cgit.freedesktop.org/spice/win32/vd_agent/ Could you check? thanks On Thu, Nov 7, 2013 at 11:02 PM, Uri Lublin wrote: > The destination directory for file_xfer was a public one (e.g. desktop > directory of all-users). This is since vdagent.exe d

Re: [Spice-devel] [vdagent-win PATCH 6/6] Makefile.am: add INCLUDES to AM_CPPFLAGS

2013-11-08 Thread Christophe Fergeau
On Fri, Nov 08, 2013 at 12:02:56AM +0200, Uri Lublin wrote: > Fixes the following autoreconf (automake) warning: > Makefile.am:6: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or > '*_CPPFLAGS') > > diff --git a/Makefile.am b/Makefile.am > index da0b5a5..fc017d5 100644 > --- a/Makefile.a

Re: [Spice-devel] [vdagent-win PATCH 4/6] vdagent: file-xfer: make user desktop the target directory

2013-11-08 Thread Christophe Fergeau
On Fri, Nov 08, 2013 at 12:02:54AM +0200, Uri Lublin wrote: > Before, the target directory was a public one (for all users), > as file creation was not done with user privileges. > > Now that the file is created with user privileges, it's > better to make the user desktop the target directory. >

Re: [Spice-devel] Spice bug62033, Gnome bug 680195 rework: new inhibitors for desktop effects

2013-11-08 Thread Bastien Nocera
On Fri, 2013-11-08 at 00:35 +0400, Fedor Lyakhov wrote: > OK, got it. Thanks for your patience. I'll CC you once the patch is ready... > > I understand reasons behind both of the approaches - this one is > simple. But I'd need to add Spice vdagent D-Bus API for exactly this > one use case... hope