In theory, zero-ing the surface shouldn't be necessary, as only
invalidated/painted region should be shown. However, this results in
less artifacts on resolution changes (probably some regions are painted,
but with masks, blend, copy etc), in particular on console after VM
reboot.
---
gtk/channel-
> The open issue, in my mind, is whether or not it is worth doing a more
> complete generalization. That is, the current code has essentially hard
> coded requirements for the format and number of channels. It also uses
> fairly static sizing for frame buffers.
The spice-gtk code is pretty clean
- Original Message -
> While looking at the SASL code, I noticed some memory leaks in error paths.
> This commit adds a cleanup: block to free some of the memory dynamically
> allocated in that function, and remove the corresponding g_free() from
> the regular code flow. This should ensur
While looking at the SASL code, I noticed some memory leaks in error paths.
This commit adds a cleanup: block to free some of the memory dynamically
allocated in that function, and remove the corresponding g_free() from
the regular code flow. This should ensure that both the regular path
and the er
ack
On Wed, Oct 16, 2013 at 6:34 PM, Christophe Fergeau wrote:
> If spice_util_set_debug() gets called before spice_util_get_debug(),
> then the value set using spice_util_set_debug() will be overridden
> by the result of g_getenv("SPICE_DEBUG") != NULL the first time
> spice_util_get_debug() is
ack
On Wed, Oct 16, 2013 at 6:34 PM, Christophe Fergeau wrote:
> When SPICE_DEBUG is set but --spice-debug is not used, we fail
> to set G_MESSAGES_DEBUG to the log domain used by spice-gtk, which
> causes debug messages not to be printed as one would expect.
> ---
> gtk/spice-util.c | 34 ++
Signed-off-by: Jeremy White
---
README |2 +-
configure.ac |8 +---
gtk/channel-playback.c | 59 -
gtk/channel-record.c | 99
4 files changed, 49 insertions(+), 119 deletions(-)
d
This makes celt optional, and paves the way to readily add additional codecs.
Signed-off-by: Jeremy White
---
README |1 -
client/audio_channels.h | 12 ++-
client/playback_channel.cpp | 59 ++--
client/record_channel.cpp | 69 ++
configur
Signed-off-by: Jeremy White
---
common/Makefile.am |7 ++
common/snd_codec.c | 285
common/snd_codec.h | 69 +
configure.ac | 16 +++
4 files changed, 377 insertions(+)
create mode 100644 common/snd_codec.c
create m
The following three patches are a resend of my first sequence from
yesterday that generalizes sound processing.
This set should incorporate all of Christophe's feedback.
The open issue, in my mind, is whether or not it is worth doing a more
complete generalization. That is, the current code has
When SPICE_DEBUG is set but --spice-debug is not used, we fail
to set G_MESSAGES_DEBUG to the log domain used by spice-gtk, which
causes debug messages not to be printed as one would expect.
---
gtk/spice-util.c | 34 +++---
1 file changed, 23 insertions(+), 11 deletion
If spice_util_set_debug() gets called before spice_util_get_debug(),
then the value set using spice_util_set_debug() will be overridden
by the result of g_getenv("SPICE_DEBUG") != NULL the first time
spice_util_get_debug() is called.
This causes remote-viewer --spice-debug to not enable debug as
a
- Original Message -
> Sorry to ask, but what was the leak exactly?
Ok, found some on error. You could simplify the code a bit, to unify a bit more
the free() location.
Perhaps have a final "cleanup:" block?
> - Original Message -
> > While looking at the SASL code, I noticed
ack
- Original Message -
> When exiting remote-viewer after authenticating through SASL, I got
> this crash:
>
> #0 0x000100a51870 in ?? ()
> #1 0x00314d20c53e in _sasl_log (conn=, level=5,
> fmt=0x7fffe49893e8 "DIGEST-MD5 client mech dispose")
> at common.c:1985
> #2
Sorry to ask, but what was the leak exactly?
- Original Message -
> While looking at the SASL code, I noticed some memory leaks.
> ---
> gtk/spice-channel.c | 12
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c
> i
When exiting remote-viewer after authenticating through SASL, I got
this crash:
#0 0x000100a51870 in ?? ()
#1 0x00314d20c53e in _sasl_log (conn=, level=5,
fmt=0x7fffe49893e8 "DIGEST-MD5 client mech dispose")
at common.c:1985
#2 0x7fffe4982d88 in digestmd5_client_mech_dispos
While looking at the SASL code, I noticed some memory leaks.
---
gtk/spice-channel.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c
index 08418f7..9b2697e 100644
--- a/gtk/spice-channel.c
+++ b/gtk/spice-channel.c
@@ -1387
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
Thanks for the review; it is much appreciated.
On 10/16/2013 06:05 AM, Christophe Fergeau wrote:
> The subject is misleading, it's not just changing spice-server, but both
> server and client.
Fair enough, I'll amend that.
> Can you fix the playbacke typo while at it?
Sure.
> This does not see
Hi,
I'm afraid that none of these cards will work. IIRC it was explained for
nVidia approach that it would be necessary to add their closed-source
code to qemu which is not going to happen.
You might have better luck with AMD card "passthrough" approach but I'm
not sure if GPUs can be passed throu
Are you intentionally using the same value for ENCODE/DECODE_FAILED? I'm
asking because ENCODER/DECODER_UNAVAILABLE got different values.
Nope, that's a bug. I'll respin that one.
Looks good otherwise, ACK.
Christophe
___
Spice-devel mailing li
- Original Message -
> Hi,
>
> I just took a look into those functions that are not seem to be involved
> in performance issues. Until today I stopped at the
> gdk_window_update_idle() as this call is suggestive of being innocent. I
> thought it may sleep.
>
> However this calling threa
On Tue, Oct 15, 2013 at 09:28:55AM -0500, Jeremy White wrote:
> Signed-off-by: Jeremy White
> ---
> configure.ac | 37 +++---
> gtk/channel-playback.c | 58 +++-
> gtk/channel-record.c | 98
> +++-
>
We were looking at this card:
It's just for a couple of users that need GPU, the rest we can arrange
with terminal server without GPU.
http://hothardware.com/News/AMD-Sets-Its-Eyes-On-New-GPU-Virtualization-Markets-Launches-S9000--S7000-Family/
AMD's Citrix and VMWare support uses a mode called
The subject is misleading, it's not just changing spice-server, but both
server and client.
On Tue, Oct 15, 2013 at 09:28:46AM -0500, Jeremy White wrote:
> This makes celt optional, and paves the way to readily add additional codecs.
>
> Signed-off-by: Jeremy White
> ---
> README
Signed-off-by: Dietmar Maurer
Index: new/gtk/channel-inputs.c
===
--- new.orig/gtk/channel-inputs.c 2013-10-16 09:53:10.0 +0200
+++ new/gtk/channel-inputs.c2013-10-16 10:00:11.0 +0200
@@ -451,6 +451,21 @@
Signed-off-by: Dietmar Maurer
Index: new/server/inputs_channel.c
===
--- new.orig/server/inputs_channel.c2013-10-16 12:37:14.0 +0200
+++ new/server/inputs_channel.c 2013-10-16 12:37:41.0 +0200
@@ -124,6 +124,11 @@
Introduce a new capability SPICE_INPUTS_CAP_KEY_UTF8.
Signed-off-by: Dietmar Maurer
Index: new/spice-common/spice.proto
===
--- new.orig/spice-common/spice.proto 2013-07-17 17:33:52.0 +0200
+++ new/spice-common/spice.proto
This version sends utf8 characters instead of keysyms.
I tried to include all suggestion from Marc.
Description:
The SPICE input channel currently only sends scancodes. Thus the
server does not know what character was pressed (server does not know
the client keymap).
But some SPICE applications
> > I just send this to the list to archive the work I have done so far.
> > Marc already expressed that he do like the current patches, so I will
> > rewrite them and post v3 soon.
Oh sorry - I want to write "Marc already expressed that he do NOT like the
current patches"
> Yes, but I have conc
On Wed, Oct 16, 2013 at 7:15 AM, wrote:
> This version adds code to directly forward keysmys to vdagent, which then
> tries to inject keysyms into X11.
>
> That way you always have correct input characters even if VM and
> client do not share the same keymap!
>
> Experiemts showed that is quite u
- Original Message -
> Note: This is an ugly hack because there is currently no clean way to do it.
>
> But experiments showed that the X11 agent is the wrong place to do such
> things, because it is started to late (after login).
That should not be a big problem, the greeter should run
On Tue, Oct 15, 2013 at 09:28:23AM -0500, Jeremy White wrote:
> Signed-off-by: Jeremy White
> ---
> common/Makefile.am |4 +
> common/snd_codec.c | 261
>
> common/snd_codec.h | 79
> configure.ac | 16
> 4
ACK
On Tue, Oct 15, 2013 at 09:29:22AM -0500, Jeremy White wrote:
> Signed-off-by: Jeremy White
> ---
> spice/enums.h|1 +
> spice/protocol.h |2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/spice/enums.h b/spice/enums.h
> index f192e43..fdcffa8 100644
> --- a/spice/enums.
On Wed, Oct 16, 2013 at 10:37:07AM +0200, Mario wrote:
> Hi,
>
> I just took a look into those functions that are not seem to be
> involved in performance issues. Until today I stopped at the
> gdk_window_update_idle() as this call is suggestive of being
> innocent. I thought it may sleep.
>
> Ho
hi List,
I get a "no map for 173" error when touching the minus key on recent
browsers and on a spanish browser.
I know there are known issues regarding translation of web key codes
into scan codes and am eager to help solving this , a precedent
thread pointed editing
- Original Message -
> From: "Gerd Hoffmann"
> To: "Dave Airlie"
> Cc: "Hans de Goede" , "spice-devel"
> , "Dave Airlie"
>
> Sent: Wednesday, 9 October, 2013 6:44:58 PM
> Subject: Re: [Spice-devel] RFC: Integrating Virgil and Spice
>
> On Mi, 2013-10-09 at 08:46 +1000, Dave Airlie wr
Le 16/10/2013 09:24, Christophe Fergeau
a écrit :
Hey,
On Tue, Oct 15, 2013 at 05:13:21PM -0400, Itamar Heim wrote:
On 10/15/2013 04:50 PM, Mario Giammarco wrote:
Itamar Heim writes:
On 10/04/2013 01:58
Hey,
On Tue, Oct 15, 2013 at 05:13:21PM -0400, Itamar Heim wrote:
> On 10/15/2013 04:50 PM, Mario Giammarco wrote:
> >Itamar Heim writes:
> >
> >>
> >>On 10/04/2013 01:58 PM, Mario Giammarco wrote:
> >
> >rendering is slow;
>
> adding spice-devel on this one
>
> >>>Thanks, to be
39 matches
Mail list logo
