Re: [Spice-devel] Windows Guest Tools 0.65.1

2013-10-07 Thread Christophe Fergeau
On Mon, Oct 07, 2013 at 06:10:24PM +0200, Christophe Fergeau wrote: > The release is signed with GPG key: > A525 E3EA 186A AB45 DD0F 86AF 24A4 69FB 7A56 F78E > http://spice-space.org/download/windows/spice-guest-tools/spice-guest-tools-0.65.1.exe.sig Correct URL is http://spice-space.org/download

Re: [Spice-devel] Windows Guest Tools 0.65

2013-10-07 Thread Christophe Fergeau
On Tue, Oct 08, 2013 at 12:45:17AM +0200, Dominique Rodrigues wrote: > However, is it a side effect to not be able anymore to navigate in the > spice-space.org/download/ folders ? > > See for instance that : > > > Not Found > > The requested URL /download/windows/spice-guest-tools/ was not fo

Re: [Spice-devel] Windows Guest Tools 0.65

2013-10-07 Thread Dominique Rodrigues
Great ! Tested and validated ^^. A nice improvement. However, is it a side effect to not be able anymore to navigate in the spice-space.org/download/ folders ? See for instance that : Not Found The requested URL /download/windows/s

Re: [Spice-devel] RFC on sound codec refactoring

2013-10-07 Thread Jeremy White
> 2. Modify qemu to change the device sample rate dynamically > > This seems like it should be possible. I'm working up a > hack to try it (basically, we regen the rate at voice_enable > time). This seems to fly in the face of 'normal' > practice, so there is probably

Re: [Spice-devel] RFC on sound codec refactoring

2013-10-07 Thread Jeremy White
>> When spice-server detects that qemu hasn't been updated and is still using >> 44.1, then it could advertise it does not support Opus and only use celt >> until qemu is recompiled. > > Yep, that will work too. And it will probably handle the transition > with less code. That would sure be easi

Re: [Spice-devel] govirt 0.30 plans

2013-10-07 Thread i iordanov
Hi Christophe, Thank you! iordan On Mon, Oct 7, 2013 at 5:11 AM, Christophe Fergeau wrote: > Hey, > > On Thu, Oct 03, 2013 at 04:03:22PM -0400, i iordanov wrote: >> When do you plan to release govirt 0.30 with the SSL fixes and the new >> API for getting available VMs, powering on the VM at log

Re: [Spice-devel] Win7 64-bit QXL driver (binary) is not signed properly

2013-10-07 Thread Christophe Fergeau
Hey Tsukasa, On Sat, Oct 05, 2013 at 07:15:01PM +0900, Tsukasa #01 (Oi) wrote: > [Possible solution] > > If my guess is right, this issue can be fixed by Red Hat. Specifically, > code signing process can be fixed to use proper cross-certificate, which > extends chain of trust from Microsoft (sing

[Spice-devel] Windows Guest Tools 0.65

2013-10-07 Thread Christophe Fergeau
Hi, A new release of the SPICE Guest Tools for Windows is now available at http://spice-space.org/download/windows/spice-guest-tools/spice-guest-tools-0.65.1.exe There is only one change over 0.65, but it's a very important one: the QXL driver shipped in this installer now has a WHQL signature, w

Re: [Spice-devel] RFC on sound codec refactoring

2013-10-07 Thread Gerd Hoffmann
On Mo, 2013-10-07 at 15:03 +0200, Christophe Fergeau wrote: > On Mon, Oct 07, 2013 at 12:26:50PM +0200, Gerd Hoffmann wrote: > > On Mo, 2013-10-07 at 05:35 -0400, Marc-André Lureau wrote: > > > Instead of having to resample, can't we fix qemu (and spice headers) to > > > use 48khz by default? > >

Re: [Spice-devel] [PATCH spice-common] Remove INLINE usage

2013-10-07 Thread Christophe Fergeau
ACK On Fri, Oct 04, 2013 at 12:45:31PM +0200, Marc-André Lureau wrote: > Since inline is c99 and its already used in some files > --- > common/bitops.h | 6 +++--- > common/canvas_utils.c | 2 +- > common/lines.c| 2 +- > common/lz.c | 26 +- > c

Re: [Spice-devel] [PATCH proto] macros: remove INLINE

2013-10-07 Thread Christophe Fergeau
On Mon, Oct 07, 2013 at 10:11:32AM -0400, Marc-André Lureau wrote: > > > - Original Message - > > On Mon, Oct 07, 2013 at 09:16:30AM -0400, Marc-André Lureau wrote: > > > > > > > > > > Won't that make VC++ unhappy? > > > > > > It's not being used in the protocol headers. > > > > > > F

Re: [Spice-devel] [PATCH proto] macros: remove INLINE

2013-10-07 Thread Marc-André Lureau
Since the old client is written in C++, perhaps spice-common code is compiled with vc++. According to msdn, "inline" is supported in this case: http://msdn.microsoft.com/en-us/library/z8y1yy88.aspx "The inline keyword is available only in C++." On Mon, Oct 7, 2013 at 4:11 PM, Marc-André Lureau

Re: [Spice-devel] [PATCH proto] macros: remove INLINE

2013-10-07 Thread Marc-André Lureau
- Original Message - > On Mon, Oct 07, 2013 at 09:16:30AM -0400, Marc-André Lureau wrote: > > > > > > > Won't that make VC++ unhappy? > > > > It's not being used in the protocol headers. > > > > For the usage, it's used partially in spice-common (mixed with regular > > inline), in whi

Re: [Spice-devel] [PATCH proto] macros: remove INLINE

2013-10-07 Thread Christophe Fergeau
On Mon, Oct 07, 2013 at 09:16:30AM -0400, Marc-André Lureau wrote: > > > > Won't that make VC++ unhappy? > > It's not being used in the protocol headers. > > For the usage, it's used partially in spice-common (mixed with regular > inline), in which we require c99 anyway, as said in commit messa

Re: [Spice-devel] [PATCH proto] macros: remove INLINE

2013-10-07 Thread Marc-André Lureau
- Original Message - > On Mon, Oct 07, 2013 at 01:28:34PM +0200, Marc-André Lureau wrote: > > hey, > > > > if no acks, I'll move ahead and commit this under the trivial rule. > > Won't that make VC++ unhappy? It's not being used in the protocol headers. For the usage, it's used partia

Re: [Spice-devel] [PATCH proto] macros: remove INLINE

2013-10-07 Thread Christophe Fergeau
On Mon, Oct 07, 2013 at 01:28:34PM +0200, Marc-André Lureau wrote: > hey, > > if no acks, I'll move ahead and commit this under the trivial rule. Won't that make VC++ unhappy? Christophe pgpMEKM_XOE6a.pgp Description: PGP signature ___ Spice-devel ma

Re: [Spice-devel] RFC on sound codec refactoring

2013-10-07 Thread Christophe Fergeau
On Mon, Oct 07, 2013 at 12:26:50PM +0200, Gerd Hoffmann wrote: > On Mo, 2013-10-07 at 05:35 -0400, Marc-André Lureau wrote: > > Instead of having to resample, can't we fix qemu (and spice headers) to use > > 48khz by default? > > Sure we can switch the default. spice headers is enougth btw. Jus

Re: [Spice-devel] RFC on sound codec refactoring

2013-10-07 Thread Christophe Fergeau
On Mon, Oct 07, 2013 at 07:08:40AM -0500, Jeremy White wrote: > >>Instead of having to resample, can't we fix qemu (and spice headers) to use > >>48khz by default? > > > >Sure we can switch the default. spice headers is enougth btw. Just > >update the frequency there. And bumb the minor version

Re: [Spice-devel] spice-gtk on MAC OSX

2013-10-07 Thread Marc-André Lureau
- Original Message - > Marc, > > thank you for your message. > > Cairo-SDL can be realized in two ways: > > // Integrate SDL into cairo > http://www.cairographics.org/SDL/ I wonder why that would make it faster than a cairo quartz surface / backend. > // Use the integration (even if

Re: [Spice-devel] [PATCH] worker: handle red_get_surface_cmd() error explicitely

2013-10-07 Thread Christophe Fergeau
ACK On Mon, Oct 07, 2013 at 01:53:47PM +0200, Marc-André Lureau wrote: > Don't ignore red_get_surface_cmd() error, and explicitely interrupt and > free cmd before processing. > --- > server/red_worker.c | 56 > ++--- > 1 file changed, 32 insertions

Re: [Spice-devel] spice-gtk on MAC OSX

2013-10-07 Thread Mario Lombardo
Marc, thank you for your message. Cairo-SDL can be realized in two ways: // Integrate SDL into cairo http://www.cairographics.org/SDL/ // Use the integration (even if this is not up to date - this may help me to understand) http://cgit.freedesktop.org/~joonas/cairosdl/tree/README Regarding

Re: [Spice-devel] RFC on sound codec refactoring

2013-10-07 Thread Jeremy White
Instead of having to resample, can't we fix qemu (and spice headers) to use 48khz by default? Sure we can switch the default. spice headers is enougth btw. Just update the frequency there. And bumb the minor version so spice-server can figure which frequency is used by qemu. You can still f

Re: [Spice-devel] [PATCH] RFC: server: plug some leaks on error

2013-10-07 Thread Marc-André Lureau
On Mon, Oct 7, 2013 at 10:02 AM, Christophe Fergeau wrote: > Hey, > > Patch looks good, a few comments: > - handle_dev_loadvm_commands() would have the same surface_cmd leak > except that it does not check red_get_surface_cmd() return value, > probably a bug as well I just sent another patch

[Spice-devel] [PATCH] worker: handle red_get_surface_cmd() error explicitely

2013-10-07 Thread Marc-André Lureau
Don't ignore red_get_surface_cmd() error, and explicitely interrupt and free cmd before processing. --- server/red_worker.c | 56 ++--- 1 file changed, 32 insertions(+), 24 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 8f

Re: [Spice-devel] [PATCH proto] macros: remove INLINE

2013-10-07 Thread Marc-André Lureau
hey, if no acks, I'll move ahead and commit this under the trivial rule. On Fri, Oct 4, 2013 at 12:45 PM, Marc-André Lureau wrote: > This macro isn't used in the protocol headers, and clashes with other > define from qemu. > --- > spice/macros.h | 6 -- > 1 file changed, 6 deletions(-) > >

Re: [Spice-devel] spice-gtk on MAC OSX

2013-10-07 Thread Marc-André Lureau
Hi - Original Message - > Hi, > > I just compiled the spice-gtk client (spicy) on OSX > (http://www.spice-space.org/page/OSX_Client/Build). > > I am able to connect to the spice server using this client but it is > more slow than any VNC client I know. > > > I looked into the code and

Re: [Spice-devel] multi monitor and http connect proxy

2013-10-07 Thread Alexandre DERUMIER
>>What are guest OS, agent & driver, and client versions? guest is fedora19, with last updates client : remote-viewer : 0.5.7 spice-gtk3 0.21 (same with 0.20) Can you provide SPICE_DEBUG=1 log of spice client? (G_MESSAGES_DEBUG=all SPICE_DEBUG=1 ./remote-viewer...) debug log -- #G

Re: [Spice-devel] RFC on sound codec refactoring

2013-10-07 Thread Gerd Hoffmann
On Mo, 2013-10-07 at 05:35 -0400, Marc-André Lureau wrote: > > - Original Message - > > On Fri, Oct 04, 2013 at 01:16:24PM -0500, Jeremy White wrote: > > > Yes, he pointed out some issues back in August when this last came up > > > (primarily supporting 'old' clients if you're sampling at

[Spice-devel] spice-gtk on MAC OSX

2013-10-07 Thread Mario Lombardo
Hi, I just compiled the spice-gtk client (spicy) on OSX (http://www.spice-space.org/page/OSX_Client/Build). I am able to connect to the spice server using this client but it is more slow than any VNC client I know. I looked into the code and found two different places where this client se

[Spice-devel] [patch 1/2] extend vdagent protocol with VD_AGENT_CAP_KEYVAL

2013-10-07 Thread dietmar
Signed-off-by: Dietmar Maurer Index: new/spice-common/spice-protocol/spice/vd_agent.h === --- new.orig/spice-common/spice-protocol/spice/vd_agent.h 2013-10-07 10:51:28.0 +0200 +++ new/spice-common/spice-protocol/spice/

[Spice-devel] [patch 0/2] vdagent KEYVAL extension

2013-10-07 Thread dietmar
This is my second approach to implement the ability to send utf8 input from spice-gtk to spiceterm. https://git.proxmox.com/?p=spiceterm.git;a=summary The patch is quite simple. I still hope there is some interest to get that working? ___ Spice-devel

[Spice-devel] [patch 2/2] send KEYVAL messages if agent has VD_AGENT_CAP_KEYVAL

2013-10-07 Thread dietmar
Signed-off-by: Dietmar Maurer Index: new/gtk/channel-main.c === --- new.orig/gtk/channel-main.c 2013-10-07 11:01:52.0 +0200 +++ new/gtk/channel-main.c 2013-10-07 11:02:51.0 +0200 @@ -191,6 +191,7 @@ [ VD_AGE

Re: [Spice-devel] RFC on sound codec refactoring

2013-10-07 Thread Marc-André Lureau
- Original Message - > On Fri, Oct 04, 2013 at 01:16:24PM -0500, Jeremy White wrote: > > Yes, he pointed out some issues back in August when this last came up > > (primarily supporting 'old' clients if you're sampling at 48K). That's > > the bit I'm not entirely clear on just yet, and ho

Re: [Spice-devel] RFC on sound codec refactoring

2013-10-07 Thread Christophe Fergeau
On Fri, Oct 04, 2013 at 01:16:24PM -0500, Jeremy White wrote: > Yes, he pointed out some issues back in August when this last came up > (primarily supporting 'old' clients if you're sampling at 48K). That's > the bit I'm not entirely clear on just yet, and hope to research a bit > further. I'll l

Re: [Spice-devel] [PATCH 1/3] server: mark deprecated symbols

2013-10-07 Thread Marc-André Lureau
- Original Message - > ACK. gcc outputs warning when you try to access deprecated struct members? yes > I never tried deprecation attributes in such a setting. > > Christophe > > On Thu, Oct 03, 2013 at 11:02:05PM +0200, Marc-André Lureau wrote: > > --- > > server/Makefile.am | 1 +

Re: [Spice-devel] govirt 0.30 plans

2013-10-07 Thread Christophe Fergeau
Hey, On Thu, Oct 03, 2013 at 04:03:22PM -0400, i iordanov wrote: > When do you plan to release govirt 0.30 with the SSL fixes and the new > API for getting available VMs, powering on the VM at login time, etc.? Ah thanks for the ping, after some bug fixing in the last weeks in the new features, i

Re: [Spice-devel] [PATCH 3/3] server/tests: avoid using deprecated symbols

2013-10-07 Thread Christophe Fergeau
ACK assuming the test still behaves the same after the changes. It could go in before the patch introducing the deprecation warnings. Christophe On Thu, Oct 03, 2013 at 11:02:07PM +0200, Marc-André Lureau wrote: > --- > server/tests/test_display_base.c | 13 ++--- > 1 file changed, 6 ins

Re: [Spice-devel] [PATCH 2/3] server: set dispatcher before calling attache_worker

2013-10-07 Thread Christophe Fergeau
ACK, too bad we can't easily fix the attache_worker typo :( On Thu, Oct 03, 2013 at 11:02:06PM +0200, Marc-André Lureau wrote: > This allows to call spice_qxl_add_memslot during attache_worker(), like > done in the tests. > --- > server/red_dispatcher.c | 12 +++- > server/red_dispatcher.

Re: [Spice-devel] [PATCH 1/3] server: mark deprecated symbols

2013-10-07 Thread Christophe Fergeau
ACK. gcc outputs warning when you try to access deprecated struct members? I never tried deprecation attributes in such a setting. Christophe On Thu, Oct 03, 2013 at 11:02:05PM +0200, Marc-André Lureau wrote: > --- > server/Makefile.am | 1 + > server/spice.h | 51 ++

Re: [Spice-devel] [PATCH] RFC: server: plug some leaks on error

2013-10-07 Thread Christophe Fergeau
On Fri, Oct 04, 2013 at 08:59:55PM +0200, Marc-André Lureau wrote: > diff --git a/spice-common b/spice-common > index e443c9f..7e8ba10 16 > --- a/spice-common > +++ b/spice-common > @@ -1 +1 @@ > -Subproject commit e443c9f6039407633d38a0eba03c344272ac8559 > +Subproject commit 7e8ba10779a3fb11d5

Re: [Spice-devel] [PATCH] RFC: server: plug some leaks on error

2013-10-07 Thread Christophe Fergeau
Hey, Patch looks good, a few comments: - handle_dev_loadvm_commands() would have the same surface_cmd leak except that it does not check red_get_surface_cmd() return value, probably a bug as well - things would be slightly nicer if red_get_surface_cmd()/red_get_cursor_cmd() returned a newly

Re: [Spice-devel] [PATCH] server: release all pressed keys on client disconnect

2013-10-07 Thread Christophe Fergeau
ACK While you're changing this code, can you also push a patch doing s/relase/release in this file? Thanks, Christophe On Fri, Oct 04, 2013 at 06:51:32PM +0200, Marc-André Lureau wrote: > Releasing modifiers keys unconditionally on disconnect leads to > unexpected guest wakeups. To improve the s

Re: [Spice-devel] the development of spice-gtk

2013-10-07 Thread Christophe Fergeau
Hi, On Sat, Sep 28, 2013 at 11:07:52PM +0800, 小巷 wrote: > hi,everyone.at first thanks for your contribution to the SPICE project. > i am study the spice-gtk lately. i want to learn and develop the client at > the foundation of spice-gtk. > so,i want to know how i could make a lot of development i

Re: [Spice-devel] multi monitor and http connect proxy

2013-10-07 Thread Dietmar Maurer
> > And I don't see any connection to http connect proxy . > > > > Is it a bug ? > > What are guest OS, agent & driver, and client versions? > > Can you provide SPICE_DEBUG=1 log of spice client? > (G_MESSAGES_DEBUG=all SPICE_DEBUG=1 ./remote-viewer...) I am not sure if the following is related,