Re: [Spice-devel] [PATCH xf86-video-qxl 07/11] xspice: add uinput support to vdagent support

2013-09-04 Thread Jeremy White
> +n = read(uinput_fd, (char *)&inp_event + offset, sizeof(inp_event) - > offset); > +offset += n; > +if (offset < sizeof(inp_event)) { > +return; > +} Nit: you don't handle errors (I realize you're only here when select indicates read data is present, but still...) Chee

Re: [Spice-devel] [PATCH xf86-video-qxl 00/11] Xspice vdagent support

2013-09-04 Thread Jeremy White
I have done a cursory review, and it doesn't seem to break things horribly . A few nits: > I have used this for the last day and it seems fine, so I'm sending it as a > patchset and not RFC. > > Alon Levy (11): > xspice: support sending monitors config This introduces a warning; and we were

Re: [Spice-devel] [virt-tools-list] Is virsh supposed to work on Windows?

2013-09-04 Thread Marc-André Lureau
- Original Message - > Hi, > >> I'm trying to use virsh and virt-viewer on Windows. I'm running the > >> latest binaries from http://spice-space.org/download.html, that is, > >> virt-viewer-x64-0.5.7.msi on a Windows 7 64-bits computer. > >> > >> So far I got remote-viewer.exe to work, a

Re: [Spice-devel] [virt-tools-list] Is virsh supposed to work on Windows?

2013-09-04 Thread Fernando Lozano
Hi, I'm trying to use virsh and virt-viewer on Windows. I'm running the latest binaries from http://spice-space.org/download.html, that is, virt-viewer-x64-0.5.7.msi on a Windows 7 64-bits computer. So far I got remote-viewer.exe to work, after some pain. But have no sucess using virt-viewer.ex

Re: [Spice-devel] [virt-tools-list] Is virsh supposed to work on Windows?

2013-09-04 Thread Marc-André Lureau
- Original Message - > On 09/04/2013 12:53 PM, Fernando Lozano wrote: > > Hi there, > > > > Sorry for the cross-post, but I seeked help on this issue before on > > those lists, but nobody answered. :-( > > > > I'm trying to use virsh and virt-viewer on Windows. I'm running the > > late

Re: [Spice-devel] [virt-tools-list] Is virsh supposed to work on Windows?

2013-09-04 Thread Eric Blake
On 09/04/2013 12:53 PM, Fernando Lozano wrote: > Hi there, > > Sorry for the cross-post, but I seeked help on this issue before on > those lists, but nobody answered. :-( > > I'm trying to use virsh and virt-viewer on Windows. I'm running the > latest binaries from http://spice-space.org/downloa

[Spice-devel] Is virsh supposed to work on Windows?

2013-09-04 Thread Fernando Lozano
Hi there, Sorry for the cross-post, but I seeked help on this issue before on those lists, but nobody answered. :-( I'm trying to use virsh and virt-viewer on Windows. I'm running the latest binaries from http://spice-space.org/download.html, that is, virt-viewer-x64-0.5.7.msi on a Windows

Re: [Spice-devel] FOSDEM'14

2013-09-04 Thread Christophe Fergeau
Hey Fedor, On Tue, Sep 03, 2013 at 01:06:18PM +0400, Fedor Lyakhov wrote: > Hello Spice developers, > > I'm planning to visit FOSDEM this year, hope to meet you in 'real > life'. As I'm a newbie, there are few questions which bother me: > > 1. Do you know whether Virtualization devroom will be h