[Spice-devel] [PATCH v2 xf86-video-qxl] Xspice: vdagent{, d} launching support

2013-09-02 Thread Alon Levy
It checks for a new enough vdagentd/vdagent via the new -S command line parameter available via "vdagentd -h" and "vdagent -h". Signed-off-by: Alon Levy --- v2: forgot to commit some stuff in v1. scripts/Xspice | 43 +-- 1 file changed, 41 insertions(+),

Re: [Spice-devel] [PATCH xf86-video-qxl 00/11] Xspice vdagent support

2013-09-02 Thread Alon Levy
The two v2 patches I've just sent fix the clipboard, so now everything seems to work. Any reviewers appreciated! > This is the second attempt, using vdagentd & vdagent as external processes, > the changes required to vdagent are in an accompanying patchset, they are > relatively small. > > With

[Spice-devel] [PATCH v2 xf86-video-qxl] xspice: add vdagent support

2013-09-02 Thread Alon Levy
Adds a configurable virtio path used to communicate with the vdagentd, and a configuration variable for enabling the thing. With this you can have multiple monitors, but due to usage of a tablet you cannot generate pointer events on and monitors besides the first. clipboard already works. The ne

[Spice-devel] [PATCH v3 vdagent-linux] vdagentd: support fake uinput

2013-09-02 Thread Alon Levy
This is used with Xspice. Fake means we open a pipe for write only, and don't do any ioctls on it. Specifically it means the axis and buttons have to be coordinated for now with Xspice (xf86-video-qxl). Signed-off-by: Alon Levy --- src/vdagentd-uinput.c | 11 +-- src/vdagentd-uinput.h |

Re: [Spice-devel] How to command the server that he has to do the whole work?

2013-09-02 Thread Flo
Thank you. I just asked because I read something like that on http://de.redhat.com/resourcelibrary/articles/rhev-desktops-spice Is it planned to implement a feature like this? > Date: Mon, 2 Sep 2013 08:10:09 -0400 > From: al...@redhat.com > To: der_elef...@live.de > CC: spice-devel@lists.freed

Re: [Spice-devel] [PATCH v2 vdagent-linux] vdagentd: support fake uinput

2013-09-02 Thread Hans de Goede
Hi, On 09/02/2013 05:12 PM, Alon Levy wrote: This is used with Xspice. Fake means we open a pipe for write only, and don't do any ioctls on it. Specifically it means the axis and buttons have to be coordinated for now with Xspice (xf86-video-qxl). Signed-off-by: Alon Levy --- src/vdagentd-ui

[Spice-devel] [PATCH v2 vdagent-linux] vdagentd: support fake uinput

2013-09-02 Thread Alon Levy
This is used with Xspice. Fake means we open a pipe for write only, and don't do any ioctls on it. Specifically it means the axis and buttons have to be coordinated for now with Xspice (xf86-video-qxl). Signed-off-by: Alon Levy --- src/vdagentd-uinput.c | 11 +-- src/vdagentd-uinput.h |

Re: [Spice-devel] [PATCH vdagent-linux 4/4] vdagentd: support fake uinput

2013-09-02 Thread Hans de Goede
Comments inline. On 09/02/2013 05:02 PM, Alon Levy wrote: This is used with Xspice. Fake means we open a pipe for write only, and don't do any ioctls on it. Specifically it means the axis and buttons have to be coordinated for now with Xspice (xf86-video-qxl). Signed-off-by: Alon Levy --- sr

Re: [Spice-devel] [PATCH vdagent-linux 4/4] vdagentd: support fake uinput

2013-09-02 Thread Alon Levy
> This is used with Xspice. Fake means we open a pipe for write only, and > don't do any ioctls on it. Specifically it means the axis and buttons > have to be coordinated for now with Xspice (xf86-video-qxl). This patch needs to be broken, and possibly the second part thrown - making lack of uinp

Re: [Spice-devel] [PATCH vdagent-linux 3/4] vdagentd: support virtio as uds for Xspice usage

2013-09-02 Thread Hans de Goede
ACK. On 09/02/2013 05:02 PM, Alon Levy wrote: Signed-off-by: Alon Levy --- src/vdagent-virtio-port.c | 53 +-- 1 file changed, 47 insertions(+), 6 deletions(-) diff --git a/src/vdagent-virtio-port.c b/src/vdagent-virtio-port.c index 05bd344..bdd22

Re: [Spice-devel] [PATCH vdagent-linux 2/4] vdagentd: support configurable socket to vdagent

2013-09-02 Thread Hans de Goede
ACK. On 09/02/2013 05:02 PM, Alon Levy wrote: Signed-off-by: Alon Levy --- src/vdagentd.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/src/vdagentd.c b/src/vdagentd.c index f4cea44..2288671 100644 --- a/src/vdagentd.c +++ b/src/vdage

Re: [Spice-devel] [PATCH vdagent-linux 1/4] vdagent: add option to change vdagentd socket

2013-09-02 Thread Hans de Goede
ACK. On 09/02/2013 05:02 PM, Alon Levy wrote: Signed-off-by: Alon Levy --- src/vdagent.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/vdagent.c b/src/vdagent.c index 10ebf6e..f270615 100644 --- a/src/vdagent.c +++ b/src/vdagent.c @@ -43,6 +43,7 @@ #inclu

[Spice-devel] [PATCH xf86-video-qxl 10/11] Xspice: require display parameter, and set if earlier in environment

2013-09-02 Thread Alon Levy
Signed-off-by: Alon Levy --- scripts/Xspice | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/Xspice b/scripts/Xspice index 5375624..ba04951 100755 --- a/scripts/Xspice +++ b/scripts/Xspice @@ -213,6 +213,10 @@ display="" for arg in xorg_args: if arg.startswith

[Spice-devel] [PATCH xf86-video-qxl 11/11] Xspice: vdagent{, d} launching support

2013-09-02 Thread Alon Levy
It checks for a new enough vdagentd/vdagent via the new -S command line parameter available via "vdagentd -h" and "vdagent -h". Signed-off-by: Alon Levy --- scripts/Xspice | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/scripts/Xspice b/scrip

[Spice-devel] [PATCH xf86-video-qxl 09/11] Xspice: correct doc string

2013-09-02 Thread Alon Levy
Signed-off-by: Alon Levy --- scripts/Xspice | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Xspice b/scripts/Xspice index b50ea46..5375624 100755 --- a/scripts/Xspice +++ b/scripts/Xspice @@ -12,7 +12,7 @@ Xspice is kept in the same repository. It can also be used to

[Spice-devel] [PATCH xf86-video-qxl 08/11] Xspice: use subprocess.Popen, nicer cleanup of files/processes

2013-09-02 Thread Alon Levy
Signed-off-by: Alon Levy --- scripts/Xspice | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/scripts/Xspice b/scripts/Xspice index bfa9197..b50ea46 100755 --- a/scripts/Xspice +++ b/scripts/Xspice @@ -22,6 +22,7 @@ import sys import tempfile impo

[Spice-devel] [PATCH xf86-video-qxl 07/11] xspice: add uinput support to vdagent support

2013-09-02 Thread Alon Levy
Signed-off-by: Alon Levy --- src/Makefile.am| 2 + src/qxl.h | 1 + src/qxl_driver.c | 3 ++ src/spiceqxl_uinput.c | 118 + src/spiceqxl_uinput.h | 8 src/spiceqxl_vdagent.c | 2 + 6 files changed, 134 ins

[Spice-devel] [PATCH xf86-video-qxl 06/11] xspice: add vdagent support

2013-09-02 Thread Alon Levy
Adds a configurable virtio path used to communicate with the vdagentd, and a configuration variable for enabling the thing. With this you can have multiple monitors, but due to usage of a tablet you cannot generate pointer events on and monitors besides the first. The next patch adds uinput emula

[Spice-devel] [PATCH xf86-video-qxl 03/11] xspice: zero memory on allocation, fix uninitialized use (valgrind reported)

2013-09-02 Thread Alon Levy
Signed-off-by: Alon Levy --- src/qxl_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 731a71a..d5ad45f 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -177,13 +177,13 @@ unmap_memory_helper (qxl_screen_t *qxl) st

[Spice-devel] [PATCH xf86-video-qxl 05/11] qxl_option_helpers: add required includes

2013-09-02 Thread Alon Levy
Signed-off-by: Alon Levy --- src/qxl_option_helpers.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qxl_option_helpers.h b/src/qxl_option_helpers.h index 12a14ff..7c54c72 100644 --- a/src/qxl_option_helpers.h +++ b/src/qxl_option_helpers.h @@ -1,6 +1,8 @@ #ifndef OPTION_HELPERS_H #d

[Spice-devel] [PATCH xf86-video-qxl 02/11] qxl_driver: fix build for Xspice

2013-09-02 Thread Alon Levy
Signed-off-by: Alon Levy --- src/qxl_driver.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index ac5408e..731a71a 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -1214,10 +1214,14 @@ qxl_init_scrn (ScrnInfoPtr pScrn, Bool kms

[Spice-devel] [PATCH xf86-video-qxl 04/11] spiceqxl_inputs: expose buttons & position api for agent usage

2013-09-02 Thread Alon Levy
Signed-off-by: Alon Levy --- src/spiceqxl_inputs.c | 41 + src/spiceqxl_inputs.h | 2 ++ 2 files changed, 27 insertions(+), 16 deletions(-) diff --git a/src/spiceqxl_inputs.c b/src/spiceqxl_inputs.c index 2b8a15e..b39eeae 100644 --- a/src/spiceqxl_inputs.

[Spice-devel] [PATCH xf86-video-qxl 00/11] Xspice vdagent support

2013-09-02 Thread Alon Levy
This is the second attempt, using vdagentd & vdagent as external processes, the changes required to vdagent are in an accompanying patchset, they are relatively small. With this patchset you can: change resolution by resizing remote-viewer window get multiple monitors including working pointer

[Spice-devel] [PATCH xf86-video-qxl 01/11] xspice: support sending monitors config

2013-09-02 Thread Alon Levy
Signed-off-by: Alon Levy --- src/qxl_io.c | 9 +++-- src/spiceqxl_display.c | 10 ++ src/spiceqxl_display.h | 2 ++ 3 files changed, 19 insertions(+), 2 deletions(-) diff --git a/src/qxl_io.c b/src/qxl_io.c index 37bdc24..8fa90b6 100644 --- a/src/qxl_io.c +++ b/src/qxl_io

[Spice-devel] [PATCH vdagent-linux 4/4] vdagentd: support fake uinput

2013-09-02 Thread Alon Levy
This is used with Xspice. Fake means we open a pipe for write only, and don't do any ioctls on it. Specifically it means the axis and buttons have to be coordinated for now with Xspice (xf86-video-qxl). Signed-off-by: Alon Levy --- src/vdagentd-uinput.c | 11 +-- src/vdagentd-uinput.h |

[Spice-devel] [PATCH vdagent-linux 3/4] vdagentd: support virtio as uds for Xspice usage

2013-09-02 Thread Alon Levy
Signed-off-by: Alon Levy --- src/vdagent-virtio-port.c | 53 +-- 1 file changed, 47 insertions(+), 6 deletions(-) diff --git a/src/vdagent-virtio-port.c b/src/vdagent-virtio-port.c index 05bd344..bdd22d9 100644 --- a/src/vdagent-virtio-port.c +++ b/src

[Spice-devel] [PATCH vdagent-linux 2/4] vdagentd: support configurable socket to vdagent

2013-09-02 Thread Alon Levy
Signed-off-by: Alon Levy --- src/vdagentd.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/src/vdagentd.c b/src/vdagentd.c index f4cea44..2288671 100644 --- a/src/vdagentd.c +++ b/src/vdagentd.c @@ -55,6 +55,7 @@ struct agent_data { /* var

[Spice-devel] [PATCH vdagent-linux 0/4] Xspice support

2013-09-02 Thread Alon Levy
With these patches and the related changes to xf86-video-qxl you can run Xspice with an agent. The changes: add a parameter (-S for both vdagentd and vdagent) to set the udcs socket. try virtio as a UDS if it fails to open as a device (tried only after trying it as a device) if uinput file do

[Spice-devel] [PATCH vdagent-linux 1/4] vdagent: add option to change vdagentd socket

2013-09-02 Thread Alon Levy
Signed-off-by: Alon Levy --- src/vdagent.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/vdagent.c b/src/vdagent.c index 10ebf6e..f270615 100644 --- a/src/vdagent.c +++ b/src/vdagent.c @@ -43,6 +43,7 @@ #include "vdagent-file-xfers.h" static const char *port

Re: [Spice-devel] How to command the server that he has to do the whole work?

2013-09-02 Thread Alon Levy
> Hi, > > as I read the spice server offloads the work/jobs to the client. But what if > the client is too weak? Are there commands which tell the server to handle > the work by itself and just give the result to the client? Regards No, there is no such logic. > > __

[Spice-devel] How to command the server that he has to do the whole work?

2013-09-02 Thread Flo
Hi, as I read the spice server offloads the work/jobs to the client. But what if the client is too weak? Are there commands which tell the server to handle the work by itself and just give the result to the client? Regards ___

Re: [Spice-devel] [PATCH] server: bitmap_consistent: replace spice_error with spice_warning

2013-09-02 Thread Uri Lublin
On 09/02/2013 11:11 AM, Christophe Fergeau wrote: On Sun, Sep 01, 2013 at 09:43:17PM +0300, Uri Lublin wrote: bitmap_consistent should return true or false. Currently it aborts instead of returning false, due to spice_error. Replacing spice_error with spice_warning, provides information and retu

[Spice-devel] Porting spice-xpi-2.8 to Chromium

2013-09-02 Thread Ueli Banholzer
Hi all I tried to use spice-xpi-2.8 with Chromium (on a RaspPi). Now, I get this error when the UserPortal tries to connect with the plugin. pi@raspberrypi ~ $ /usr/bin/chromium --user-agent="Mozilla/5.0 (X11; Debian; Linux armv6l; rv:21.0) Gecko/20100101 Firefox/21.0" [1:1:3688624088:ERROR:nss_

Re: [Spice-devel] [PATCH] server: bitmap_consistent: replace spice_error with spice_warning

2013-09-02 Thread Christophe Fergeau
On Sun, Sep 01, 2013 at 09:43:17PM +0300, Uri Lublin wrote: > bitmap_consistent should return true or false. > Currently it aborts instead of returning false, due to spice_error. > Replacing spice_error with spice_warning, provides information and returns > false, as expected. Looking for spice_er

Re: [Spice-devel] [PATCH] server: bitmap_consistent: replace spice_error with spice_warning

2013-09-02 Thread Christophe Fergeau
On Sun, Sep 01, 2013 at 09:43:17PM +0300, Uri Lublin wrote: > bitmap_consistent should return true or false. > Currently it aborts instead of returning false, due to spice_error. > Replacing spice_error with spice_warning, provides information and returns > false, as expected. Looks good, ACK. Ch

Re: [Spice-devel] [PATCH 1/2] server/red_worker.h: order includes correcty

2013-09-02 Thread Christophe Fergeau
On Sun, Sep 01, 2013 at 03:24:32AM -0400, Alon Levy wrote: > > Do we document anywhere what is a 'correct' order? I assume it's config.h, > > alphabetically ordered system headers (with subdirs coming last), and > > finally local headers? > > I assume this is pretty standard practice, but I always