Re: [Spice-devel] [PATCH] xddm/miniport/qxl.inf: bump version and touch date

2013-07-17 Thread Alon Levy
Yes, I know. And still I find this annoying. - Original Message - > Internal RH brew builds replace date & version anyway according to build > params, but I guess upstream these should be updated on every change, or > at least every official build, otherwise it will prevent updating the >

Re: [Spice-devel] [PATCH] xddm/miniport/qxl.inf: bump version and touch date

2013-07-17 Thread agilboa
Internal RH brew builds replace date & version anyway according to build params, but I guess upstream these should be updated on every change, or at least every official build, otherwise it will prevent updating the driver. On 07/17/2013 05:53 PM, Yonit Halperin wrote: ACK. Maybe Arnon knows

[Spice-devel] Announcing spice server release 0.12.4

2013-07-17 Thread Uri Lublin
Hi All, I'm happy to announce spice 0.12.4 release. Major changes in 0.12.4: * log actual address spice-server binds to * main_channel: fix double release of migration target data (rhbz#859027) * red_channel: replace an assert upon threads mismatch with a warning (rhbz#

Re: [Spice-devel] [PATCH 11/11] Release 0.12.4

2013-07-17 Thread Uri Lublin
On 07/17/2013 06:19 PM, Alon Levy wrote: ACK series, just one minor spelling mistake below. --- NEWS | 13 + configure.ac | 4 ++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index acfffb8..684e993 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1

[Spice-devel] [PATCH] xddm/miniport/qxl.inf: bump version and touch date

2013-07-17 Thread Alon Levy
We haven't done this for most any change. Perhaps we should do this? No idea what the x.y.z.w convention is, so I made the most minor change right now. But the date is the important bit. --- xddm/miniport/qxl.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xddm/miniport/qxl

Re: [Spice-devel] [PATCH 11/11] Release 0.12.4

2013-07-17 Thread Alon Levy
ACK series, just one minor spelling mistake below. > --- > NEWS | 13 + > configure.ac | 4 ++-- > 2 files changed, 15 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index acfffb8..684e993 100644 > --- a/NEWS > +++ b/NEWS > @@ -1,3 +1,16 @@ > +Major changes in

[Spice-devel] [PATCH 03/11] syntax-check: update AUTHORS

2013-07-17 Thread Uri Lublin
--- AUTHORS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/AUTHORS b/AUTHORS index 230387e..a516469 100644 --- a/AUTHORS +++ b/AUTHORS @@ -18,22 +18,28 @@ Previous Spice maintainers were Patches also contributed by Alexander Larsson +Andrew Eikum Aric Stewart Arn

Re: [Spice-devel] spice guest tools win8

2013-07-17 Thread Ignazio Cassano
Many thanks 2013/7/17 David Blechter > Hi, > > it is in development, dates are not set yet. > > > Thanks, > David Blechter > 978-392-3182 > > > -- > > *From: *"Ignazio Cassano" > *To: *spice-devel@lists.freedesktop.org > *Sent: *Wednesday, July 17, 2013 10:24:22 AM >

Re: [Spice-devel] spice guest tools win8

2013-07-17 Thread David Blechter
Hi, it is in development, dates are not set yet. Thanks, David Blechter 978-392-3182 - Original Message - > From: "Ignazio Cassano" > To: spice-devel@lists.freedesktop.org > Sent: Wednesday, July 17, 2013 10:24:22 AM > Subject: [Spice-devel] spice guest tools win8 > Hi all, > I'd

Re: [Spice-devel] [PATCH] xddm/miniport/qxl.inf: bump version and touch date

2013-07-17 Thread Yonit Halperin
ACK. Maybe Arnon knows more about the version scheme. On 07/17/2013 10:15 AM, Alon Levy wrote: We haven't done this for most any change. Perhaps we should do this? No idea what the x.y.z.w convention is, so I made the most minor change right now. But the date is the important bit. --- xddm/mini

Re: [Spice-devel] [server PATCH 6/8] red_worker: make CCC_FOREACH safe

2013-07-17 Thread Uri Lublin
On 07/08/2013 01:58 PM, Christophe Fergeau wrote: On Mon, Jul 08, 2013 at 01:32:28PM +0300, Uri Lublin wrote: Even though it is not used, it's better to make it safe (or remove it). I'd either remove it, or fold that patch into the next one (ie silently make it safe by switching to SAFE_FOREACH

Re: [Spice-devel] [server/tests PATCH 4/6] server/tests: remove option from usage if AUTOMATED_TESTS is not configured

2013-07-17 Thread Uri Lublin
On 07/14/2013 03:47 PM, Uri Lublin wrote: On 07/14/2013 12:19 PM, Alon Levy wrote: On Tue, 2013-07-09 at 19:15 +0300, Uri Lublin wrote: ACK, just one comment that is nice to fix before pushing. diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c index a4fdae9..33

[Spice-devel] spice guest tools win8

2013-07-17 Thread Ignazio Cassano
Hi all, I'd like to know when spice guest tools will be released for windows 8. A tried to install spice-guest-tools-0.59 but during installation it gives errors about operating system version. Regards Ignazio ___ Spice-devel mailing list Spice-devel@list

[Spice-devel] [PATCH 09/11] syntax-check: trailing whitespaces -- ignore binary files

2013-07-17 Thread Uri Lublin
--- maint.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/maint.mk b/maint.mk index 405c6d0..fa2fe74 100644 --- a/maint.mk +++ b/maint.mk @@ -696,6 +696,8 @@ sc_require_test_exit_idiom: exit 1; } || :; \ fi +exclude_file_nam

[Spice-devel] [PATCH 11/11] Release 0.12.4

2013-07-17 Thread Uri Lublin
--- NEWS | 13 + configure.ac | 4 ++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index acfffb8..684e993 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,16 @@ +Major changes in 0.12.4: + +* log actual address spice-server binds

[Spice-devel] [PATCH 10/11] Update spice-common submodule (get spice-protocol 0.12.6)

2013-07-17 Thread Uri Lublin
--- spice-common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice-common b/spice-common index 30e8478..fe93908 16 --- a/spice-common +++ b/spice-common @@ -1 +1 @@ -Subproject commit 30e84783cad7a5d4cd345367a267cafbfd0571af +Subproject commit fe93908238196bd632287fc987

[Spice-devel] [PATCH 08/11] syntax-check: remove trailing whitespaces

2013-07-17 Thread Uri Lublin
Only whitespace changes in this commit. --- server/char_device.c | 4 ++-- server/red_parse_qxl.c | 5 ++--- server/red_worker.c| 6 +++--- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/server/char_device.c b/server/char_device.c index 792ab9c..660a788 100644 --- a/server/ch

[Spice-devel] [PATCH 05/11] syntax-check: fix no-newline or empty line at EOF

2013-07-17 Thread Uri Lublin
--- server/char_device.c| 1 - server/tests/.gitignore | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/server/char_device.c b/server/char_device.c index f500f04..721bd8d 100644 --- a/server/char_device.c +++ b/server/char_device.c @@ -977,4 +977,3 @@ int spice_char_device

[Spice-devel] [PATCH 06/11] syntax-check: use test A && test B instead of test A -a B

2013-07-17 Thread Uri Lublin
--- server/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/Makefile.am b/server/Makefile.am index 7a52b17..d351dae 100644 --- a/server/Makefile.am +++ b/server/Makefile.am @@ -135,4 +135,4 @@ EXTRA_DIST =\ BUILT_SOURCE

[Spice-devel] [PATCH 07/11] syntax-check: make sure config.h is the first included .h file

2013-07-17 Thread Uri Lublin
--- server/char_device.c| 1 + server/spice_timer_queue.c | 1 + server/tests/test_vdagent.c | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/server/char_device.c b/server/char_device.c index 721bd8d..792ab9c 100644 --- a/server/char_device.c +++ b/server/char_device.

[Spice-devel] [PATCH 04/11] syntax-check: s/the the/the/ in a comment

2013-07-17 Thread Uri Lublin
--- server/char_device.h | 2 +- server/reds.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/server/char_device.h b/server/char_device.h index 99bdb2e..c17a40d 100644 --- a/server/char_device.h +++ b/server/char_device.h @@ -138,7 +138,7 @@ int spice_char_device_sta

[Spice-devel] [PATCH 02/11] syntax-check: fix cast_of_argument_to_free

2013-07-17 Thread Uri Lublin
In this case, make syntax-check is wrong, and we actually do need the cast. A cast is needed when types are uint64_t <--> pointer Using a local "ptr" variable makes both gcc and syntax-check happy. --- server/tests/test_display_base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) dif

[Spice-devel] [PATCH 01/11] syntax-check: fix avoid_if_before_free

2013-07-17 Thread Uri Lublin
--- server/red_parse_qxl.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/server/red_parse_qxl.c b/server/red_parse_qxl.c index 65781e7..7d4d4a1 100644 --- a/server/red_parse_qxl.c +++ b/server/red_parse_qxl.c @@ -490,12 +490,8 @@ static SpiceImage *red_get_image(RedMe

Re: [Spice-devel] [PATCH qxl-win] miniport: disable surfaces by default

2013-07-17 Thread Yonit Halperin
ACK On 07/17/2013 09:04 AM, Alon Levy wrote: Change the registry checking logic we already have, instead of enabling surfaces by default we now disable surfaces by default. They can be enabled without driver change by creating a registry key name "SurfacesEnabled" of type DWORD with any value un

[Spice-devel] [PATCH qxl-win] miniport: disable surfaces by default

2013-07-17 Thread Alon Levy
Change the registry checking logic we already have, instead of enabling surfaces by default we now disable surfaces by default. They can be enabled without driver change by creating a registry key name "SurfacesEnabled" of type DWORD with any value under the adapter key. To find the adapter key, o

Re: [Spice-devel] spice-gtk http connect proxy authentification ?

2013-07-17 Thread Marc-André Lureau
Hi - Mensaje original - > Hi, > > I would like to known if it's planned to add authentification to http > spice_proxy soon ? It wasn't planned so far. > I think It should be easy, > > we just need to be able to parse a proxy url like this > > http://username:password@host:port > >