Re: [Spice-devel] [PATCH spice-gtk 0/7] Basic Broadway support

2013-05-10 Thread Hans de Goede
Looks good, ACK series. On 05/10/2013 10:46 PM, Marc-André Lureau wrote: Hi, I did some experiment with using Broadway backend with spice-gtk. The result is a bit of clean-up and some basic support for keysyms mapping, which is very limited and should be solved at Gdk/Broadway level, see also:

[Spice-devel] [PATCH spice-gtk 7/7] vncdisplaykeymap: add broadway support

2013-05-10 Thread Marc-André Lureau
--- gtk/vncdisplaykeymap.c | 24 1 file changed, 24 insertions(+) diff --git a/gtk/vncdisplaykeymap.c b/gtk/vncdisplaykeymap.c index b5241c1..8b01294 100644 --- a/gtk/vncdisplaykeymap.c +++ b/gtk/vncdisplaykeymap.c @@ -59,6 +59,10 @@ static struct { static unsigned int

[Spice-devel] [PATCH spice-gtk 6/7] keymaps: add basic x11 keysyms

2013-05-10 Thread Marc-André Lureau
Ok, this isn't a good idea, but atm, the browser don't seem to send hardware keycode, and so Gtk+ broadway backend decided to use keysyms representation, which spice-gtk receives as "hardware keycodes"... Since Gdk keysyms are same as X11, add a new x11 keysym to keymap. This is not going to fly,

[Spice-devel] [PATCH spice-gtk 5/7] vncdisplaykeymap: adapt gtk2 compat code

2013-05-10 Thread Marc-André Lureau
--- gtk/vncdisplaykeymap.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/gtk/vncdisplaykeymap.c b/gtk/vncdisplaykeymap.c index 1f17165..b5241c1 100644 --- a/gtk/vncdisplaykeymap.c +++ b/gtk/vncdisplaykeymap.c @@ -75,8 +75,8 @@ static unsigned int ref_count_for_un

[Spice-devel] [PATCH spice-gtk 4/7] vncdisplaykeymap: use a window to associate table

2013-05-10 Thread Marc-André Lureau
--- gtk/spice-widget.c | 5 - gtk/vncdisplaykeymap.c | 12 ++-- gtk/vncdisplaykeymap.h | 3 ++- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c index 0b1fe31..065c02b 100644 --- a/gtk/spice-widget.c +++ b/gtk/spice-widget.c

[Spice-devel] [PATCH spice-gtk 3/7] widget: check backend is X11

2013-05-10 Thread Marc-André Lureau
spice-gtk blindly assume the backend is X11 if it's compiled on Unix. But nowadays, gtk+ support runtime backend selection. https://bugzilla.redhat.com/show_bug.cgi?id=961577 --- gtk/spice-widget.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/gtk/spice-widget.c

[Spice-devel] [PATCH spice-gtk 2/7] Remove unused spice_set_keyboard_lock_modifiers()

2013-05-10 Thread Marc-André Lureau
That code was used in early version to set client modifiers lock but it is the wrong approach, and guest should follow client state instead. --- gtk/spice-widget.c | 61 -- 1 file changed, 61 deletions(-) diff --git a/gtk/spice-widget.c b/gtk/sp

[Spice-devel] [PATCH spice-gtk 0/7] Basic Broadway support

2013-05-10 Thread Marc-André Lureau
Hi, I did some experiment with using Broadway backend with spice-gtk. The result is a bit of clean-up and some basic support for keysyms mapping, which is very limited and should be solved at Gdk/Broadway level, see also: https://bugzilla.gnome.org/show_bug.cgi?id=700105 Fixes crash: https://bugz

Re: [Spice-devel] [PATCH spice-gtk v4 0/3] asynced mm-time handling

2013-05-10 Thread Marc-André Lureau
ack series, thanks! On Fri, May 10, 2013 at 10:14 PM, Yonit Halperin wrote: > Updates from previous version: > - make emit_main_context handle calls from both coroutine context and main > context > - definition of sruct SPICE_SESSION_MM_TIME_RESET > - no threshold for mm-time-reset if time goes

[Spice-devel] [PATCH spice-gtk v4 3/3] channel-display: protect video streaming from temporarily unsynced mm_time (migration related)

2013-05-10 Thread Yonit Halperin
rhbz#951664 When the src and dst servers have different mm-times, we can hit a case when for a short period of time the session mm-time and the video mm-time are not synced. If the video mm-time is much bigger than the session mm-time, the next stream rendering will be scheduled to (video-mm-time

[Spice-devel] [PATCH spice-gtk v4 2/3] spice-session: new signal for notifying on a significant change in mm-time

2013-05-10 Thread Yonit Halperin
mm-time can change after migration. This can cause video synchronization problems after migration if not handled appropriately (see rhbz#951664). --- gtk/spice-session.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/gtk/spice-session.c b/gtk/spice-

[Spice-devel] [PATCH spice-gtk v4 1/3] emit_main_context macro: handle calls from both coroutine context and main context

2013-05-10 Thread Yonit Halperin
--- gtk/coroutine.h | 1 + gtk/spice-channel-priv.h | 12 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/gtk/coroutine.h b/gtk/coroutine.h index 031a97b..a9b3a87 100644 --- a/gtk/coroutine.h +++ b/gtk/coroutine.h @@ -55,6 +55,7 @@ struct coroutine #endif };

[Spice-devel] [PATCH spice-gtk v4 0/3] asynced mm-time handling

2013-05-10 Thread Yonit Halperin
Updates from previous version: - make emit_main_context handle calls from both coroutine context and main context - definition of sruct SPICE_SESSION_MM_TIME_RESET - no threshold for mm-time-reset if time goes backwards - allow calling display_stream_schedule when the frames queue is empty Yonit.

[Spice-devel] help me with the compression algorithm

2013-05-10 Thread bigclouds
hi,all 1.when data is image, when it is jpeg? if jpeg has a better compression? 2.how to disable video compression , in my case, it is often that video remain unchanged(not updated effectively). 3.how to set options if i do not care bandwidth? 4.how to set options if bandwidth is senstive?

[Spice-devel] vm down for client reset

2013-05-10 Thread bigclouds
hi,all 1.it seems that there are many racing condition between channels. for example all channels of a vm connect to just only one client, if the client down, a variable shared between channels should be set. let see my problem. 1.server is aware of client is down (reset), 2.snd_receive sti

Re: [Spice-devel] [Engine-devel] ovirt user portal and attach a cd

2013-05-10 Thread Itamar Heim
On 05/10/2013 12:01 PM, Andrej Bagon wrote: Dear Itamar, while pressing the http://elmarco.fedorapeople.org/spice.cab download link there is a file Not Found. There is no .cab file in the directory listing either. maybe spice-devel (cc'd) knows of a different one Best Regards, Andrej On 05